ASoC: amd: acp: clear pdm dma interrupt mask
Subsystems (3)
PATCH 1/12 ASoC: amd: acp: clear pdm dma interrupt mask
Clear pdm dma interrupt mask in acp_dmic_shutdown().
'Fixes: c32bd332ce5c9 ("ASoC: amd: acp: Add generic support for PDM controller on ACP")'
--- sound/soc/amd/acp/acp-pdm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/amd/acp/acp-pdm.c +1 -1
@@ -176,7 +176,7 @@ static void acp_dmic_dai_shutdown(struct snd_pcm_substream *substream,/* Disable DMIC interrupts */ ext_int_ctrl =readl (ACP_EXTERNAL_INTR_CNTL (adata,0 )); - ext_int_ctrl |= ~PDM_DMA_INTR_MASK ; + ext_int_ctrl &= ~PDM_DMA_INTR_MASK ;writel (ext_int_ctrl,ACP_EXTERNAL_INTR_CNTL (adata,0 )); }
Signature · 1 line
2.25.1
PATCH 1/11 ASoC: amd: acp: remove acp poweroff function
BIOS invokes ACP Power off sequence based on ACP device state. Remove redundant code from ACP PCI driver for ACP Power off sequence.
--- sound/soc/amd/acp/acp-rembrandt.c | 25 ------------------------- sound/soc/amd/acp/acp-renoir.c | 17 ----------------- 2 files changed, 42 deletions(-)
sound/soc/amd/acp/acp-rembrandt.c +0 -25
@@ -204,23 +204,6 @@ static int acp6x_power_on(void __iomem *base)return -ETIMEDOUT ; } -static int acp6x_power_off (void __iomem *base) -{ -u32 val; -int timeout; - -writel (ACP_PGFSM_CNTL_POWER_OFF_MASK , - base +ACP6X_PGFSM_CONTROL ); - timeout =0 ; -while (++timeout <500 ) { - val =readl (base +ACP6X_PGFSM_STATUS ); -if ((val &ACP_PGFSM_STATUS_MASK ) ==ACP_POWERED_OFF ) -return 0 ; -udelay (1 ); - } -return -ETIMEDOUT ; -} -static int acp6x_reset (void __iomem *base) {u32 val;
@@ -299,14 +282,6 @@ static int rmb_acp_deinit(void __iomem *base) }writel (0x00 , base +ACP_CONTROL ); - -/* power off */ - ret =acp6x_power_off (base); -if (ret) { -pr_err ("ACP power off failed\n" ); -return ret; - } -return 0 ; }
sound/soc/amd/acp/acp-renoir.c +0 -17
@@ -169,17 +169,6 @@ static int acp3x_power_on(void __iomem *base)return readl_poll_timeout (base +ACP_PGFSM_STATUS , val, !val,DELAY_US ,ACP_TIMEOUT ); } -static int acp3x_power_off (void __iomem *base) -{ -u32 val; - -writel (ACP_PWR_OFF_MASK , base +ACP_PGFSM_CONTROL ); - -return readl_poll_timeout (base +ACP_PGFSM_STATUS , val, - (val &ACP_PGFSM_STAT_MASK ) ==ACP_POWERED_OFF , -DELAY_US ,ACP_TIMEOUT ); -} -static int acp3x_reset (void __iomem *base) {u32 val;
@@ -246,12 +235,6 @@ static int rn_acp_deinit(void __iomem *base)return ret;writel (0x00 , base +ACP_CONTROL ); - -/* power off */ - ret =acp3x_power_off (base); -if (ret) -return ret; -return 0 ; }static int renoir_audio_probe (struct platform_device *pdev)
Signature · 1 line
2.25.1
PATCH 2/11 ASoC: amd: acp: refactor the acp init and de-init sequence
In reply to Syed Saba KareemRemove the individual acp init and de-init functions from different variants of acp pci driver(for renoir/rembrandt platforms) and use a common file to define callbacks and refactor the callbacks to support existing platforms.
--- sound/soc/amd/acp/Kconfig | 4 + sound/soc/amd/acp/Makefile | 2 + sound/soc/amd/acp/acp-legacy-common.c | 99 +++++++++++++++++++++++ sound/soc/amd/acp/acp-pci.c | 9 +++ sound/soc/amd/acp/acp-rembrandt.c | 110 -------------------------- sound/soc/amd/acp/acp-renoir.c | 92 --------------------- sound/soc/amd/acp/amd.h | 21 +++++ 7 files changed, 135 insertions(+), 202 deletions(-) create mode 100644 sound/soc/amd/acp/acp-legacy-common.c
sound/soc/amd/acp/Kconfig +4 -0
@@ -18,6 +18,9 @@ if SND_SOC_AMD_ACP_COMMON config SND_SOC_AMD_ACP_PDM tristate +config SND_SOC_AMD_ACP_LEGACY_COMMON + tristate + config SND_SOC_AMD_ACP_I2S tristate
@@ -28,6 +31,7 @@ config SND_SOC_AMD_ACP_PCM config SND_SOC_AMD_ACP_PCI tristate "AMD ACP PCI Driver Support" depends on X86 && PCI + select SND_SOC_AMD_ACP_LEGACY_COMMON help This options enables generic PCI driver for ACP device.
sound/soc/amd/acp/Makefile +2 -0
@@ -8,6 +8,7 @@ snd-acp-pcm-objs := acp-platform.o snd-acp-i2s-objs := acp-i2s.o snd-acp-pdm-objs := acp-pdm.o +snd-acp-legacy-common-objs := acp-legacy-common.o snd-acp-pci-objs := acp-pci.o #platform specific driver
@@ -22,6 +23,7 @@ snd-acp-sof-mach-objs := acp-sof-mach.o obj-$(CONFIG_SND_SOC_AMD_ACP_PCM) += snd-acp-pcm.o obj-$(CONFIG_SND_SOC_AMD_ACP_I2S) += snd-acp-i2s.o obj-$(CONFIG_SND_SOC_AMD_ACP_PDM) += snd-acp-pdm.o +obj-$(CONFIG_SND_SOC_AMD_ACP_LEGACY_COMMON) += snd-acp-legacy-common.o obj-$(CONFIG_SND_SOC_AMD_ACP_PCI) += snd-acp-pci.o obj-$(CONFIG_SND_AMD_ASOC_RENOIR) += snd-acp-renoir.o
sound/soc/amd/acp/acp-legacy-common.c new file +99 -0
99 lines not on this page · raw message
sound/soc/amd/acp/acp-pci.c +9 -0
@@ -107,6 +107,7 @@ static int acp_pci_probe(struct pci_dev *pci, const struct pci_device_id *pci_id goto unregister_dmic_dev; } +acp_init (chip); res =devm_kcalloc (&pci->dev, num_res,sizeof (struct resource ),GFP_KERNEL );if (!res) { ret = -ENOMEM ;
@@ -155,10 +156,17 @@ static int acp_pci_probe(struct pci_dev *pci, const struct pci_device_id *pci_idstatic void acp_pci_remove (struct pci_dev *pci) { +struct acp_chip_info *chip; +int ret; + + chip =pci_get_drvdata (pci);if (dmic_dev)platform_device_unregister (dmic_dev);if (pdev)platform_device_unregister (pdev); + ret =acp_deinit (chip->base); +if (ret) +dev_err (&pci->dev,"ACP de-init failed\n" ); }/* PCI IDs */
@@ -178,4 +186,5 @@ static struct pci_driver snd_amd_acp_pci_driver = {module_pci_driver (snd_amd_acp_pci_driver);MODULE_LICENSE ("Dual BSD/GPL" ); +MODULE_IMPORT_NS (SND_SOC_ACP_COMMON );MODULE_ALIAS (DRV_NAME );
sound/soc/amd/acp/acp-rembrandt.c +0 -110
140 lines not on this page · raw message
sound/soc/amd/acp/acp-renoir.c +0 -92
124 lines not on this page · raw message
sound/soc/amd/acp/amd.h +21 -0
@@ -92,6 +92,25 @@#define SLOT_WIDTH_24 0x18#define SLOT_WIDTH_32 0x20 +#define ACP6X_PGFSM_CONTROL 0x1024 +#define ACP6X_PGFSM_STATUS 0x1028 + +#define ACP_SOFT_RST_DONE_MASK 0x00010001 + +#define ACP_PGFSM_CNTL_POWER_ON_MASK 0x01 +#define ACP_PGFSM_CNTL_POWER_OFF_MASK 0x00 +#define ACP_PGFSM_STATUS_MASK 0x03 +#define ACP_POWERED_ON 0x00 +#define ACP_POWER_ON_IN_PROGRESS 0x01 +#define ACP_POWERED_OFF 0x02 +#define ACP_POWER_OFF_IN_PROGRESS 0x03 + +#define ACP_ERROR_MASK 0x20000000 +#define ACP_EXT_INTR_STAT_CLEAR_MASK 0xffffffff + +#define ACP_TIMEOUT 500 +#define DELAY_US 5 +struct acp_chip_info {char *name;/* Platform name */ unsigned int acp_rev;/* ACP Revision id */
@@ -168,6 +187,8 @@ int acp_platform_unregister(struct device *dev);int acp_machine_select (struct acp_dev_data *adata); +int acp_init (struct acp_chip_info *chip); +int acp_deinit (void __iomem *base);/* Machine configuration */ int snd_amd_acp_find_config (struct pci_dev *pci);
Signature · 1 line
2.25.1
PATCH 2/12 ASoC: amd: acp: remove acp poweroff function
In reply to Syed Saba KareemBIOS invokes ACP Power off sequence based on ACP device state. Remove redundant code from ACP PCI driver for ACP Power off sequence.
--- sound/soc/amd/acp/acp-rembrandt.c | 25 ------------------------- sound/soc/amd/acp/acp-renoir.c | 17 ----------------- 2 files changed, 42 deletions(-)
sound/soc/amd/acp/acp-rembrandt.c +0 -25
@@ -204,23 +204,6 @@ static int acp6x_power_on(void __iomem *base)return -ETIMEDOUT ; } -static int acp6x_power_off (void __iomem *base) -{ -u32 val; -int timeout; - -writel (ACP_PGFSM_CNTL_POWER_OFF_MASK , - base +ACP6X_PGFSM_CONTROL ); - timeout =0 ; -while (++timeout <500 ) { - val =readl (base +ACP6X_PGFSM_STATUS ); -if ((val &ACP_PGFSM_STATUS_MASK ) ==ACP_POWERED_OFF ) -return 0 ; -udelay (1 ); - } -return -ETIMEDOUT ; -} -static int acp6x_reset (void __iomem *base) {u32 val;
@@ -299,14 +282,6 @@ static int rmb_acp_deinit(void __iomem *base) }writel (0x00 , base +ACP_CONTROL ); - -/* power off */ - ret =acp6x_power_off (base); -if (ret) { -pr_err ("ACP power off failed\n" ); -return ret; - } -return 0 ; }
sound/soc/amd/acp/acp-renoir.c +0 -17
@@ -169,17 +169,6 @@ static int acp3x_power_on(void __iomem *base)return readl_poll_timeout (base +ACP_PGFSM_STATUS , val, !val,DELAY_US ,ACP_TIMEOUT ); } -static int acp3x_power_off (void __iomem *base) -{ -u32 val; - -writel (ACP_PWR_OFF_MASK , base +ACP_PGFSM_CONTROL ); - -return readl_poll_timeout (base +ACP_PGFSM_STATUS , val, - (val &ACP_PGFSM_STAT_MASK ) ==ACP_POWERED_OFF , -DELAY_US ,ACP_TIMEOUT ); -} -static int acp3x_reset (void __iomem *base) {u32 val;
@@ -246,12 +235,6 @@ static int rn_acp_deinit(void __iomem *base)return ret;writel (0x00 , base +ACP_CONTROL ); - -/* power off */ - ret =acp3x_power_off (base); -if (ret) -return ret; -return 0 ; }static int renoir_audio_probe (struct platform_device *pdev)
Signature · 1 line
2.25.1
PATCH 3/11 ASoC: amd: acp: add acp i2s master clock generation for rembrandt platform
In reply to Syed Saba KareemAdd acp i2s master clock generation logic for rembrandt platform.
--- sound/soc/amd/acp/acp-legacy-common.c | 19 +++++++++++++++++++ sound/soc/amd/acp/acp-rembrandt.c | 26 ++++++++++++++++++++++++++ sound/soc/amd/acp/amd.h | 3 +++ 3 files changed, 48 insertions(+)
sound/soc/amd/acp/acp-legacy-common.c +19 -0
@@ -13,6 +13,7 @@*/ #include "amd.h" +#include <linux/pci.h> #include <linux/export.h> static int acp_power_on (struct acp_chip_info *chip)
@@ -96,4 +97,22 @@ int acp_deinit(void __iomem *base) }EXPORT_SYMBOL_NS_GPL (acp_deinit,SND_SOC_ACP_COMMON ); +int smn_write (struct pci_dev *dev,u32 smn_addr,u32 data) +{ +pci_write_config_dword (dev,0x60 , smn_addr); +pci_write_config_dword (dev,0x64 , data); +return 0 ; +} +EXPORT_SYMBOL_NS_GPL (smn_write,SND_SOC_ACP_COMMON ); + +int smn_read (struct pci_dev *dev,u32 smn_addr) +{ +u32 data; + +pci_write_config_dword (dev,0x60 , smn_addr); +pci_read_config_dword (dev,0x64 , &data); +return data; +} +EXPORT_SYMBOL_NS_GPL (smn_read,SND_SOC_ACP_COMMON ); +MODULE_LICENSE ("Dual BSD/GPL" );
sound/soc/amd/acp/acp-rembrandt.c +26 -0
@@ -19,11 +19,17 @@#include <sound/soc.h> #include <sound/soc-dai.h> #include <linux/dma-mapping.h> +#include <linux/pci.h> #include "amd.h" #define DRV_NAME "acp_asoc_rembrandt" +#define MP1_C2PMSG_69 0x3B10A14 +#define MP1_C2PMSG_85 0x3B10A54 +#define MP1_C2PMSG_93 0x3B10A74 +#define HOST_BRIDGE_ID 0x14B5 +static struct acp_resource rsrc = { .offset =0 , .no_of_ctrls =2 ,
@@ -160,6 +166,25 @@ static struct snd_soc_dai_driver acp_rmb_dai[] = { }, }; +int acp6x_master_clock_generate (struct device *dev) +{ +int data =0 ; +struct pci_dev *smn_dev; + + smn_dev =pci_get_device (PCI_VENDOR_ID_AMD ,HOST_BRIDGE_ID ,NULL ); +if (!smn_dev) { +dev_err (dev,"Failed to get host bridge device\n" ); +return -ENODEV ; + } + +smn_write (smn_dev,MP1_C2PMSG_93 ,0 ); +smn_write (smn_dev,MP1_C2PMSG_85 ,0xC4 ); +smn_write (smn_dev,MP1_C2PMSG_69 ,0x4 ); +read_poll_timeout (smn_read, data, data,DELAY_US , +ACP_TIMEOUT , false, smn_dev,MP1_C2PMSG_93 ); +return 0 ; +} +static void acp6x_enable_interrupts (struct acp_dev_data *adata) {struct acp_resource *rsrc = adata->rsrc;
@@ -228,6 +253,7 @@ static int rembrandt_audio_probe(struct platform_device *pdev)acp_machine_select (adata);dev_set_drvdata (dev, adata); +acp6x_master_clock_generate (dev);acp6x_enable_interrupts (adata);acp_platform_register (dev);
sound/soc/amd/acp/amd.h +3 -0
@@ -187,6 +187,9 @@ int acp_platform_unregister(struct device *dev);int acp_machine_select (struct acp_dev_data *adata); +int smn_read (struct pci_dev *dev,u32 smn_addr); +int smn_write (struct pci_dev *dev,u32 smn_addr,u32 data); +int acp_init (struct acp_chip_info *chip);int acp_deinit (void __iomem *base);/* Machine configuration */
Signature · 1 line
2.25.1
PATCH 3/12 ASoC: amd: acp: refactor the acp init and de-init sequence
In reply to Syed Saba KareemRemove the individual acp init and de-init functions from different variants of acp pci driver(for renoir/rembrandt platforms) and use a common file to define callbacks and refactor the callbacks to support existing platforms.
--- sound/soc/amd/acp/Kconfig | 4 + sound/soc/amd/acp/Makefile | 2 + sound/soc/amd/acp/acp-legacy-common.c | 99 +++++++++++++++++++++++ sound/soc/amd/acp/acp-pci.c | 9 +++ sound/soc/amd/acp/acp-rembrandt.c | 110 -------------------------- sound/soc/amd/acp/acp-renoir.c | 92 --------------------- sound/soc/amd/acp/amd.h | 21 +++++ 7 files changed, 135 insertions(+), 202 deletions(-) create mode 100644 sound/soc/amd/acp/acp-legacy-common.c
sound/soc/amd/acp/Kconfig +4 -0
@@ -18,6 +18,9 @@ if SND_SOC_AMD_ACP_COMMON config SND_SOC_AMD_ACP_PDM tristate +config SND_SOC_AMD_ACP_LEGACY_COMMON + tristate + config SND_SOC_AMD_ACP_I2S tristate
@@ -28,6 +31,7 @@ config SND_SOC_AMD_ACP_PCM config SND_SOC_AMD_ACP_PCI tristate "AMD ACP PCI Driver Support" depends on X86 && PCI + select SND_SOC_AMD_ACP_LEGACY_COMMON help This options enables generic PCI driver for ACP device.
sound/soc/amd/acp/Makefile +2 -0
@@ -8,6 +8,7 @@ snd-acp-pcm-objs := acp-platform.o snd-acp-i2s-objs := acp-i2s.o snd-acp-pdm-objs := acp-pdm.o +snd-acp-legacy-common-objs := acp-legacy-common.o snd-acp-pci-objs := acp-pci.o #platform specific driver
@@ -22,6 +23,7 @@ snd-acp-sof-mach-objs := acp-sof-mach.o obj-$(CONFIG_SND_SOC_AMD_ACP_PCM) += snd-acp-pcm.o obj-$(CONFIG_SND_SOC_AMD_ACP_I2S) += snd-acp-i2s.o obj-$(CONFIG_SND_SOC_AMD_ACP_PDM) += snd-acp-pdm.o +obj-$(CONFIG_SND_SOC_AMD_ACP_LEGACY_COMMON) += snd-acp-legacy-common.o obj-$(CONFIG_SND_SOC_AMD_ACP_PCI) += snd-acp-pci.o obj-$(CONFIG_SND_AMD_ASOC_RENOIR) += snd-acp-renoir.o
sound/soc/amd/acp/acp-legacy-common.c new file +99 -0
99 lines not on this page · raw message
sound/soc/amd/acp/acp-pci.c +9 -0
@@ -107,6 +107,7 @@ static int acp_pci_probe(struct pci_dev *pci, const struct pci_device_id *pci_id goto unregister_dmic_dev; } +acp_init (chip); res =devm_kcalloc (&pci->dev, num_res,sizeof (struct resource ),GFP_KERNEL );if (!res) { ret = -ENOMEM ;
@@ -155,10 +156,17 @@ static int acp_pci_probe(struct pci_dev *pci, const struct pci_device_id *pci_idstatic void acp_pci_remove (struct pci_dev *pci) { +struct acp_chip_info *chip; +int ret; + + chip =pci_get_drvdata (pci);if (dmic_dev)platform_device_unregister (dmic_dev);if (pdev)platform_device_unregister (pdev); + ret =acp_deinit (chip->base); +if (ret) +dev_err (&pci->dev,"ACP de-init failed\n" ); }/* PCI IDs */
@@ -178,4 +186,5 @@ static struct pci_driver snd_amd_acp_pci_driver = {module_pci_driver (snd_amd_acp_pci_driver);MODULE_LICENSE ("Dual BSD/GPL" ); +MODULE_IMPORT_NS (SND_SOC_ACP_COMMON );MODULE_ALIAS (DRV_NAME );
sound/soc/amd/acp/acp-rembrandt.c +0 -110
140 lines not on this page · raw message
sound/soc/amd/acp/acp-renoir.c +0 -92
124 lines not on this page · raw message
sound/soc/amd/acp/amd.h +21 -0
@@ -92,6 +92,25 @@#define SLOT_WIDTH_24 0x18#define SLOT_WIDTH_32 0x20 +#define ACP6X_PGFSM_CONTROL 0x1024 +#define ACP6X_PGFSM_STATUS 0x1028 + +#define ACP_SOFT_RST_DONE_MASK 0x00010001 + +#define ACP_PGFSM_CNTL_POWER_ON_MASK 0x01 +#define ACP_PGFSM_CNTL_POWER_OFF_MASK 0x00 +#define ACP_PGFSM_STATUS_MASK 0x03 +#define ACP_POWERED_ON 0x00 +#define ACP_POWER_ON_IN_PROGRESS 0x01 +#define ACP_POWERED_OFF 0x02 +#define ACP_POWER_OFF_IN_PROGRESS 0x03 + +#define ACP_ERROR_MASK 0x20000000 +#define ACP_EXT_INTR_STAT_CLEAR_MASK 0xffffffff + +#define ACP_TIMEOUT 500 +#define DELAY_US 5 +struct acp_chip_info {char *name;/* Platform name */ unsigned int acp_rev;/* ACP Revision id */
@@ -168,6 +187,8 @@ int acp_platform_unregister(struct device *dev);int acp_machine_select (struct acp_dev_data *adata); +int acp_init (struct acp_chip_info *chip); +int acp_deinit (void __iomem *base);/* Machine configuration */ int snd_amd_acp_find_config (struct pci_dev *pci);
Signature · 1 line
2.25.1
PATCH 4/12 ASoC: amd: acp: add acp i2s master clock generation for rembrandt platform
In reply to Syed Saba KareemAdd acp i2s master clock generation logic for rembrandt platform.
--- sound/soc/amd/acp/acp-legacy-common.c | 19 +++++++++++++++++++ sound/soc/amd/acp/acp-rembrandt.c | 26 ++++++++++++++++++++++++++ sound/soc/amd/acp/amd.h | 3 +++ 3 files changed, 48 insertions(+)
sound/soc/amd/acp/acp-legacy-common.c +19 -0
@@ -13,6 +13,7 @@*/ #include "amd.h" +#include <linux/pci.h> #include <linux/export.h> static int acp_power_on (struct acp_chip_info *chip)
@@ -96,4 +97,22 @@ int acp_deinit(void __iomem *base) }EXPORT_SYMBOL_NS_GPL (acp_deinit,SND_SOC_ACP_COMMON ); +int smn_write (struct pci_dev *dev,u32 smn_addr,u32 data) +{ +pci_write_config_dword (dev,0x60 , smn_addr); +pci_write_config_dword (dev,0x64 , data); +return 0 ; +} +EXPORT_SYMBOL_NS_GPL (smn_write,SND_SOC_ACP_COMMON ); + +int smn_read (struct pci_dev *dev,u32 smn_addr) +{ +u32 data; + +pci_write_config_dword (dev,0x60 , smn_addr); +pci_read_config_dword (dev,0x64 , &data); +return data; +} +EXPORT_SYMBOL_NS_GPL (smn_read,SND_SOC_ACP_COMMON ); +MODULE_LICENSE ("Dual BSD/GPL" );
sound/soc/amd/acp/acp-rembrandt.c +26 -0
@@ -19,11 +19,17 @@#include <sound/soc.h> #include <sound/soc-dai.h> #include <linux/dma-mapping.h> +#include <linux/pci.h> #include "amd.h" #define DRV_NAME "acp_asoc_rembrandt" +#define MP1_C2PMSG_69 0x3B10A14 +#define MP1_C2PMSG_85 0x3B10A54 +#define MP1_C2PMSG_93 0x3B10A74 +#define HOST_BRIDGE_ID 0x14B5 +static struct acp_resource rsrc = { .offset =0 , .no_of_ctrls =2 ,
@@ -160,6 +166,25 @@ static struct snd_soc_dai_driver acp_rmb_dai[] = { }, }; +int acp6x_master_clock_generate (struct device *dev) +{ +int data =0 ; +struct pci_dev *smn_dev; + + smn_dev =pci_get_device (PCI_VENDOR_ID_AMD ,HOST_BRIDGE_ID ,NULL ); +if (!smn_dev) { +dev_err (dev,"Failed to get host bridge device\n" ); +return -ENODEV ; + } + +smn_write (smn_dev,MP1_C2PMSG_93 ,0 ); +smn_write (smn_dev,MP1_C2PMSG_85 ,0xC4 ); +smn_write (smn_dev,MP1_C2PMSG_69 ,0x4 ); +read_poll_timeout (smn_read, data, data,DELAY_US , +ACP_TIMEOUT , false, smn_dev,MP1_C2PMSG_93 ); +return 0 ; +} +static void acp6x_enable_interrupts (struct acp_dev_data *adata) {struct acp_resource *rsrc = adata->rsrc;
@@ -228,6 +253,7 @@ static int rembrandt_audio_probe(struct platform_device *pdev)acp_machine_select (adata);dev_set_drvdata (dev, adata); +acp6x_master_clock_generate (dev);acp6x_enable_interrupts (adata);acp_platform_register (dev);
sound/soc/amd/acp/amd.h +3 -0
@@ -187,6 +187,9 @@ int acp_platform_unregister(struct device *dev);int acp_machine_select (struct acp_dev_data *adata); +int smn_read (struct pci_dev *dev,u32 smn_addr); +int smn_write (struct pci_dev *dev,u32 smn_addr,u32 data); +int acp_init (struct acp_chip_info *chip);int acp_deinit (void __iomem *base);/* Machine configuration */
Signature · 1 line
2.25.1
Mark Brown
maintainerRe: [PATCH 04/12] ASoC: amd: acp: add acp i2s master clock generation for rembrandt platform
Quoted 1 line · Syed Saba Kareem
Add acp i2s master clock generation logic for rembrandt platform.
This doesn't apply against current code, please check and resend.
RE: [PATCH 04/12] ASoC: amd: acp: add acp i2s master clock generation for rembrandt platform
[AMD Official Use Only - General]
We found few warnings, will fix, and will resend the patch series.
Thanks,
Syed Saba Kareem
-----Original Message-----
From: Mark Brown <[email protected]>
Sent: Friday, June 23, 2023 4:01 AM
To: Saba Kareem, Syed <[email protected]>
Cc: [email protected]; Mukunda, Vijendar <[email protected]>; Hiregoudar, Basavaraj <[email protected]>; Dommati, Sunil-kumar <[email protected]>; Reddy, V sujith kumar <[email protected]>; Liam Girdwood <[email protected]>; Jaroslav Kysela <[email protected]>; Takashi Iwai <[email protected]>; Nicolas Ferre <[email protected]>; Uwe Kleine-König <[email protected]>; Prasad, Prasad <[email protected]>; Ajit Kumar Pandey <[email protected]>; open list <[email protected]>
Subject: Re: [PATCH 04/12] ASoC: amd: acp: add acp i2s master clock generation for rembrandt platform
Quoted 1 line · Syed Saba Kareem
Add acp i2s master clock generation logic for rembrandt platform.
This doesn't apply against current code, please check and resend.
kernel test robot
build botRe: [PATCH 04/12] ASoC: amd: acp: add acp i2s master clock generation for rembrandt platform
In reply to Syed Saba Kareemkernel test robot noticed the following build warnings:
Hi Syed,
kernel test robot noticed the following build warnings:
[auto build test WARNING on broonie-sound/for-next]
[also build test WARNING on linus/master v6.4-rc7 next-20230622] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Syed-Saba-Kareem/ASoC-amd-acp-remove-acp-poweroff-function/20230622-233145 base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next patch link: https://lore.kernel.org/r/20230622152406.3709231-7-Syed.SabaKareem%40amd.com patch subject: [PATCH 04/12] ASoC: amd: acp: add acp i2s master clock generation for rembrandt platform config: i386-allyesconfig (https://download.01.org/0day-ci/archive/20230623/[email protected]/config) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 reproduce: (https://download.01.org/0day-ci/archive/20230623/[email protected]/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
All warnings (new ones prefixed by >>):
>> sound/soc/amd/acp/acp-rembrandt.c:169:5: warning: no previous prototype for 'acp6x_master_clock_generate' [-Wmissing-prototypes]
169 | int acp6x_master_clock_generate(struct device *dev)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
vim +/acp6x_master_clock_generate +169 sound/soc/amd/acp/acp-rembrandt.c
168
> 169 int acp6x_master_clock_generate(struct device *dev)
170 {
171 int data = 0;
172 struct pci_dev *smn_dev;
173
174 smn_dev = pci_get_device(PCI_VENDOR_ID_AMD, HOST_BRIDGE_ID, NULL);
175 if (!smn_dev) {
176 dev_err(dev, "Failed to get host bridge device\n");
177 return -ENODEV;
178 }
179
180 smn_write(smn_dev, MP1_C2PMSG_93, 0);
181 smn_write(smn_dev, MP1_C2PMSG_85, 0xC4);
182 smn_write(smn_dev, MP1_C2PMSG_69, 0x4);
183 read_poll_timeout(smn_read, data, data, DELAY_US,
184 ACP_TIMEOUT, false, smn_dev, MP1_C2PMSG_93);
185 return 0;
186 }
187
Signature · 2 lines
0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
PATCH 4/11 ASoC: amd: acp: remove the redundant acp enable/disable interrupts functions
In reply to Syed Saba KareemInstead of having individual acp enable/disable interrupts functions for each platform, implement common place holder to handle the same for all AMD platforms.
--- sound/soc/amd/acp/acp-legacy-common.c | 21 +++++++++++++++++++++ sound/soc/amd/acp/acp-rembrandt.c | 24 ++---------------------- sound/soc/amd/acp/acp-renoir.c | 23 ++--------------------- sound/soc/amd/acp/amd.h | 2 ++ 4 files changed, 27 insertions(+), 43 deletions(-)
sound/soc/amd/acp/acp-legacy-common.c +21 -0
@@ -16,6 +16,27 @@#include <linux/pci.h> #include <linux/export.h> +void acp_enable_interrupts (struct acp_dev_data *adata) +{ +struct acp_resource *rsrc = adata->rsrc; +u32 ext_intr_ctrl; + +writel (0x01 ,ACP_EXTERNAL_INTR_ENB (adata)); + ext_intr_ctrl =readl (ACP_EXTERNAL_INTR_CNTL (adata, rsrc->irqp_used)); + ext_intr_ctrl |=ACP_ERROR_MASK ; +writel (ext_intr_ctrl,ACP_EXTERNAL_INTR_CNTL (adata, rsrc->irqp_used)); +} +EXPORT_SYMBOL_NS_GPL (acp_enable_interrupts,SND_SOC_ACP_COMMON ); + +void acp_disable_interrupts (struct acp_dev_data *adata) +{ +struct acp_resource *rsrc = adata->rsrc; + +writel (ACP_EXT_INTR_STAT_CLEAR_MASK ,ACP_EXTERNAL_INTR_STAT (adata, rsrc->irqp_used)); +writel (0x00 ,ACP_EXTERNAL_INTR_ENB (adata)); +} +EXPORT_SYMBOL_NS_GPL (acp_disable_interrupts,SND_SOC_ACP_COMMON ); +static int acp_power_on (struct acp_chip_info *chip) {u32 val, acp_pgfsm_stat_reg, acp_pgfsm_ctrl_reg;
sound/soc/amd/acp/acp-rembrandt.c +2 -22
@@ -185,26 +185,6 @@ int acp6x_master_clock_generate(struct device *dev)return 0 ; } -static void acp6x_enable_interrupts (struct acp_dev_data *adata) -{ -struct acp_resource *rsrc = adata->rsrc; -u32 ext_intr_ctrl; - -writel (0x01 ,ACP_EXTERNAL_INTR_ENB (adata)); - ext_intr_ctrl =readl (ACP_EXTERNAL_INTR_CNTL (adata, rsrc->irqp_used)); - ext_intr_ctrl |=ACP_ERROR_MASK ; -writel (ext_intr_ctrl,ACP_EXTERNAL_INTR_CNTL (adata, rsrc->irqp_used)); -} - -static void acp6x_disable_interrupts (struct acp_dev_data *adata) -{ -struct acp_resource *rsrc = adata->rsrc; - -writel (ACP_EXT_INTR_STAT_CLEAR_MASK , -ACP_EXTERNAL_INTR_STAT (adata, rsrc->irqp_used)); -writel (0x00 ,ACP_EXTERNAL_INTR_ENB (adata)); -} -static int rembrandt_audio_probe (struct platform_device *pdev) {struct device *dev = &pdev->dev;
@@ -254,7 +234,7 @@ static int rembrandt_audio_probe(struct platform_device *pdev)dev_set_drvdata (dev, adata);acp6x_master_clock_generate (dev); -acp6x_enable_interrupts (adata); +acp_enable_interrupts (adata);acp_platform_register (dev);return 0 ;
@@ -265,7 +245,7 @@ static void rembrandt_audio_remove(struct platform_device *pdev)struct device *dev = &pdev->dev;struct acp_dev_data *adata =dev_get_drvdata (dev); -acp6x_disable_interrupts (adata); +acp_disable_interrupts (adata);acp_platform_unregister (dev); }
sound/soc/amd/acp/acp-renoir.c +2 -21
@@ -140,25 +140,6 @@ static struct snd_soc_dai_driver acp_renoir_dai[] = { }, }; -static void acp3x_enable_interrupts (struct acp_dev_data *adata) -{ -struct acp_resource *rsrc = adata->rsrc; -u32 ext_intr_ctrl; - -writel (0x01 ,ACP_EXTERNAL_INTR_ENB (adata)); - ext_intr_ctrl =readl (ACP_EXTERNAL_INTR_CNTL (adata, rsrc->irqp_used)); - ext_intr_ctrl |=ACP_ERROR_MASK ; -writel (ext_intr_ctrl,ACP_EXTERNAL_INTR_CNTL (adata, rsrc->irqp_used)); -} - -static void acp3x_disable_interrupts (struct acp_dev_data *adata) -{ -struct acp_resource *rsrc = adata->rsrc; - -writel (ACP_EXT_INTR_STAT_CLEAR_MASK , -ACP_EXTERNAL_INTR_STAT (adata, rsrc->irqp_used)); -writel (0x00 ,ACP_EXTERNAL_INTR_ENB (adata)); -}static int renoir_audio_probe (struct platform_device *pdev) {
@@ -207,7 +188,7 @@ static int renoir_audio_probe(struct platform_device *pdev)acp_machine_select (adata);dev_set_drvdata (dev, adata); -acp3x_enable_interrupts (adata); +acp_enable_interrupts (adata);acp_platform_register (dev);return 0 ;
@@ -218,7 +199,7 @@ static void renoir_audio_remove(struct platform_device *pdev)struct device *dev = &pdev->dev;struct acp_dev_data *adata =dev_get_drvdata (dev); -acp3x_disable_interrupts (adata); +acp_disable_interrupts (adata);acp_platform_unregister (dev); }
sound/soc/amd/acp/amd.h +2 -0
@@ -192,6 +192,8 @@ int smn_write(struct pci_dev *dev, u32 smn_addr, u32 data);int acp_init (struct acp_chip_info *chip);int acp_deinit (void __iomem *base); +void acp_enable_interrupts (struct acp_dev_data *adata); +void acp_disable_interrupts (struct acp_dev_data *adata);/* Machine configuration */ int snd_amd_acp_find_config (struct pci_dev *pci);
Signature · 1 line
2.25.1
PATCH 5/12 ASoC: amd: acp: remove the redundant acp enable/disable interrupts functions
In reply to Syed Saba KareemInstead of having individual acp enable/disable interrupts functions for each platform, implement common place holder to handle the same for all AMD platforms.
--- sound/soc/amd/acp/acp-legacy-common.c | 21 +++++++++++++++++++++ sound/soc/amd/acp/acp-rembrandt.c | 24 ++---------------------- sound/soc/amd/acp/acp-renoir.c | 23 ++--------------------- sound/soc/amd/acp/amd.h | 2 ++ 4 files changed, 27 insertions(+), 43 deletions(-)
sound/soc/amd/acp/acp-legacy-common.c +21 -0
@@ -16,6 +16,27 @@#include <linux/pci.h> #include <linux/export.h> +void acp_enable_interrupts (struct acp_dev_data *adata) +{ +struct acp_resource *rsrc = adata->rsrc; +u32 ext_intr_ctrl; + +writel (0x01 ,ACP_EXTERNAL_INTR_ENB (adata)); + ext_intr_ctrl =readl (ACP_EXTERNAL_INTR_CNTL (adata, rsrc->irqp_used)); + ext_intr_ctrl |=ACP_ERROR_MASK ; +writel (ext_intr_ctrl,ACP_EXTERNAL_INTR_CNTL (adata, rsrc->irqp_used)); +} +EXPORT_SYMBOL_NS_GPL (acp_enable_interrupts,SND_SOC_ACP_COMMON ); + +void acp_disable_interrupts (struct acp_dev_data *adata) +{ +struct acp_resource *rsrc = adata->rsrc; + +writel (ACP_EXT_INTR_STAT_CLEAR_MASK ,ACP_EXTERNAL_INTR_STAT (adata, rsrc->irqp_used)); +writel (0x00 ,ACP_EXTERNAL_INTR_ENB (adata)); +} +EXPORT_SYMBOL_NS_GPL (acp_disable_interrupts,SND_SOC_ACP_COMMON ); +static int acp_power_on (struct acp_chip_info *chip) {u32 val, acp_pgfsm_stat_reg, acp_pgfsm_ctrl_reg;
sound/soc/amd/acp/acp-rembrandt.c +2 -22
@@ -185,26 +185,6 @@ int acp6x_master_clock_generate(struct device *dev)return 0 ; } -static void acp6x_enable_interrupts (struct acp_dev_data *adata) -{ -struct acp_resource *rsrc = adata->rsrc; -u32 ext_intr_ctrl; - -writel (0x01 ,ACP_EXTERNAL_INTR_ENB (adata)); - ext_intr_ctrl =readl (ACP_EXTERNAL_INTR_CNTL (adata, rsrc->irqp_used)); - ext_intr_ctrl |=ACP_ERROR_MASK ; -writel (ext_intr_ctrl,ACP_EXTERNAL_INTR_CNTL (adata, rsrc->irqp_used)); -} - -static void acp6x_disable_interrupts (struct acp_dev_data *adata) -{ -struct acp_resource *rsrc = adata->rsrc; - -writel (ACP_EXT_INTR_STAT_CLEAR_MASK , -ACP_EXTERNAL_INTR_STAT (adata, rsrc->irqp_used)); -writel (0x00 ,ACP_EXTERNAL_INTR_ENB (adata)); -} -static int rembrandt_audio_probe (struct platform_device *pdev) {struct device *dev = &pdev->dev;
@@ -254,7 +234,7 @@ static int rembrandt_audio_probe(struct platform_device *pdev)dev_set_drvdata (dev, adata);acp6x_master_clock_generate (dev); -acp6x_enable_interrupts (adata); +acp_enable_interrupts (adata);acp_platform_register (dev);return 0 ;
@@ -265,7 +245,7 @@ static void rembrandt_audio_remove(struct platform_device *pdev)struct device *dev = &pdev->dev;struct acp_dev_data *adata =dev_get_drvdata (dev); -acp6x_disable_interrupts (adata); +acp_disable_interrupts (adata);acp_platform_unregister (dev); }
sound/soc/amd/acp/acp-renoir.c +2 -21
@@ -140,25 +140,6 @@ static struct snd_soc_dai_driver acp_renoir_dai[] = { }, }; -static void acp3x_enable_interrupts (struct acp_dev_data *adata) -{ -struct acp_resource *rsrc = adata->rsrc; -u32 ext_intr_ctrl; - -writel (0x01 ,ACP_EXTERNAL_INTR_ENB (adata)); - ext_intr_ctrl =readl (ACP_EXTERNAL_INTR_CNTL (adata, rsrc->irqp_used)); - ext_intr_ctrl |=ACP_ERROR_MASK ; -writel (ext_intr_ctrl,ACP_EXTERNAL_INTR_CNTL (adata, rsrc->irqp_used)); -} - -static void acp3x_disable_interrupts (struct acp_dev_data *adata) -{ -struct acp_resource *rsrc = adata->rsrc; - -writel (ACP_EXT_INTR_STAT_CLEAR_MASK , -ACP_EXTERNAL_INTR_STAT (adata, rsrc->irqp_used)); -writel (0x00 ,ACP_EXTERNAL_INTR_ENB (adata)); -}static int renoir_audio_probe (struct platform_device *pdev) {
@@ -207,7 +188,7 @@ static int renoir_audio_probe(struct platform_device *pdev)acp_machine_select (adata);dev_set_drvdata (dev, adata); -acp3x_enable_interrupts (adata); +acp_enable_interrupts (adata);acp_platform_register (dev);return 0 ;
@@ -218,7 +199,7 @@ static void renoir_audio_remove(struct platform_device *pdev)struct device *dev = &pdev->dev;struct acp_dev_data *adata =dev_get_drvdata (dev); -acp3x_disable_interrupts (adata); +acp_disable_interrupts (adata);acp_platform_unregister (dev); }
sound/soc/amd/acp/amd.h +2 -0
@@ -192,6 +192,8 @@ int smn_write(struct pci_dev *dev, u32 smn_addr, u32 data);int acp_init (struct acp_chip_info *chip);int acp_deinit (void __iomem *base); +void acp_enable_interrupts (struct acp_dev_data *adata); +void acp_disable_interrupts (struct acp_dev_data *adata);/* Machine configuration */ int snd_amd_acp_find_config (struct pci_dev *pci);
Signature · 1 line
2.25.1
kernel test robot
build botRe: [PATCH 05/12] ASoC: amd: acp: remove the redundant acp enable/disable interrupts functions
kernel test robot noticed the following build errors:
Hi Syed,
kernel test robot noticed the following build errors:
[auto build test ERROR on broonie-sound/for-next]
[also build test ERROR on linus/master v6.4-rc7 next-20230622] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Syed-Saba-Kareem/ASoC-amd-acp-remove-acp-poweroff-function/20230622-233145 base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next patch link: https://lore.kernel.org/r/20230622152406.3709231-9-Syed.SabaKareem%40amd.com patch subject: [PATCH 05/12] ASoC: amd: acp: remove the redundant acp enable/disable interrupts functions config: i386-buildonly-randconfig-r006-20230622 (https://download.01.org/0day-ci/archive/20230623/[email protected]/config) compiler: clang version 15.0.7 (https://github.com/llvm/llvm-project.git 8dfdcc7b7bf66834a761bd8de445840ef68e4d1a) reproduce: (https://download.01.org/0day-ci/archive/20230623/[email protected]/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
All errors (new ones prefixed by >>):
>> ld.lld: error: undefined symbol: acp_enable_interrupts >>> referenced by acp-renoir.c:191 (sound/soc/amd/acp/acp-renoir.c:191) >>> sound/soc/amd/acp/acp-renoir.o:(renoir_audio_probe) in archive vmlinux.a -- >> ld.lld: error: undefined symbol: acp_disable_interrupts >>> referenced by acp-renoir.c:202 (sound/soc/amd/acp/acp-renoir.c:202) >>> sound/soc/amd/acp/acp-renoir.o:(renoir_audio_remove) in archive vmlinux.a
pahole: .tmp_vmlinux.btf: Invalid argument ld.lld: error: .btf.vmlinux.bin.o: unknown file type
Signature · 2 lines
0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
PATCH 5/11 ASoC: amd: acp: store platform device reference created in pci probe call
In reply to Syed Saba KareemStore the platform device reference created in pci driver, it will be used in restoring the interrupts during system level resume.
--- sound/soc/amd/acp/acp-pci.c | 2 +- sound/soc/amd/acp/amd.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-)
sound/soc/amd/acp/acp-pci.c +1 -1
@@ -141,7 +141,7 @@ static int acp_pci_probe(struct pci_dev *pci, const struct pci_device_id *pci_id ret =PTR_ERR (pdev); goto unregister_dmic_dev; } - + chip->chip_pdev = pdev;return ret; unregister_dmic_dev:
sound/soc/amd/acp/amd.h +1 -0
@@ -115,6 +115,7 @@ struct acp_chip_info {char *name;/* Platform name */ unsigned int acp_rev;/* ACP Revision id */ void __iomem *base;/* ACP memory PCI base */ +struct platform_device *chip_pdev; };struct acp_stream {
Signature · 1 line
2.25.1
PATCH 6/11 ASoC: amd: acp: add pm ops support for acp pci driver
In reply to Syed Saba KareemAdd pm ops support for common acp pci driver.
--- sound/soc/amd/acp/acp-pci.c | 45 +++++++++++++++++++++++++++++++++++++ 1 file changed, 45 insertions(+)
sound/soc/amd/acp/acp-pci.c +45 -0
@@ -142,6 +142,11 @@ static int acp_pci_probe(struct pci_dev *pci, const struct pci_device_id *pci_id goto unregister_dmic_dev; } chip->chip_pdev = pdev; +dev_set_drvdata (&pci->dev, chip); +pm_runtime_set_autosuspend_delay (&pci->dev,2000 ); +pm_runtime_use_autosuspend (&pci->dev); +pm_runtime_put_noidle (&pci->dev); +pm_runtime_allow (&pci->dev);return ret; unregister_dmic_dev:
@@ -154,12 +159,49 @@ static int acp_pci_probe(struct pci_dev *pci, const struct pci_device_id *pci_idreturn ret; }; +static int __maybe_unused snd_acp_suspend (struct device *dev) +{ +struct acp_chip_info *chip; +int ret; + + chip =dev_get_drvdata (dev); + ret =acp_deinit (chip->base); +if (ret) +dev_err (dev,"ACP de-init failed\n" ); +return ret; +} + +static int __maybe_unused snd_acp_resume (struct device *dev) +{ +struct acp_chip_info *chip; +struct acp_dev_data *adata; +struct device child; +int ret; + + chip =dev_get_drvdata (dev); + ret =acp_init (chip); +if (ret) +dev_err (dev,"ACP init failed\n" ); + child = chip->chip_pdev->dev; + adata =dev_get_drvdata (&child); +if (adata) +acp_enable_interrupts (adata); +return ret; +} + +static const struct dev_pm_ops acp_pm_ops = { + SET_RUNTIME_PM_OPS(snd_acp_suspend, snd_acp_resume, NULL) +SET_SYSTEM_SLEEP_PM_OPS (snd_acp_suspend, snd_acp_resume) +}; +static void acp_pci_remove (struct pci_dev *pci) {struct acp_chip_info *chip;int ret; chip =pci_get_drvdata (pci); +pm_runtime_forbid (&pci->dev); +pm_runtime_get_noresume (&pci->dev);if (dmic_dev)platform_device_unregister (dmic_dev);if (pdev)
@@ -182,6 +224,9 @@ static struct pci_driver snd_amd_acp_pci_driver = { .id_table = acp_pci_ids, .probe = acp_pci_probe, .remove = acp_pci_remove, + .driver = { + .pm = &acp_pm_ops, + }, };module_pci_driver (snd_amd_acp_pci_driver);
Signature · 1 line
2.25.1
PATCH 6/12 ASoC: amd: acp: store platform device reference created in pci probe call
In reply to Syed Saba KareemStore the platform device reference created in pci driver, it will be used in restoring the interrupts during system level resume.
--- sound/soc/amd/acp/acp-pci.c | 2 +- sound/soc/amd/acp/amd.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-)
sound/soc/amd/acp/acp-pci.c +1 -1
@@ -141,7 +141,7 @@ static int acp_pci_probe(struct pci_dev *pci, const struct pci_device_id *pci_id ret =PTR_ERR (pdev); goto unregister_dmic_dev; } - + chip->chip_pdev = pdev;return ret; unregister_dmic_dev:
sound/soc/amd/acp/amd.h +1 -0
@@ -115,6 +115,7 @@ struct acp_chip_info {char *name;/* Platform name */ unsigned int acp_rev;/* ACP Revision id */ void __iomem *base;/* ACP memory PCI base */ +struct platform_device *chip_pdev; };struct acp_stream {
Signature · 1 line
2.25.1
PATCH 7/12 ASoC: amd: acp: add pm ops support for acp pci driver
In reply to Syed Saba KareemAdd pm ops support for common acp pci driver.
--- sound/soc/amd/acp/acp-pci.c | 45 +++++++++++++++++++++++++++++++++++++ 1 file changed, 45 insertions(+)
sound/soc/amd/acp/acp-pci.c +45 -0
@@ -142,6 +142,11 @@ static int acp_pci_probe(struct pci_dev *pci, const struct pci_device_id *pci_id goto unregister_dmic_dev; } chip->chip_pdev = pdev; +dev_set_drvdata (&pci->dev, chip); +pm_runtime_set_autosuspend_delay (&pci->dev,2000 ); +pm_runtime_use_autosuspend (&pci->dev); +pm_runtime_put_noidle (&pci->dev); +pm_runtime_allow (&pci->dev);return ret; unregister_dmic_dev:
@@ -154,12 +159,49 @@ static int acp_pci_probe(struct pci_dev *pci, const struct pci_device_id *pci_idreturn ret; }; +static int __maybe_unused snd_acp_suspend (struct device *dev) +{ +struct acp_chip_info *chip; +int ret; + + chip =dev_get_drvdata (dev); + ret =acp_deinit (chip->base); +if (ret) +dev_err (dev,"ACP de-init failed\n" ); +return ret; +} + +static int __maybe_unused snd_acp_resume (struct device *dev) +{ +struct acp_chip_info *chip; +struct acp_dev_data *adata; +struct device child; +int ret; + + chip =dev_get_drvdata (dev); + ret =acp_init (chip); +if (ret) +dev_err (dev,"ACP init failed\n" ); + child = chip->chip_pdev->dev; + adata =dev_get_drvdata (&child); +if (adata) +acp_enable_interrupts (adata); +return ret; +} + +static const struct dev_pm_ops acp_pm_ops = { + SET_RUNTIME_PM_OPS(snd_acp_suspend, snd_acp_resume, NULL) +SET_SYSTEM_SLEEP_PM_OPS (snd_acp_suspend, snd_acp_resume) +}; +static void acp_pci_remove (struct pci_dev *pci) {struct acp_chip_info *chip;int ret; chip =pci_get_drvdata (pci); +pm_runtime_forbid (&pci->dev); +pm_runtime_get_noresume (&pci->dev);if (dmic_dev)platform_device_unregister (dmic_dev);if (pdev)
@@ -182,6 +224,9 @@ static struct pci_driver snd_amd_acp_pci_driver = { .id_table = acp_pci_ids, .probe = acp_pci_probe, .remove = acp_pci_remove, + .driver = { + .pm = &acp_pm_ops, + }, };module_pci_driver (snd_amd_acp_pci_driver);
Signature · 1 line
2.25.1
PATCH 7/11 ASoC: amd: acp: store xfer_resolution of the stream
In reply to Syed Saba KareemStore the 'xfer_resolution' of the stream in private data structure, it will be used to reprogram the xfer_resolution for the active stream during system level resume.
--- sound/soc/amd/acp/acp-i2s.c | 2 ++ sound/soc/amd/acp/amd.h | 2 ++ 2 files changed, 4 insertions(+)
sound/soc/amd/acp/acp-i2s.c +2 -0
@@ -149,6 +149,7 @@ static int acp_i2s_hwparams(struct snd_pcm_substream *substream, struct snd_pcm_dev_err (dev,"Invalid dai id %x\n" , dai->driver->id);return -EINVAL ; } + adata->xfer_tx_resolution[dai->driver->id -1 ] = xfer_resolution; }else {switch (dai->driver->id) {case I2S_BT_INSTANCE :
@@ -167,6 +168,7 @@ static int acp_i2s_hwparams(struct snd_pcm_substream *substream, struct snd_pcm_dev_err (dev,"Invalid dai id %x\n" , dai->driver->id);return -EINVAL ; } + adata->xfer_rx_resolution[dai->driver->id -1 ] = xfer_resolution; } val =readl (adata->acp_base + reg_val);
sound/soc/amd/acp/amd.h +2 -0
@@ -166,6 +166,8 @@ struct acp_dev_data {struct acp_resource *rsrc;u32 tdm_tx_fmt[3 ];u32 tdm_rx_fmt[3 ]; +u32 xfer_tx_resolution[3 ]; +u32 xfer_rx_resolution[3 ]; };union acp_i2stdm_mstrclkgen {
Signature · 1 line
2.25.1
PATCH 8/12 ASoC: amd: acp: store xfer_resolution of the stream
In reply to Syed Saba KareemStore the 'xfer_resolution' of the stream in private data structure, it will be used to reprogram the xfer_resolution for the active stream during system level resume.
--- sound/soc/amd/acp/acp-i2s.c | 2 ++ sound/soc/amd/acp/amd.h | 2 ++ 2 files changed, 4 insertions(+)
sound/soc/amd/acp/acp-i2s.c +2 -0
@@ -149,6 +149,7 @@ static int acp_i2s_hwparams(struct snd_pcm_substream *substream, struct snd_pcm_dev_err (dev,"Invalid dai id %x\n" , dai->driver->id);return -EINVAL ; } + adata->xfer_tx_resolution[dai->driver->id -1 ] = xfer_resolution; }else {switch (dai->driver->id) {case I2S_BT_INSTANCE :
@@ -167,6 +168,7 @@ static int acp_i2s_hwparams(struct snd_pcm_substream *substream, struct snd_pcm_dev_err (dev,"Invalid dai id %x\n" , dai->driver->id);return -EINVAL ; } + adata->xfer_rx_resolution[dai->driver->id -1 ] = xfer_resolution; } val =readl (adata->acp_base + reg_val);
sound/soc/amd/acp/amd.h +2 -0
@@ -166,6 +166,8 @@ struct acp_dev_data {struct acp_resource *rsrc;u32 tdm_tx_fmt[3 ];u32 tdm_rx_fmt[3 ]; +u32 xfer_tx_resolution[3 ]; +u32 xfer_rx_resolution[3 ]; };union acp_i2stdm_mstrclkgen {
Signature · 1 line
2.25.1
PATCH 8/11 ASoC: amd: acp: export config_acp_dma() and config_pte_for_stream() symbols
In reply to Syed Saba KareemExport config_acp_dma() and config_pte_for_stream() functions. These functions will be used to restore stream configuration during system level resume.
--- sound/soc/amd/acp/acp-platform.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
sound/soc/amd/acp/acp-platform.c +4 -2
@@ -128,7 +128,7 @@ static irqreturn_t i2s_irq_handler(int irq, void *data)return IRQ_NONE ; } -static void config_pte_for_stream (struct acp_dev_data *adata,struct acp_stream *stream) +void config_pte_for_stream (struct acp_dev_data *adata,struct acp_stream *stream) {struct acp_resource *rsrc = adata->rsrc;u32 pte_reg, pte_size, reg_val;
@@ -144,8 +144,9 @@ static void config_pte_for_stream(struct acp_dev_data *adata, struct acp_streamwritel (PAGE_SIZE_4K_ENABLE , adata->acp_base + pte_size);writel (0x01 , adata->acp_base +ACPAXI2AXI_ATU_CTRL ); } +EXPORT_SYMBOL_NS_GPL (config_pte_for_stream,SND_SOC_ACP_COMMON ); -static void config_acp_dma (struct acp_dev_data *adata,struct acp_stream *stream,int size) +void config_acp_dma (struct acp_dev_data *adata,struct acp_stream *stream,int size) {struct snd_pcm_substream *substream = stream->substream;struct acp_resource *rsrc = adata->rsrc;
@@ -169,6 +170,7 @@ static void config_acp_dma(struct acp_dev_data *adata, struct acp_stream *stream addr +=PAGE_SIZE ; } } +EXPORT_SYMBOL_NS_GPL (config_acp_dma,SND_SOC_ACP_COMMON );static int acp_dma_open (struct snd_soc_component *component,struct snd_pcm_substream *substream) {
Signature · 1 line
2.25.1
PATCH 9/12 ASoC: amd: acp: export config_acp_dma() and config_pte_for_stream() symbols
In reply to Syed Saba KareemExport config_acp_dma() and config_pte_for_stream() functions. These functions will be used to restore stream configuration during system level resume.
--- sound/soc/amd/acp/acp-platform.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
sound/soc/amd/acp/acp-platform.c +4 -2
@@ -128,7 +128,7 @@ static irqreturn_t i2s_irq_handler(int irq, void *data)return IRQ_NONE ; } -static void config_pte_for_stream (struct acp_dev_data *adata,struct acp_stream *stream) +void config_pte_for_stream (struct acp_dev_data *adata,struct acp_stream *stream) {struct acp_resource *rsrc = adata->rsrc;u32 pte_reg, pte_size, reg_val;
@@ -144,8 +144,9 @@ static void config_pte_for_stream(struct acp_dev_data *adata, struct acp_streamwritel (PAGE_SIZE_4K_ENABLE , adata->acp_base + pte_size);writel (0x01 , adata->acp_base +ACPAXI2AXI_ATU_CTRL ); } +EXPORT_SYMBOL_NS_GPL (config_pte_for_stream,SND_SOC_ACP_COMMON ); -static void config_acp_dma (struct acp_dev_data *adata,struct acp_stream *stream,int size) +void config_acp_dma (struct acp_dev_data *adata,struct acp_stream *stream,int size) {struct snd_pcm_substream *substream = stream->substream;struct acp_resource *rsrc = adata->rsrc;
@@ -169,6 +170,7 @@ static void config_acp_dma(struct acp_dev_data *adata, struct acp_stream *stream addr +=PAGE_SIZE ; } } +EXPORT_SYMBOL_NS_GPL (config_acp_dma,SND_SOC_ACP_COMMON );static int acp_dma_open (struct snd_soc_component *component,struct snd_pcm_substream *substream) {
Signature · 1 line
2.25.1
PATCH 9/11 ASoC: amd: acp: store the pdm stream channel mask
In reply to Syed Saba KareemStore the pdm stream channel mask, it will be used during system level resume.
--- sound/soc/amd/acp/acp-pdm.c | 1 + sound/soc/amd/acp/amd.h | 1 + 2 files changed, 2 insertions(+)
sound/soc/amd/acp/acp-pdm.c +1 -0
@@ -135,6 +135,7 @@ static int acp_dmic_hwparams(struct snd_pcm_substream *substream,return -EINVAL ; } + adata->ch_mask = ch_mask;if (params_format (hwparams) !=SNDRV_PCM_FORMAT_S32_LE ) {dev_err (dai->dev,"Invalid format:%d\n" ,params_format (hwparams));return -EINVAL ;
sound/soc/amd/acp/amd.h +1 -0
@@ -164,6 +164,7 @@ struct acp_dev_data {u32 lrclk_div;struct acp_resource *rsrc; +u32 ch_mask;u32 tdm_tx_fmt[3 ];u32 tdm_rx_fmt[3 ];u32 xfer_tx_resolution[3 ];
Signature · 1 line
2.25.1
PATCH 10/11 ASoC: amd: acp: move pdm macros to common header file
In reply to Syed Saba KareemMove pdm related macros from pdm file to common header file so that it can be used across different files.
--- sound/soc/amd/acp/acp-pdm.c | 12 ------------ sound/soc/amd/acp/amd.h | 12 ++++++++++++ 2 files changed, 12 insertions(+), 12 deletions(-)
sound/soc/amd/acp/acp-pdm.c +0 -12
@@ -25,18 +25,6 @@#define DRV_NAME "acp-pdm" -#define PDM_DMA_STAT 0x10 -#define PDM_DMA_INTR_MASK 0x10000 -#define PDM_DEC_64 0x2 -#define PDM_CLK_FREQ_MASK 0x07 -#define PDM_MISC_CTRL_MASK 0x10 -#define PDM_ENABLE 0x01 -#define PDM_DISABLE 0x00 -#define DMA_EN_MASK 0x02 -#define DELAY_US 5 -#define PDM_TIMEOUT 1000 -#define ACP_REGION2_OFFSET 0x02000000 -static int acp_dmic_prepare (struct snd_pcm_substream *substream,struct snd_soc_dai *dai) {
sound/soc/amd/acp/amd.h +12 -0
@@ -111,6 +111,18 @@#define ACP_TIMEOUT 500#define DELAY_US 5 +#define PDM_DMA_STAT 0x10 +#define PDM_DMA_INTR_MASK 0x10000 +#define PDM_DEC_64 0x2 +#define PDM_CLK_FREQ_MASK 0x07 +#define PDM_MISC_CTRL_MASK 0x10 +#define PDM_ENABLE 0x01 +#define PDM_DISABLE 0x00 +#define DMA_EN_MASK 0x02 +#define DELAY_US 5 +#define PDM_TIMEOUT 1000 +#define ACP_REGION2_OFFSET 0x02000000 +struct acp_chip_info {char *name;/* Platform name */ unsigned int acp_rev;/* ACP Revision id */
Signature · 1 line
2.25.1
PATCH 10/12 ASoC: amd: acp: store the pdm stream channel mask
In reply to Syed Saba KareemStore the pdm stream channel mask, it will be used during system level resume.
--- sound/soc/amd/acp/acp-pdm.c | 1 + sound/soc/amd/acp/amd.h | 1 + 2 files changed, 2 insertions(+)
sound/soc/amd/acp/acp-pdm.c +1 -0
@@ -135,6 +135,7 @@ static int acp_dmic_hwparams(struct snd_pcm_substream *substream,return -EINVAL ; } + adata->ch_mask = ch_mask;if (params_format (hwparams) !=SNDRV_PCM_FORMAT_S32_LE ) {dev_err (dai->dev,"Invalid format:%d\n" ,params_format (hwparams));return -EINVAL ;
sound/soc/amd/acp/amd.h +1 -0
@@ -164,6 +164,7 @@ struct acp_dev_data {u32 lrclk_div;struct acp_resource *rsrc; +u32 ch_mask;u32 tdm_tx_fmt[3 ];u32 tdm_rx_fmt[3 ];u32 xfer_tx_resolution[3 ];
Signature · 1 line
2.25.1
PATCH 11/11 ASoC: amd: acp: add pm ops support for rembrandt platform
In reply to Syed Saba KareemAdd pm ops for rembrandt platform.
--- sound/soc/amd/acp/acp-legacy-common.c | 208 ++++++++++++++++++++++++++ sound/soc/amd/acp/acp-rembrandt.c | 42 +++++- sound/soc/amd/acp/amd.h | 9 ++ 3 files changed, 258 insertions(+), 1 deletion(-)
sound/soc/amd/acp/acp-legacy-common.c +208 -0
@@ -37,6 +37,214 @@ void acp_disable_interrupts(struct acp_dev_data *adata) }EXPORT_SYMBOL_NS_GPL (acp_disable_interrupts,SND_SOC_ACP_COMMON ); +static void set_acp_pdm_ring_buffer (struct snd_pcm_substream *substream, +struct snd_soc_dai *dai) +{ +struct snd_pcm_runtime *runtime = substream->runtime; +struct acp_stream *stream = runtime->private_data; +struct device *dev = dai->component->dev; +struct acp_dev_data *adata =dev_get_drvdata (dev); + +u32 physical_addr, pdm_size, period_bytes; + + period_bytes =frames_to_bytes (runtime, runtime->period_size); + pdm_size =frames_to_bytes (runtime, runtime->buffer_size); + physical_addr = stream->reg_offset +MEM_WINDOW_START ; + +/* Init ACP PDM Ring buffer */ +writel (physical_addr, adata->acp_base +ACP_WOV_RX_RINGBUFADDR ); +writel (pdm_size, adata->acp_base +ACP_WOV_RX_RINGBUFSIZE ); +writel (period_bytes, adata->acp_base +ACP_WOV_RX_INTR_WATERMARK_SIZE ); +writel (0x01 , adata->acp_base +ACPAXI2AXI_ATU_CTRL ); +} + +static void set_acp_pdm_clk (struct snd_pcm_substream *substream, +struct snd_soc_dai *dai) +{ +struct device *dev = dai->component->dev; +struct acp_dev_data *adata =dev_get_drvdata (dev); +unsigned int pdm_ctrl; + +/* Enable default ACP PDM clk */ +writel (PDM_CLK_FREQ_MASK , adata->acp_base +ACP_WOV_CLK_CTRL ); + pdm_ctrl =readl (adata->acp_base +ACP_WOV_MISC_CTRL ); + pdm_ctrl |=PDM_MISC_CTRL_MASK ; +writel (pdm_ctrl, adata->acp_base +ACP_WOV_MISC_CTRL ); +set_acp_pdm_ring_buffer (substream, dai); +} + +void restore_acp_pdm_params (struct snd_pcm_substream *substream, +struct acp_dev_data *adata) +{ +struct snd_soc_dai *dai; +struct snd_soc_pcm_runtime *soc_runtime; +u32 ext_int_ctrl; + + soc_runtime =asoc_substream_to_rtd (substream); + dai =asoc_rtd_to_cpu (soc_runtime,0 ); +/* Programming channel mask and sampling rate */ +writel (adata->ch_mask, adata->acp_base +ACP_WOV_PDM_NO_OF_CHANNELS ); +writel (PDM_DEC_64 , adata->acp_base +ACP_WOV_PDM_DECIMATION_FACTOR ); + +/* Enabling ACP Pdm interuppts */ + ext_int_ctrl =readl (ACP_EXTERNAL_INTR_CNTL (adata,0 )); + ext_int_ctrl |=PDM_DMA_INTR_MASK ; +writel (ext_int_ctrl,ACP_EXTERNAL_INTR_CNTL (adata,0 )); +set_acp_pdm_clk (substream, dai); +} +EXPORT_SYMBOL_NS_GPL (restore_acp_pdm_params,SND_SOC_ACP_COMMON ); + +static int set_acp_i2s_dma_fifo (struct snd_pcm_substream *substream, +struct snd_soc_dai *dai) +{ +struct device *dev = dai->component->dev; +struct acp_dev_data *adata =dev_get_drvdata (dev); +struct acp_resource *rsrc = adata->rsrc; +struct acp_stream *stream = substream->runtime->private_data; +u32 reg_dma_size, reg_fifo_size, reg_fifo_addr; +u32 phy_addr, acp_fifo_addr, ext_int_ctrl; +unsigned int dir = substream->stream; + +switch (dai->driver->id) { +case I2S_SP_INSTANCE : +if (dir ==SNDRV_PCM_STREAM_PLAYBACK ) { + reg_dma_size =ACP_I2S_TX_DMA_SIZE ; + acp_fifo_addr = rsrc->sram_pte_offset + +SP_PB_FIFO_ADDR_OFFSET ; + reg_fifo_addr =ACP_I2S_TX_FIFOADDR ; + reg_fifo_size =ACP_I2S_TX_FIFOSIZE ; + phy_addr =I2S_SP_TX_MEM_WINDOW_START + stream->reg_offset; +writel (phy_addr, adata->acp_base +ACP_I2S_TX_RINGBUFADDR ); + }else { + reg_dma_size =ACP_I2S_RX_DMA_SIZE ; + acp_fifo_addr = rsrc->sram_pte_offset + +SP_CAPT_FIFO_ADDR_OFFSET ; + reg_fifo_addr =ACP_I2S_RX_FIFOADDR ; + reg_fifo_size =ACP_I2S_RX_FIFOSIZE ; + phy_addr =I2S_SP_RX_MEM_WINDOW_START + stream->reg_offset; +writel (phy_addr, adata->acp_base +ACP_I2S_RX_RINGBUFADDR ); + } +break ; +case I2S_BT_INSTANCE : +if (dir ==SNDRV_PCM_STREAM_PLAYBACK ) { + reg_dma_size =ACP_BT_TX_DMA_SIZE ; + acp_fifo_addr = rsrc->sram_pte_offset + +BT_PB_FIFO_ADDR_OFFSET ; + reg_fifo_addr =ACP_BT_TX_FIFOADDR ; + reg_fifo_size =ACP_BT_TX_FIFOSIZE ; + phy_addr =I2S_BT_TX_MEM_WINDOW_START + stream->reg_offset; +writel (phy_addr, adata->acp_base +ACP_BT_TX_RINGBUFADDR ); + }else { + reg_dma_size =ACP_BT_RX_DMA_SIZE ; + acp_fifo_addr = rsrc->sram_pte_offset + +BT_CAPT_FIFO_ADDR_OFFSET ; + reg_fifo_addr =ACP_BT_RX_FIFOADDR ; + reg_fifo_size =ACP_BT_RX_FIFOSIZE ; + phy_addr =I2S_BT_TX_MEM_WINDOW_START + stream->reg_offset; +writel (phy_addr, adata->acp_base +ACP_BT_RX_RINGBUFADDR ); + } +break ; +case I2S_HS_INSTANCE : +if (dir ==SNDRV_PCM_STREAM_PLAYBACK ) { + reg_dma_size =ACP_HS_TX_DMA_SIZE ; + acp_fifo_addr = rsrc->sram_pte_offset + +HS_PB_FIFO_ADDR_OFFSET ; + reg_fifo_addr =ACP_HS_TX_FIFOADDR ; + reg_fifo_size =ACP_HS_TX_FIFOSIZE ; + phy_addr =I2S_HS_TX_MEM_WINDOW_START + stream->reg_offset; +writel (phy_addr, adata->acp_base +ACP_HS_TX_RINGBUFADDR ); + }else { + reg_dma_size =ACP_HS_RX_DMA_SIZE ; + acp_fifo_addr = rsrc->sram_pte_offset + +HS_CAPT_FIFO_ADDR_OFFSET ; + reg_fifo_addr =ACP_HS_RX_FIFOADDR ; + reg_fifo_size =ACP_HS_RX_FIFOSIZE ; + phy_addr =I2S_HS_RX_MEM_WINDOW_START + stream->reg_offset; +writel (phy_addr, adata->acp_base +ACP_HS_RX_RINGBUFADDR ); + } +break ; +default : +dev_err (dev,"Invalid dai id %x\n" , dai->driver->id); +return -EINVAL ; + } + +writel (DMA_SIZE , adata->acp_base + reg_dma_size); +writel (acp_fifo_addr, adata->acp_base + reg_fifo_addr); +writel (FIFO_SIZE , adata->acp_base + reg_fifo_size); + + ext_int_ctrl =readl (ACP_EXTERNAL_INTR_CNTL (adata, rsrc->irqp_used)); + ext_int_ctrl |=BIT (I2S_RX_THRESHOLD (rsrc->offset)) | +BIT (BT_RX_THRESHOLD (rsrc->offset)) | +BIT (I2S_TX_THRESHOLD (rsrc->offset)) | +BIT (BT_TX_THRESHOLD (rsrc->offset)) | +BIT (HS_RX_THRESHOLD (rsrc->offset)) | +BIT (HS_TX_THRESHOLD (rsrc->offset)); + +writel (ext_int_ctrl,ACP_EXTERNAL_INTR_CNTL (adata, rsrc->irqp_used)); +return 0 ; +} + +int restore_acp_i2s_params (struct snd_pcm_substream *substream, +struct acp_dev_data *adata, +struct acp_stream *stream) +{ +struct snd_soc_dai *dai; +struct snd_soc_pcm_runtime *soc_runtime; +u32 tdm_fmt, reg_val, fmt_reg, val; + + soc_runtime =asoc_substream_to_rtd (substream); + dai =asoc_rtd_to_cpu (soc_runtime,0 ); +if (substream->stream ==SNDRV_PCM_STREAM_PLAYBACK ) { + tdm_fmt = adata->tdm_tx_fmt[stream->dai_id -1 ]; +switch (stream->dai_id) { +case I2S_BT_INSTANCE : + reg_val =ACP_BTTDM_ITER ; + fmt_reg =ACP_BTTDM_TXFRMT ; +break ; +case I2S_SP_INSTANCE : + reg_val =ACP_I2STDM_ITER ; + fmt_reg =ACP_I2STDM_TXFRMT ; +break ; +case I2S_HS_INSTANCE : + reg_val =ACP_HSTDM_ITER ; + fmt_reg =ACP_HSTDM_TXFRMT ; +break ; +default : +pr_err ("Invalid dai id %x\n" , stream->dai_id); +return -EINVAL ; + } + val = adata->xfer_tx_resolution[stream->dai_id -1 ] <<3 ; + }else { + tdm_fmt = adata->tdm_rx_fmt[stream->dai_id -1 ]; +switch (stream->dai_id) { +case I2S_BT_INSTANCE : + reg_val =ACP_BTTDM_IRER ; + fmt_reg =ACP_BTTDM_RXFRMT ; +break ; +case I2S_SP_INSTANCE : + reg_val =ACP_I2STDM_IRER ; + fmt_reg =ACP_I2STDM_RXFRMT ; +break ; +case I2S_HS_INSTANCE : + reg_val =ACP_HSTDM_IRER ; + fmt_reg =ACP_HSTDM_RXFRMT ; +break ; +default : +pr_err ("Invalid dai id %x\n" , stream->dai_id); +return -EINVAL ; + } + val = adata->xfer_rx_resolution[stream->dai_id -1 ] <<3 ; + } +writel (val, adata->acp_base + reg_val); +if (adata->tdm_mode ==TDM_ENABLE ) { +writel (tdm_fmt, adata->acp_base + fmt_reg); + val =readl (adata->acp_base + reg_val); +writel (val |0x2 , adata->acp_base + reg_val); + } +return set_acp_i2s_dma_fifo (substream, dai); +} +EXPORT_SYMBOL_NS_GPL (restore_acp_i2s_params,SND_SOC_ACP_COMMON ); +static int acp_power_on (struct acp_chip_info *chip) {u32 val, acp_pgfsm_stat_reg, acp_pgfsm_ctrl_reg;
sound/soc/amd/acp/acp-rembrandt.c +41 -1
67 lines not on this page · raw message
sound/soc/amd/acp/amd.h +9 -0
@@ -110,6 +110,7 @@#define ACP_TIMEOUT 500#define DELAY_US 5 +#define ACP_SUSPEND_DELAY_MS 2000#define PDM_DMA_STAT 0x10#define PDM_DMA_INTR_MASK 0x10000
@@ -213,6 +214,14 @@ void acp_disable_interrupts(struct acp_dev_data *adata);/* Machine configuration */ int snd_amd_acp_find_config (struct pci_dev *pci); +void config_pte_for_stream (struct acp_dev_data *adata,struct acp_stream *stream); +void config_acp_dma (struct acp_dev_data *adata,struct acp_stream *stream,int size); +void restore_acp_pdm_params (struct snd_pcm_substream *substream, +struct acp_dev_data *adata); + +int restore_acp_i2s_params (struct snd_pcm_substream *substream, +struct acp_dev_data *adata,struct acp_stream *stream); +static inline u64 acp_get_byte_count (struct acp_dev_data *adata,int dai_id,int direction) {u64 byte_count, low =0 , high =0 ;
Signature · 1 line
2.25.1
PATCH 11/12 ASoC: amd: acp: move pdm macros to common header file
In reply to Syed Saba KareemMove pdm related macros from pdm file to common header file so that it can be used across different files.
--- sound/soc/amd/acp/acp-pdm.c | 12 ------------ sound/soc/amd/acp/amd.h | 12 ++++++++++++ 2 files changed, 12 insertions(+), 12 deletions(-)
sound/soc/amd/acp/acp-pdm.c +0 -12
@@ -25,18 +25,6 @@#define DRV_NAME "acp-pdm" -#define PDM_DMA_STAT 0x10 -#define PDM_DMA_INTR_MASK 0x10000 -#define PDM_DEC_64 0x2 -#define PDM_CLK_FREQ_MASK 0x07 -#define PDM_MISC_CTRL_MASK 0x10 -#define PDM_ENABLE 0x01 -#define PDM_DISABLE 0x00 -#define DMA_EN_MASK 0x02 -#define DELAY_US 5 -#define PDM_TIMEOUT 1000 -#define ACP_REGION2_OFFSET 0x02000000 -static int acp_dmic_prepare (struct snd_pcm_substream *substream,struct snd_soc_dai *dai) {
sound/soc/amd/acp/amd.h +12 -0
@@ -111,6 +111,18 @@#define ACP_TIMEOUT 500#define DELAY_US 5 +#define PDM_DMA_STAT 0x10 +#define PDM_DMA_INTR_MASK 0x10000 +#define PDM_DEC_64 0x2 +#define PDM_CLK_FREQ_MASK 0x07 +#define PDM_MISC_CTRL_MASK 0x10 +#define PDM_ENABLE 0x01 +#define PDM_DISABLE 0x00 +#define DMA_EN_MASK 0x02 +#define DELAY_US 5 +#define PDM_TIMEOUT 1000 +#define ACP_REGION2_OFFSET 0x02000000 +struct acp_chip_info {char *name;/* Platform name */ unsigned int acp_rev;/* ACP Revision id */
Signature · 1 line
2.25.1
PATCH 12/12 ASoC: amd: acp: add pm ops support for rembrandt platform
In reply to Syed Saba KareemAdd pm ops for rembrandt platform.
--- sound/soc/amd/acp/acp-legacy-common.c | 208 ++++++++++++++++++++++++++ sound/soc/amd/acp/acp-rembrandt.c | 42 +++++- sound/soc/amd/acp/amd.h | 9 ++ 3 files changed, 258 insertions(+), 1 deletion(-)
sound/soc/amd/acp/acp-legacy-common.c +208 -0
@@ -37,6 +37,214 @@ void acp_disable_interrupts(struct acp_dev_data *adata) }EXPORT_SYMBOL_NS_GPL (acp_disable_interrupts,SND_SOC_ACP_COMMON ); +static void set_acp_pdm_ring_buffer (struct snd_pcm_substream *substream, +struct snd_soc_dai *dai) +{ +struct snd_pcm_runtime *runtime = substream->runtime; +struct acp_stream *stream = runtime->private_data; +struct device *dev = dai->component->dev; +struct acp_dev_data *adata =dev_get_drvdata (dev); + +u32 physical_addr, pdm_size, period_bytes; + + period_bytes =frames_to_bytes (runtime, runtime->period_size); + pdm_size =frames_to_bytes (runtime, runtime->buffer_size); + physical_addr = stream->reg_offset +MEM_WINDOW_START ; + +/* Init ACP PDM Ring buffer */ +writel (physical_addr, adata->acp_base +ACP_WOV_RX_RINGBUFADDR ); +writel (pdm_size, adata->acp_base +ACP_WOV_RX_RINGBUFSIZE ); +writel (period_bytes, adata->acp_base +ACP_WOV_RX_INTR_WATERMARK_SIZE ); +writel (0x01 , adata->acp_base +ACPAXI2AXI_ATU_CTRL ); +} + +static void set_acp_pdm_clk (struct snd_pcm_substream *substream, +struct snd_soc_dai *dai) +{ +struct device *dev = dai->component->dev; +struct acp_dev_data *adata =dev_get_drvdata (dev); +unsigned int pdm_ctrl; + +/* Enable default ACP PDM clk */ +writel (PDM_CLK_FREQ_MASK , adata->acp_base +ACP_WOV_CLK_CTRL ); + pdm_ctrl =readl (adata->acp_base +ACP_WOV_MISC_CTRL ); + pdm_ctrl |=PDM_MISC_CTRL_MASK ; +writel (pdm_ctrl, adata->acp_base +ACP_WOV_MISC_CTRL ); +set_acp_pdm_ring_buffer (substream, dai); +} + +void restore_acp_pdm_params (struct snd_pcm_substream *substream, +struct acp_dev_data *adata) +{ +struct snd_soc_dai *dai; +struct snd_soc_pcm_runtime *soc_runtime; +u32 ext_int_ctrl; + + soc_runtime =asoc_substream_to_rtd (substream); + dai =asoc_rtd_to_cpu (soc_runtime,0 ); +/* Programming channel mask and sampling rate */ +writel (adata->ch_mask, adata->acp_base +ACP_WOV_PDM_NO_OF_CHANNELS ); +writel (PDM_DEC_64 , adata->acp_base +ACP_WOV_PDM_DECIMATION_FACTOR ); + +/* Enabling ACP Pdm interuppts */ + ext_int_ctrl =readl (ACP_EXTERNAL_INTR_CNTL (adata,0 )); + ext_int_ctrl |=PDM_DMA_INTR_MASK ; +writel (ext_int_ctrl,ACP_EXTERNAL_INTR_CNTL (adata,0 )); +set_acp_pdm_clk (substream, dai); +} +EXPORT_SYMBOL_NS_GPL (restore_acp_pdm_params,SND_SOC_ACP_COMMON ); + +static int set_acp_i2s_dma_fifo (struct snd_pcm_substream *substream, +struct snd_soc_dai *dai) +{ +struct device *dev = dai->component->dev; +struct acp_dev_data *adata =dev_get_drvdata (dev); +struct acp_resource *rsrc = adata->rsrc; +struct acp_stream *stream = substream->runtime->private_data; +u32 reg_dma_size, reg_fifo_size, reg_fifo_addr; +u32 phy_addr, acp_fifo_addr, ext_int_ctrl; +unsigned int dir = substream->stream; + +switch (dai->driver->id) { +case I2S_SP_INSTANCE : +if (dir ==SNDRV_PCM_STREAM_PLAYBACK ) { + reg_dma_size =ACP_I2S_TX_DMA_SIZE ; + acp_fifo_addr = rsrc->sram_pte_offset + +SP_PB_FIFO_ADDR_OFFSET ; + reg_fifo_addr =ACP_I2S_TX_FIFOADDR ; + reg_fifo_size =ACP_I2S_TX_FIFOSIZE ; + phy_addr =I2S_SP_TX_MEM_WINDOW_START + stream->reg_offset; +writel (phy_addr, adata->acp_base +ACP_I2S_TX_RINGBUFADDR ); + }else { + reg_dma_size =ACP_I2S_RX_DMA_SIZE ; + acp_fifo_addr = rsrc->sram_pte_offset + +SP_CAPT_FIFO_ADDR_OFFSET ; + reg_fifo_addr =ACP_I2S_RX_FIFOADDR ; + reg_fifo_size =ACP_I2S_RX_FIFOSIZE ; + phy_addr =I2S_SP_RX_MEM_WINDOW_START + stream->reg_offset; +writel (phy_addr, adata->acp_base +ACP_I2S_RX_RINGBUFADDR ); + } +break ; +case I2S_BT_INSTANCE : +if (dir ==SNDRV_PCM_STREAM_PLAYBACK ) { + reg_dma_size =ACP_BT_TX_DMA_SIZE ; + acp_fifo_addr = rsrc->sram_pte_offset + +BT_PB_FIFO_ADDR_OFFSET ; + reg_fifo_addr =ACP_BT_TX_FIFOADDR ; + reg_fifo_size =ACP_BT_TX_FIFOSIZE ; + phy_addr =I2S_BT_TX_MEM_WINDOW_START + stream->reg_offset; +writel (phy_addr, adata->acp_base +ACP_BT_TX_RINGBUFADDR ); + }else { + reg_dma_size =ACP_BT_RX_DMA_SIZE ; + acp_fifo_addr = rsrc->sram_pte_offset + +BT_CAPT_FIFO_ADDR_OFFSET ; + reg_fifo_addr =ACP_BT_RX_FIFOADDR ; + reg_fifo_size =ACP_BT_RX_FIFOSIZE ; + phy_addr =I2S_BT_TX_MEM_WINDOW_START + stream->reg_offset; +writel (phy_addr, adata->acp_base +ACP_BT_RX_RINGBUFADDR ); + } +break ; +case I2S_HS_INSTANCE : +if (dir ==SNDRV_PCM_STREAM_PLAYBACK ) { + reg_dma_size =ACP_HS_TX_DMA_SIZE ; + acp_fifo_addr = rsrc->sram_pte_offset + +HS_PB_FIFO_ADDR_OFFSET ; + reg_fifo_addr =ACP_HS_TX_FIFOADDR ; + reg_fifo_size =ACP_HS_TX_FIFOSIZE ; + phy_addr =I2S_HS_TX_MEM_WINDOW_START + stream->reg_offset; +writel (phy_addr, adata->acp_base +ACP_HS_TX_RINGBUFADDR ); + }else { + reg_dma_size =ACP_HS_RX_DMA_SIZE ; + acp_fifo_addr = rsrc->sram_pte_offset + +HS_CAPT_FIFO_ADDR_OFFSET ; + reg_fifo_addr =ACP_HS_RX_FIFOADDR ; + reg_fifo_size =ACP_HS_RX_FIFOSIZE ; + phy_addr =I2S_HS_RX_MEM_WINDOW_START + stream->reg_offset; +writel (phy_addr, adata->acp_base +ACP_HS_RX_RINGBUFADDR ); + } +break ; +default : +dev_err (dev,"Invalid dai id %x\n" , dai->driver->id); +return -EINVAL ; + } + +writel (DMA_SIZE , adata->acp_base + reg_dma_size); +writel (acp_fifo_addr, adata->acp_base + reg_fifo_addr); +writel (FIFO_SIZE , adata->acp_base + reg_fifo_size); + + ext_int_ctrl =readl (ACP_EXTERNAL_INTR_CNTL (adata, rsrc->irqp_used)); + ext_int_ctrl |=BIT (I2S_RX_THRESHOLD (rsrc->offset)) | +BIT (BT_RX_THRESHOLD (rsrc->offset)) | +BIT (I2S_TX_THRESHOLD (rsrc->offset)) | +BIT (BT_TX_THRESHOLD (rsrc->offset)) | +BIT (HS_RX_THRESHOLD (rsrc->offset)) | +BIT (HS_TX_THRESHOLD (rsrc->offset)); + +writel (ext_int_ctrl,ACP_EXTERNAL_INTR_CNTL (adata, rsrc->irqp_used)); +return 0 ; +} + +int restore_acp_i2s_params (struct snd_pcm_substream *substream, +struct acp_dev_data *adata, +struct acp_stream *stream) +{ +struct snd_soc_dai *dai; +struct snd_soc_pcm_runtime *soc_runtime; +u32 tdm_fmt, reg_val, fmt_reg, val; + + soc_runtime =asoc_substream_to_rtd (substream); + dai =asoc_rtd_to_cpu (soc_runtime,0 ); +if (substream->stream ==SNDRV_PCM_STREAM_PLAYBACK ) { + tdm_fmt = adata->tdm_tx_fmt[stream->dai_id -1 ]; +switch (stream->dai_id) { +case I2S_BT_INSTANCE : + reg_val =ACP_BTTDM_ITER ; + fmt_reg =ACP_BTTDM_TXFRMT ; +break ; +case I2S_SP_INSTANCE : + reg_val =ACP_I2STDM_ITER ; + fmt_reg =ACP_I2STDM_TXFRMT ; +break ; +case I2S_HS_INSTANCE : + reg_val =ACP_HSTDM_ITER ; + fmt_reg =ACP_HSTDM_TXFRMT ; +break ; +default : +pr_err ("Invalid dai id %x\n" , stream->dai_id); +return -EINVAL ; + } + val = adata->xfer_tx_resolution[stream->dai_id -1 ] <<3 ; + }else { + tdm_fmt = adata->tdm_rx_fmt[stream->dai_id -1 ]; +switch (stream->dai_id) { +case I2S_BT_INSTANCE : + reg_val =ACP_BTTDM_IRER ; + fmt_reg =ACP_BTTDM_RXFRMT ; +break ; +case I2S_SP_INSTANCE : + reg_val =ACP_I2STDM_IRER ; + fmt_reg =ACP_I2STDM_RXFRMT ; +break ; +case I2S_HS_INSTANCE : + reg_val =ACP_HSTDM_IRER ; + fmt_reg =ACP_HSTDM_RXFRMT ; +break ; +default : +pr_err ("Invalid dai id %x\n" , stream->dai_id); +return -EINVAL ; + } + val = adata->xfer_rx_resolution[stream->dai_id -1 ] <<3 ; + } +writel (val, adata->acp_base + reg_val); +if (adata->tdm_mode ==TDM_ENABLE ) { +writel (tdm_fmt, adata->acp_base + fmt_reg); + val =readl (adata->acp_base + reg_val); +writel (val |0x2 , adata->acp_base + reg_val); + } +return set_acp_i2s_dma_fifo (substream, dai); +} +EXPORT_SYMBOL_NS_GPL (restore_acp_i2s_params,SND_SOC_ACP_COMMON ); +static int acp_power_on (struct acp_chip_info *chip) {u32 val, acp_pgfsm_stat_reg, acp_pgfsm_ctrl_reg;
sound/soc/amd/acp/acp-rembrandt.c +41 -1
67 lines not on this page · raw message
sound/soc/amd/acp/amd.h +9 -0
@@ -110,6 +110,7 @@#define ACP_TIMEOUT 500#define DELAY_US 5 +#define ACP_SUSPEND_DELAY_MS 2000#define PDM_DMA_STAT 0x10#define PDM_DMA_INTR_MASK 0x10000
@@ -213,6 +214,14 @@ void acp_disable_interrupts(struct acp_dev_data *adata);/* Machine configuration */ int snd_amd_acp_find_config (struct pci_dev *pci); +void config_pte_for_stream (struct acp_dev_data *adata,struct acp_stream *stream); +void config_acp_dma (struct acp_dev_data *adata,struct acp_stream *stream,int size); +void restore_acp_pdm_params (struct snd_pcm_substream *substream, +struct acp_dev_data *adata); + +int restore_acp_i2s_params (struct snd_pcm_substream *substream, +struct acp_dev_data *adata,struct acp_stream *stream); +static inline u64 acp_get_byte_count (struct acp_dev_data *adata,int dai_id,int direction) {u64 byte_count, low =0 , high =0 ;
Signature · 1 line
2.25.1
Mark Brown
maintainerQuoted 6 lines · Syed Saba Kareem
Clear pdm dma interrupt mask in
acp_dmic_shutdown().'Fixes:
c32bd332ce5c9("ASoC: amd: acp: Add generic support for PDM controller on ACP")'
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[01/12] ASoC: amd: acp: clear pdm dma interrupt mask
commit: ad60672394bd1f95c58d3d9336902f47e05126fc
[02/12] ASoC: amd: acp: remove acp poweroff function
commit: 3eb96217c16cb7be0fe6e1d416ff4fe47f686bea[03/11] ASoC: amd: acp: add acp i2s master clock generation for rembrandt platform
(no commit info)
[04/12] ASoC: amd: acp: add acp i2s master clock generation for rembrandt platform
(no commit info)
[05/11] ASoC: amd: acp: store platform device reference created in pci probe call
(no commit info)
[06/11] ASoC: amd: acp: add pm ops support for acp pci driver
(no commit info)
[07/12] ASoC: amd: acp: add pm ops support for acp pci driver
(no commit info)
[08/11] ASoC: amd: acp: export config_acp_dma() and config_pte_for_stream() symbols
(no commit info)
[09/11] ASoC: amd: acp: store the pdm stream channel mask
(no commit info)
[10/12] ASoC: amd: acp: store the pdm stream channel mask
(no commit info)
[11/12] ASoC: amd: acp: move pdm macros to common header file
(no commit info)
[12/12] ASoC: amd: acp: add pm ops support for rembrandt platform
(no commit info)
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark