Skip to contentSkip to conversation

f2fs: update mtime and ctime in move file range method

PATCH Superseded Yunlei He 3 participants 5 messages Jun 22, 2023 – Jun 23, 2023 F2FS file system

lore
Share & tools
lore

Yunlei He

author
#0 lore raw

PATCH v2 1/2 f2fs: update mtime and ctime in move file range method

Mtime and ctime stay old value without update after move file range ioctl. This patch add time update.

---
v2:
-update both src and dst inode

 fs/f2fs/file.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)
fs/f2fs/file.c +13 -0
index cb42d8464ad9..e59fc8faa035 100644
@@ -2886,6 +2886,19 @@ static int f2fs_move_file_range(struct file *file_in, loff_t pos_in,
 		f2fs_up_write(&F2FS_I(dst)->i_gc_rwsem[WRITE]);
 out_src:
 	f2fs_up_write(&F2FS_I(src)->i_gc_rwsem[WRITE]);
+
+	if (!ret) {
+		src->i_mtime = src->i_ctime = current_time(src);
+		f2fs_mark_inode_dirty_sync(src, false);
+
+		if (src != dst) {
+			dst->i_mtime = dst->i_ctime = current_time(dst);
+			f2fs_mark_inode_dirty_sync(dst, false);
+		}
+
+		f2fs_update_time(sbi, REQ_TIME);
+	}
+
 out_unlock:
 	if (src != dst)
 		inode_unlock(dst);
Signature · 1 line
2.40.1
author
#1 lore raw

PATCH 2/2 f2fs: truncate pages if move file range success

If move file range success, it should remove old data from src and dst page cache.

---
 fs/f2fs/file.c | 3 +++
 1 file changed, 3 insertions(+)
fs/f2fs/file.c +3 -0
index e59fc8faa035..4bece7c56656 100644
@@ -2896,6 +2896,9 @@ static int f2fs_move_file_range(struct file *file_in, loff_t pos_in,
 			f2fs_mark_inode_dirty_sync(dst, false);
 		}
 
+		truncate_pagecache_range(src, pos_in, pos_in + len - 1);
+		truncate_pagecache_range(dst, pos_out, pos_out + len - 1);
+
 		f2fs_update_time(sbi, REQ_TIME);
 	}
 
Signature · 1 line
2.40.1
maintainer
#4 lore raw
In reply to Yunlei He
Quoted 15 lines · Yunlei He

Mtime and ctime stay old value without update after move file range ioctl. This patch add time update.

---
v2:

(quoted diff) +0 -1
-update both src and dst inode
 fs/f2fs/file.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)
fs/f2fs/file.c +0 -0
index cb42d8464ad9..e59fc8faa035 100644

fs/f2fs/file.c static int f2fs_move_file_range(struct file *file_in, loff_t pos_in, · line 2890

Quoted 5 lines
fs/f2fs/file.c +2 -0
@@ -2886,6 +2886,19 @@ static int f2fs_move_file_range(struct file *file_in, loff_t pos_in,
 		f2fs_up_write(&F2FS_I(dst)->i_gc_rwsem[WRITE]);
 out_src:
 	f2fs_up_write(&F2FS_I(src)->i_gc_rwsem[WRITE]);
+
+	if (!ret) {

Applied with minor change like:

	if (ret)
		goto out_unlock;
	...
Quoted 16 lines
fs/f2fs/file.c +11 -0
+		src->i_mtime = src->i_ctime = current_time(src);
+		f2fs_mark_inode_dirty_sync(src, false);
+
+		if (src != dst) {
+			dst->i_mtime = dst->i_ctime = current_time(dst);
+			f2fs_mark_inode_dirty_sync(dst, false);
+		}
+
+		f2fs_update_time(sbi, REQ_TIME);
+	}
+
 out_unlock:
 	if (src != dst)
 		inode_unlock(dst);
Signature · 1 line
2.40.1