ksmbd: Use struct_size() helper in ksmbd_negotiate_smb_dialect()
Subsystems (2)
PATCH 1/1 ksmbd: Use struct_size() helper in ksmbd_negotiate_smb_dialect()
Prefer struct_size() over open-coded versions.
--- fs/smb/server/smb_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/smb/server/smb_common.c +1 -1
@@ -266,7 +266,7 @@ static int ksmbd_negotiate_smb_dialect(void *buf)if (smb2_neg_size > smb_buf_length) goto err_out; -if (smb2_neg_size +le16_to_cpu (req->DialectCount) *sizeof (__le16) > +if (struct_size (req, Dialects,le16_to_cpu (req->DialectCount)) > smb_buf_length) goto err_out;
Signature · 1 line
2.34.1
Quoted 4 lines · Gustavo A. R. Silva
Prefer
struct_size()over open-coded versions.
Reviewed-by Kees Cook <[email protected]>
Signature · 1 line
Kees Cook
2023-06-22 6:29 GMT+09:00, Gustavo A. R. Silva <[email protected]>:
Quoted 4 lines
Prefer
struct_size()over open-coded versions.
Acked-by Namjae Jeon <[email protected]>
Thanks!
Quoted 4 lines · Gustavo A. R. Silva
Prefer
struct_size()over open-coded versions.
Reviewed-by Sergey Senozhatsky <[email protected]>
2023-06-22 6:29 GMT+09:00, Gustavo A. R. Silva <[email protected]>:
Quoted 4 lines
Prefer
struct_size()over open-coded versions.
Applied it with reviewed/acked-by tags to #ksmbd-for-next-next.
Thanks.