cpufreq: qcom-cpufreq-hw: Use dev_err_probe() when failing to get icc paths
Subsystems (2)
PATCH 1/1 cpufreq: qcom-cpufreq-hw: Use dev_err_probe() when failing to get icc paths
This way, if there's an issue (in this case a -EPROBE_DEFER), you can get useful output:
[root@dhcp19-243-150 ~]# cat /sys/kernel/debug/devices_deferred
18591000.cpufreq qcom-cpufreq-hw: Failed to find icc paths
--- drivers/cpufreq/qcom-cpufreq-hw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/cpufreq/qcom-cpufreq-hw.c +1 -1
@@ -661,7 +661,7 @@ static int qcom_cpufreq_hw_driver_probe(struct platform_device *pdev) ret =dev_pm_opp_of_find_icc_paths (cpu_dev,NULL );if (ret) -return ret; +return dev_err_probe (dev, ret,"Failed to find icc paths\n" );for (num_domains =0 ; num_domains <MAX_FREQ_DOMAINS ; num_domains++)if (!platform_get_resource (pdev,IORESOURCE_MEM , num_domains))
Signature · 1 line
2.40.1
Quoted 7 lines · Andrew Halaney
This way, if there's an issue (in this case a -EPROBE_DEFER), you can get useful output:
[root@dhcp19-243-150 ~]# cat
/sys/kernel/debug/devices_deferred
18591000.cpufreq qcom-cpufreq-hw: Failed to find icc pathsSigned-off-by Andrew Halaney <[email protected]>
Regards,
Bjorn
Quoted 20 lines
--- drivers/cpufreq/qcom-cpufreq-hw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/cpufreq/qcom-cpufreq-hw.c +1
-1@@ -661,7 +661,7 @@ static int qcom_cpufreq_hw_driver_probe(struct platform_device *pdev) ret =dev_pm_opp_of_find_icc_paths (cpu_dev,NULL );if (ret) -return ret; +return dev_err_probe (dev, ret,"Failed to find icc paths\n" );for (num_domains =0 ; num_domains <MAX_FREQ_DOMAINS ; num_domains++)if (!platform_get_resource (pdev,IORESOURCE_MEM , num_domains))Signature · 1 line
2.40.1
Quoted 10 lines · Bjorn Andersson
Quoted 7 lines · Andrew Halaney
This way, if there's an issue (in this case a -EPROBE_DEFER), you can get useful output:
[root@dhcp19-243-150 ~]# cat
/sys/kernel/debug/devices_deferred
18591000.cpufreq qcom-cpufreq-hw: Failed to find icc pathsSigned-off-by Andrew Halaney <[email protected]>Reviewed-by Bjorn Andersson <[email protected]>
Applied. Thanks.
Signature · 1 line
viresh