libbpf: kprobe.multi: feedback function counts by kernel traced
PATCH 1/1 libbpf: kprobe.multi: feedback function counts by kernel traced
From: Jackie Liu <[email protected]>
When tracking functions through kprobe.multi, the number of tracked functions cannot be directly obtained. Sometimes in order to calculate this value, it is necessary to recalculate according to the pattern in the program. This is unnecessary. It is calculated by libbpf feedback through opts.cnt value, which can save resources. Example at [1].
[1] https://github.com/JackieLiu1/ketones/blob/master/src/funccount/funccount.c#L317
--- tools/lib/bpf/libbpf.c | 3 ++- tools/lib/bpf/libbpf.h | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-)
tools/lib/bpf/libbpf.c +2 -1
@@ -10506,7 +10506,7 @@ static void kprobe_multi_resolve_reinit(struct kprobe_multi_resolve *res)struct bpf_link *bpf_program__attach_kprobe_multi_opts (const struct bpf_program *prog,const char *pattern, -const struct bpf_kprobe_multi_opts *opts) +struct bpf_kprobe_multi_opts *opts) {LIBBPF_OPTS (bpf_link_create_opts, lopts);struct kprobe_multi_resolve res = {
@@ -10582,6 +10582,7 @@ bpf_program__attach_kprobe_multi_opts(const struct bpf_program *prog, } link->fd = link_fd;free (res.addrs); +OPTS_SET (opts, cnt, res.cnt);return link; error:
tools/lib/bpf/libbpf.h +1 -1
@@ -527,7 +527,7 @@ struct bpf_kprobe_multi_opts { LIBBPF_API struct bpf_link *bpf_program__attach_kprobe_multi_opts (const struct bpf_program *prog,const char *pattern, -const struct bpf_kprobe_multi_opts *opts); +struct bpf_kprobe_multi_opts *opts);struct bpf_ksyscall_opts {/* size of this struct, for forward/backward compatibility */
Signature · 1 line
2.25.1
Quoted 30 lines · Jackie Liu
From: Jackie Liu <[email protected]>
When tracking functions through kprobe.multi, the number of tracked functions cannot be directly obtained. Sometimes in order to calculate this value, it is necessary to recalculate according to the pattern in the program. This is unnecessary. It is calculated by libbpf feedback through opts.cnt value, which can save resources. Example at [1].
[1] https://github.com/JackieLiu1/ketones/blob/master/src/funccount/funccount.c#L317
Signed-off-by Jackie Liu <[email protected]>--- tools/lib/bpf/libbpf.c | 3 ++- tools/lib/bpf/libbpf.h | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-)tools/lib/bpf/libbpf.c +1
-1@@ -10506,7 +10506,7 @@ static void kprobe_multi_resolve_reinit(struct kprobe_multi_resolve *res)struct bpf_link *bpf_program__attach_kprobe_multi_opts (const struct bpf_program *prog,const char *pattern, -const struct bpf_kprobe_multi_opts *opts) +struct bpf_kprobe_multi_opts *opts) {LIBBPF_OPTS (bpf_link_create_opts, lopts);struct kprobe_multi_resolve res = {
tools/lib/bpf/libbpf.c bpf_program__attach_kprobe_multi_opts(const struct bpf_program *prog, · line 10585
Quoted 4 lines
tools/lib/bpf/libbpf.c +1
-0@@ -10582,6 +10582,7 @@ bpf_program__attach_kprobe_multi_opts(const struct bpf_program *prog, } link->fd = link_fd;free (res.addrs); +OPTS_SET (opts, cnt, res.cnt);
hum I'm not sure it's good idea to use opts for output values
there's ongoing patchset adding possibility to get this info/value via BPF_OBJ_GET_INFO_BY_FD syscall [1]
jirka
Quoted 19 lines
tools/lib/bpf/libbpf.c +0
-0return link; error:tools/lib/bpf/libbpf.h +1
-1@@ -527,7 +527,7 @@ struct bpf_kprobe_multi_opts { LIBBPF_API struct bpf_link *bpf_program__attach_kprobe_multi_opts (const struct bpf_program *prog,const char *pattern, -const struct bpf_kprobe_multi_opts *opts); +struct bpf_kprobe_multi_opts *opts);struct bpf_ksyscall_opts {/* size of this struct, for forward/backward compatibility */ Signature · 1 line
2.25.1
Quoted 30 lines · Jiri Olsa
Quoted 28 lines · Jackie Liu
From: Jackie Liu <[email protected]>
When tracking functions through kprobe.multi, the number of tracked functions cannot be directly obtained. Sometimes in order to calculate this value, it is necessary to recalculate according to the pattern in the program. This is unnecessary. It is calculated by libbpf feedback through opts.cnt value, which can save resources. Example at [1].
[1] https://github.com/JackieLiu1/ketones/blob/master/src/funccount/funccount.c#L317
Signed-off-by Jackie Liu <[email protected]>--- tools/lib/bpf/libbpf.c | 3 ++- tools/lib/bpf/libbpf.h | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-)tools/lib/bpf/libbpf.c +1
-1@@ -10506,7 +10506,7 @@ static void kprobe_multi_resolve_reinit(struct kprobe_multi_resolve *res)struct bpf_link *bpf_program__attach_kprobe_multi_opts (const struct bpf_program *prog,const char *pattern, -const struct bpf_kprobe_multi_opts *opts) +struct bpf_kprobe_multi_opts *opts) {LIBBPF_OPTS (bpf_link_create_opts, lopts);
Quoted 9 lines
tools/lib/bpf/libbpf.c bpf_program__attach_kprobe_multi_opts(const struct bpf_program *prog, · line 10585
Quoted 6 lines
tools/lib/bpf/libbpf.c +1
-0struct kprobe_multi_resolve res = {@@ -10582,6 +10582,7 @@ bpf_program__attach_kprobe_multi_opts(const struct bpf_program *prog, } link->fd = link_fd;free (res.addrs); +OPTS_SET (opts, cnt, res.cnt);hum I'm not sure it's good idea to use opts for output values
We do use opts for output parameters in some cases, but in this case I think it's not strictly necessary for libbpf to report back on the number of resolved addresses. If an application really needs it, then getting it from BPF link info is one way, but I'd argue that an application should just do its own resolution if this is important for its logic.
Quoted 26 lines
there's ongoing patchset adding possibility to get this info/value via
BPF_OBJ_GET_INFO_BY_FDsyscall [1]jirka
[1] https://lore.kernel.org/bpf/[email protected]/
Quoted 19 lines
tools/lib/bpf/libbpf.c +0
-0return link; error:tools/lib/bpf/libbpf.h +1
-2@@ -527,7 +527,7 @@ struct bpf_kprobe_multi_opts { LIBBPF_API struct bpf_link *bpf_program__attach_kprobe_multi_opts (const struct bpf_program *prog,const char *pattern, -const struct bpf_kprobe_multi_opts *opts); +struct bpf_kprobe_multi_opts *opts);struct bpf_ksyscall_opts {/* size of this struct, for forward/backward compatibility */ --2.25.1