Skip to contentSkip to conversation

selftests/input: add tests for the EVIOCSABS ioctl

PATCH In review Dana Elfassy 2 participants 2 messages Jun 25, 2023 – Jun 28, 2023 Kselftest

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 selftests/input: add tests for the EVIOCSABS ioctl

This patch introduces two tests for the EVIOCSABS ioctl. The first one checks that the ioctl fails when the EV_ABS bit was not set, and the second one just checks that the normal workflow for this ioctl succeeds.

---
This patch depends on '[v3] selftests/input: Introduce basic tests for evdev ioctls' [1] sent to the ML.
[1] https://patchwork.kernel.org/project/linux-input/patch/[email protected]/

 tools/testing/selftests/input/evioc-test.c | 23 ++++++++++++++++++++++
 1 file changed, 23 insertions(+)
tools/testing/selftests/input/evioc-test.c +23 -0
index 4c0c8ebed378..7afd537f0b24 100644
@@ -279,4 +279,27 @@ TEST(eviocgrep_get_repeat_settings)
 	selftest_uinput_destroy(uidev);
 }
 
+TEST(eviocsabs_set_abs_value_limits)
+{
+	struct selftest_uinput *uidev;
+	struct input_absinfo absinfo;
+	int rc;
+
+	// fail test on dev->absinfo
+	rc = selftest_uinput_create_device(&uidev), -1;
+	ASSERT_EQ(0, rc);
+	ASSERT_NE(NULL, uidev);
+	rc = ioctl(uidev->evdev_fd, EVIOCSABS(0), &absinfo);
+	ASSERT_EQ(-1, rc);
+	selftest_uinput_destroy(uidev);
+
+	// ioctl normal flow
+	rc = selftest_uinput_create_device(&uidev, EV_ABS, -1);
+	ASSERT_EQ(0, rc);
+	ASSERT_NE(NULL, uidev);
+	rc = ioctl(uidev->evdev_fd, EVIOCSABS(0), &absinfo);
+	ASSERT_EQ(0, rc);
+	selftest_uinput_destroy(uidev);
+}
+
 TEST_HARNESS_MAIN
Signature · 1 line
2.41.0
Reviewed-by Enric Balletbo i Serra on v2 1/1
#1 lore raw

Hi Dana,

Thank you for the patch.

Missatge de Dana Elfassy <[email protected]> del dia dg., 25 de juny 2023 a les 14:31:

Quoted 7 lines

This patch introduces two tests for the EVIOCSABS ioctl. The first one checks that the ioctl fails when the EV_ABS bit was not set, and the second one just checks that the normal workflow for this ioctl succeeds.

Using gcov i see that this covers the code path when an EVIOCSABS ioctl is called, so

Quoted 42 lines

---
This patch depends on '[v3] selftests/input: Introduce basic tests for evdev ioctls' [1] sent to the ML.
[1] https://patchwork.kernel.org/project/linux-input/patch/[email protected]/

 tools/testing/selftests/input/evioc-test.c | 23 ++++++++++++++++++++++
 1 file changed, 23 insertions(+)
tools/testing/selftests/input/evioc-test.c +23 -1
index 4c0c8ebed378..7afd537f0b24 100644
@@ -279,4 +279,27 @@ TEST(eviocgrep_get_repeat_settings)
        selftest_uinput_destroy(uidev);
 }
 
+TEST(eviocsabs_set_abs_value_limits)
+{
+       struct selftest_uinput *uidev;
+       struct input_absinfo absinfo;
+       int rc;
+
+       // fail test on dev->absinfo
+       rc = selftest_uinput_create_device(&uidev), -1;
+       ASSERT_EQ(0, rc);
+       ASSERT_NE(NULL, uidev);
+       rc = ioctl(uidev->evdev_fd, EVIOCSABS(0), &absinfo);
+       ASSERT_EQ(-1, rc);
+       selftest_uinput_destroy(uidev);
+
+       // ioctl normal flow
+       rc = selftest_uinput_create_device(&uidev, EV_ABS, -1);
+       ASSERT_EQ(0, rc);
+       ASSERT_NE(NULL, uidev);
+       rc = ioctl(uidev->evdev_fd, EVIOCSABS(0), &absinfo);
+       ASSERT_EQ(0, rc);
+       selftest_uinput_destroy(uidev);
+}
+
 TEST_HARNESS_MAIN
--

2.41.0