net/idpf: refine RTE_PMD_REGISTER_PARAM_STRING of IDPF PMD
PATCH 1/1 net/idpf: refine RTE_PMD_REGISTER_PARAM_STRING of IDPF PMD
This patch refines 'IDPF_VPORT' param string in
'RTE_PMD_REGISTER_PARAM_STRING'.
--- drivers/net/idpf/idpf_ethdev.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/net/idpf/idpf_ethdev.c +3 -3
@@ -1478,9 +1478,9 @@ RTE_PMD_REGISTER_PCI(net_idpf, rte_idpf_pmd);RTE_PMD_REGISTER_PCI_TABLE (net_idpf, pci_id_idpf_map);RTE_PMD_REGISTER_KMOD_DEP (net_idpf,"* igb_uio | vfio-pci" );RTE_PMD_REGISTER_PARAM_STRING (net_idpf, -IDPF_TX_SINGLE_Q "=<0|1> " -IDPF_RX_SINGLE_Q "=<0|1> " -IDPF_VPORT "=[vport_set0,[vport_set1],...]" ); +IDPF_TX_SINGLE_Q "=<0|1> " +IDPF_RX_SINGLE_Q "=<0|1> " +IDPF_VPORT "=[vport0_begin[-vport0_end][,vport1_begin[-vport1_end]][,..]]" );RTE_LOG_REGISTER_SUFFIX (idpf_logtype_init, init,NOTICE );RTE_LOG_REGISTER_SUFFIX (idpf_logtype_driver, driver,NOTICE );
Signature · 1 line
2.34.1
Quoted 10 lines
-----Original Message-----
From: Mingxia Liu <[email protected]>
Sent: Monday, June 26, 2023 10:06 PM
To: [email protected]
Cc: Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>; Liu, Mingxia <[email protected]>
Subject: [PATCH] net/idpf: refineRTE_PMD_REGISTER_PARAM_STRINGof IDPF PMD
No need to mention the PMD in the title as its duplicate with the prefix.
How about
net/idpf: refine vport parameter string
Quoted 14 lines
This patch refines '
IDPF_VPORT' param string in
'RTE_PMD_REGISTER_PARAM_STRING'.Signed-off-by Mingxia Liu <[email protected]>--- drivers/net/idpf/idpf_ethdev.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)drivers/net/idpf/idpf_ethdev.c +0
-0
drivers/net/idpf/idpf_ethdev.c RTE_PMD_REGISTER_PCI(net_idpf, rte_idpf_pmd); · line 1484
Quoted 10 lines
drivers/net/idpf/idpf_ethdev.c +4
-3@@ -1478,9 +1478,9 @@ RTE_PMD_REGISTER_PCI(net_idpf, rte_idpf_pmd);RTE_PMD_REGISTER_PCI_TABLE (net_idpf, pci_id_idpf_map);RTE_PMD_REGISTER_KMOD_DEP (net_idpf,"* igb_uio | vfio-pci" );RTE_PMD_REGISTER_PARAM_STRING (net_idpf, -IDPF_TX_SINGLE_Q "=<0|1> " -IDPF_RX_SINGLE_Q "=<0|1> " -IDPF_VPORT "=[vport_set0,[vport_set1],...]" ); +IDPF_TX_SINGLE_Q "=<0|1> " +IDPF_RX_SINGLE_Q "=<0|1> " +IDPF_VPORT +"=[vport0_begin[-vport0_end][,vport1_begin[-vport1_end]][,..]]" );
Better to use "<>" to wrap a symbol
How about " [<begin>[-<end>][,<begin >[-<end>]][, ... ]]"?
Quoted 5 lines
drivers/net/idpf/idpf_ethdev.c +0
-1RTE_LOG_REGISTER_SUFFIX (idpf_logtype_init, init,NOTICE );RTE_LOG_REGISTER_SUFFIX (idpf_logtype_driver, driver,NOTICE ); --2.34.1
Quoted 47 lines
-----Original Message-----
From: Zhang, Qi Z <[email protected]>
Sent: Friday, June 30, 2023 5:08 PM
To: Liu, Mingxia <[email protected]>; [email protected]
Cc: Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>; Liu, Mingxia <[email protected]>
Subject: RE: [PATCH] net/idpf: refineRTE_PMD_REGISTER_PARAM_STRINGof IDPF PMDQuoted 8 lines
-----Original Message-----
From: Mingxia Liu <[email protected]>
Sent: Monday, June 26, 2023 10:06 PM
To: [email protected]
Cc: Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>; Liu, Mingxia <[email protected]>
Subject: [PATCH] net/idpf: refineRTE_PMD_REGISTER_PARAM_STRINGof IDPF PMDNo need to mention the PMD in the title as its duplicate with the prefix.
How about
net/idpf: refine vport parameter string
Quoted 19 lines
This patch refines '
IDPF_VPORT' param string in
'RTE_PMD_REGISTER_PARAM_STRING'.Signed-off-by Mingxia Liu <[email protected]>--- drivers/net/idpf/idpf_ethdev.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)(quoted diff) +0
-0
b/drivers/net/idpf/idpf_ethdev.cindex3e66898aaf..34ca5909f1100644drivers/net/idpf/idpf_ethdev.c +0
-2@@ -1478,9 +1478,9 @@ RTE_PMD_REGISTER_PCI(net_idpf, rte_idpf_pmd);RTE_PMD_REGISTER_PCI_TABLE (net_idpf, pci_id_idpf_map);RTE_PMD_REGISTER_KMOD_DEP (net_idpf,"* igb_uio | vfio-pci" ); RTE_PMD_REGISTER_PARAM_STRING(net_idpf, -IDPF_TX_SINGLE_Q "=<0|1> " - IDPF_RX_SINGLE_Q "=<0|1> "
Quoted 9 lines
drivers/net/idpf/idpf_ethdev.c RTE_PMD_REGISTER_PCI(net_idpf, rte_idpf_pmd);
Quoted 5 lines
drivers/net/idpf/idpf_ethdev.c +4
-1- IDPF_VPORT "=[vport_set0,[vport_set1],...]"); +IDPF_TX_SINGLE_Q "=<0|1> " +IDPF_RX_SINGLE_Q "=<0|1> " +IDPF_VPORT +"=[vport0_begin[-vport0_end][,vport1_begin[-vport1_end]][,..]]");Better to use "<>" to wrap a symbol
How about " [<begin>[-<end>][,<begin >[-<end>]][, ... ]]"?
[Liu, Mingxia] Thanks, new patch has been sent.
Quoted 5 lines
Quoted 5 lines
drivers/net/idpf/idpf_ethdev.c +0
-1RTE_LOG_REGISTER_SUFFIX (idpf_logtype_init, init,NOTICE );RTE_LOG_REGISTER_SUFFIX (idpf_logtype_driver, driver,NOTICE ); --2.34.1
PATCH v2 1/1 net/idpf: refine vport parameter string
In reply to Mingxia LiuThis patch refines 'IDPF_VPORT' param string in
'RTE_PMD_REGISTER_PARAM_STRING'.
--- drivers/net/idpf/idpf_ethdev.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/net/idpf/idpf_ethdev.c +3 -3
@@ -1472,9 +1472,9 @@ RTE_PMD_REGISTER_PCI(net_idpf, rte_idpf_pmd);RTE_PMD_REGISTER_PCI_TABLE (net_idpf, pci_id_idpf_map);RTE_PMD_REGISTER_KMOD_DEP (net_idpf,"* igb_uio | vfio-pci" );RTE_PMD_REGISTER_PARAM_STRING (net_idpf, -IDPF_TX_SINGLE_Q "=<0|1> " -IDPF_RX_SINGLE_Q "=<0|1> " -IDPF_VPORT "=[vport_set0,[vport_set1],...]" ); +IDPF_TX_SINGLE_Q "=<0|1> " +IDPF_RX_SINGLE_Q "=<0|1> " +IDPF_VPORT "=[<begin>[-<end>][,<begin >[-<end>]][, ... ]]" );RTE_LOG_REGISTER_SUFFIX (idpf_logtype_init, init,NOTICE );RTE_LOG_REGISTER_SUFFIX (idpf_logtype_driver, driver,NOTICE );
Signature · 1 line
2.34.1
RE: [PATCH v2] net/idpf: refine vport parameter string
Quoted 10 lines
-----Original Message-----
From: Mingxia Liu <[email protected]>
Sent: Saturday, July 1, 2023 2:52 AM
To: [email protected]
Cc: Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>; Liu, Mingxia <[email protected]>
Subject: [PATCH v2] net/idpf: refine vport parameter string
Quoted 4 lines
This patch refines '
IDPF_VPORT' param string in
'RTE_PMD_REGISTER_PARAM_STRING'.Signed-off-by Mingxia Liu <[email protected]>
Applied to dpdk-next-net-intel.
Thanks
Qi