drivers/opp/of.c:516 dev_pm_opp_of_find_icc_paths() warn: passing zero to 'dev_err_probe'
kernel test robot
build botBCC: [email protected]
CC: [email protected]
TO: Andrew Halaney <[email protected]>
CC: Viresh Kumar <[email protected]>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/vireshk/pm.git opp/linux-next head: fa155f4f834882a79788218aea4914568b41dd0f commit: fa155f4f834882a79788218aea4914568b41dd0f [8/8] OPP: Use dev_err_probe() when failing to get icc_path
:::::: branch date: 5 hours ago
:::::: commit date: 5 hours ago
config: openrisc-randconfig-m041-20230625 (https://download.01.org/0day-ci/archive/20230626/[email protected]/config)
compiler: or1k-linux-gcc (GCC) 12.3.0
reproduce: (https://download.01.org/0day-ci/archive/20230626/[email protected]/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]> | Reported-by: Dan Carpenter <[email protected]> | Closes: https://lore.kernel.org/r/[email protected]/
smatch warnings:drivers/opp/of.c:516 dev_pm_opp_of_find_icc_paths() warn: passing zero to 'dev_err_probe'
vim +/dev_err_probe +516 drivers/opp/of.c
45679f9b508f10 Sibi Sankar 2020-05-28 476
6d3f922c46f2e9 Georgi Djakov 2020-05-12 477 int dev_pm_opp_of_find_icc_paths(struct device *dev,
6d3f922c46f2e9 Georgi Djakov 2020-05-12 478 struct opp_table *opp_table)
6d3f922c46f2e9 Georgi Djakov 2020-05-12 479 {
6d3f922c46f2e9 Georgi Djakov 2020-05-12 480 struct device_node *np;
45679f9b508f10 Sibi Sankar 2020-05-28 481 int ret, i, count, num_paths;
6d3f922c46f2e9 Georgi Djakov 2020-05-12 482 struct icc_path **paths;
6d3f922c46f2e9 Georgi Djakov 2020-05-12 483
45679f9b508f10 Sibi Sankar 2020-05-28 484 ret = _bandwidth_supported(dev, opp_table);
6ee70e8c34e37a Nicola Mazzucato 2020-12-08 485 if (ret == -EINVAL)
6ee70e8c34e37a Nicola Mazzucato 2020-12-08 486 return 0; /* Empty OPP table is a valid corner-case, let's not fail */
6ee70e8c34e37a Nicola Mazzucato 2020-12-08 487 else if (ret <= 0)
45679f9b508f10 Sibi Sankar 2020-05-28 488 return ret;
45679f9b508f10 Sibi Sankar 2020-05-28 489
45679f9b508f10 Sibi Sankar 2020-05-28 490 ret = 0;
45679f9b508f10 Sibi Sankar 2020-05-28 491
6d3f922c46f2e9 Georgi Djakov 2020-05-12 492 np = of_node_get(dev->of_node);
6d3f922c46f2e9 Georgi Djakov 2020-05-12 493 if (!np)
6d3f922c46f2e9 Georgi Djakov 2020-05-12 494 return 0;
6d3f922c46f2e9 Georgi Djakov 2020-05-12 495
6d3f922c46f2e9 Georgi Djakov 2020-05-12 496 count = of_count_phandle_with_args(np, "interconnects",
6d3f922c46f2e9 Georgi Djakov 2020-05-12 497 "#interconnect-cells");
6d3f922c46f2e9 Georgi Djakov 2020-05-12 498 of_node_put(np);
6d3f922c46f2e9 Georgi Djakov 2020-05-12 499 if (count < 0)
6d3f922c46f2e9 Georgi Djakov 2020-05-12 500 return 0;
6d3f922c46f2e9 Georgi Djakov 2020-05-12 501
6d3f922c46f2e9 Georgi Djakov 2020-05-12 502 /* two phandles when #interconnect-cells = <1> */
6d3f922c46f2e9 Georgi Djakov 2020-05-12 503 if (count % 2) {
6d3f922c46f2e9 Georgi Djakov 2020-05-12 504 dev_err(dev, "%s: Invalid interconnects values\n", __func__);
6d3f922c46f2e9 Georgi Djakov 2020-05-12 505 return -EINVAL;
6d3f922c46f2e9 Georgi Djakov 2020-05-12 506 }
6d3f922c46f2e9 Georgi Djakov 2020-05-12 507
6d3f922c46f2e9 Georgi Djakov 2020-05-12 508 num_paths = count / 2;
6d3f922c46f2e9 Georgi Djakov 2020-05-12 509 paths = kcalloc(num_paths, sizeof(*paths), GFP_KERNEL);
6d3f922c46f2e9 Georgi Djakov 2020-05-12 510 if (!paths)
6d3f922c46f2e9 Georgi Djakov 2020-05-12 511 return -ENOMEM;
6d3f922c46f2e9 Georgi Djakov 2020-05-12 512
6d3f922c46f2e9 Georgi Djakov 2020-05-12 513 for (i = 0; i < num_paths; i++) {
6d3f922c46f2e9 Georgi Djakov 2020-05-12 514 paths[i] = of_icc_get_by_index(dev, i);
6d3f922c46f2e9 Georgi Djakov 2020-05-12 515 if (IS_ERR(paths[i])) {
fa155f4f834882 Andrew Halaney 2023-06-23 @516 ret = dev_err_probe(dev, ret, "%s: Unable to get path%d\n", __func__, i);
6d3f922c46f2e9 Georgi Djakov 2020-05-12 517 goto err;
6d3f922c46f2e9 Georgi Djakov 2020-05-12 518 }
6d3f922c46f2e9 Georgi Djakov 2020-05-12 519 }
6d3f922c46f2e9 Georgi Djakov 2020-05-12 520
6d3f922c46f2e9 Georgi Djakov 2020-05-12 521 if (opp_table) {
6d3f922c46f2e9 Georgi Djakov 2020-05-12 522 opp_table->paths = paths;
6d3f922c46f2e9 Georgi Djakov 2020-05-12 523 opp_table->path_count = num_paths;
6d3f922c46f2e9 Georgi Djakov 2020-05-12 524 return 0;
6d3f922c46f2e9 Georgi Djakov 2020-05-12 525 }
6d3f922c46f2e9 Georgi Djakov 2020-05-12 526
6d3f922c46f2e9 Georgi Djakov 2020-05-12 527 err:
6d3f922c46f2e9 Georgi Djakov 2020-05-12 528 while (i--)
6d3f922c46f2e9 Georgi Djakov 2020-05-12 529 icc_put(paths[i]);
6d3f922c46f2e9 Georgi Djakov 2020-05-12 530
6d3f922c46f2e9 Georgi Djakov 2020-05-12 531 kfree(paths);
6d3f922c46f2e9 Georgi Djakov 2020-05-12 532
6d3f922c46f2e9 Georgi Djakov 2020-05-12 533 return ret;
6d3f922c46f2e9 Georgi Djakov 2020-05-12 534 }
6d3f922c46f2e9 Georgi Djakov 2020-05-12 535 EXPORT_SYMBOL_GPL(dev_pm_opp_of_find_icc_paths);
6d3f922c46f2e9 Georgi Djakov 2020-05-12 536 Signature · 2 lines
0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki