package/python-setuptools: add missing dependency on host-python-wheel
PATCH 1/1 package/python-setuptools: add missing dependency on host-python-wheel
While migrating to pep517 build backend the host-python-wheel dependency has been added to host-python-setuptools but not to python-setuptools.
Fixes:
https://gitlab.com/buildroot.org/buildroot/-/jobs/4537951715
--- package/python-setuptools/python-setuptools.mk | 1 + 1 file changed, 1 insertion(+)
package/python-setuptools/python-setuptools.mk +1 -0
@@ -12,6 +12,7 @@ PYTHON_SETUPTOOLS_LICENSE_FILES = LICENSE PYTHON_SETUPTOOLS_CPE_ID_VENDOR = python PYTHON_SETUPTOOLS_CPE_ID_PRODUCT = setuptools PYTHON_SETUPTOOLS_SETUP_TYPE = pep517 +PYTHON_SETUPTOOLS_DEPENDENCIES = host-python-wheel HOST_PYTHON_SETUPTOOLS_DEPENDENCIES = host-python-wheel $(eval $(python-package))
Signature · 6 lines
2.41.0 _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
James, All,
On 2023-06-26 22:29 +0200, Romain Naour spake thusly:
Quoted 18 lines
While migrating to pep517 build backend the host-python-wheel dependency has been added to host-python-setuptools but not to python-setuptools.
Fixes:
https://gitlab.com/buildroot.org/buildroot/-/jobs/4537951715Signed-off-by Romain Naour <[email protected]>Cc James Hilliard <[email protected]>--- package/python-setuptools/python-setuptools.mk | 1 + 1 file changed, 1 insertion(+)package/python-setuptools/python-setuptools.mk +0
-0
package/python-setuptools/python-setuptools.mk PYTHON_SETUPTOOLS_LICENSE_FILES = LICENSE · line 16
Quoted 5 lines
package/python-setuptools/python-setuptools.mk +1
-0@@ -12,6 +12,7 @@ PYTHON_SETUPTOOLS_LICENSE_FILES = LICENSE PYTHON_SETUPTOOLS_CPE_ID_VENDOR = python PYTHON_SETUPTOOLS_CPE_ID_PRODUCT = setuptools PYTHON_SETUPTOOLS_SETUP_TYPE = pep517 +PYTHON_SETUPTOOLS_DEPENDENCIES = host-python-wheel HOST_PYTHON_SETUPTOOLS_DEPENDENCIES = host-python-wheel
Should this not be done in the python package infra instead?
I.e. if host-python-wheel is required by the pep517 build backend, then all packages that are pep517 will need wheel, so it should be done by the infra rather than by each individual package...
Of course, by the virtue of being a dependency of python-setuptools, it becomes a dependency of all python-packages that already depends on {host-,}python-setuptools, so it technically works, even with PPD. Nonetheless, it is semantically incorrect.
Or did I miss something?
Regards,
Yann E. MORIN.
Quoted 8 lines
package/python-setuptools/python-setuptools.mk +0
-0$(eval $(python-package))Signature · 6 lines
2.41.0 _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Signature · 10 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Quoted 30 lines · Yann E. MORIN
James, All,
On 2023-06-26 22:29 +0200, Romain Naour spake thusly:
Quoted 18 lines
While migrating to pep517 build backend the host-python-wheel dependency has been added to host-python-setuptools but not to python-setuptools.
Fixes:
https://gitlab.com/buildroot.org/buildroot/-/jobs/4537951715Signed-off-by Romain Naour <[email protected]>Cc James Hilliard <[email protected]>--- package/python-setuptools/python-setuptools.mk | 1 + 1 file changed, 1 insertion(+)package/python-setuptools/python-setuptools.mk +0
-0package/python-setuptools/python-setuptools.mk PYTHON_SETUPTOOLS_LICENSE_FILES = LICENSE · line 16
Quoted 5 lines
package/python-setuptools/python-setuptools.mk +1
-0@@ -12,6 +12,7 @@ PYTHON_SETUPTOOLS_LICENSE_FILES = LICENSE PYTHON_SETUPTOOLS_CPE_ID_VENDOR = python PYTHON_SETUPTOOLS_CPE_ID_PRODUCT = setuptools PYTHON_SETUPTOOLS_SETUP_TYPE = pep517 +PYTHON_SETUPTOOLS_DEPENDENCIES = host-python-wheel HOST_PYTHON_SETUPTOOLS_DEPENDENCIES = host-python-wheelShould this not be done in the python package infra instead?
Quoted 3 lines
I.e. if host-python-wheel is required by the pep517 build backend, then all packages that are pep517 will need wheel, so it should be done by the infra rather than by each individual package...
So host-python-wheel is not required by the pep517 build frontend, only the setuptools pep517 build backend, it's not needed for flit and non-setuptools based pep517 build backends.
Quoted 5 lines
Of course, by the virtue of being a dependency of python-setuptools, it becomes a dependency of all python-packages that already depends on {host-,}python-setuptools, so it technically works, even with PPD. Nonetheless, it is semantically incorrect.
So setuptools is no longer required in the dependency tree for any non-setuptools based packages.
See my patch switching setuptools over to the pep517 build frontend:
https://patchwork.ozlabs.org/project/buildroot/patch/[email protected]/
Quoted 15 lines
Or did I miss something?
Regards,
Yann E. MORIN.Quoted 8 lines
package/python-setuptools/python-setuptools.mk +0
-1$(eval $(python-package)) --2.41.0
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
Quoted 7 lines
--
.-----------------.--------------------.------------------.--------------------.| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
Quoted 3 lines · Romain Naour
While migrating to pep517 build backend the host-python-wheel dependency has been added to host-python-setuptools but not to python-setuptools.
What is really going on here is that setuptools' setup.py checks at build time
if the wheel dependency is present. Since it uses host-python to check that, we need host-python-wheel as a build dependency. I extended the commit message to explain this better.
However, this implies that target python-wheel should also be present at
runtime. The Z3 in the fixes line doesn't trigger the wheel dependency, but in general it should be there. I've therefore also added a runtime dependency in the Config.in.
I think we'll see more of these issues with PEP517 setup types, because PEP517
tools will generally check dependencies at build time, but they use the host directory for that. So I do think that we should find a more generic solution for this.
For now, though, I've just applied this to master, thanks.
Regards,
Arnout
Quoted 15 lines
Fixes:
https://gitlab.com/buildroot.org/buildroot/-/jobs/4537951715Signed-off-by Romain Naour <[email protected]>Cc James Hilliard <[email protected]>--- package/python-setuptools/python-setuptools.mk | 1 + 1 file changed, 1 insertion(+)package/python-setuptools/python-setuptools.mk +0
-0
package/python-setuptools/python-setuptools.mk PYTHON_SETUPTOOLS_LICENSE_FILES = LICENSE · line 18
Quoted 7 lines
package/python-setuptools/python-setuptools.mk +1
-0@@ -12,6 +12,7 @@ PYTHON_SETUPTOOLS_LICENSE_FILES = LICENSE PYTHON_SETUPTOOLS_CPE_ID_VENDOR = python PYTHON_SETUPTOOLS_CPE_ID_PRODUCT = setuptools PYTHON_SETUPTOOLS_SETUP_TYPE = pep517 +PYTHON_SETUPTOOLS_DEPENDENCIES = host-python-wheel HOST_PYTHON_SETUPTOOLS_DEPENDENCIES = host-python-wheel $(eval $(python-package))
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot