sctp_big_chunk: Do not use md5 hmac algo if fips is enabled
PATCH v2 1/1 sctp_big_chunk: Do not use md5 hmac algo if fips is enabled
MD5 is not FIPS compliant. But still md5 is used as the default algorithm for sctp even when fips is enabled. Due to this, sctp_big_chunk testcase is failing because listen() system call in setup_server() is failing in fips environment.
Fix is to not use md5 algorithm while setting up server, instead set it to none
Signed-Off by: Ashwin Dayanand Kamat <[email protected]>
----
v2:
As per the review comments given by Petr, did below changes in v2,
* Moved the logic to sctp_server() function
* Setting none as the default algo
* make sure cookie_hmac_alg file is present before accessing it
--- testcases/network/sctp/sctp_big_chunk.c | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+)
testcases/network/sctp/sctp_big_chunk.c +21 -0
@@ -34,6 +34,24 @@ static int addr_num = 3273;static void setup_server (void ) { +const char *const cmd_modprobe[] = {"modprobe" ,"sctp" ,NULL }; +const char hmac_algo_path[] ="/proc/sys/net/sctp/cookie_hmac_alg" ; +char hmac_algo[CHAR_MAX ]; +int hmac_algo_changed =0 ; + +/* Disable md5 if fips is enabled. Set it to none */ +if (tst_fips_enabled ()) { +if (access (hmac_algo_path,F_OK ) <0 ) { +SAFE_CMD (cmd_modprobe,NULL ,NULL ); + } + +if (!access (hmac_algo_path,F_OK )) { +SAFE_FILE_SCANF (hmac_algo_path,"%s" , hmac_algo); +SAFE_FILE_PRINTF (hmac_algo_path,"%s" ,"none" ); + hmac_algo_changed =1 ; + } + } + loc.sin6_family =AF_INET6 ; loc.sin6_addr = in6addr_loopback;
@@ -46,6 +64,9 @@ static void setup_server(void)SAFE_LISTEN (sfd,1 );srand (port); + +if (hmac_algo_changed) +SAFE_FILE_PRINTF (hmac_algo_path,"%s" , hmac_algo); }static void update_packet_field (size_t *off,void *buf,size_t buf_len)
Signature · 5 lines
2.39.0 -- Mailing list info: https://lists.linux.it/listinfo/ltp
Hi Ashwin,
LGTM now.
Kind regards,
Petr
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
Hi,
Quoted 6 lines
MD5 is not FIPS compliant. But still md5 is used as the default algorithm for sctp even when fips is enabled. Due to this,
sctp_big_chunktestcase is failing becauselisten()system call insetup_server()is failing in fips environment.Fix is to not use md5 algorithm while setting up server, instead set it to none
Quoted 7 lines
Signed-Off by: Ashwin Dayanand Kamat <[email protected]>
----
v2:
As per the review comments given by Petr, did below changes in v2,
* Moved the logic tosctp_server()function
* Setting none as the default algo
* make surecookie_hmac_algfile is present before accessing it
BTW I suggested modprobe, because I'm not aware of other way to trigger it. But maybe creating SCTP socket would trigger it, e.g. socket(PF_INET, SOCK_STREAM, IPPROTO_SCTP);
If yes, IMHO it'd be more elegant solution and (likely) we would not depend on modprobe.
Kind regards,
Petr
Quoted 43 lines
--- testcases/network/sctp/sctp_big_chunk.c | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+)testcases/network/sctp/sctp_big_chunk.c +21
-0@@ -34,6 +34,24 @@ static int addr_num = 3273;static void setup_server (void ) { +const char *const cmd_modprobe[] = {"modprobe" ,"sctp" ,NULL }; +const char hmac_algo_path[] ="/proc/sys/net/sctp/cookie_hmac_alg" ; +char hmac_algo[CHAR_MAX ]; +int hmac_algo_changed =0 ; + +/* Disable md5 if fips is enabled. Set it to none */ +if (tst_fips_enabled ()) { +if (access (hmac_algo_path,F_OK ) <0 ) { +SAFE_CMD (cmd_modprobe,NULL ,NULL ); + } + +if (!access (hmac_algo_path,F_OK )) { +SAFE_FILE_SCANF (hmac_algo_path,"%s" , hmac_algo); +SAFE_FILE_PRINTF (hmac_algo_path,"%s" ,"none" ); + hmac_algo_changed =1 ; + } + } + loc.sin6_family =AF_INET6 ; loc.sin6_addr = in6addr_loopback;@@ -46,6 +64,9 @@ static void setup_server(void)SAFE_LISTEN (sfd,1 );srand (port); + +if (hmac_algo_changed) +SAFE_FILE_PRINTF (hmac_algo_path,"%s" , hmac_algo); }static void update_packet_field (size_t *off,void *buf,size_t buf_len)
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
Quoted 15 lines
Hi,
Quoted 6 lines
MD5 is not FIPS compliant. But still md5 is used as the default algorithm for sctp even when fips is enabled. Due to this,
sctp_big_chunktestcase is failing becauselisten()system call insetup_server()is failing in fips environment.Fix is to not use md5 algorithm while setting up server, instead set it to none
Quoted 7 lines
Signed-Off by: Ashwin Dayanand Kamat <[email protected]>
----
v2:
As per the review comments given by Petr, did below changes in v2,
* Moved the logic tosctp_server()function
* Setting none as the default algo
* make surecookie_hmac_algfile is present before accessing it
Quoted 3 lines
BTW I suggested modprobe, because I'm not aware of other way to trigger it. But maybe creating SCTP socket would trigger it, e.g.
socket(PF_INET, SOCK_STREAM, IPPROTO_SCTP);
Yes, this simple socket call loads sctp module. Could we use something like this:
int fd; fd = SAFE_SOCKET(PF_INET, SOCK_STREAM, IPPROTO_SCTP); SAFE_CLOSE(fd);
to make sure sctp is loaded instead of directly calling modprobe?
I'm sorry I didn't find this before.
Kind regards,
Petr
Quoted 49 lines
If yes, IMHO it'd be more elegant solution and (likely) we would not depend on modprobe.
Kind regards,
PetrQuoted 43 lines
--- testcases/network/sctp/sctp_big_chunk.c | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+)testcases/network/sctp/sctp_big_chunk.c +21
-0@@ -34,6 +34,24 @@ static int addr_num = 3273;static void setup_server (void ) { +const char *const cmd_modprobe[] = {"modprobe" ,"sctp" ,NULL }; +const char hmac_algo_path[] ="/proc/sys/net/sctp/cookie_hmac_alg" ; +char hmac_algo[CHAR_MAX ]; +int hmac_algo_changed =0 ; + +/* Disable md5 if fips is enabled. Set it to none */ +if (tst_fips_enabled ()) { +if (access (hmac_algo_path,F_OK ) <0 ) { +SAFE_CMD (cmd_modprobe,NULL ,NULL ); + } + +if (!access (hmac_algo_path,F_OK )) { +SAFE_FILE_SCANF (hmac_algo_path,"%s" , hmac_algo); +SAFE_FILE_PRINTF (hmac_algo_path,"%s" ,"none" ); + hmac_algo_changed =1 ; + } + } + loc.sin6_family =AF_INET6 ; loc.sin6_addr = in6addr_loopback;@@ -46,6 +64,9 @@ static void setup_server(void)SAFE_LISTEN (sfd,1 );srand (port); + +if (hmac_algo_changed) +SAFE_FILE_PRINTF (hmac_algo_path,"%s" , hmac_algo); }static void update_packet_field (size_t *off,void *buf,size_t buf_len)
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
Hi Ashwin,
LGTM, but as I wrote, I'd prefer so load with SAFE_SOCKET(). Will you please send v3?
Kind regards,
Petr
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
Quoted 13 lines · Petr Vorel
!! External Email
Hi Ashwin,
Tested-by Petr Vorel <[email protected]>LGTM, but as I wrote, I'd prefer so load with
SAFE_SOCKET(). Will you please send v3?
Hi Petr,
Thanks for your inputs. I have sent the v3 patch and have made changes as suggested by you.
Thanks,
Ashwin
Quoted 4 lines
Kind regards,
Petr!! External Email: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender.
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp