Skip to contentSkip to conversation

ARM: dts: exynos: Add Samsung Galaxy Tab 3 8.0 boards

PATCH Superseded Artur Weber 2 participants 2 messages Jun 28, 2023 – Jul 10, 2023

Subsystems (3)

v5 of 6 Superseded Latest is v6 →

lore
Share & tools
lore
#0 lore raw

PATCH v5 1/1 ARM: dts: exynos: Add Samsung Galaxy Tab 3 8.0 boards

Introduce support for the Galaxy Tab 3 8.0 series of boards:

- Samsung Galaxy Tab 3 8.0 WiFi (SM-T310/lt01wifi)
- Samsung Galaxy Tab 3 8.0 3G (SM-T311/lt013g)
- Samsung Galaxy Tab 3 8.0 LTE (SM-T315/lt01lte)

What works:

- Display and backlight
- Touchscreen
- GPIO buttons, hall sensor
- WiFi and Bluetooth
- USB, fuel gauge, charging
- Accelerometer and magnetometer
- Audio: speaker, microphone, headset
- WiFi model only: light sensor

---
This is an updated version of "[PATCH v3 13/13] ARM: dts: exynos: Add Samsung Galaxy Tab 3 8.0 boards"[1].

Changed in v5:
- Re-added disabled RTC node instead of deleting it with delete-node

Changed in v4:
- Added touchkey keycodes
- Added audio nodes
- Added MMC aliases
- Fixed dtbs_check warnings
- Fixed indentation in pinctrl sleep state overrides

Changed in v3:
- Addressed review comments
- Removed rtc node (RTC is provided by PMIC)
- Added CPU thermal node
- Fixed dtbs_check warnings
- Added common changes from next/dt

Should pass dtbs_check with no errors, provided that the following patches are present:

Backlight node is adapted to changes from "[PATCH v2 1/4] dt-bindings:
backlight: lp855x: convert to YAML and modernize"[2]. The whole patchset has been merged into the backlight tree.

Touchkey keycode property is added by "[PATCH 1/2] dt-bindings: mms114: Add linux,keycodes property for touch keys"[3]. So far only the bindings part of the patch has been acked, otherwise everything is awaiting review.

Display bindings have been added by "[PATCH v5 1/3] dt-bindings: display:
panel: Add Samsung S6D7AA0 LCD panel controller"[4]. These are already reviewed and merged into the DRM tree.

[1] https://lore.kernel.org/linux-devicetree/[email protected]/
[2] https://lore.kernel.org/linux-devicetree/[email protected]/
[3] https://lore.kernel.org/linux-devicetree/[email protected]/
[4] https://lore.kernel.org/linux-devicetree/[email protected]/

---
 arch/arm/boot/dts/Makefile                  |    3 +
 arch/arm/boot/dts/exynos4212-tab3-3g8.dts   |   29 +
 arch/arm/boot/dts/exynos4212-tab3-lte8.dts  |   44 +
 arch/arm/boot/dts/exynos4212-tab3-wifi8.dts |   26 +
 arch/arm/boot/dts/exynos4212-tab3.dtsi      | 1310 +++++++++++++++++++
 5 files changed, 1412 insertions(+)
 create mode 100644 arch/arm/boot/dts/exynos4212-tab3-3g8.dts
 create mode 100644 arch/arm/boot/dts/exynos4212-tab3-lte8.dts
 create mode 100644 arch/arm/boot/dts/exynos4212-tab3-wifi8.dts
 create mode 100644 arch/arm/boot/dts/exynos4212-tab3.dtsi
arch/arm/boot/dts/Makefile +3 -0
index 59829fc90315..6a4ca481171e 100644
@@ -217,6 +217,9 @@ dtb-$(CONFIG_ARCH_EXYNOS4) += \
 	exynos4210-smdkv310.dtb \
 	exynos4210-trats.dtb \
 	exynos4210-universal_c210.dtb \
+	exynos4212-tab3-3g8.dtb \
+	exynos4212-tab3-lte8.dtb \
+	exynos4212-tab3-wifi8.dtb \
 	exynos4412-i9300.dtb \
 	exynos4412-i9305.dtb \
 	exynos4412-itop-elite.dtb \
arch/arm/boot/dts/exynos4212-tab3-3g8.dts new file +29 -0
new file mode 100644
index 000000000000..d96b2dd44608
@@ -0,0 +1,29 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Samsung's Exynos4212 based Galaxy Tab 3 8.0 3G board device tree
+ * source
+ *
+ * Copyright (c) 2013 Samsung Electronics Co., Ltd.
+ *		http://www.samsung.com
+ */
+
+/dts-v1/;
+#include "exynos4212-tab3.dtsi"
+
+/ {
+	model = "Samsung Galaxy Tab 3 8.0 3G (SM-T311) based on Exynos4212";
+	compatible = "samsung,t311", "samsung,tab3", "samsung,exynos4212", "samsung,exynos4";
+	chassis-type = "tablet";
+};
+
+/* Pin control sleep state overrides */
+&sleep0 {
+	PIN_SLP(gpb-5, INPUT, UP);
+};
+
+&sleep1 {
+	PIN_SLP(gpl0-0, OUT0, NONE);
+	PIN_SLP(gpl1-0, OUT0, NONE);
+	PIN_SLP(gpl2-4, OUT0, NONE);
+	PIN_SLP(gpm3-3, OUT1, NONE);
+};
arch/arm/boot/dts/exynos4212-tab3-lte8.dts new file +44 -0

44 lines not on this page · raw message

arch/arm/boot/dts/exynos4212-tab3-wifi8.dts new file +26 -0
new file mode 100644
index 000000000000..54cb01703b60
@@ -0,0 +1,26 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Samsung's Exynos4212 based Galaxy Tab 3 8.0 WiFi board device tree
+ * source
+ *
+ * Copyright (c) 2013 Samsung Electronics Co., Ltd.
+ *		http://www.samsung.com
+ */
+
+/dts-v1/;
+#include "exynos4212-tab3.dtsi"
+
+/ {
+	model = "Samsung Galaxy Tab 3 8.0 WiFi (SM-T310) based on Exynos4212";
+	compatible = "samsung,t310", "samsung,tab3", "samsung,exynos4212", "samsung,exynos4";
+	chassis-type = "tablet";
+};
+
+&i2c_lightsensor {
+	status = "okay";
+
+	lightsensor@10 {
+		compatible = "capella,cm3323";
+		reg = <0x10>;
+	};
+};
arch/arm/boot/dts/exynos4212-tab3.dtsi new file +1310 -0

1,310 lines not on this page · raw message

base-commit: a3119e95a0d193a0c13168ba48bd081ce11060ff

Signature · 1 line
2.41.0
#1 lore raw
Quoted 58 lines · Artur Weber

Introduce support for the Galaxy Tab 3 8.0 series of boards:

- Samsung Galaxy Tab 3 8.0 WiFi (SM-T310/lt01wifi)
- Samsung Galaxy Tab 3 8.0 3G (SM-T311/lt013g)
- Samsung Galaxy Tab 3 8.0 LTE (SM-T315/lt01lte)

What works:

- Display and backlight
- Touchscreen
- GPIO buttons, hall sensor
- WiFi and Bluetooth
- USB, fuel gauge, charging
- Accelerometer and magnetometer
- Audio: speaker, microphone, headset
- WiFi model only: light sensor

---
This is an updated version of "[PATCH v3 13/13] ARM: dts: exynos: Add Samsung Galaxy Tab 3 8.0 boards"[1].

Changed in v5:
- Re-added disabled RTC node instead of deleting it with delete-node

Changed in v4:
- Added touchkey keycodes
- Added audio nodes
- Added MMC aliases
- Fixed dtbs_check warnings
- Fixed indentation in pinctrl sleep state overrides

Changed in v3:
- Addressed review comments
- Removed rtc node (RTC is provided by PMIC)
- Added CPU thermal node
- Fixed dtbs_check warnings
- Added common changes from next/dt

Should pass dtbs_check with no errors, provided that the following patches are present:

Backlight node is adapted to changes from "[PATCH v2 1/4] dt-bindings:
backlight: lp855x: convert to YAML and modernize"[2]. The whole patchset has been merged into the backlight tree.

Touchkey keycode property is added by "[PATCH 1/2] dt-bindings: mms114: Add linux,keycodes property for touch keys"[3]. So far only the bindings part of the patch has been acked, otherwise everything is awaiting review.

Display bindings have been added by "[PATCH v5 1/3] dt-bindings: display:
panel: Add Samsung S6D7AA0 LCD panel controller"[4]. These are already reviewed and merged into the DRM tree.

[1] https://lore.kernel.org/linux-devicetree/[email protected]/
[2] https://lore.kernel.org/linux-devicetree/[email protected]/
[3] https://lore.kernel.org/linux-devicetree/[email protected]/
[4] https://lore.kernel.org/linux-devicetree/[email protected]/

Quoted 6 lines
---
 arch/arm/boot/dts/Makefile                  |    3 +
 arch/arm/boot/dts/exynos4212-tab3-3g8.dts   |   29 +
 arch/arm/boot/dts/exynos4212-tab3-lte8.dts  |   44 +
 arch/arm/boot/dts/exynos4212-tab3-wifi8.dts |   26 +
 arch/arm/boot/dts/exynos4212-tab3.dtsi      | 1310 +++++++++++++++++++

This does not apply. You rebased your work on some older version/tree, without new layout. Please work on linux-next.

Best regards,
Krzysztof