usb: dwc3-generic: Ensure reset GPIO is configured as an output
Subsystems (2)
PATCH 1/1 usb: dwc3-generic: Ensure reset GPIO is configured as an output
GPIOD_ACTIVE_LOW is not enough to configure a GPIO as an output, we need GPIOD_IS_OUT as well.
Fixes b252d79b0936d60b ("usb: dwc3: Add support to reset usb ULPI phy")
Signed-off-by Peter Korsgaard <[email protected]>
--- drivers/usb/dwc3/dwc3-generic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/usb/dwc3/dwc3-generic.c +1 -1
@@ -105,7 +105,7 @@ static int dwc3_generic_probe(struct udevice *dev,if (CONFIG_IS_ENABLED (DM_GPIO ) &&device_is_compatible (dev->parent,"xlnx,zynqmp-dwc3" )) { priv->ulpi_reset =devm_gpiod_get_optional (dev->parent,"reset" , -GPIOD_ACTIVE_LOW ); +GPIOD_IS_OUT |GPIOD_ACTIVE_LOW );/* property is optional, don't return error! */ if (priv->ulpi_reset) {/* Toggle ulpi to reset the phy. */
Signature · 1 line
2.30.2
Marek Vasut
AppliedQuoted 5 lines · Peter Korsgaard
GPIOD_ACTIVE_LOWis not enough to configure a GPIO as an output, we needGPIOD_IS_OUTas well.Fixes b252d79b0936d60b ("usb: dwc3: Add support to reset usb ULPI phy")Signed-off-by Peter Korsgaard <[email protected]>
Applied to usb/master, thanks !