Skip to contentSkip to conversation

serial: 8250: Preserve original value of DLF register

PATCH Superseded ruihongluo 2 participants 6 messages Jun 28, 2023 – Jun 29, 2023

Subsystems (3)

v1 of 4 Superseded Latest is v4 →

lore
Share & tools
lore

ruihongluo

author
#0 lore raw

PATCH 1/1 serial: 8250: Preserve original value of DLF register

This commit is aimed at preserving the original value of the DLF(Divisor Latch Fraction Register). When the DLF register is modified without preservation, it can disrupt the baudrate settings established by firmware or bootloader , leading to data corruption and the generation of unreadable or distorted characters.

---
 drivers/tty/serial/8250/8250_dwlib.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/tty/serial/8250/8250_dwlib.c +4 -2
index 75f32f054ebb..d30957722da8 100644
@@ -244,7 +244,7 @@ void dw8250_setup_port(struct uart_port *p)
 	struct dw8250_port_data *pd = p->private_data;
 	struct dw8250_data *data = to_dw8250_data(pd);
 	struct uart_8250_port *up = up_to_u8250p(p);
-	u32 reg;
+	u32 reg, orig;
 
 	pd->hw_rs485_support = dw8250_detect_rs485_hw(p);
 	if (pd->hw_rs485_support) {
@@ -270,9 +270,11 @@ void dw8250_setup_port(struct uart_port *p)
 	dev_dbg(p->dev, "Designware UART version %c.%c%c\n",
 		(reg >> 24) & 0xff, (reg >> 16) & 0xff, (reg >> 8) & 0xff);
 
+	/* Preserve value written by firmware or bootloader  */
+	orig = dw8250_readl_ext(p, DW_UART_DLF);
 	dw8250_writel_ext(p, DW_UART_DLF, ~0U);
 	reg = dw8250_readl_ext(p, DW_UART_DLF);
-	dw8250_writel_ext(p, DW_UART_DLF, 0);
+	dw8250_writel_ext(p, DW_UART_DLF, orig);
 
 	if (reg) {
 		pd->dlf_size = fls(reg);
Signature · 1 line
2.39.2
#1 lore raw
Quoted 1 line · ruihongluo

This commit is aimed at preserving the original value of the

"This commit is aimed at preserving the original..." --> "Preserve the original..."

Quoted 4 lines

DLF(Divisor Latch Fraction Register). When the DLF register is modified without preservation, it can disrupt the baudrate settings established by firmware or bootloader , leading to data corruption and the generation of unreadable or distorted characters.

You have From different to SoB. You need to fix this. It can be done by setting corresponding values in the ~/.gitconfig of your machine where you are making patches on.

Quick fix is to run

	git commit --amend --author="ruihongluo <[email protected]>"

and resend as a v2.

Code wise looks good to me, thank you for fixing this. Perhaps it needs a Fixes tag, as

Fixes 701c5e73b296 ("serial: 8250_dw: add fractional divisor support")

added before your SoB line. (Again, use git commit --amend to address this.)

Quoted 2 lines

---

Also don't forget to add a changelog here for v2 to describe your changes.

Signature · 2 lines
With Best Regards,
Andy Shevchenko
author
#2 lore raw

PATCH v2 1/1 serial: 8250: Preserve original value of DLF register

This commit is aimed at preserving the original value of the DLF(Divisor Latch Fraction Register). When the DLF register is modified without preservation, it can disrupt the baudrate settings established by firmware or bootloader , leading to data corruption and the generation of unreadable or distorted characters.

Fixes 701c5e73b296 ("serial: 8250_dw: add fractional divisor support")

---
v2:
- added fixes tag

 drivers/tty/serial/8250/8250_dwlib.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/tty/serial/8250/8250_dwlib.c +4 -2
index 75f32f054ebb..d30957722da8 100644
@@ -244,7 +244,7 @@ void dw8250_setup_port(struct uart_port *p)
 	struct dw8250_port_data *pd = p->private_data;
 	struct dw8250_data *data = to_dw8250_data(pd);
 	struct uart_8250_port *up = up_to_u8250p(p);
-	u32 reg;
+	u32 reg, orig;
 
 	pd->hw_rs485_support = dw8250_detect_rs485_hw(p);
 	if (pd->hw_rs485_support) {
@@ -270,9 +270,11 @@ void dw8250_setup_port(struct uart_port *p)
 	dev_dbg(p->dev, "Designware UART version %c.%c%c\n",
 		(reg >> 24) & 0xff, (reg >> 16) & 0xff, (reg >> 8) & 0xff);
 
+	/* Preserve value written by firmware or bootloader  */
+	orig = dw8250_readl_ext(p, DW_UART_DLF);
 	dw8250_writel_ext(p, DW_UART_DLF, ~0U);
 	reg = dw8250_readl_ext(p, DW_UART_DLF);
-	dw8250_writel_ext(p, DW_UART_DLF, 0);
+	dw8250_writel_ext(p, DW_UART_DLF, orig);
 
 	if (reg) {
 		pd->dlf_size = fls(reg);
Signature · 6 lines
Just wanted to drop a quick note to say thanks for your help with git
send-email and code modifications.
Your assistance on the details was much appreciated.

Best regards,
Ruihong Luo
#3 lore raw
Quoted 8 lines · ruihongluo

This commit is aimed at preserving the original value of the DLF(Divisor Latch Fraction Register). When the DLF register is modified without preservation, it can disrupt the baudrate settings established by firmware or bootloader , leading to data corruption and the generation of unreadable or distorted characters.

Fixes 701c5e73b296 ("serial: 8250_dw: add fractional divisor support")

To make it a tag you should avoid blank lines in the tag block.

Quoted 4 lines

---
v2:
- added fixes tag

Actually not. See above.

And what about the rest of the comments?

...

Quoted 3 lines

Just wanted to drop a quick note to say thanks for your help with git send-email and code modifications.
Your assistance on the details was much appreciated.

You're welcome!

Quoted 1 line

Ruihong Luo

This seems needs to be in your Git config:

$ cat ~/.gitconfig
[user]
	name = Ruihong Luo
	email = [email protected]
Signature · 2 lines
With Best Regards,
Andy Shevchenko
#4 lore raw

PATCH v2 1/1 serial: 8250: Preserve original value of DLF register

This commit is aimed at preserving the original value of the DLF(Divisor Latch Fraction Register). When the DLF register is modified without preservation, it can disrupt the baudrate settings established by firmware or bootloader , leading to data corruption and the generation of unreadable or distorted characters.

Fixes 701c5e73b296 ("serial: 8250_dw: add fractional divisor support")

---
v2:
- add a tag

 drivers/tty/serial/8250/8250_dwlib.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/tty/serial/8250/8250_dwlib.c +4 -2
index 75f32f054ebb..d30957722da8 100644
@@ -244,7 +244,7 @@ void dw8250_setup_port(struct uart_port *p)
 	struct dw8250_port_data *pd = p->private_data;
 	struct dw8250_data *data = to_dw8250_data(pd);
 	struct uart_8250_port *up = up_to_u8250p(p);
-	u32 reg;
+	u32 reg, orig;
 
 	pd->hw_rs485_support = dw8250_detect_rs485_hw(p);
 	if (pd->hw_rs485_support) {
@@ -270,9 +270,11 @@ void dw8250_setup_port(struct uart_port *p)
 	dev_dbg(p->dev, "Designware UART version %c.%c%c\n",
 		(reg >> 24) & 0xff, (reg >> 16) & 0xff, (reg >> 8) & 0xff);
 
+	/* Preserve value written by firmware or bootloader  */
+	orig = dw8250_readl_ext(p, DW_UART_DLF);
 	dw8250_writel_ext(p, DW_UART_DLF, ~0U);
 	reg = dw8250_readl_ext(p, DW_UART_DLF);
-	dw8250_writel_ext(p, DW_UART_DLF, 0);
+	dw8250_writel_ext(p, DW_UART_DLF, orig);
 
 	if (reg) {
 		pd->dlf_size = fls(reg);
Signature · 1 line
2.39.2
#5 lore raw
Quoted 1 line · Ruihong Luo

This commit is aimed at preserving the original value of the

Preserve the original value...

Quoted 1 line

DLF(Divisor Latch Fraction Register). When the DLF register is

Divisor Latch Fraction (DLF) register...

Quoted 2 lines

modified without preservation, it can disrupt the baudrate settings established by firmware or bootloader , leading to data corruption

...bootloader, leading...

Quoted 7 lines

and the generation of unreadable or distorted characters.

Fixes 701c5e73b296 ("serial: 8250_dw: add fractional divisor support")

---
v2:
- add a tag

It's a v3 and still some comments are not (yet) addressed:
1) your from header in email != SoB;
2) do not use In-reply-to email header for the new patch versions;
3) the commit message should be amended as I pointed out above again.

It will go nowhere if you continue ignoring reviewers' comments.

Signature · 2 lines
With Best Regards,
Andy Shevchenko