ceph: don't let check_caps skip sending responses for revoke msgs
Subsystems (2)
PATCH v3 1/1 ceph: don't let check_caps skip sending responses for revoke msgs
From: Xiubo Li <[email protected]>
If a client sends out a cap update dropping caps with the prior 'seq' just before an incoming cap revoke request, then the client may drop the revoke because it believes it's already released the requested capabilities.
This causes the MDS to wait indefinitely for the client to respond to the revoke. It's therefore always a good idea to ack the cap revoke request with the bumped up 'seq'.
---
V3:
- Updated the commit message from Patrick. Thanks!
fs/ceph/caps.c | 9 +++++++++ 1 file changed, 9 insertions(+)
fs/ceph/caps.c +9 -0
@@ -3566,6 +3566,15 @@ static void handle_cap_grant(struct inode *inode, }BUG_ON (cap->issued & ~cap->implemented); +/* don't let check_caps skip sending a response to MDS for revoke msgs */ +if (le32_to_cpu (grant->op) ==CEPH_CAP_OP_REVOKE ) { + cap->mds_wanted =0 ; +if (cap == ci->i_auth_cap) + check_caps =1 ;/* check auth cap only */ +else + check_caps =2 ;/* check all caps */ + } +if (extra_info->inline_version >0 && extra_info->inline_version >= ci->i_inline_version) { ci->i_inline_version = extra_info->inline_version;
Signature · 1 line
2.40.1
Quoted 12 lines · On Wed, Jun 28, 2023 at 10:36 PM <[email protected]> wrote:
From: Xiubo Li <[email protected]>
If a client sends out a cap update dropping caps with the prior 'seq' just before an incoming cap revoke request, then the client may drop the revoke because it believes it's already released the requested capabilities.
This causes the MDS to wait indefinitely for the client to respond to the revoke. It's therefore always a good idea to ack the cap revoke request with the bumped up 'seq'.
Quoted 5 lines
Signed-off-by Xiubo Li <[email protected]>Reviewed-by Milind Changire <[email protected]>Signed-off-by Ilya Dryomov <[email protected]>
Signature · 5 lines
Patrick Donnelly, Ph.D. He / Him / His Red Hat Partner Engineer IBM, Inc. GPG: 19F28A586F808C2402351B93C3301A3E258DD79D