Skip to contentSkip to conversation

lib: sbi: fix comment indent

PATCH New Gianluca Guida 2 participants 3 messages Jun 29, 2023 – Jul 5, 2023

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 lib: sbi: fix comment indent

Use tabs rather than spaces.

---
 lib/sbi/sbi_ecall_dbcn.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
lib/sbi/sbi_ecall_dbcn.c +4 -4
index ecec027..8e68729 100644
@@ -34,10 +34,10 @@ static int sbi_ecall_dbcn_handler(unsigned long extid, unsigned long funcid,
 		 * Based on above, we simply fail if the upper 32bits of
 		 * the physical address (i.e. a2 register) is non-zero on
 		 * RV32.
-                 *
-                 * Analogously, we fail if the upper 64bit of the
-                 * physical address (i.e. a2 register) is non-zero on
-                 * RV64.
+		 *
+		 * Analogously, we fail if the upper 64bit of the
+		 * physical address (i.e. a2 register) is non-zero on
+		 * RV64.
 		 */
 		if (regs->a2)
 			return SBI_ERR_FAILED;
Signature · 1 line
2.34.1
#1 lore raw

PATCH 1/1 lib: sbi: fix comment indent

Quoted 4 lines · On Thu, Jun 29, 2023 at 8:00?PM Gianluca Guida <[email protected]> wrote:

Use tabs rather than spaces.

Looks good to me.

Regards,
Anup

Quoted 31 lines
---
 lib/sbi/sbi_ecall_dbcn.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
lib/sbi/sbi_ecall_dbcn.c +4 -5
index ecec027..8e68729 100644
@@ -34,10 +34,10 @@ static int sbi_ecall_dbcn_handler(unsigned long extid, unsigned long funcid,
                 * Based on above, we simply fail if the upper 32bits of
                 * the physical address (i.e. a2 register) is non-zero on
                 * RV32.
-                 *
-                 * Analogously, we fail if the upper 64bit of the
-                 * physical address (i.e. a2 register) is non-zero on
-                 * RV64.
+                *
+                * Analogously, we fail if the upper 64bit of the
+                * physical address (i.e. a2 register) is non-zero on
+                * RV64.
                 */
                if (regs->a2)
                        return SBI_ERR_FAILED;
--

2.34.1

--
opensbi mailing list
opensbi at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/opensbi

Applied
#2 lore raw

PATCH 1/1 lib: sbi: fix comment indent

In reply to Gianluca Guida
Quoted 4 lines · On Thu, Jun 29, 2023 at 8:00?PM Gianluca Guida <[email protected]> wrote:

Use tabs rather than spaces.

Applied this patch to the riscv/opensbi repo.

Regards,
Anup

Quoted 31 lines
---
 lib/sbi/sbi_ecall_dbcn.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
lib/sbi/sbi_ecall_dbcn.c +4 -5
index ecec027..8e68729 100644
@@ -34,10 +34,10 @@ static int sbi_ecall_dbcn_handler(unsigned long extid, unsigned long funcid,
                 * Based on above, we simply fail if the upper 32bits of
                 * the physical address (i.e. a2 register) is non-zero on
                 * RV32.
-                 *
-                 * Analogously, we fail if the upper 64bit of the
-                 * physical address (i.e. a2 register) is non-zero on
-                 * RV64.
+                *
+                * Analogously, we fail if the upper 64bit of the
+                * physical address (i.e. a2 register) is non-zero on
+                * RV64.
                 */
                if (regs->a2)
                        return SBI_ERR_FAILED;
--

2.34.1

--
opensbi mailing list
opensbi at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/opensbi