Skip to contentSkip to conversation

drm/i915: Swap ggtt_vma during legacy cursor update

PATCH In review Maarten Lankhorst 3 participants 5 messages Jun 29, 2023 – Jul 25, 2023

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 drm/i915: Swap ggtt_vma during legacy cursor update

Xe is lacking the ability to re-use the ggtt_vma when updating cursor. Instead of pinning from the new plane_state, move the ggtt_vma from old_plane_state to new_plane_state.

---
 drivers/gpu/drm/i915/display/intel_cursor.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/gpu/drm/i915/display/intel_cursor.c +2 -3
index 4962247911d41..6f34098ea314d 100644
@@ -688,9 +688,8 @@ intel_legacy_cursor_update(struct drm_plane *_plane,
 	if (ret)
 		goto out_free;
 
-	ret = intel_plane_pin_fb(new_plane_state);
-	if (ret)
-		goto out_free;
+	/* magic trick! */
+	swap(new_plane_state->ggtt_vma, old_plane_state->ggtt_vma);
 
 	intel_frontbuffer_flush(to_intel_frontbuffer(new_plane_state->hw.fb),
 				ORIGIN_CURSOR_UPDATE);
Signature · 1 line
2.39.2
#1 lore raw

PATCH 2/2 drm/i915: Handle legacy cursor update as normal update

Move hw_done to cleanup, to ensure we only unpin cursor fb after we received a flip event. This disables the legacy_cursor_update immediate completion of flip_done events, and waits for flip_done before cleaning up.

---
 drivers/gpu/drm/i915/display/intel_display.c      | 15 ++++++++++++++-
 .../gpu/drm/i915/display/intel_display_types.h    |  2 +-
 2 files changed, 15 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/display/intel_display.c +14 -1
index 43bcd3d011bf5..38c3eb8d95789 100644
@@ -6864,6 +6864,9 @@ static void intel_atomic_cleanup_work(struct work_struct *work)
 	struct intel_crtc *crtc;
 	int i;
 
+	if (state->cursor_update)
+		drm_atomic_helper_wait_for_flip_done(&i915->drm, &state->base);
+
 	for_each_old_intel_crtc_in_state(state, crtc, old_crtc_state, i)
 		intel_color_cleanup_commit(old_crtc_state);
 
@@ -7062,7 +7065,8 @@ static void intel_atomic_commit_tail(struct intel_atomic_state *state)
 	 * - switch over to the vblank wait helper in the core after that since
 	 *   we don't need out special handling any more.
 	 */
-	drm_atomic_helper_wait_for_flip_done(dev, &state->base);
+	if (!state->cursor_update)
+		drm_atomic_helper_wait_for_flip_done(dev, &state->base);
 
 	for_each_new_intel_crtc_in_state(state, crtc, new_crtc_state, i) {
 		if (new_crtc_state->do_async_flip)
@@ -7247,6 +7251,15 @@ int intel_atomic_commit(struct drm_device *dev, struct drm_atomic_state *_state,
 				state->base.legacy_cursor_update = false;
 	}
 
+	if (state->base.legacy_cursor_update) {
+		/*
+		 * If this is a legacy cursor update, handle like a normal update,
+		 * but wait before calling cleanup
+		 */
+		state->base.legacy_cursor_update = false;
+		state->cursor_update = true;
+	}
+
 	ret = intel_atomic_prepare_commit(state);
 	if (ret) {
 		drm_dbg_atomic(&dev_priv->drm,
drivers/gpu/drm/i915/display/intel_display_types.h +1 -1
index c85cf8adc7a69..01f7c8d24179c 100644
@@ -646,7 +646,7 @@ struct intel_atomic_state {
 	/* Internal commit, as opposed to userspace/client initiated one */
 	bool internal;
 
-	bool dpll_set, modeset;
+	bool dpll_set, modeset, cursor_update;
 
 	struct intel_shared_dpll_state shared_dpll[I915_NUM_PLLS];
 
Signature · 1 line
2.39.2
#2 lore raw

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Swap ggtt_vma during legacy cursor update

In reply to Maarten Lankhorst
== Series Details ==

== Series Details ==

Series: series starting with [1/2] drm/i915: Swap ggtt_vma during legacy cursor update
URL : https://patchwork.freedesktop.org/series/120018/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_13337 -> Patchwork_120018v1
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120018v1/index.html

Participating hosts (41 -> 40)
------------------------------

Missing (1): fi-snb-2520m

Known issues
------------

Here are the changes found in Patchwork_120018v1 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_lmem_swapping@parallel-random-engines:
- bat-mtlp-8: NOTRUN -> [SKIP][1] ([i915#4613]) +3 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120018v1/bat-mtlp-8/igt@[email protected]

* igt@i915_pm_rps@basic-api:
- bat-mtlp-8: NOTRUN -> [SKIP][2] ([i915#6621])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120018v1/bat-mtlp-8/igt@[email protected]

* igt@i915_selftest@live@gt_mocs:
- bat-mtlp-8: NOTRUN -> [DMESG-FAIL][3] ([i915#7059])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120018v1/bat-mtlp-8/igt@i915_selftest@live@gt_mocs.html

* igt@i915_selftest@live@migrate:
- bat-dg2-11: [PASS][4] -> [DMESG-WARN][5] ([i915#7699])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13337/bat-dg2-11/igt@i915_selftest@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120018v1/bat-dg2-11/igt@i915_selftest@[email protected]

* igt@i915_selftest@live@requests:
- bat-mtlp-8: NOTRUN -> [ABORT][6] ([i915#7982])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120018v1/bat-mtlp-8/igt@i915_selftest@[email protected]

* igt@i915_selftest@live@reset:
- bat-rpls-2: [PASS][7] -> [ABORT][8] ([i915#4983] / [i915#7461] / [i915#7913] / [i915#8347])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13337/bat-rpls-2/igt@i915_selftest@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120018v1/bat-rpls-2/igt@i915_selftest@[email protected]

* igt@kms_pipe_crc_basic@suspend-read-crc:
- fi-bsw-nick: NOTRUN -> [SKIP][9] ([fdo#109271]) +1 similar issue
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120018v1/fi-bsw-nick/igt@[email protected]

* igt@prime_vgem@basic-fence-read:
- bat-mtlp-8: NOTRUN -> [SKIP][10] ([i915#3708]) +2 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120018v1/bat-mtlp-8/igt@[email protected]

* igt@prime_vgem@basic-gtt:
- bat-mtlp-8: NOTRUN -> [SKIP][11] ([i915#3708] / [i915#4077]) +1 similar issue
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120018v1/bat-mtlp-8/igt@[email protected]

#### Possible fixes ####

* igt@i915_pm_rpm@basic-pci-d3-state:
- bat-mtlp-8: [ABORT][12] ([i915#7077] / [i915#7977]) -> [PASS][13]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13337/bat-mtlp-8/igt@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120018v1/bat-mtlp-8/igt@[email protected]

* igt@i915_selftest@live@execlists:
- fi-bsw-nick: [ABORT][14] ([i915#7913]) -> [PASS][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13337/fi-bsw-nick/igt@i915_selftest@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120018v1/fi-bsw-nick/igt@i915_selftest@[email protected]

* igt@i915_selftest@live@gt_heartbeat:
- fi-apl-guc: [DMESG-FAIL][16] ([i915#5334]) -> [PASS][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13337/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120018v1/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html

* igt@i915_selftest@live@gt_pm:
- bat-rpls-2: [DMESG-FAIL][18] ([i915#4258] / [i915#7913]) -> [PASS][19]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13337/bat-rpls-2/igt@i915_selftest@live@gt_pm.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120018v1/bat-rpls-2/igt@i915_selftest@live@gt_pm.html

* igt@i915_selftest@live@slpc:
- bat-mtlp-6: [DMESG-WARN][20] ([i915#6367]) -> [PASS][21]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13337/bat-mtlp-6/igt@i915_selftest@[email protected]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120018v1/bat-mtlp-6/igt@i915_selftest@[email protected]

#### Warnings ####

* igt@kms_psr@primary_mmap_gtt:
- bat-rplp-1: [SKIP][22] ([i915#1072]) -> [ABORT][23] ([i915#8442] / [i915#8668])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13337/bat-rplp-1/igt@kms_psr@primary_mmap_gtt.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120018v1/bat-rplp-1/igt@kms_psr@primary_mmap_gtt.html

[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4258]: https://gitlab.freedesktop.org/drm/intel/issues/4258
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#7059]: https://gitlab.freedesktop.org/drm/intel/issues/7059
[i915#7077]: https://gitlab.freedesktop.org/drm/intel/issues/7077
[i915#7461]: https://gitlab.freedesktop.org/drm/intel/issues/7461
[i915#7699]: https://gitlab.freedesktop.org/drm/intel/issues/7699
[i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
[i915#7977]: https://gitlab.freedesktop.org/drm/intel/issues/7977
[i915#7982]: https://gitlab.freedesktop.org/drm/intel/issues/7982
[i915#8347]: https://gitlab.freedesktop.org/drm/intel/issues/8347
[i915#8442]: https://gitlab.freedesktop.org/drm/intel/issues/8442
[i915#8668]: https://gitlab.freedesktop.org/drm/intel/issues/8668

Build changes
-------------

* Linux: CI_DRM_13337 -> Patchwork_120018v1

CI-20190529: 20190529
CI_DRM_13337: 6f8963ce33be65c67e53b16fa18325e12ab76861 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7356: 66452bb0118e8d3a78d054cef50a60a9858a00a9 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_120018v1: 6f8963ce33be65c67e53b16fa18325e12ab76861 @ git://anongit.freedesktop.org/gfx-ci/linux

### Linux commits

d1f1a3383eda drm/i915: Handle legacy cursor update as normal update a06f5e90585d drm/i915: Swap ggtt_vma during legacy cursor update

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120018v1/index.html

#3 lore raw

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/2] drm/i915: Swap ggtt_vma during legacy cursor update

In reply to Maarten Lankhorst
== Series Details ==

== Series Details ==

Series: series starting with [1/2] drm/i915: Swap ggtt_vma during legacy cursor update
URL : https://patchwork.freedesktop.org/series/120018/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_13337_full -> Patchwork_120018v1_full
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with Patchwork_120018v1_full absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_120018v1_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

Participating hosts (8 -> 8)
------------------------------

No changes in participating hosts

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_120018v1_full:

### IGT changes ###

#### Possible regressions ####

* igt@kms_async_flips@test-cursor@pipe-a-hdmi-a-2:
- shard-glk: [PASS][1] -> [FAIL][2] +8 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13337/shard-glk7/igt@kms_async_flips@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120018v1/shard-glk4/igt@kms_async_flips@[email protected]

* igt@kms_async_flips@test-cursor@pipe-a-vga-1:
- shard-snb: [PASS][3] -> [FAIL][4] +5 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13337/shard-snb4/igt@kms_async_flips@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120018v1/shard-snb5/igt@kms_async_flips@[email protected]

* igt@kms_async_flips@test-cursor@pipe-b-dp-1:
- shard-apl: [PASS][5] -> [FAIL][6] +4 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13337/shard-apl6/igt@kms_async_flips@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120018v1/shard-apl2/igt@kms_async_flips@[email protected]

* igt@kms_async_flips@test-cursor@pipe-b-dp-4:
- shard-dg2: NOTRUN -> [FAIL][7] +3 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120018v1/shard-dg2-11/igt@kms_async_flips@[email protected]

* igt@kms_async_flips@test-cursor@pipe-b-hdmi-a-1:
- shard-tglu: [PASS][8] -> [FAIL][9] +6 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13337/shard-tglu-3/igt@kms_async_flips@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120018v1/shard-tglu-7/igt@kms_async_flips@[email protected]

* igt@kms_async_flips@test-cursor@pipe-b-hdmi-a-2:
- shard-rkl: [PASS][10] -> [FAIL][11] +6 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13337/shard-rkl-3/igt@kms_async_flips@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120018v1/shard-rkl-2/igt@kms_async_flips@[email protected]

* igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions-varying-size:
- shard-dg2: [PASS][12] -> [FAIL][13] +4 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13337/shard-dg2-10/igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions-varying-size.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120018v1/shard-dg2-11/igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions-varying-size.html

#### Suppressed ####

The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.

* igt@kms_async_flips@test-cursor@pipe-b-hdmi-a-4:
- {shard-dg1}: [PASS][14] -> [FAIL][15] +7 similar issues
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13337/shard-dg1-14/igt@kms_async_flips@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120018v1/shard-dg1-15/igt@kms_async_flips@[email protected]

Known issues
------------

Here are the changes found in Patchwork_120018v1_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_eio@in-flight-suspend:
- shard-dg2: [PASS][16] -> [FAIL][17] ([fdo#103375])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13337/shard-dg2-10/igt@[email protected]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120018v1/shard-dg2-5/igt@[email protected]

* igt@gem_exec_balancer@full-pulse:
- shard-dg2: [PASS][18] -> [FAIL][19] ([i915#6032])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13337/shard-dg2-8/igt@[email protected]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120018v1/shard-dg2-10/igt@[email protected]

* igt@gem_exec_fair@basic-none@bcs0:
- shard-rkl: [PASS][20] -> [FAIL][21] ([i915#2842]) +3 similar issues
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13337/shard-rkl-1/igt@gem_exec_fair@[email protected]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120018v1/shard-rkl-1/igt@gem_exec_fair@[email protected]

* igt@gem_exec_whisper@basic-fds-forked-all:
- shard-tglu: [PASS][22] -> [INCOMPLETE][23] ([i915#6755] / [i915#7392])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13337/shard-tglu-6/igt@[email protected]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120018v1/shard-tglu-8/igt@[email protected]

* igt@gem_lmem_swapping@heavy-verify-random-ccs:
- shard-apl: NOTRUN -> [SKIP][24] ([fdo#109271] / [i915#4613]) +1 similar issue
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120018v1/shard-apl4/igt@[email protected]

* igt@gem_userptr_blits@dmabuf-sync:
- shard-apl: NOTRUN -> [SKIP][25] ([fdo#109271] / [i915#3323])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120018v1/shard-apl4/igt@[email protected]

* igt@gen9_exec_parse@allowed-single:
- shard-glk: [PASS][26] -> [ABORT][27] ([i915#5566])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13337/shard-glk4/igt@[email protected]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120018v1/shard-glk9/igt@[email protected]

* igt@i915_pm_rpm@dpms-non-lpsp:
- shard-rkl: [PASS][28] -> [SKIP][29] ([i915#1397]) +1 similar issue
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13337/shard-rkl-6/igt@[email protected]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120018v1/shard-rkl-7/igt@[email protected]

* igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait:
- shard-dg2: [PASS][30] -> [SKIP][31] ([i915#1397])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13337/shard-dg2-8/igt@[email protected]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120018v1/shard-dg2-10/igt@[email protected]

* igt@kms_async_flips@async-flip-with-page-flip-events@pipe-b-vga-1-linear:
- shard-snb: NOTRUN -> [SKIP][32] ([fdo#109271]) +15 similar issues
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120018v1/shard-snb2/igt@kms_async_flips@[email protected]

* igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-180-async-flip:
- shard-apl: NOTRUN -> [SKIP][33] ([fdo#109271]) +41 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120018v1/shard-apl4/igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-180-async-flip.html

* igt@kms_ccs@pipe-c-bad-aux-stride-y_tiled_gen12_rc_ccs_cc:
- shard-apl: NOTRUN -> [SKIP][34] ([fdo#109271] / [i915#3886]) +1 similar issue
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120018v1/shard-apl4/igt@kms_ccs@pipe-c-bad-aux-stride-y_tiled_gen12_rc_ccs_cc.html

* igt@kms_content_protection@srm@pipe-a-dp-1:
- shard-apl: NOTRUN -> [TIMEOUT][35] ([i915#7173])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120018v1/shard-apl4/igt@kms_content_protection@[email protected]

* igt@kms_content_protection@srm@pipe-a-dp-2:
- shard-dg2: NOTRUN -> [TIMEOUT][36] ([i915#7173]) +1 similar issue
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120018v1/shard-dg2-12/igt@kms_content_protection@[email protected]

* igt@kms_cursor_crc@cursor-onscreen-32x32:
- shard-apl: NOTRUN -> [SKIP][37] ([fdo#109271] / [i915#4579]) +2 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120018v1/shard-apl4/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-blt:
- shard-dg2: [PASS][38] -> [FAIL][39] ([i915#6880])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13337/shard-dg2-11/igt@[email protected]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120018v1/shard-dg2-10/igt@[email protected]

* igt@kms_hdr@bpc-switch-suspend:
- shard-rkl: NOTRUN -> [SKIP][40] ([i915#3555] / [i915#4579])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120018v1/shard-rkl-2/igt@[email protected]

* igt@kms_hdr@static-toggle-dpms:
- shard-dg2: NOTRUN -> [SKIP][41] ([i915#3555] / [i915#4579])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120018v1/shard-dg2-10/igt@[email protected]

* igt@kms_plane_scaling@intel-max-src-size@pipe-a-dp-4:
- shard-dg2: NOTRUN -> [FAIL][42] ([i915#8292])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120018v1/shard-dg2-11/igt@kms_plane_scaling@[email protected]

* igt@kms_plane_scaling@plane-downscale-with-modifiers-factor-0-25@pipe-a-hdmi-a-2:
- shard-rkl: NOTRUN -> [SKIP][43] ([i915#5176]) +3 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120018v1/shard-rkl-6/igt@kms_plane_scaling@[email protected]

* igt@kms_plane_scaling@plane-downscale-with-modifiers-factor-0-25@pipe-b-hdmi-a-2:
- shard-rkl: NOTRUN -> [SKIP][44] ([i915#4579] / [i915#5176]) +3 similar issues
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120018v1/shard-rkl-6/igt@kms_plane_scaling@[email protected]

* igt@kms_plane_scaling@planes-downscale-factor-0-25-unity-scaling@pipe-d-hdmi-a-1:
- shard-dg2: NOTRUN -> [SKIP][45] ([i915#4579] / [i915#5235]) +3 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120018v1/shard-dg2-10/igt@kms_plane_scaling@[email protected]

* igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-20x20@pipe-a-hdmi-a-2:
- shard-rkl: NOTRUN -> [SKIP][46] ([i915#5235])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120018v1/shard-rkl-4/igt@kms_plane_scaling@[email protected]

* igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-20x20@pipe-b-hdmi-a-2:
- shard-rkl: NOTRUN -> [SKIP][47] ([i915#4579] / [i915#5235])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120018v1/shard-rkl-4/igt@kms_plane_scaling@[email protected]

* igt@kms_plane_scaling@planes-downscale-factor-0-5-upscale-20x20@pipe-b-hdmi-a-1:
- shard-snb: NOTRUN -> [SKIP][48] ([fdo#109271] / [i915#4579]) +9 similar issues
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120018v1/shard-snb1/igt@kms_plane_scaling@[email protected]

* igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-25@pipe-a-dp-4:
- shard-dg2: NOTRUN -> [SKIP][49] ([i915#5235]) +11 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120018v1/shard-dg2-11/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-25@pipe-a-dp-4.html

* igt@kms_sysfs_edid_timing:
- shard-dg2: [PASS][50] -> [FAIL][51] ([IGT#2])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13337/shard-dg2-11/igt@kms_sysfs_edid_timing.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120018v1/shard-dg2-10/igt@kms_sysfs_edid_timing.html

* igt@perf@enable-disable@0-rcs0:
- shard-dg2: [PASS][52] -> [FAIL][53] ([i915#8724])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13337/shard-dg2-7/igt@perf@[email protected]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120018v1/shard-dg2-11/igt@perf@[email protected]

#### Possible fixes ####

* igt@drm_fdinfo@most-busy-check-all@rcs0:
- shard-rkl: [FAIL][54] ([i915#7742]) -> [PASS][55]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13337/shard-rkl-2/igt@drm_fdinfo@[email protected]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120018v1/shard-rkl-2/igt@drm_fdinfo@[email protected]

* igt@gem_barrier_race@remote-request@rcs0:
- {shard-dg1}: [ABORT][56] ([i915#7461] / [i915#8234]) -> [PASS][57]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13337/shard-dg1-18/igt@gem_barrier_race@[email protected]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120018v1/shard-dg1-18/igt@gem_barrier_race@[email protected]

* igt@gem_create@hog-create@smem0:
- shard-dg2: [FAIL][58] ([i915#5892] / [i915#7679]) -> [PASS][59]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13337/shard-dg2-1/igt@gem_create@[email protected]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120018v1/shard-dg2-6/igt@gem_create@[email protected]

* igt@gem_ctx_isolation@preservation-s3@vcs1:
- shard-dg2: [FAIL][60] ([fdo#103375]) -> [PASS][61] +3 similar issues
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13337/shard-dg2-5/igt@gem_ctx_isolation@[email protected]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120018v1/shard-dg2-7/igt@gem_ctx_isolation@[email protected]

* igt@gem_eio@unwedge-stress:
- {shard-dg1}: [FAIL][62] ([i915#5784]) -> [PASS][63]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13337/shard-dg1-17/igt@[email protected]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120018v1/shard-dg1-19/igt@[email protected]

* igt@gem_exec_fair@basic-pace@vecs0:
- shard-rkl: [FAIL][64] ([i915#2842]) -> [PASS][65] +1 similar issue
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13337/shard-rkl-7/igt@gem_exec_fair@[email protected]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120018v1/shard-rkl-4/igt@gem_exec_fair@[email protected]

* igt@gen9_exec_parse@allowed-single:
- shard-apl: [ABORT][66] ([i915#5566]) -> [PASS][67]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13337/shard-apl7/igt@[email protected]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120018v1/shard-apl4/igt@[email protected]

* igt@i915_pm_rc6_residency@rc6-idle@rcs0:
- {shard-dg1}: [FAIL][68] ([i915#3591]) -> [PASS][69] +1 similar issue
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13337/shard-dg1-14/igt@i915_pm_rc6_residency@[email protected]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120018v1/shard-dg1-15/igt@i915_pm_rc6_residency@[email protected]

* igt@i915_pm_rpm@dpms-mode-unset-non-lpsp:
- shard-dg2: [SKIP][70] ([i915#1397]) -> [PASS][71] +1 similar issue
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13337/shard-dg2-10/igt@[email protected]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120018v1/shard-dg2-5/igt@[email protected]
- shard-rkl: [SKIP][72] ([i915#1397]) -> [PASS][73] +1 similar issue
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13337/shard-rkl-7/igt@[email protected]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120018v1/shard-rkl-4/igt@[email protected]

* igt@i915_pm_rpm@modeset-lpsp:
- {shard-dg1}: [SKIP][74] ([i915#1397]) -> [PASS][75]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13337/shard-dg1-17/igt@[email protected]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120018v1/shard-dg1-19/igt@[email protected]

* igt@i915_suspend@basic-s3-without-i915:
- shard-rkl: [FAIL][76] ([fdo#103375]) -> [PASS][77]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13337/shard-rkl-6/igt@[email protected]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120018v1/shard-rkl-2/igt@[email protected]

* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-glk: [FAIL][78] ([i915#2346]) -> [PASS][79]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13337/shard-glk9/igt@[email protected]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120018v1/shard-glk7/igt@[email protected]

* igt@kms_flip@2x-flip-vs-expired-vblank@ac-hdmi-a1-hdmi-a2:
- shard-glk: [FAIL][80] ([i915#79]) -> [PASS][81]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13337/shard-glk9/igt@kms_flip@[email protected]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120018v1/shard-glk7/igt@kms_flip@[email protected]

* igt@kms_frontbuffer_tracking@fbc-badstride:
- shard-dg2: [FAIL][82] ([i915#6880]) -> [PASS][83]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13337/shard-dg2-10/igt@[email protected]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120018v1/shard-dg2-12/igt@[email protected]

* igt@perf_pmu@busy-double-start@vecs0:
- {shard-dg1}: [FAIL][84] ([i915#4349]) -> [PASS][85] +1 similar issue
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13337/shard-dg1-12/igt@perf_pmu@[email protected]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120018v1/shard-dg1-14/igt@perf_pmu@[email protected]

#### Warnings ####

* igt@kms_content_protection@type1:
- shard-dg2: [SKIP][86] ([i915#4579] / [i915#7118] / [i915#7162]) -> [SKIP][87] ([i915#4579] / [i915#7118])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13337/shard-dg2-11/igt@[email protected]
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120018v1/shard-dg2-5/igt@[email protected]

* igt@kms_fbcon_fbt@psr-suspend:
- shard-rkl: [SKIP][88] ([fdo#110189] / [i915#3955]) -> [SKIP][89] ([i915#3955])
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13337/shard-rkl-1/igt@[email protected]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120018v1/shard-rkl-7/igt@[email protected]

* igt@kms_force_connector_basic@force-load-detect:
- shard-rkl: [SKIP][90] ([fdo#109285]) -> [SKIP][91] ([fdo#109285] / [i915#4098])
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13337/shard-rkl-6/igt@[email protected]
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120018v1/shard-rkl-2/igt@[email protected]

* igt@kms_multipipe_modeset@basic-max-pipe-crc-check:
- shard-rkl: [SKIP][92] ([i915#4070] / [i915#4816]) -> [SKIP][93] ([i915#4816])
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13337/shard-rkl-2/igt@[email protected]
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120018v1/shard-rkl-4/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[IGT#2]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/2
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3323]: https://gitlab.freedesktop.org/drm/intel/issues/3323
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4349]: https://gitlab.freedesktop.org/drm/intel/issues/4349
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4816]: https://gitlab.freedesktop.org/drm/intel/issues/4816
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#5892]: https://gitlab.freedesktop.org/drm/intel/issues/5892
[i915#6032]: https://gitlab.freedesktop.org/drm/intel/issues/6032
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6755]: https://gitlab.freedesktop.org/drm/intel/issues/6755
[i915#6880]: https://gitlab.freedesktop.org/drm/intel/issues/6880
[i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
[i915#7162]: https://gitlab.freedesktop.org/drm/intel/issues/7162
[i915#7173]: https://gitlab.freedesktop.org/drm/intel/issues/7173
[i915#7392]: https://gitlab.freedesktop.org/drm/intel/issues/7392
[i915#7461]: https://gitlab.freedesktop.org/drm/intel/issues/7461
[i915#7679]: https://gitlab.freedesktop.org/drm/intel/issues/7679
[i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#8234]: https://gitlab.freedesktop.org/drm/intel/issues/8234
[i915#8247]: https://gitlab.freedesktop.org/drm/intel/issues/8247
[i915#8292]: https://gitlab.freedesktop.org/drm/intel/issues/8292
[i915#8502]: https://gitlab.freedesktop.org/drm/intel/issues/8502
[i915#8708]: https://gitlab.freedesktop.org/drm/intel/issues/8708
[i915#8709]: https://gitlab.freedesktop.org/drm/intel/issues/8709
[i915#8724]: https://gitlab.freedesktop.org/drm/intel/issues/8724

Build changes
-------------

* Linux: CI_DRM_13337 -> Patchwork_120018v1

CI-20190529: 20190529
CI_DRM_13337: 6f8963ce33be65c67e53b16fa18325e12ab76861 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7356: 66452bb0118e8d3a78d054cef50a60a9858a00a9 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_120018v1: 6f8963ce33be65c67e53b16fa18325e12ab76861 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120018v1/index.html

#4 lore raw
In reply to Maarten Lankhorst
Quoted 25 lines

-----Original Message-----
From: Intel-gfx <[email protected]> On Behalf Of Maarten Lankhorst
Sent: Thursday, June 29, 2023 9:05 PM
To: [email protected]
Subject: [Intel-gfx] [PATCH 1/2] drm/i915: Swap ggtt_vma during legacy cursor update

Xe is lacking the ability to re-use the ggtt_vma when updating cursor. Instead of pinning from the new plane_state, move the ggtt_vma from old_plane_state to new_plane_state.

---
 drivers/gpu/drm/i915/display/intel_cursor.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/gpu/drm/i915/display/intel_cursor.c +0 -0
index 4962247911d41..6f34098ea314d 100644

drivers/gpu/drm/i915/display/intel_cursor.c intel_legacy_cursor_update(struct drm_plane *_plane, · line 692

Quoted 8 lines
drivers/gpu/drm/i915/display/intel_cursor.c +2 -3
@@ -688,9 +688,8 @@ intel_legacy_cursor_update(struct drm_plane *_plane,
 	if (ret)
 		goto out_free;
 
-	ret = intel_plane_pin_fb(new_plane_state);
-	if (ret)
-		goto out_free;
+	/* magic trick! */
+	swap(new_plane_state->ggtt_vma, old_plane_state->ggtt_vma);

There are failures in CI due to the change, this causes device busy issue.
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120018v1/shard-dg2-11/igt@kms_async_flips@[email protected]

Please cross check once.

Regards,
Uma Shankar

Quoted 4 lines
drivers/gpu/drm/i915/display/intel_cursor.c +0 -1
 	intel_frontbuffer_flush(to_intel_frontbuffer(new_plane_state->hw.fb),
 				ORIGIN_CURSOR_UPDATE);
--

2.39.2