Skip to contentSkip to conversation

HID: logitech-hidpp: Add wired USB id for Logitech G502 Lightspeed

PATCH In review Stuart Hayhurst 2 participants 5 messages Jun 29, 2023 – Jun 30, 2023

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 HID: logitech-hidpp: Add wired USB id for Logitech G502 Lightspeed

Previously, support for the G502 had been attempted and reverted within this driver. Since then, a new version of this mouse has been released, and seems to work fine.

---
 drivers/hid/hid-logitech-hidpp.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/hid/hid-logitech-hidpp.c +2 -0
index 5e1a412fd28f..050bad0f9aca 100644
@@ -4598,6 +4598,8 @@ static const struct hid_device_id hidpp_devices[] = {
 
 	{ /* Logitech G403 Wireless Gaming Mouse over USB */
 	  HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC082) },
+	{ /* Logitech G502 Lightspeed Wireless Gaming Mouse over USB */
+	  HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC08D) },
 	{ /* Logitech G703 Gaming Mouse over USB */
 	  HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC087) },
 	{ /* Logitech G703 Hero Gaming Mouse over USB */
Signature · 1 line
2.40.1.521.gf1e218fcd8
#1 lore raw
Quoted 2 lines · Stuart Hayhurst

Previously, support for the G502 had been attempted and reverted within this driver.

Can you please mention the commit(s) where this was done?

Quoted 2 lines

Since then, a new version of this mouse has been released, and seems to work fine.

Can you please list the features that get enabled by adding this USB ID to the list in the commit message?

Cheers

Quoted 22 lines

---
 drivers/hid/hid-logitech-hidpp.c | 2 ++

 1 file changed, 2 insertions(+)
drivers/hid/hid- renamed from drivers/hid/hid-logitech-hidpp.c +0 -0

logitech-hidpp.c
index 5e1a412fd28f..050bad0f9aca 100644

drivers/hid/hid-logitech-hidpp.c +0 -0
@@ -4598,6 +4598,8 @@ static const struct hid_device_id
 hidpp_devices[] = {


        { /* Logitech G403 Wireless Gaming Mouse over USB */ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC082) }, +       { /* Logitech G502 Lightspeed Wireless Gaming Mouse over USB */
+         HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC08D) }, { /* Logitech G703 Gaming Mouse over USB */ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC087) }, { /* Logitech G703 Hero Gaming Mouse over USB */

#2 lore raw

PATCH 1/1 HID: logitech-hidpp: Add wired USB id for Logitech G502 Lightspeed

In reply to Stuart Hayhurst

Previously, support for the G502 had been attempted in commit 27fc32f.
This caused some issues and was reverted by addf338.
Since then, a new version of this mouse has been released (Lightpseed Wireless), and works correctly.

This device has support for battery reporting with the driver

---
 drivers/hid/hid-logitech-hidpp.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/hid/hid-logitech-hidpp.c +2 -0
index 5e1a412fd28f..94a045ef8e50 100644
@@ -4598,6 +4598,8 @@ static const struct hid_device_id hidpp_devices[] = {
 
 	{ /* Logitech G403 Wireless Gaming Mouse over USB */
 	  HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC082) },
+	{ /* Logitech G502 Lightspeed Wireless Gaming Mouse over USB */
+	  HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC08D) },
 	{ /* Logitech G703 Gaming Mouse over USB */
 	  HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC087) },
 	{ /* Logitech G703 Hero Gaming Mouse over USB */
Signature · 1 line
2.40.1.521.gf1e218fcd8
#3 lore raw

PATCH v2 1/1 HID: logitech-hidpp: Add wired USB id for Logitech G502 Lightspeed

In reply to Stuart Hayhurst

Previously, support for the G502 had been attempted in commit 27fc32f.
This caused some issues and was reverted by addf338.
Since then, a new version of this mouse has been released (Lightpseed Wireless), and works correctly.

This device has support for battery reporting with the driver

---
 drivers/hid/hid-logitech-hidpp.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/hid/hid-logitech-hidpp.c +2 -0
index 5e1a412fd28f..94a045ef8e50 100644
@@ -4598,6 +4598,8 @@ static const struct hid_device_id hidpp_devices[] = {
 
 	{ /* Logitech G403 Wireless Gaming Mouse over USB */
 	  HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC082) },
+	{ /* Logitech G502 Lightspeed Wireless Gaming Mouse over USB */
+	  HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC08D) },
 	{ /* Logitech G703 Gaming Mouse over USB */
 	  HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC087) },
 	{ /* Logitech G703 Hero Gaming Mouse over USB */
Signature · 1 line
2.40.1.521.gf1e218fcd8
#4 lore raw
Quoted 5 lines · Stuart Hayhurst

Previously, support for the G502 had been attempted in commit 27fc32f.
This caused some issues and was reverted by addf338.
Since then, a new version of this mouse has been released (Lightpseed Wireless), and works correctly.

Sorry to do this to you, but you might need to rework the description again. The kernel maintainers are pretty strict when it comes to commit references.

"If you want to refer to a specific commit, don't just refer to the SHA-1 ID of the commit. Please also include the oneline summary of the commit, to make it easier for reviewers to know what it is about."

https://docs.kernel.org/process/submitting-patches.html#describe-your-changes

So 12-character short SHA-1 and the subject of the commit. ./scripts/checkpatch.pl should warn about that.

Should be:
27fc32fd9417 ("HID: logitech-hidpp: add USB PID for a few more supported mice"
and
addf3382c47c ("Revert "HID: logitech-hidpp: add USB PID for a few more supported mice"")

But you'll want to check those :)

Quoted 24 lines

This device has support for battery reporting with the driver

---
 drivers/hid/hid-logitech-hidpp.c | 2 ++

 1 file changed, 2 insertions(+)
drivers/hid/hid- renamed from drivers/hid/hid-logitech-hidpp.c +0 -0

logitech-hidpp.c
index 5e1a412fd28f..94a045ef8e50 100644

drivers/hid/hid-logitech-hidpp.c +0 -0
@@ -4598,6 +4598,8 @@ static const struct hid_device_id
 hidpp_devices[] = {


        { /* Logitech G403 Wireless Gaming Mouse over USB */ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC082) }, +       { /* Logitech G502 Lightspeed Wireless Gaming Mouse over USB */
+         HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC08D) }, { /* Logitech G703 Gaming Mouse over USB */ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC087) }, { /* Logitech G703 Hero Gaming Mouse over USB */