PCI/VGA: Move the new_state assignment out the loop
PATCH 1/2 PCI/VGA: Move the new_state assignment out the loop
From: Sui Jingfeng <[email protected]>
In the vga_arbiter_notify_clients() function, the value of the 'new_state' variable will be 'false' on the systems which have more than one PCI display card. Its value will be 'true' on the systems which have only one or no PCI display card. Its value is not relevant to the iteration, so move the new_state assignment out the loop. For multiple video card systems this could be an optimization.
Signed-off-by Sui Jingfeng <[email protected]>
--- drivers/pci/vgaarb.c | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-)
drivers/pci/vgaarb.c +7 -9
@@ -1482,22 +1482,20 @@ static void vga_arbiter_notify_clients(void) {struct vga_device *vgadev;unsigned long flags; -uint32_t new_decodes; -bool new_state; +bool state;if (!vga_arbiter_used)return ; + state = (vga_count >1 ) ? false : true; +spin_lock_irqsave (&vga_lock, flags);list_for_each_entry (vgadev, &vga_list, list) { -if (vga_count >1 ) - new_state = false; -else - new_state = true;if (vgadev->set_decode) { - new_decodes = vgadev->set_decode (vgadev->pdev, - new_state); -vga_update_device_decodes (vgadev, new_decodes); +unsigned int decodes; + + decodes = vgadev->set_decode (vgadev->pdev, state); +vga_update_device_decodes (vgadev, decodes); } }spin_unlock_irqrestore (&vga_lock, flags);
Signature · 1 line
2.25.1