build: remove redundant SOURCES assignments
PATCH 1/1 build: remove redundant SOURCES assignments
From: Bartosz Golaszewski <[email protected]>
For any given target (let's say foobar), automake defaults to looking for foobar.c if foobar_SOURCES are not specified. Remove redundant assignments as we've seen multiple hidden typos in makefiles already.
Signed-off-by Bartosz Golaszewski <[email protected]>
--- examples/Makefile.am | 26 -------------------------- tests/gpiosim/Makefile.am | 1 - tools/Makefile.am | 12 ------------ 3 files changed, 39 deletions(-)
examples/Makefile.am +0 -26
@@ -20,29 +20,3 @@ noinst_PROGRAMS = \ watch_line_rising \ watch_line_value \ watch_multiple_line_values - -async_watch_line_value_SOURCES = async_watch_line_value.c - -find_line_by_name_SOURCES = find_line_by_name.c - -get_chip_info_SOURCES = get_chip_info.c - -get_line_info_SOURCES = get_line_info.c - -get_line_value_SOURCES = get_line_value.c - -get_multiple_line_values_SOURCES = get_multiple_line_values.c - -reconfigure_input_to_output_SOURCES = reconfigure_input_to_output.c - -toggle_line_value_SOURCES = toggle_line_value.c - -toggle_multiple_line_value_SOURCES = toggle_multiple_line_value.c - -watch_line_info_SOURCES = watch_line_info.c - -watch_line_rising_SOURCES = watch_line_rising.c - -watch_line_value_SOURCES = watch_line_value.c - -watch_multiple_line_values_SOURCES = watch_multiple_line_values.c
tests/gpiosim/Makefile.am +0 -1
@@ -12,5 +12,4 @@ libgpiosim_la_CFLAGS = $(AM_CFLAGS) $(KMOD_CFLAGS) $(MOUNT_CFLAGS) libgpiosim_la_LDFLAGS = -version-info $(subst .,:,$(ABI_GPIOSIM_VERSION)) libgpiosim_la_LDFLAGS += $(KMOD_LIBS) $(MOUNT_LIBS) -pthread -gpiosim_selftest_SOURCES = gpiosim-selftest.c gpiosim_selftest_LDADD = libgpiosim.la
tools/Makefile.am +0 -12
@@ -18,18 +18,6 @@ endif bin_PROGRAMS = gpiodetect gpioinfo gpioget gpioset gpiomon gpionotify -gpiodetect_SOURCES = gpiodetect.c - -gpioinfo_SOURCES = gpioinfo.c - -gpioget_SOURCES = gpioget.c - -gpioset_SOURCES = gpioset.c - -gpiomon_SOURCES = gpiomon.c - -gpionotify_SOURCES = gpionotify.c - if WITH_TESTS noinst_SCRIPTS = gpio-tools-test.bash
Signature · 1 line
2.39.2
Quoted 9 lines · Bartosz Golaszewski
From: Bartosz Golaszewski <[email protected]>
For any given target (let's say foobar), automake defaults to looking for
foobar.ciffoobar_SOURCESare not specified. Remove redundant assignments as we've seen multiple hidden typos in makefiles already.Signed-off-by Bartosz Golaszewski <[email protected]>---
Sorry for the noise, sent it without the libgpiod tag.
Bart