Skip to contentSkip to conversation

drm/nouveau/disp/g94: enable HDMI

PATCH In review Karol Herbst 3 participants 4 messages Jun 30, 2023 – Jul 8, 2023

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/nouveau/disp/g94: enable HDMI

Cc Ben Skeggs <[email protected]>
Cc Lyude Paul <[email protected]>
Fixes f530bc60a30b ("drm/nouveau/disp: move HDMI config into acquire + infoframe methods")
---
 drivers/gpu/drm/nouveau/nvkm/engine/disp/g94.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/nouveau/nvkm/engine/disp/g94.c +1 -0
index a4853c4e5ee3..67ef889a0c5f 100644
@@ -295,6 +295,7 @@ g94_sor = {
 	.clock = nv50_sor_clock,
 	.war_2 = g94_sor_war_2,
 	.war_3 = g94_sor_war_3,
+	.hdmi = &g84_sor_hdmi,
 	.dp = &g94_sor_dp,
 };
 
Signature · 1 line
2.41.0
maintainer Reviewed-by on v1 1/1
#1 lore raw

But seeing as I looked at this + some other patches yesterday I assume there's still more to this?

Quoted 20 lines · Karol Herbst
Cc Ben Skeggs <[email protected]>
Cc Lyude Paul <[email protected]>
Fixes f530bc60a30b ("drm/nouveau/disp: move HDMI config into acquire + infoframe methods")
---
 drivers/gpu/drm/nouveau/nvkm/engine/disp/g94.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/nouveau/nvkm/engine/disp/g94.c +1 -0
index a4853c4e5ee3..67ef889a0c5f 100644
@@ -295,6 +295,7 @@ g94_sor = {
 	.clock = nv50_sor_clock,
 	.war_2 = g94_sor_war_2,
 	.war_3 = g94_sor_war_3,
+	.hdmi = &g84_sor_hdmi,
 	.dp = &g94_sor_dp,
 };
 
Signature · 3 lines
Cheers,
 Lyude Paul (she/her)
 Software Engineer at Red Hat
#2 lore raw
Quoted 6 lines · Lyude Paul

But seeing as I looked at this + some other patches yesterday I assume there's still more to this?

not really. All those patches are all independent and just a bunch of fixes. I just figured this one out a bit later.

Quoted 27 lines · Karol Herbst
Quoted 13 lines
Cc Ben Skeggs <[email protected]>
Cc Lyude Paul <[email protected]>
Fixes f530bc60a30b ("drm/nouveau/disp: move HDMI config into acquire + infoframe methods")
---
 drivers/gpu/drm/nouveau/nvkm/engine/disp/g94.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/nouveau/nvkm/engine/disp/g94.c +0 -0
index a4853c4e5ee3..67ef889a0c5f 100644

drivers/gpu/drm/nouveau/nvkm/engine/disp/g94.c g94_sor = { · line 301

Quoted 7 lines
drivers/gpu/drm/nouveau/nvkm/engine/disp/g94.c +1 -0
@@ -295,6 +295,7 @@ g94_sor = {
      .clock = nv50_sor_clock,
      .war_2 = g94_sor_war_2,
      .war_3 = g94_sor_war_3,
+     .hdmi = &g84_sor_hdmi,
      .dp = &g94_sor_dp,
 };
 

--
Cheers,
Lyude Paul (she/her)
Software Engineer at Red Hat