net/idpf: refine dev_link_update function
PATCH 1/1 net/idpf: refine dev_link_update function
This patch refines idpf_dev_link_update callback function according to CPFL PMD basic code.
--- drivers/net/idpf/idpf_ethdev.c | 63 ++++++++++++++++------------------ 1 file changed, 30 insertions(+), 33 deletions(-)
drivers/net/idpf/idpf_ethdev.c +30 -33
@@ -30,6 +30,23 @@ static const char * const idpf_valid_args[] = {NULL }; +uint32_t idpf_supported_speeds[] = { +RTE_ETH_SPEED_NUM_NONE , +RTE_ETH_SPEED_NUM_10M , +RTE_ETH_SPEED_NUM_100M , +RTE_ETH_SPEED_NUM_1G , +RTE_ETH_SPEED_NUM_2_5G , +RTE_ETH_SPEED_NUM_5G , +RTE_ETH_SPEED_NUM_10G , +RTE_ETH_SPEED_NUM_20G , +RTE_ETH_SPEED_NUM_25G , +RTE_ETH_SPEED_NUM_40G , +RTE_ETH_SPEED_NUM_50G , +RTE_ETH_SPEED_NUM_56G , +RTE_ETH_SPEED_NUM_100G , +RTE_ETH_SPEED_NUM_200G +}; +static const uint64_t idpf_map_hena_rss[] = { [IDPF_HASH_NONF_UNICAST_IPV4_UDP ] =RTE_ETH_RSS_NONFRAG_IPV4_UDP ,
@@ -110,42 +127,22 @@ idpf_dev_link_update(struct rte_eth_dev *dev, {struct idpf_vport *vport = dev->data->dev_private;struct rte_eth_link new_link; +unsigned int i;memset (&new_link,0 ,sizeof (new_link)); -switch (vport->link_speed) { -case RTE_ETH_SPEED_NUM_10M : - new_link.link_speed =RTE_ETH_SPEED_NUM_10M ; -break ; -case RTE_ETH_SPEED_NUM_100M : - new_link.link_speed =RTE_ETH_SPEED_NUM_100M ; -break ; -case RTE_ETH_SPEED_NUM_1G : - new_link.link_speed =RTE_ETH_SPEED_NUM_1G ; -break ; -case RTE_ETH_SPEED_NUM_10G : - new_link.link_speed =RTE_ETH_SPEED_NUM_10G ; -break ; -case RTE_ETH_SPEED_NUM_20G : - new_link.link_speed =RTE_ETH_SPEED_NUM_20G ; -break ; -case RTE_ETH_SPEED_NUM_25G : - new_link.link_speed =RTE_ETH_SPEED_NUM_25G ; -break ; -case RTE_ETH_SPEED_NUM_40G : - new_link.link_speed =RTE_ETH_SPEED_NUM_40G ; -break ; -case RTE_ETH_SPEED_NUM_50G : - new_link.link_speed =RTE_ETH_SPEED_NUM_50G ; -break ; -case RTE_ETH_SPEED_NUM_100G : - new_link.link_speed =RTE_ETH_SPEED_NUM_100G ; -break ; -case RTE_ETH_SPEED_NUM_200G : - new_link.link_speed =RTE_ETH_SPEED_NUM_200G ; -break ; -default : - new_link.link_speed =RTE_ETH_SPEED_NUM_NONE ; +for (i =0 ; i <RTE_DIM (idpf_supported_speeds); i++) { +if (vport->link_speed == idpf_supported_speeds[i]) { + new_link.link_speed = vport->link_speed; +break ; + } + } + +if (i ==RTE_DIM (idpf_supported_speeds)) { +if (vport->link_up) + new_link.link_speed =RTE_ETH_SPEED_NUM_UNKNOWN ; +else + new_link.link_speed =RTE_ETH_SPEED_NUM_NONE ; } new_link.link_duplex =RTE_ETH_LINK_FULL_DUPLEX ;
Signature · 1 line
2.34.1
Quoted 90 lines
-----Original Message-----
From: Mingxia Liu <[email protected]>
Sent: Monday, June 26, 2023 7:15 PM
To: [email protected]
Cc: Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>; Liu, Mingxia <[email protected]>
Subject: [PATCH] net/idpf: refinedev_link_updatefunctionThis patch refines
idpf_dev_link_updatecallback function according to CPFL PMD basic code.Signed-off-by Mingxia Liu <[email protected]>--- drivers/net/idpf/idpf_ethdev.c | 63 ++++++++++++++++------------------ 1 file changed, 30 insertions(+), 33 deletions(-)drivers/net/idpf/idpf_ethdev.c +22
-33@@ -30,6 +30,23 @@ static const char * const idpf_valid_args[] = {NULL }; +uint32_t idpf_supported_speeds[] = { +RTE_ETH_SPEED_NUM_NONE , +RTE_ETH_SPEED_NUM_10M , +RTE_ETH_SPEED_NUM_100M , +RTE_ETH_SPEED_NUM_1G , +RTE_ETH_SPEED_NUM_2_5G , +RTE_ETH_SPEED_NUM_5G , +RTE_ETH_SPEED_NUM_10G , +RTE_ETH_SPEED_NUM_20G , +RTE_ETH_SPEED_NUM_25G , +RTE_ETH_SPEED_NUM_40G , +RTE_ETH_SPEED_NUM_50G , +RTE_ETH_SPEED_NUM_56G , +RTE_ETH_SPEED_NUM_100G , +RTE_ETH_SPEED_NUM_200G +}; +static const uint64_t idpf_map_hena_rss[] = { [IDPF_HASH_NONF_UNICAST_IPV4_UDP ] =RTE_ETH_RSS_NONFRAG_IPV4_UDP ,@@ -110,42 +127,22 @@ idpf_dev_link_update(struct rte_eth_dev *dev, {struct idpf_vport *vport = dev->data->dev_private;struct rte_eth_link new_link; +unsigned int i;memset (&new_link,0 ,sizeof (new_link)); -switch (vport->link_speed) { -case RTE_ETH_SPEED_NUM_10M : - new_link.link_speed =RTE_ETH_SPEED_NUM_10M ; -break ; -case RTE_ETH_SPEED_NUM_100M : - new_link.link_speed =RTE_ETH_SPEED_NUM_100M ; -break ; -case RTE_ETH_SPEED_NUM_1G : - new_link.link_speed =RTE_ETH_SPEED_NUM_1G ; -break ; -case RTE_ETH_SPEED_NUM_10G : - new_link.link_speed =RTE_ETH_SPEED_NUM_10G ; -break ; -case RTE_ETH_SPEED_NUM_20G : - new_link.link_speed =RTE_ETH_SPEED_NUM_20G ; -break ; -case RTE_ETH_SPEED_NUM_25G : - new_link.link_speed =RTE_ETH_SPEED_NUM_25G ; -break ; -case RTE_ETH_SPEED_NUM_40G : - new_link.link_speed =RTE_ETH_SPEED_NUM_40G ; -break ; -case RTE_ETH_SPEED_NUM_50G : - new_link.link_speed =RTE_ETH_SPEED_NUM_50G ; -break ; -case RTE_ETH_SPEED_NUM_100G : - new_link.link_speed =RTE_ETH_SPEED_NUM_100G ; -break ; -case RTE_ETH_SPEED_NUM_200G : - new_link.link_speed =RTE_ETH_SPEED_NUM_200G ; -break ; -default : - new_link.link_speed =RTE_ETH_SPEED_NUM_NONE ; +for (i =0 ; i <RTE_DIM (idpf_supported_speeds); i++) { +if (vport->link_speed == idpf_supported_speeds[i]) { + new_link.link_speed = vport->link_speed; +break ;
drivers/net/idpf/idpf_ethdev.c idpf_dev_link_update(struct rte_eth_dev *dev, { · line 146
Quoted 10 lines
drivers/net/idpf/idpf_ethdev.c +8
-0+ } + } + +if (i ==RTE_DIM (idpf_supported_speeds)) { +if (vport->link_up) + new_link.link_speed =RTE_ETH_SPEED_NUM_UNKNOWN ; +else + new_link.link_speed =RTE_ETH_SPEED_NUM_NONE ; }
What about
/* initialize with default value */
new_link.link_speed = vport->link_up ? RTE_ETH_SPEED_NUM_UNKNOWN : RTE_ETH_SPEED_NUM_NONE
/ * update in case a match */
for (i = 0; i < RTE_DIM(idpf_supported_speeds); i++) {
....
}Quoted 4 lines
drivers/net/idpf/idpf_ethdev.c +0
-1new_link.link_duplex =RTE_ETH_LINK_FULL_DUPLEX ; --2.34.1
Quoted 114 lines
-----Original Message-----
From: Zhang, Qi Z <[email protected]>
Sent: Friday, June 30, 2023 4:27 PM
To: Liu, Mingxia <[email protected]>; [email protected]
Cc: Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>; Liu, Mingxia <[email protected]>
Subject: RE: [PATCH] net/idpf: refinedev_link_updatefunctionQuoted 89 lines
-----Original Message-----
From: Mingxia Liu <[email protected]>
Sent: Monday, June 26, 2023 7:15 PM
To: [email protected]
Cc: Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>; Liu, Mingxia <[email protected]>
Subject: [PATCH] net/idpf: refinedev_link_updatefunctionThis patch refines
idpf_dev_link_updatecallback function according to CPFL PMD basic code.Signed-off-by Mingxia Liu <[email protected]>--- drivers/net/idpf/idpf_ethdev.c | 63 ++++++++++++++++------------------ 1 file changed, 30 insertions(+), 33 deletions(-)(quoted diff) +0
-0
b/drivers/net/idpf/idpf_ethdev.cindexfb59655555..bfdac92b95100644drivers/net/idpf/idpf_ethdev.c +22
-33@@ -30,6 +30,23 @@ static const char * const idpf_valid_args[] = {NULL }; +uint32_t idpf_supported_speeds[] = { +RTE_ETH_SPEED_NUM_NONE , +RTE_ETH_SPEED_NUM_10M , +RTE_ETH_SPEED_NUM_100M , +RTE_ETH_SPEED_NUM_1G , +RTE_ETH_SPEED_NUM_2_5G , +RTE_ETH_SPEED_NUM_5G , +RTE_ETH_SPEED_NUM_10G , +RTE_ETH_SPEED_NUM_20G , +RTE_ETH_SPEED_NUM_25G , +RTE_ETH_SPEED_NUM_40G , +RTE_ETH_SPEED_NUM_50G , +RTE_ETH_SPEED_NUM_56G , +RTE_ETH_SPEED_NUM_100G , +RTE_ETH_SPEED_NUM_200G +}; +static const uint64_t idpf_map_hena_rss[] = { [IDPF_HASH_NONF_UNICAST_IPV4_UDP ] =RTE_ETH_RSS_NONFRAG_IPV4_UDP ,@@ -110,42 +127,22 @@ idpf_dev_link_update(struct rte_eth_dev *dev, {struct idpf_vport *vport = dev->data->dev_private;struct rte_eth_link new_link; +unsigned int i;memset (&new_link,0 ,sizeof (new_link)); -switch (vport->link_speed) { -case RTE_ETH_SPEED_NUM_10M : - new_link.link_speed =RTE_ETH_SPEED_NUM_10M ; -break ; -case RTE_ETH_SPEED_NUM_100M : - new_link.link_speed =RTE_ETH_SPEED_NUM_100M ; -break ; -case RTE_ETH_SPEED_NUM_1G : - new_link.link_speed =RTE_ETH_SPEED_NUM_1G ; -break ; -case RTE_ETH_SPEED_NUM_10G : - new_link.link_speed =RTE_ETH_SPEED_NUM_10G ; -break ; -case RTE_ETH_SPEED_NUM_20G : - new_link.link_speed =RTE_ETH_SPEED_NUM_20G ; -break ; -case RTE_ETH_SPEED_NUM_25G : - new_link.link_speed =RTE_ETH_SPEED_NUM_25G ; -break ; -case RTE_ETH_SPEED_NUM_40G : - new_link.link_speed =RTE_ETH_SPEED_NUM_40G ; -break ; -case RTE_ETH_SPEED_NUM_50G : - new_link.link_speed =RTE_ETH_SPEED_NUM_50G ; -break ; -case RTE_ETH_SPEED_NUM_100G : - new_link.link_speed =RTE_ETH_SPEED_NUM_100G ; -break ; -case RTE_ETH_SPEED_NUM_200G : - new_link.link_speed =RTE_ETH_SPEED_NUM_200G ; -break ; -default : - new_link.link_speed =RTE_ETH_SPEED_NUM_NONE ; +for (i =0 ; i <RTE_DIM (idpf_supported_speeds); i++) { +if (vport->link_speed == idpf_supported_speeds[i]) { + new_link.link_speed = vport->link_speed; +break ;drivers/net/idpf/idpf_ethdev.c idpf_dev_link_update(struct rte_eth_dev *dev, { · line 146
Quoted 10 lines
drivers/net/idpf/idpf_ethdev.c +8
-0+ } + } + +if (i ==RTE_DIM (idpf_supported_speeds)) { +if (vport->link_up) + new_link.link_speed =RTE_ETH_SPEED_NUM_UNKNOWN ; +else + new_link.link_speed =RTE_ETH_SPEED_NUM_NONE ; }What about
Quoted 9 lines
/* initialize with default value */
new_link.link_speed =vport->link_up?RTE_ETH_SPEED_NUM_UNKNOWN:RTE_ETH_SPEED_NUM_NONE/ * update in case a match */
for (i = 0; i < RTE_DIM(idpf_supported_speeds); i++) { .... }
[Liu, Mingxia] Good idea, new patch has been sent.
Quoted 4 lines
Quoted 4 lines
drivers/net/idpf/idpf_ethdev.c +0
-1new_link.link_duplex =RTE_ETH_LINK_FULL_DUPLEX ; --2.34.1
PATCH v2 1/1 net/idpf: refine dev_link_update function
In reply to Mingxia LiuThis patch refines idpf_dev_link_update callback function according to CPFL PMD basic code.
--- drivers/net/idpf/idpf_ethdev.c | 63 +++++++++++++++------------------- 1 file changed, 28 insertions(+), 35 deletions(-)
drivers/net/idpf/idpf_ethdev.c +28 -35
@@ -30,6 +30,23 @@ static const char * const idpf_valid_args[] = {NULL }; +uint32_t idpf_supported_speeds[] = { +RTE_ETH_SPEED_NUM_NONE , +RTE_ETH_SPEED_NUM_10M , +RTE_ETH_SPEED_NUM_100M , +RTE_ETH_SPEED_NUM_1G , +RTE_ETH_SPEED_NUM_2_5G , +RTE_ETH_SPEED_NUM_5G , +RTE_ETH_SPEED_NUM_10G , +RTE_ETH_SPEED_NUM_20G , +RTE_ETH_SPEED_NUM_25G , +RTE_ETH_SPEED_NUM_40G , +RTE_ETH_SPEED_NUM_50G , +RTE_ETH_SPEED_NUM_56G , +RTE_ETH_SPEED_NUM_100G , +RTE_ETH_SPEED_NUM_200G +}; +static const uint64_t idpf_map_hena_rss[] = { [IDPF_HASH_NONF_UNICAST_IPV4_UDP ] =RTE_ETH_RSS_NONFRAG_IPV4_UDP ,
@@ -110,47 +127,23 @@ idpf_dev_link_update(struct rte_eth_dev *dev, {struct idpf_vport *vport = dev->data->dev_private;struct rte_eth_link new_link; +unsigned int i;memset (&new_link,0 ,sizeof (new_link)); -switch (vport->link_speed) { -case RTE_ETH_SPEED_NUM_10M : - new_link.link_speed =RTE_ETH_SPEED_NUM_10M ; -break ; -case RTE_ETH_SPEED_NUM_100M : - new_link.link_speed =RTE_ETH_SPEED_NUM_100M ; -break ; -case RTE_ETH_SPEED_NUM_1G : - new_link.link_speed =RTE_ETH_SPEED_NUM_1G ; -break ; -case RTE_ETH_SPEED_NUM_10G : - new_link.link_speed =RTE_ETH_SPEED_NUM_10G ; -break ; -case RTE_ETH_SPEED_NUM_20G : - new_link.link_speed =RTE_ETH_SPEED_NUM_20G ; -break ; -case RTE_ETH_SPEED_NUM_25G : - new_link.link_speed =RTE_ETH_SPEED_NUM_25G ; -break ; -case RTE_ETH_SPEED_NUM_40G : - new_link.link_speed =RTE_ETH_SPEED_NUM_40G ; -break ; -case RTE_ETH_SPEED_NUM_50G : - new_link.link_speed =RTE_ETH_SPEED_NUM_50G ; -break ; -case RTE_ETH_SPEED_NUM_100G : - new_link.link_speed =RTE_ETH_SPEED_NUM_100G ; -break ; -case RTE_ETH_SPEED_NUM_200G : - new_link.link_speed =RTE_ETH_SPEED_NUM_200G ; -break ; -default : - new_link.link_speed =RTE_ETH_SPEED_NUM_NONE ; +/* initialize with default value */ + new_link.link_speed = vport->link_up ?RTE_ETH_SPEED_NUM_UNKNOWN :RTE_ETH_SPEED_NUM_NONE ; + +/* update in case a match */ +for (i =0 ; i <RTE_DIM (idpf_supported_speeds); i++) { +if (vport->link_speed == idpf_supported_speeds[i]) { + new_link.link_speed = vport->link_speed; +break ; + } } new_link.link_duplex =RTE_ETH_LINK_FULL_DUPLEX ; - new_link.link_status = vport->link_up ?RTE_ETH_LINK_UP : -RTE_ETH_LINK_DOWN ; + new_link.link_status = vport->link_up ?RTE_ETH_LINK_UP :RTE_ETH_LINK_DOWN ; new_link.link_autoneg = (dev->data->dev_conf.link_speeds &RTE_ETH_LINK_SPEED_FIXED ) ?RTE_ETH_LINK_FIXED :RTE_ETH_LINK_AUTONEG ;
Signature · 1 line
2.34.1
Quoted 9 lines
-----Original Message-----
From: Mingxia Liu <[email protected]>
Sent: Saturday, July 1, 2023 2:56 AM
To: [email protected]
Cc: Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>; Liu, Mingxia <[email protected]>
Subject: [PATCH v2] net/idpf: refinedev_link_updatefunction
net/idpf: refine dev link update
Quoted 3 lines
This patch refines
idpf_dev_link_updatecallback function according to CPFL PMD basic code.
The patch is for idpf PMD, not the common/idpf part, why ref CPFL PMD here?
Quoted 20 lines
-----Original Message-----
From: Zhang, Qi Z <[email protected]>
Sent: Monday, July 3, 2023 10:22 AM
To: Liu, Mingxia <[email protected]>; [email protected]
Cc: Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>; Liu, Mingxia <[email protected]>
Subject: RE: [PATCH v2] net/idpf: refinedev_link_updatefunctionQuoted 7 lines
-----Original Message-----
From: Mingxia Liu <[email protected]>
Sent: Saturday, July 1, 2023 2:56 AM
To: [email protected]
Cc: Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>; Liu, Mingxia <[email protected]>
Subject: [PATCH v2] net/idpf: refinedev_link_updatefunction
Quoted 8 lines
net/idpf: refine dev link update
Quoted 3 lines
This patch refines
idpf_dev_link_updatecallback function according to CPFL PMD basic code.The patch is for idpf PMD, not the common/idpf part, why ref CPFL PMD here?
[Liu, Mingxia] Because this change referred to cpfl basic code, maybe it's better to delete it. New patch has been sent.
PATCH v3 1/1 net/idpf: refine dev_link_update function
In reply to Mingxia LiuThis patch refines dev_link_update() of IDPF PMD, optimizing the code style.
--- drivers/net/idpf/idpf_ethdev.c | 63 +++++++++++++++------------------- 1 file changed, 28 insertions(+), 35 deletions(-)
drivers/net/idpf/idpf_ethdev.c +28 -35
@@ -30,6 +30,23 @@ static const char * const idpf_valid_args[] = {NULL }; +uint32_t idpf_supported_speeds[] = { +RTE_ETH_SPEED_NUM_NONE , +RTE_ETH_SPEED_NUM_10M , +RTE_ETH_SPEED_NUM_100M , +RTE_ETH_SPEED_NUM_1G , +RTE_ETH_SPEED_NUM_2_5G , +RTE_ETH_SPEED_NUM_5G , +RTE_ETH_SPEED_NUM_10G , +RTE_ETH_SPEED_NUM_20G , +RTE_ETH_SPEED_NUM_25G , +RTE_ETH_SPEED_NUM_40G , +RTE_ETH_SPEED_NUM_50G , +RTE_ETH_SPEED_NUM_56G , +RTE_ETH_SPEED_NUM_100G , +RTE_ETH_SPEED_NUM_200G +}; +static const uint64_t idpf_map_hena_rss[] = { [IDPF_HASH_NONF_UNICAST_IPV4_UDP ] =RTE_ETH_RSS_NONFRAG_IPV4_UDP ,
@@ -110,47 +127,23 @@ idpf_dev_link_update(struct rte_eth_dev *dev, {struct idpf_vport *vport = dev->data->dev_private;struct rte_eth_link new_link; +unsigned int i;memset (&new_link,0 ,sizeof (new_link)); -switch (vport->link_speed) { -case RTE_ETH_SPEED_NUM_10M : - new_link.link_speed =RTE_ETH_SPEED_NUM_10M ; -break ; -case RTE_ETH_SPEED_NUM_100M : - new_link.link_speed =RTE_ETH_SPEED_NUM_100M ; -break ; -case RTE_ETH_SPEED_NUM_1G : - new_link.link_speed =RTE_ETH_SPEED_NUM_1G ; -break ; -case RTE_ETH_SPEED_NUM_10G : - new_link.link_speed =RTE_ETH_SPEED_NUM_10G ; -break ; -case RTE_ETH_SPEED_NUM_20G : - new_link.link_speed =RTE_ETH_SPEED_NUM_20G ; -break ; -case RTE_ETH_SPEED_NUM_25G : - new_link.link_speed =RTE_ETH_SPEED_NUM_25G ; -break ; -case RTE_ETH_SPEED_NUM_40G : - new_link.link_speed =RTE_ETH_SPEED_NUM_40G ; -break ; -case RTE_ETH_SPEED_NUM_50G : - new_link.link_speed =RTE_ETH_SPEED_NUM_50G ; -break ; -case RTE_ETH_SPEED_NUM_100G : - new_link.link_speed =RTE_ETH_SPEED_NUM_100G ; -break ; -case RTE_ETH_SPEED_NUM_200G : - new_link.link_speed =RTE_ETH_SPEED_NUM_200G ; -break ; -default : - new_link.link_speed =RTE_ETH_SPEED_NUM_NONE ; +/* initialize with default value */ + new_link.link_speed = vport->link_up ?RTE_ETH_SPEED_NUM_UNKNOWN :RTE_ETH_SPEED_NUM_NONE ; + +/* update in case a match */ +for (i =0 ; i <RTE_DIM (idpf_supported_speeds); i++) { +if (vport->link_speed == idpf_supported_speeds[i]) { + new_link.link_speed = vport->link_speed; +break ; + } } new_link.link_duplex =RTE_ETH_LINK_FULL_DUPLEX ; - new_link.link_status = vport->link_up ?RTE_ETH_LINK_UP : -RTE_ETH_LINK_DOWN ; + new_link.link_status = vport->link_up ?RTE_ETH_LINK_UP :RTE_ETH_LINK_DOWN ; new_link.link_autoneg = (dev->data->dev_conf.link_speeds &RTE_ETH_LINK_SPEED_FIXED ) ?RTE_ETH_LINK_FIXED :RTE_ETH_LINK_AUTONEG ;
Signature · 1 line
2.34.1
Quoted 10 lines
-----Original Message-----
From: Mingxia Liu <[email protected]>
Sent: Monday, July 3, 2023 7:22 PM
To: [email protected]
Cc: Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>; Liu, Mingxia <[email protected]>
Subject: [PATCH v3] net/idpf: refinedev_link_updatefunction
Quoted 3 lines
This patch refines
dev_link_update()of IDPF PMD, optimizing the code style.Signed-off-by Mingxia Liu <[email protected]>
Applied to dpdk-next-net-intel.
Thanks
Qi