Skip to contentSkip to conversation

kdb: move kdb_send_sig() declaration to a better header file

PATCH In review Daniel Thompson 2 participants 2 messages Jun 30, 2023 KGDB / KDB /debug_core

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kdb: move kdb_send_sig() declaration to a better header file

kdb_send_sig() is defined in the signal code and called from kdb, but the declaration is part of the kdb internal code. Move the declaration to the shared header to avoid the warning:

kernel/signal.c:4789:6: error: no previous prototype for 'kdb_send_sig' [-Werror=missing-prototypes]

---
 include/linux/kdb.h            | 2 ++
 kernel/debug/kdb/kdb_private.h | 1 -
 2 files changed, 2 insertions(+), 1 deletion(-)
include/linux/kdb.h +2 -0
index 07dfb6a20a1c4..f6c2ddb16b958 100644
@@ -196,6 +196,8 @@ int kdb_process_cpu(const struct task_struct *p)
 	return cpu;
 }
 
+extern void kdb_send_sig(struct task_struct *p, int sig);
+
 #ifdef CONFIG_KALLSYMS
 extern const char *kdb_walk_kallsyms(loff_t *pos);
 #else /* ! CONFIG_KALLSYMS */
kernel/debug/kdb/kdb_private.h +0 -1
index 1f8c519a5f81c..548fd4059bf9b 100644
@@ -194,7 +194,6 @@ extern char kdb_task_state_char (const struct task_struct *);
 extern bool kdb_task_state(const struct task_struct *p, const char *mask);
 extern void kdb_ps_suppressed(void);
 extern void kdb_ps1(const struct task_struct *p);
-extern void kdb_send_sig(struct task_struct *p, int sig);
 extern char kdb_getchar(void);
 extern char *kdb_getstr(char *, size_t, const char *);
 extern void kdb_gdb_state_pass(char *buf);

base-commit: 858fd168a95c5b9669aac8db6c14a9aeab446375 --
2.39.2

reviewer Reviewed-by on v1 1/1
#1 lore raw

Hi,

Quoted 8 lines · Daniel Thompson

kdb_send_sig() is defined in the signal code and called from kdb, but the declaration is part of the kdb internal code. Move the declaration to the shared header to avoid the warning:

kernel/signal.c:4789:6: error: no previous prototype for 'kdb_send_sig' [-Werror=missing-prototypes]

FWIW: these days, I think checkpatch yells at you for a bare "Reported-by" like above. It ideally wants a "Closes" tag to follow immediately with a link to the report, or in the very least a "Link" tag if this doesn't fully address the issue.

Quoted 1 line