Skip to contentSkip to conversation

Add Silicom Platform Driver

PATCH Henry Shi 2 participants 2 messages Jun 30, 2023 – Jul 12, 2023

Subsystems (3)
lore
Share & tools
lore

Henry Shi

author
#0 lore raw

Please review this patch.

The Silicom platform (silicom-platform) Linux driver for Swisscom Business Box (Swisscom BB) as well as Cordoba family products is a software solution designed to facilitate the efficient management and control of devices through the integration of various Linux frameworks. This platform driver provides seamless support for device management via the Linux LED framework, GPIO framework, Hardware Monitoring (HWMON), and device attributes. The Silicom platform driver's compatibility with these Linux frameworks allows applications to access and control Cordoba family devices using existing software that is compatible with these frameworks. This compatibility simplifies the development process, reduces dependencies on proprietary solutions, and promotes interoperability with other Linux-based systems and software.

Thanks!

Henry Shi
Silicom Ltd.
[email protected]
[email protected]

From 56b4b37297ee16a289f41a3f4e7480b7a330eaea Mon Sep 17 00:00:00 2001
From: Henry Shi <[email protected]>
Date: Fri, 30 Jun 2023 11:17:36 -0400
Subject: [PATCH] Add Silicom Platform Driver

The Silicom platform (silicom-platform) Linux driver for Swisscom Business Box (Swisscom BB) as well as Cordoba family products is a software solution designed to facilitate the efficient management and control of devices through the integration of various Linux frameworks. This platform driver provides seamless support for device management via the Linux LED framework, GPIO framework, Hardware Monitoring (HWMON), and device attributes. The Silicom platform driver's compatibility with these Linux frameworks allows applications to access and control Cordoba family devices using existing software that is compatible with these frameworks. This compatibility simplifies the development process, reduces dependencies on proprietary solutions, and promotes interoperability with other Linux-based systems and software.

---
 arch/x86/Kconfig                        |   11 +
 drivers/platform/x86/Makefile           |    1 +
 drivers/platform/x86/silicom-platform.c | 1123 +++++++++++++++++++++++
 3 files changed, 1135 insertions(+)
 create mode 100644 drivers/platform/x86/silicom-platform.c
arch/x86/Kconfig +11 -0
index 53bab123a8ee..d94ea33b365e 100644
@@ -2373,6 +2373,17 @@ config COMPAT_VDSO
 	  If unsure, say N: if you are compiling your own kernel, you
 	  are unlikely to be using a buggy version of glibc.
 
+config SILICOM_PLATFORM
+	tristate "Silicom Edge Networking device support"
+	depends on DMI
+	select LEDS_CLASS_MULTICOLOR
+	select GPIOLIB
+	help
+	  This option enables support for the LEDs/GPIO/etc downstream of the
+	  embedded controller on Silicom "Cordoba" hardware and derivatives.
+
+	  If you have a Silicom network appliance, say Y or M here.
+
 choice
 	prompt "vsyscall table for legacy applications"
 	depends on X86_64
drivers/platform/x86/Makefile +1 -0
index 2cafe51ec4d8..f2f5743a9e54 100644
@@ -113,6 +113,7 @@ obj-$(CONFIG_SERIAL_MULTI_INSTANTIATE)	+= serial-multi-instantiate.o
 obj-$(CONFIG_MLX_PLATFORM)		+= mlx-platform.o
 obj-$(CONFIG_TOUCHSCREEN_DMI)		+= touchscreen_dmi.o
 obj-$(CONFIG_WIRELESS_HOTKEY)		+= wireless-hotkey.o
+obj-$(CONFIG_SILICOM_PLATFORM)          += silicom-platform.o
 obj-$(CONFIG_X86_ANDROID_TABLETS)	+= x86-android-tablets/
 
 # Intel uncore drivers
drivers/platform/x86/silicom-platform.c new file +1123 -0

1,123 lines not on this page · raw message

Signature · 1 line
2.21.3
#1 lore raw

Hi Henri,

Quoted 16 lines · Henry Shi

Please review this patch.

The Silicom platform (silicom-platform) Linux driver for Swisscom Business Box (Swisscom BB) as well as Cordoba family products is a software solution designed to facilitate the efficient management and control of devices through the integration of various Linux frameworks. This platform driver provides seamless support for device management via the Linux LED framework, GPIO framework, Hardware Monitoring (HWMON), and device attributes. The Silicom platform driver's compatibility with these Linux frameworks allows applications to access and control Cordoba family devices using existing software that is compatible with these frameworks. This compatibility simplifies the development process, reduces dependencies on proprietary solutions, and promotes interoperability with other Linux-based systems and software.

Quoted 6 lines

Thanks!

Henry Shi
Silicom Ltd.
[email protected]
[email protected]

Thank you for the patch.

The Kconfig bits for this should be in drivers/platform/x86/Kconfig please move them there.

Please send a new version with that change with the contents of the patch actually in the body of the email so that we can quoute it while replying for review purposes.

Please use git send-email on the .patch file to submit the next version, e.g. :

git send-email Silicom-Platform-Driver.patch

Do NOT copy and paste the contents of the patch to your email client to send it, this will mangle the patch and make it unusable.

Once we have a submission with the patch content in the body of the email (with git send-email) then I'll try to make time to do a more thorough review.

Regards,

Hans