Allow disabling all native fbdev drivers and only keeping DRM emulation
Subsystems (6)
v2 cover Allow disabling all native fbdev drivers and only keeping DRM emulation
This patch series splits the fbdev core support in two different Kconfig
symbols: FB and FB_CORE. The motivation for this is to allow CONFIG_FB to be disabled, while still having the the core fbdev support needed for the CONFIG_DRM_FBDEV_EMULATION to be enabled. The motivation is automatically disabling all fbdev drivers instead of having to be disabled individually.
The reason for doing this is that now with simpledrm, there's no need for the legacy fbdev (e.g: efifb or vesafb) drivers anymore and many distros now disable them. But it would simplify the config a lot fo have a single Kconfig symbol to disable all fbdev drivers.
I've built tested with possible combinations of CONFIG_FB, CONFIG_FB_CORE, CONFIG_DRM_FBDEV_EMULATION and CONFIG_FB_DEVICE symbols set to 'y' or 'n'.
Patch 1/2 makes the CONFIG_FB split that is mentioned above and patch 2/2 makes the DRM fbdev emulation to select the new FB_CORE symbol instead of depending on FB.
This is a v2 of the patch-set that addresses issues pointed out by Arnd Bergmann and Thomas Zimmermann in the previous version:
https://lists.freedesktop.org/archives/dri-devel/2023-June/411435.html
Changes in v2:
- Keep "depends on FB" for FB_DDC, FB_HECUBA, FB_SVGALIB, FB_MACMODES, FB_BACKLIGHT, FB_MODE_HELPERS and FB_TILEBLITTING (Arnd Bergmann).
- Don't change the fb.o object name (Arnd Bergmann).
- Make FB_CORE a non-visible Kconfig symbol instead (Thomas Zimmermann).
- Make CONFIG_DRM_FBDEV_EMULATION to select FB_CORE (Thomas Zimmermann).
Javier Martinez Canillas (2):
fbdev: Split frame buffer support in FB and FB_CORE symbols
drm: Make fbdev emulation select FB_CORE instead of depends on FB
arch/x86/Makefile | 2 +- arch/x86/video/Makefile | 2 +- drivers/gpu/drm/Kconfig | 2 +- drivers/video/console/Kconfig | 2 +- drivers/video/fbdev/Kconfig | 40 +++++++++++++++++++------------ drivers/video/fbdev/core/Makefile | 2 +- 6 files changed, 30 insertions(+), 20 deletions(-)
base-commit: 270689d257c88fd1ad7050041ed196a8188e6914
Signature · 1 line
2.41.0
PATCH v2 1/2 fbdev: Split frame buffer support in FB and FB_CORE symbols
Currently the CONFIG_FB option has to be enabled even if no legacy fbdev drivers are needed (e.g: only to have support for framebuffer consoles).
The DRM subsystem has a fbdev emulation layer, but depends on CONFIG_FB and so it can only be enabled if that dependency is enabled as well.
That means fbdev drivers have to be explicitly disabled if users want to enable CONFIG_FB, only to use fbcon and/or the DRM fbdev emulation layer.
This patch introduces a non-visible CONFIG_FB_CORE symbol that could be enabled just to have core support needed for CONFIG_DRM_FBDEV_EMULATION, allowing CONFIG_FB to be disabled (and automatically disabling all the fbdev drivers).
---
Changes in v2:
- Keep "depends on FB" for FB_DDC, FB_HECUBA, FB_SVGALIB, FB_MACMODES, FB_BACKLIGHT, FB_MODE_HELPERS and FB_TILEBLITTING (Arnd Bergmann).
- Don't change the fb.o object name (Arnd Bergmann).
- Make FB_CORE a non-visible Kconfig symbol instead (Thomas Zimmermann).
arch/x86/Makefile | 2 +- arch/x86/video/Makefile | 2 +- drivers/video/console/Kconfig | 2 +- drivers/video/fbdev/Kconfig | 40 +++++++++++++++++++------------ drivers/video/fbdev/core/Makefile | 2 +- 5 files changed, 29 insertions(+), 19 deletions(-)
arch/x86/Makefile +1 -1
@@ -259,7 +259,7 @@ drivers-$(CONFIG_PCI) += arch/x86/pci/ # suspend and hibernation support drivers-$(CONFIG_PM) += arch/x86/power/ -drivers-$(CONFIG_FB) += arch/x86/video/ +drivers-$(CONFIG_FB_CORE) += arch/x86/video/ #### # boot loader support. Several targets are kept for legacy purposes
arch/x86/video/Makefile +1 -1
@@ -1,2 +1,2 @@ # SPDX-License-Identifier: GPL-2.0-only -obj-$(CONFIG_FB) += fbdev.o +obj-$(CONFIG_FB_CORE) += fbdev.o
drivers/video/console/Kconfig +1 -1
@@ -72,7 +72,7 @@ config DUMMY_CONSOLE_ROWS config FRAMEBUFFER_CONSOLE bool "Framebuffer Console support" - depends on FB && !UML + depends on FB_CORE && !UML select VT_HW_CONSOLE_BINDING select CRC32 select FONT_SUPPORT
drivers/video/fbdev/Kconfig +25 -15
@@ -6,8 +6,12 @@ config FB_NOTIFY bool +menuconfig FB_CORE + tristate "Core support for frame buffer devices" + menuconfig FB - tristate "Support for frame buffer devices" + tristate "Support for frame buffer device drivers" + select FB_CORE select FB_NOTIFY select VIDEO_CMDLINE help
@@ -33,6 +37,12 @@ menuconfig FB <http://www.munted.org.uk/programming/Framebuffer-HOWTO-1.3.html> for more information. + This enables support for native frame buffer device (fbdev) drivers. + + The DRM subsystem provides support for emulated frame buffer devices + on top of KMS drivers, but this option allows legacy fbdev drivers to + be enabled as well. + Say Y here and to the driver for your graphics board below if you are compiling a kernel for a non-x86 architecture.
@@ -44,7 +54,7 @@ menuconfig FB config FIRMWARE_EDID bool "Enable firmware EDID" - depends on FB + depends on FB_CORE help This enables access to the EDID transferred from the firmware. On the i386, this is from the Video BIOS. Enable this if DDC/I2C
@@ -59,7 +69,7 @@ config FIRMWARE_EDID config FB_DEVICE bool "Provide legacy /dev/fb* device" - depends on FB + select FB_CORE default y help Say Y here if you want the legacy /dev/fb* device file and
@@ -75,7 +85,7 @@ config FB_DDC config FB_CFB_FILLRECT tristate - depends on FB + depends on FB_CORE help Include the cfb_fillrect function for generic software rectangle filling. This is used by drivers that don't provide their own
@@ -83,7 +93,7 @@ config FB_CFB_FILLRECT config FB_CFB_COPYAREA tristate - depends on FB + depends on FB_CORE help Include the cfb_copyarea function for generic software area copying. This is used by drivers that don't provide their own (accelerated)
@@ -91,7 +101,7 @@ config FB_CFB_COPYAREA config FB_CFB_IMAGEBLIT tristate - depends on FB + depends on FB_CORE help Include the cfb_imageblit function for generic software image blitting. This is used by drivers that don't provide their own
@@ -99,7 +109,7 @@ config FB_CFB_IMAGEBLIT config FB_CFB_REV_PIXELS_IN_BYTE bool - depends on FB + depends on FB_CORE help Allow generic frame-buffer functions to work on displays with 1, 2 and 4 bits per pixel depths which has opposite order of pixels in
@@ -107,7 +117,7 @@ config FB_CFB_REV_PIXELS_IN_BYTE config FB_SYS_FILLRECT tristate - depends on FB + depends on FB_CORE help Include the sys_fillrect function for generic software rectangle filling. This is used by drivers that don't provide their own
@@ -115,7 +125,7 @@ config FB_SYS_FILLRECT config FB_SYS_COPYAREA tristate - depends on FB + depends on FB_CORE help Include the sys_copyarea function for generic software area copying. This is used by drivers that don't provide their own (accelerated)
@@ -123,7 +133,7 @@ config FB_SYS_COPYAREA config FB_SYS_IMAGEBLIT tristate - depends on FB + depends on FB_CORE help Include the sys_imageblit function for generic software image blitting. This is used by drivers that don't provide their own
@@ -162,22 +172,22 @@ endchoice config FB_SYS_FOPS tristate - depends on FB + depends on FB_CORE config FB_DEFERRED_IO bool - depends on FB + depends on FB_CORE config FB_IO_HELPERS bool - depends on FB + depends on FB_CORE select FB_CFB_COPYAREA select FB_CFB_FILLRECT select FB_CFB_IMAGEBLIT config FB_SYS_HELPERS bool - depends on FB + depends on FB_CORE select FB_SYS_COPYAREA select FB_SYS_FILLRECT select FB_SYS_FOPS
@@ -185,7 +195,7 @@ config FB_SYS_HELPERS config FB_SYS_HELPERS_DEFERRED bool - depends on FB + depends on FB_CORE select FB_DEFERRED_IO select FB_SYS_HELPERS
drivers/video/fbdev/core/Makefile +1 -1
@@ -1,6 +1,6 @@ # SPDX-License-Identifier: GPL-2.0 obj-$(CONFIG_FB_NOTIFY) += fb_notify.o -obj-$(CONFIG_FB) += fb.o +obj-$(CONFIG_FB_CORE) += fb.o fb-y := fb_backlight.o \ fb_info.o \ fbmem.o fbmon.o fbcmap.o \
Signature · 1 line
2.41.0
Re: [PATCH v2 1/2] fbdev: Split frame buffer support in FB and FB_CORE symbols
Hi,
Does this series apply on top of the previous series or on what?
Quoted 36 lines · Javier Martinez Canillas
Currently the
CONFIG_FBoption has to be enabled even if no legacy fbdev drivers are needed (e.g: only to have support for framebuffer consoles).The DRM subsystem has a fbdev emulation layer, but depends on
CONFIG_FBand so it can only be enabled if that dependency is enabled as well.That means fbdev drivers have to be explicitly disabled if users want to enable
CONFIG_FB, only to use fbcon and/or the DRM fbdev emulation layer.This patch introduces a non-visible
CONFIG_FB_COREsymbol that could be enabled just to have core support needed forCONFIG_DRM_FBDEV_EMULATION, allowingCONFIG_FBto be disabled (and automatically disabling all the fbdev drivers).Signed-off-by Javier Martinez Canillas <[email protected]>---
Changes in v2:
- Keep "depends on FB" forFB_DDC,FB_HECUBA,FB_SVGALIB,FB_MACMODES,FB_BACKLIGHT,FB_MODE_HELPERSandFB_TILEBLITTING(Arnd Bergmann).
- Don't change the fb.o object name (Arnd Bergmann).
- MakeFB_COREa non-visibleKconfigsymbol instead (Thomas Zimmermann).arch/x86/Makefile | 2 +- arch/x86/video/Makefile | 2 +- drivers/video/console/Kconfig | 2 +- drivers/video/fbdev/Kconfig | 40 +++++++++++++++++++------------ drivers/video/fbdev/core/Makefile | 2 +- 5 files changed, 29 insertions(+), 19 deletions(-)drivers/video/fbdev/Kconfig +0
-0
drivers/video/fbdev/Kconfig line 11
Quoted 6 lines
drivers/video/fbdev/Kconfig +3
-0@@ -6,8 +6,12 @@ config FB_NOTIFY bool +menuconfig FB_CORE + tristate "Core support for frame buffer devices" +
I could be reading this incorrectly, but FB_CORE does not appear to be a non-visible Kconfig symbol here.
drivers/video/fbdev/Kconfig line 17
Quoted 7 lines
drivers/video/fbdev/Kconfig +2
-1menuconfig FB - tristate "Support for frame buffer devices" + tristate "Support for frame buffer device drivers" + select FB_CORE select FB_NOTIFY select VIDEO_CMDLINE help
thanks.
Signature · 1 line
~Randy
Re: [PATCH v2 1/2] fbdev: Split frame buffer support in FB and FB_CORE symbols
In reply to Javier Martinez CanillasQuoted 9 lines · Javier Martinez Canillas
Currently the
CONFIG_FBoption has to be enabled even if no legacy fbdev drivers are needed (e.g: only to have support for framebuffer consoles).The DRM subsystem has a fbdev emulation layer, but depends on
CONFIG_FBand so it can only be enabled if that dependency is enabled as well.That means fbdev drivers have to be explicitly disabled if users want to enable
CONFIG_FB, only to use fbcon and/or the DRM fbdev emulation layer.
Quoted 7 lines
This patch introduces a non-visible
CONFIG_FB_COREsymbol that could be enabled just to have core support needed forCONFIG_DRM_FBDEV_EMULATION, allowingCONFIG_FBto be disabled (and automatically disabling all the fbdev drivers).Signed-off-by Javier Martinez Canillas <[email protected]>---
I found two more things now:
drivers/video/fbdev/Kconfig line 11
Quoted 4 lines
drivers/video/fbdev/Kconfig +3
-0+menuconfig FB_CORE + tristate "Core support for frame buffer devices" +
This is not actually a hidden option, since you left the prompt after the 'tristate' keyword. There is also no pointn in having it as a menu, just use the simpler
config FB_CORE
tristate
or (as in my other email)
config FB_CORE
def_tristate FB || (DRM && DRM_FBDEV_EMULATION)
Quoted 10 lines
drivers/video/fbdev/Kconfig +1
-1@@ -44,7 +54,7 @@ menuconfig FB config FIRMWARE_EDID bool "Enable firmware EDID" - depends on FB + depends on FB_CORE help This enables access to the EDID transferred from the firmware. On the i386, this is from the Video BIOS. Enable this if DDC/I2C
drivers/video/fbdev/Kconfig config FIRMWARE_EDID · line 75
Quoted 8 lines
drivers/video/fbdev/Kconfig +1
-1@@ -59,7 +69,7 @@ config FIRMWARE_EDID config FB_DEVICE bool "Provide legacy /dev/fb* device" - depends on FB + select FB_CORE default y help Say Y here if you want the legacy /dev/fb* device file and
These are now the only user visible sub-options when CONFIG_FB is disabled. I missed FIRMWARE_EDID earlier, but this also looks like it can clearly be left as depending on FB since nothing else calls fb_firmware_edid. In fact, it looks like all of fbmon.c could be left out since none of its exported symbols are needed for DRM.
That would leave CONFIG_FB_DEVICE as the only user visible option for DRM-only configs, which is slightly odd for the menuconfig, so I still wonder if that could be done differently.
Is there actually a point in configurations for kernels with FB=y, DRM=n and FB_DEVICE=n? If we don't expect that to be a useful configuration, an easier way would be to have CONFIG_FB turn it on implicitly and instead have a user-visible Kconfig option below CONFIG_DRM_FBDEV_EMULATION that allows controlling the creation of /dev/fb*.
Arnd
Re: [PATCH v2 1/2] fbdev: Split frame buffer support in FB and FB_CORE symbols
Hi Arnd,
Quoted 37 lines · Arnd Bergmann
Quoted 17 lines · Javier Martinez Canillas
Currently the
CONFIG_FBoption has to be enabled even if no legacy fbdev drivers are needed (e.g: only to have support for framebuffer consoles).The DRM subsystem has a fbdev emulation layer, but depends on
CONFIG_FBand so it can only be enabled if that dependency is enabled as well.That means fbdev drivers have to be explicitly disabled if users want to enable
CONFIG_FB, only to use fbcon and/or the DRM fbdev emulation layer.This patch introduces a non-visible
CONFIG_FB_COREsymbol that could be enabled just to have core support needed forCONFIG_DRM_FBDEV_EMULATION, allowingCONFIG_FBto be disabled (and automatically disabling all the fbdev drivers).Signed-off-by Javier Martinez Canillas <[email protected]>drivers/video/fbdev/Kconfig config FIRMWARE_EDID · line 75
Quoted 8 lines
drivers/video/fbdev/Kconfig +1
-1@@ -59,7 +69,7 @@ config FIRMWARE_EDID config FB_DEVICE bool "Provide legacy /dev/fb* device" - depends on FB + select FB_CORE default y help Say Y here if you want the legacy /dev/fb* device file andThese are now the only user visible sub-options when
CONFIG_FBis disabled. I missedFIRMWARE_EDIDearlier, but this also looks like it can clearly be left as depending on FB since nothing else callsfb_firmware_edid. In fact, it looks like all offbmon.ccould be left out since none of its exported symbols are needed for DRM.That would leave
CONFIG_FB_DEVICEas the only user visible option for DRM-only configs, which is slightly odd for the menuconfig, so I still wonder if that could be done differently.
Quoted 6 lines
Is there actually a point in configurations for kernels with FB=y, DRM=n and FB_DEVICE=n? If we don't expect that to be a useful configuration, an easier way would be to have
CONFIG_FBturn it on implicitly and instead have a user-visibleKconfigoption belowCONFIG_DRM_FBDEV_EMULATIONthat allows controlling the creation of/dev/fb*.
Such a combination would allow the user to still have a text console on a legacy fbdev, while not having to worry about possible security ramifications of providing fbdev userspace access.
Gr{oetje,eeting}s,
Geert
Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected] In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Re: [PATCH v2 1/2] fbdev: Split frame buffer support in FB and FB_CORE symbols
Quoted 2 lines · Geert Uytterhoeven
Hi Arnd,
[...]
Quoted 12 lines
Quoted 11 lines
That would leave
CONFIG_FB_DEVICEas the only user visible option for DRM-only configs, which is slightly odd for the menuconfig, so I still wonder if that could be done differently.Is there actually a point in configurations for kernels with FB=y, DRM=n and FB_DEVICE=n? If we don't expect that to be a useful configuration, an easier way would be to have
CONFIG_FBturn it on implicitly and instead have a user-visibleKconfigoption belowCONFIG_DRM_FBDEV_EMULATIONthat allows controlling the creation of/dev/fb*.
Quoted 4 lines
Such a combination would allow the user to still have a text console on a legacy fbdev, while not having to worry about possible security ramifications of providing fbdev userspace access.
Exactly, it may be a possible combination. Not sure how useful what would be in practice but we shouldn't restrict that IMO.
Signature · 5 lines
Best regards, Javier Martinez Canillas Core Platforms Red Hat
Thomas Zimmermann
maintainerRe: [PATCH v2 1/2] fbdev: Split frame buffer support in FB and FB_CORE symbols
In reply to Javier Martinez CanillasHi
Am 01.07.23 um 23:44 schrieb Javier Martinez Canillas:
Quoted 69 lines
Currently the
CONFIG_FBoption has to be enabled even if no legacy fbdev drivers are needed (e.g: only to have support for framebuffer consoles).The DRM subsystem has a fbdev emulation layer, but depends on
CONFIG_FBand so it can only be enabled if that dependency is enabled as well.That means fbdev drivers have to be explicitly disabled if users want to enable
CONFIG_FB, only to use fbcon and/or the DRM fbdev emulation layer.This patch introduces a non-visible
CONFIG_FB_COREsymbol that could be enabled just to have core support needed forCONFIG_DRM_FBDEV_EMULATION, allowingCONFIG_FBto be disabled (and automatically disabling all the fbdev drivers).Signed-off-by Javier Martinez Canillas <[email protected]>---
Changes in v2:
- Keep "depends on FB" forFB_DDC,FB_HECUBA,FB_SVGALIB,FB_MACMODES,FB_BACKLIGHT,FB_MODE_HELPERSandFB_TILEBLITTING(Arnd Bergmann).
- Don't change the fb.o object name (Arnd Bergmann).
- MakeFB_COREa non-visibleKconfigsymbol instead (Thomas Zimmermann).arch/x86/Makefile | 2 +- arch/x86/video/Makefile | 2 +- drivers/video/console/Kconfig | 2 +- drivers/video/fbdev/Kconfig | 40 +++++++++++++++++++------------ drivers/video/fbdev/core/Makefile | 2 +- 5 files changed, 29 insertions(+), 19 deletions(-)arch/x86/Makefile +1
-1@@ -259,7 +259,7 @@ drivers-$(CONFIG_PCI) += arch/x86/pci/ # suspend and hibernation support drivers-$(CONFIG_PM) += arch/x86/power/ -drivers-$(CONFIG_FB) += arch/x86/video/ +drivers-$(CONFIG_FB_CORE) += arch/x86/video/ #### # boot loader support. Several targets are kept for legacy purposesarch/x86/video/Makefile +1
-1@@ -1,2 +1,2 @@ # SPDX-License-Identifier: GPL-2.0-only -obj-$(CONFIG_FB) += fbdev.o +obj-$(CONFIG_FB_CORE) += fbdev.odrivers/video/console/Kconfig +1
-1@@ -72,7 +72,7 @@ config DUMMY_CONSOLE_ROWS config FRAMEBUFFER_CONSOLE bool "Framebuffer Console support" - depends on FB && !UML + depends on FB_CORE && !UML select VT_HW_CONSOLE_BINDING select CRC32 select FONT_SUPPORTdrivers/video/fbdev/Kconfig +0
-0
drivers/video/fbdev/Kconfig line 10
Quoted 5 lines
drivers/video/fbdev/Kconfig +2
-0@@ -6,8 +6,12 @@ config FB_NOTIFY bool +menuconfig FB_CORE + tristate "Core support for frame buffer devices"
With the text, this is visible; as others noted.
drivers/video/fbdev/Kconfig line 13
Quoted 4 lines
drivers/video/fbdev/Kconfig +2
-1+ menuconfig FB - tristate "Support for frame buffer devices" + tristate "Support for frame buffer device drivers"
Just keep the text as-is.
Quoted 27 lines
drivers/video/fbdev/Kconfig +8
-1+ select FB_CORE select FB_NOTIFY select VIDEO_CMDLINE help@@ -33,6 +37,12 @@ menuconfig FB <http://www.munted.org.uk/programming/Framebuffer-HOWTO-1.3.html> for more information. + This enables support for native frame buffer device (fbdev) drivers. + + The DRM subsystem provides support for emulated frame buffer devices + on top of KMS drivers, but this option allows legacy fbdev drivers to + be enabled as well. + Say Y here and to the driver for your graphics board below if you are compiling a kernel for a non-x86 architecture.@@ -44,7 +54,7 @@ menuconfig FB config FIRMWARE_EDID bool "Enable firmware EDID" - depends on FB + depends on FB_CORE help This enables access to the EDID transferred from the firmware. On the i386, this is from the Video BIOS. Enable this if DDC/I2C
drivers/video/fbdev/Kconfig config FIRMWARE_EDID · line 72
Quoted 5 lines
drivers/video/fbdev/Kconfig +1
-1@@ -59,7 +69,7 @@ config FIRMWARE_EDID config FB_DEVICE bool "Provide legacy /dev/fb* device" - depends on FB + select FB_CORE
This should depend on FB_CORE.
Best regards
Thomas
Quoted 114 lines
drivers/video/fbdev/Kconfig +12
-12default y help Say Y here if you want the legacy /dev/fb* device file and@@ -75,7 +85,7 @@ config FB_DDC config FB_CFB_FILLRECT tristate - depends on FB + depends on FB_CORE help Include the cfb_fillrect function for generic software rectangle filling. This is used by drivers that don't provide their own@@ -83,7 +93,7 @@ config FB_CFB_FILLRECT config FB_CFB_COPYAREA tristate - depends on FB + depends on FB_CORE help Include the cfb_copyarea function for generic software area copying. This is used by drivers that don't provide their own (accelerated)@@ -91,7 +101,7 @@ config FB_CFB_COPYAREA config FB_CFB_IMAGEBLIT tristate - depends on FB + depends on FB_CORE help Include the cfb_imageblit function for generic software image blitting. This is used by drivers that don't provide their own@@ -99,7 +109,7 @@ config FB_CFB_IMAGEBLIT config FB_CFB_REV_PIXELS_IN_BYTE bool - depends on FB + depends on FB_CORE help Allow generic frame-buffer functions to work on displays with 1, 2 and 4 bits per pixel depths which has opposite order of pixels in@@ -107,7 +117,7 @@ config FB_CFB_REV_PIXELS_IN_BYTE config FB_SYS_FILLRECT tristate - depends on FB + depends on FB_CORE help Include the sys_fillrect function for generic software rectangle filling. This is used by drivers that don't provide their own@@ -115,7 +125,7 @@ config FB_SYS_FILLRECT config FB_SYS_COPYAREA tristate - depends on FB + depends on FB_CORE help Include the sys_copyarea function for generic software area copying. This is used by drivers that don't provide their own (accelerated)@@ -123,7 +133,7 @@ config FB_SYS_COPYAREA config FB_SYS_IMAGEBLIT tristate - depends on FB + depends on FB_CORE help Include the sys_imageblit function for generic software image blitting. This is used by drivers that don't provide their own@@ -162,22 +172,22 @@ endchoice config FB_SYS_FOPS tristate - depends on FB + depends on FB_CORE config FB_DEFERRED_IO bool - depends on FB + depends on FB_CORE config FB_IO_HELPERS bool - depends on FB + depends on FB_CORE select FB_CFB_COPYAREA select FB_CFB_FILLRECT select FB_CFB_IMAGEBLIT config FB_SYS_HELPERS bool - depends on FB + depends on FB_CORE select FB_SYS_COPYAREA select FB_SYS_FILLRECT select FB_SYS_FOPS@@ -185,7 +195,7 @@ config FB_SYS_HELPERS config FB_SYS_HELPERS_DEFERRED bool - depends on FB + depends on FB_CORE select FB_DEFERRED_IO select FB_SYS_HELPERSdrivers/video/fbdev/core/Makefile +1
-1@@ -1,6 +1,6 @@ # SPDX-License-Identifier: GPL-2.0 obj-$(CONFIG_FB_NOTIFY) += fb_notify.o -obj-$(CONFIG_FB) += fb.o +obj-$(CONFIG_FB_CORE) += fb.o fb-y := fb_backlight.o \ fb_info.o \ fbmem.o fbmon.o fbcmap.o \
Signature · 6 lines
Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstrasse 146, 90461 Nuernberg, Germany GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman HRB 36809 (AG Nuernberg)
Re: [PATCH v2 1/2] fbdev: Split frame buffer support in FB and FB_CORE symbols
Thomas Zimmermann <[email protected]> writes:
Hello Thomas,
Thanks for your review.
Quoted 3 lines
Hi
Am 01.07.23 um 23:44 schrieb Javier Martinez Canillas:
[...]
Quoted 6 lines
drivers/video/fbdev/Kconfig line 10
Quoted 3 lines
drivers/video/fbdev/Kconfig +2
-0+menuconfig FB_CORE + tristate "Core support for frame buffer devices"With the text, this is visible; as others noted.
Yes, I misremembered what made a Kconfig symbol non-visible, and thought that was just the lack of a help section but forgot to remove the prompt.
This is already fixed in v3.
Quoted 7 lines
drivers/video/fbdev/Kconfig line 13
Quoted 4 lines
drivers/video/fbdev/Kconfig +2
-1+ menuconfig FB - tristate "Support for frame buffer devices" + tristate "Support for frame buffer device drivers"Just keep the text as-is.
I disagree. Because we are slightly changing the Kconfig symbol semantics here, for instance CONFIG_FB_CORE + CONFIG_DRM_FBDEV_EMULATION will also provide a frame buffer device (and with CONFIG_FB_DEVICE, will be exposed to user-space as a /dev/fb? device).
So now CONFIG_FB is really about allowing the native fbdev drivers to be enabled. That's why I'm changing the prompt text to make that more clear.
[...]
Quoted 7 lines
drivers/video/fbdev/Kconfig config FIRMWARE_EDID · line 72
Quoted 4 lines
config
FB_DEVICE
bool "Provide legacy/dev/fb*device"drivers/video/fbdev/Kconfig +1
-1- depends on FB + select FB_COREThis should depend on
FB_CORE.
Yes, already fixed in v3 too. I did a select to prevent symbol circular dependencies but doing that lead to CONFIG_FB_CORE=y even if CONFIG_DRM was set as a module.
But with the "select FB_CORE if DRM_FBDEV_EMULATION" in the DRM symbol as Arnd suggested, I was able to have FB_DEVICE to depend on FB_CORE again.
Quoted 3 lines
Best regards
Thomas
Signature · 5 lines
Best regards, Javier Martinez Canillas Core Platforms Red Hat
Thomas Zimmermann
maintainerRe: [PATCH v2 1/2] fbdev: Split frame buffer support in FB and FB_CORE symbols
Hi
Am 03.07.23 um 09:46 schrieb Javier Martinez Canillas:
Quoted 50 lines
Thomas Zimmermann <[email protected]> writes:
Hello Thomas,
Thanks for your review.
Quoted 3 lines
Hi
Am 01.07.23 um 23:44 schrieb Javier Martinez Canillas:
[...]
Quoted 6 lines
drivers/video/fbdev/Kconfig line 10
Quoted 3 lines
drivers/video/fbdev/Kconfig +2
-0+menuconfig FB_CORE + tristate "Core support for frame buffer devices"With the text, this is visible; as others noted.
Yes, I misremembered what made a
Kconfigsymbol non-visible, and thought that was just the lack of a help section but forgot to remove the prompt.This is already fixed in v3.
Quoted 7 lines
drivers/video/fbdev/Kconfig line 13
Quoted 4 lines
drivers/video/fbdev/Kconfig +2
-1+ menuconfig FB - tristate "Support for frame buffer devices" + tristate "Support for frame buffer device drivers"Just keep the text as-is.
I disagree. Because we are slightly changing the
Kconfigsymbol semantics here, for instanceCONFIG_FB_CORE+CONFIG_DRM_FBDEV_EMULATIONwill also provide a frame buffer device (and withCONFIG_FB_DEVICE, will be exposed to user-space as a/dev/fb? device).So now
CONFIG_FBis really about allowing the native fbdev drivers to be enabled. That's why I'm changing the prompt text to make that more clear.[...]
Quoted 7 lines
drivers/video/fbdev/Kconfig config FIRMWARE_EDID · line 72
Quoted 4 lines
config
FB_DEVICE
bool "Provide legacy/dev/fb*device"drivers/video/fbdev/Kconfig +1
-1- depends on FB + select FB_COREThis should depend on
FB_CORE.
Quoted 6 lines
Yes, already fixed in v3 too. I did a select to prevent symbol circular dependencies but doing that lead to
CONFIG_FB_CORE=yeven ifCONFIG_DRMwas set as a module.But with the "select
FB_COREifDRM_FBDEV_EMULATION" in the DRM symbol as Arnd suggested, I was able to haveFB_DEVICEto depend onFB_COREagain.
BTW, where does this item now show up in the menu? It used to be in the framebuffer menu. It's now in the graphics-drivers menu?
Best regards
Thomas
Quoted 5 lines
Quoted 4 lines
Best regards
Thomas
Signature · 6 lines
Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstrasse 146, 90461 Nuernberg, Germany GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman HRB 36809 (AG Nuernberg)
Re: [PATCH v2 1/2] fbdev: Split frame buffer support in FB and FB_CORE symbols
Thomas Zimmermann <[email protected]> writes:
[...]
Quoted 12 lines
Quoted 12 lines
Quoted 7 lines
drivers/video/fbdev/Kconfig config FIRMWARE_EDID · line 72
Quoted 4 lines
config
FB_DEVICE
bool "Provide legacy/dev/fb*device"drivers/video/fbdev/Kconfig +1
-1- depends on FB + select FB_COREThis should depend on
FB_CORE.Yes, already fixed in v3 too. I did a select to prevent symbol circular dependencies but doing that lead to
CONFIG_FB_CORE=yeven ifCONFIG_DRMwas set as a module.
Quoted 6 lines
Quoted 2 lines
But with the "select
FB_COREifDRM_FBDEV_EMULATION" in the DRM symbol as Arnd suggested, I was able to haveFB_DEVICEto depend onFB_COREagain.BTW, where does this item now show up in the menu? It used to be in the framebuffer menu. It's now in the graphics-drivers menu?
No, it's still in the framebuffer menu. But after the FB_CORE split the menuconfig ends broken (no sub-level for fbdev drivers anymore).
I was talking with Arnd and Geert about this. I think that will pause this series and instead first focus on cleaning up the fbdev Kconfig, then it should be easier to add the FB_CORE on top of that.
Quoted 3 lines
Best regards
Thomas
Signature · 5 lines
Best regards, Javier Martinez Canillas Core Platforms Red Hat
PATCH v2 2/2 drm: Make fbdev emulation select FB_CORE instead of depends on FB
In reply to Javier Martinez CanillasNow that the fbdev core has been split in FB_CORE and FB, make DRM fbdev emulation layer to just select the former.
This allows to disable the CONFIG_FB option if is not needed, which will avoid the need to explicitly disable each of the legacy fbdev drivers.
---
Changes in v2:
- Make CONFIG_DRM_FBDEV_EMULATION to select FB_CORE (Thomas Zimmermann).
drivers/gpu/drm/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/Kconfig +1 -1
@@ -132,7 +132,7 @@ config DRM_DEBUG_MODESET_LOCK config DRM_FBDEV_EMULATION bool "Enable legacy fbdev support for your modesetting driver" depends on DRM_KMS_HELPER - depends on FB=y || FB=DRM_KMS_HELPER + select FB_CORE select FRAMEBUFFER_CONSOLE if !EXPERT select FRAMEBUFFER_CONSOLE_DETECT_PRIMARY if FRAMEBUFFER_CONSOLE default y
Signature · 1 line
2.41.0
Re: [PATCH v2 2/2] drm: Make fbdev emulation select FB_CORE instead of depends on FB
Quoted 20 lines · Javier Martinez Canillas
Now that the fbdev core has been split in
FB_COREand FB, make DRM fbdev emulation layer to just select the former.This allows to disable the
CONFIG_FBoption if is not needed, which will avoid the need to explicitly disable each of the legacy fbdev drivers.Signed-off-by Javier Martinez Canillas <[email protected]>---
Changes in v2:
- MakeCONFIG_DRM_FBDEV_EMULATIONto selectFB_CORE(Thomas Zimmermann).drivers/gpu/drm/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/Kconfig +0
-0
drivers/gpu/drm/Kconfig config DRM_DEBUG_MODESET_LOCK · line 135
Quoted 5 lines
drivers/gpu/drm/Kconfig +1
-1@@ -132,7 +132,7 @@ config DRM_DEBUG_MODESET_LOCK config DRM_FBDEV_EMULATION bool "Enable legacy fbdev support for your modesetting driver" depends on DRM_KMS_HELPER - depends on FB=y || FB=DRM_KMS_HELPER + select FB_CORE
This will unfortunately force FB_CORE=y even with DRM=m, it would be nice to allow both to be loadable modules. Any of these should work:
a) Add another hidden symbol like
config DRM_FB_CORE
def_tristate DRM && DRM_FBDEV_EMULATION
select FB_COREb) move the 'select' to DRM
config DRM
tristate "Direct Rendering Manager (XFree86 4.1.0 and higher DRI support)" select FB_CORE if DRM_FBDEV_EMULATION
c) Remove the 'select' and instead use the default
config FB_CORE
def_tristate FB || (DRM && DRM_FBDEV_EMULATION)
ArndRe: [PATCH v2 2/2] drm: Make fbdev emulation select FB_CORE instead of depends on FB
Hi Arnd,
Quoted 30 lines · Arnd Bergmann
Quoted 20 lines · Javier Martinez Canillas
Now that the fbdev core has been split in
FB_COREand FB, make DRM fbdev emulation layer to just select the former.This allows to disable the
CONFIG_FBoption if is not needed, which will avoid the need to explicitly disable each of the legacy fbdev drivers.Signed-off-by Javier Martinez Canillas <[email protected]>---
Changes in v2:
- MakeCONFIG_DRM_FBDEV_EMULATIONto selectFB_CORE(Thomas Zimmermann).drivers/gpu/drm/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/Kconfig +0
-0drivers/gpu/drm/Kconfig config DRM_DEBUG_MODESET_LOCK · line 135
Quoted 5 lines
drivers/gpu/drm/Kconfig +1
-1@@ -132,7 +132,7 @@ config DRM_DEBUG_MODESET_LOCK config DRM_FBDEV_EMULATION bool "Enable legacy fbdev support for your modesetting driver" depends on DRM_KMS_HELPER - depends on FB=y || FB=DRM_KMS_HELPER + select FB_COREThis will unfortunately force FB_CORE=y even with DRM=m, it would be nice to allow both to be loadable modules. Any of these should work:
Quoted 5 lines
a) Add another hidden symbol like
config
DRM_FB_COREdef_tristate DRM && DRM_FBDEV_EMULATION select FB_CORE
More complexity to keep track of...
Quoted 6 lines
b) move the 'select' to DRM
config DRM
tristate "Direct Rendering Manager (XFree86 4.1.0 and higher DRI support)" selectFB_COREifDRM_FBDEV_EMULATION
I prefer this one, as it keeps the select close to the user.
BTW, the tristate help text can use some overhaul ;-)
Quoted 4 lines
c) Remove the 'select' and instead use the default
config
FB_COREdef_tristate FB || (DRM && DRM_FBDEV_EMULATION)
Adding it here means this patch would touch two subsystems.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Re: [PATCH v2 2/2] drm: Make fbdev emulation select FB_CORE instead of depends on FB
Quoted 33 lines · Geert Uytterhoeven
Hi Arnd,
Quoted 30 lines · Arnd Bergmann
Quoted 20 lines · Javier Martinez Canillas
Now that the fbdev core has been split in
FB_COREand FB, make DRM fbdev emulation layer to just select the former.This allows to disable the
CONFIG_FBoption if is not needed, which will avoid the need to explicitly disable each of the legacy fbdev drivers.Signed-off-by Javier Martinez Canillas <[email protected]>---
Changes in v2:
- MakeCONFIG_DRM_FBDEV_EMULATIONto selectFB_CORE(Thomas Zimmermann).drivers/gpu/drm/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/Kconfig +0
-0drivers/gpu/drm/Kconfig config DRM_DEBUG_MODESET_LOCK · line 135
Quoted 5 lines
drivers/gpu/drm/Kconfig +1
-1@@ -132,7 +132,7 @@ config DRM_DEBUG_MODESET_LOCK config DRM_FBDEV_EMULATION bool "Enable legacy fbdev support for your modesetting driver" depends on DRM_KMS_HELPER - depends on FB=y || FB=DRM_KMS_HELPER + select FB_COREThis will unfortunately force FB_CORE=y even with DRM=m, it would be nice to allow both to be loadable modules. Any of these should work:
Right, I missed that. Thanks for pointing that out.
Quoted 8 lines
Quoted 5 lines
a) Add another hidden symbol like
config
DRM_FB_COREdef_tristate DRM && DRM_FBDEV_EMULATION select FB_COREMore complexity to keep track of...
Yes, I would avoid this option as well.
Quoted 9 lines
Quoted 6 lines
b) move the 'select' to DRM
config DRM
tristate "Direct Rendering Manager (XFree86 4.1.0 and higher DRI support)" selectFB_COREifDRM_FBDEV_EMULATIONI prefer this one, as it keeps the select close to the user.
Agreed with Geert that this is the best option.
Quoted 2 lines
BTW, the tristate help text can use some overhaul ;-)
Indeed :) I will add a preparatory patch to this series improving that prompt text.
Quoted 7 lines
Quoted 4 lines
c) Remove the 'select' and instead use the default
config
FB_COREdef_tristate FB || (DRM && DRM_FBDEV_EMULATION)Adding it here means this patch would touch two subsystems.
Yeah. Even when in practice we push changes for drivers/video and drivers/gpu/drm in drm-misc, I agree that option (b) is better.
Quoted 5 lines
Gr{oetje,eeting}s,
Geert
Signature · 5 lines
Best regards, Javier Martinez Canillas Core Platforms Red Hat