TIOCSTI: always enable for CAP_SYS_ADMIN
Subsystems (2)
PATCH 1/1 TIOCSTI: always enable for CAP_SYS_ADMIN
83efeeeb3d04 ("tty: Allow TIOCSTI to be disabled") broke BRLTTY's ability to simulate keypresses on the console, thus effectively breaking braille keyboards of blind users.
This restores the TIOCSTI feature for CAP_SYS_ADMIN processes, which BRLTTY is, thus fixing braille keyboards without re-opening the security issue.
drivers/tty/tty_io.c +1 -1
@@ -2276,7 +2276,7 @@ static int tiocsti(struct tty_struct *ttchar ch, mbz =0 ;struct tty_ldisc *ld; -if (!tty_legacy_tiocsti) +if (!tty_legacy_tiocsti && !capable (CAP_SYS_ADMIN ))return -EIO ;if ((current->signal->tty != tty) && !capable (CAP_SYS_ADMIN ))
kernel test robot
build botFYI: kernel test robot notices the stable kernel rule is not satisfied.
Hi,
Thanks for your patch.
FYI: kernel test robot notices the stable kernel rule is not satisfied.
Rule: 'Cc: [email protected]' or 'commit <sha1> upstream.'
Subject: [PATCH] TIOCSTI: always enable for CAP_SYS_ADMIN
The check is based on https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
Signature · 2 lines
0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
Quoted 10 lines · Samuel Thibault
83efeeeb3d04("tty: Allow TIOCSTI to be disabled") broke BRLTTY's ability to simulate keypresses on the console, thus effectively breaking braille keyboards of blind users.This restores the TIOCSTI feature for
CAP_SYS_ADMINprocesses, which BRLTTY is, thus fixing braille keyboards without re-opening the security issue.Signed-off-by Samuel Thibault <[email protected]>Fixes 83efeeeb3d04 ("tty: Allow TIOCSTI to be disabled")
Based on the design of brltty, this appears to be the only solution. I remain surprised that FreeBSD had no brltty support, which is why they didn't run into this problem.
-Kees
Quoted 14 lines
Index:
linux-6.4/drivers/tty/tty_io.c
===================================================================drivers/tty/tty_io.c +1
-1@@ -2276,7 +2276,7 @@ static int tiocsti(struct tty_struct *ttchar ch, mbz =0 ;struct tty_ldisc *ld; -if (!tty_legacy_tiocsti) +if (!tty_legacy_tiocsti && !capable (CAP_SYS_ADMIN ))return -EIO ;if ((current->signal->tty != tty) && !capable (CAP_SYS_ADMIN ))
Signature · 1 line
Kees Cook