Skip to contentSkip to conversation

package/python-pyicu: fix build

PATCH Applied Bernd Kuhls 3 participants 3 messages Jul 2, 2023 – Jul 16, 2023

lore
Share & tools
lore
#0 lore raw

PATCH v4 1/1 package/python-pyicu: fix build

Fixes:
http://autobuild.buildroot.net/results/977/977c043615603dd3541e23b81c5f11374606aff6/

Set environment variables to cross-compile friendly values, this prevents icu-config picking up host libraries:
https://gitlab.pyicu.org/main/pyicu/-/blob/main/setup.py#L89
https://gitlab.pyicu.org/main/pyicu/-/blob/main/setup.py#L179
https://gitlab.pyicu.org/main/pyicu/-/blob/main/setup.py#L216

This follows the upstream build docs:
https://gitlab.pyicu.org/main/pyicu#building-pyicu

---
v4: removed variable ICU_BASE (Thomas)

 package/python-pyicu/python-pyicu.mk | 6 ++++++
 1 file changed, 6 insertions(+)
package/python-pyicu/python-pyicu.mk +6 -0
index 090ed51bff..213c099d07 100644
@@ -12,4 +12,10 @@ PYTHON_PYICU_LICENSE_FILES = LICENSE
 PYTHON_PYICU_DEPENDENCIES = icu
 PYTHON_PYICU_SETUP_TYPE = setuptools
 
+PYTHON_PYICU_ENV += \
+	ICU_VERSION="`$(PKG_CONFIG_HOST_BINARY) icu-i18n --modversion`" \
+	PYICU_CFLAGS="`$(PKG_CONFIG_HOST_BINARY) icu-i18n --variable=CXXFLAGS`" \
+	PYICU_LFLAGS="`$(PKG_CONFIG_HOST_BINARY) icu-i18n --libs-only-L` \
+		`$(PKG_CONFIG_HOST_BINARY) icu-i18n --libs-only-l`"
+
 $(eval $(python-package))
Signature · 6 lines
2.39.2

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw
Quoted 9 lines · Bernd Kuhls

Fixes:
http://autobuild.buildroot.net/results/977/977c043615603dd3541e23b81c5f11374606aff6/

Set environment variables to cross-compile friendly values, this prevents icu-config picking up host libraries:
https://gitlab.pyicu.org/main/pyicu/-/blob/main/setup.py#L89
https://gitlab.pyicu.org/main/pyicu/-/blob/main/setup.py#L179
https://gitlab.pyicu.org/main/pyicu/-/blob/main/setup.py#L216

Quoted 4 lines

This follows the upstream build docs:
https://gitlab.pyicu.org/main/pyicu#building-pyicu

Applied to master, thanks.

Regards,
Arnout

Quoted 11 lines

---
v4: removed variable ICU_BASE (Thomas)

  package/python-pyicu/python-pyicu.mk | 6 ++++++
  1 file changed, 6 insertions(+)
package/python-pyicu/python-pyicu.mk +0 -0
index 090ed51bff..213c099d07 100644

package/python-pyicu/python-pyicu.mk PYTHON_PYICU_LICENSE_FILES = LICENSE · line 21

Quoted 10 lines
package/python-pyicu/python-pyicu.mk +6 -0
@@ -12,4 +12,10 @@ PYTHON_PYICU_LICENSE_FILES = LICENSE
  PYTHON_PYICU_DEPENDENCIES = icu
  PYTHON_PYICU_SETUP_TYPE = setuptools
 
+PYTHON_PYICU_ENV += \
+	ICU_VERSION="`$(PKG_CONFIG_HOST_BINARY) icu-i18n --modversion`" \
+	PYICU_CFLAGS="`$(PKG_CONFIG_HOST_BINARY) icu-i18n --variable=CXXFLAGS`" \
+	PYICU_LFLAGS="`$(PKG_CONFIG_HOST_BINARY) icu-i18n --libs-only-L` \
+		`$(PKG_CONFIG_HOST_BINARY) icu-i18n --libs-only-l`"
+
  $(eval $(python-package))

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#2 lore raw
In reply to Bernd Kuhls
Quoted 9 lines · Bernd Kuhls

Fixes:
http://autobuild.buildroot.net/results/977/977c043615603dd3541e23b81c5f11374606aff6/

Set environment variables to cross-compile friendly values, this prevents icu-config picking up host libraries:
https://gitlab.pyicu.org/main/pyicu/-/blob/main/setup.py#L89
https://gitlab.pyicu.org/main/pyicu/-/blob/main/setup.py#L179
https://gitlab.pyicu.org/main/pyicu/-/blob/main/setup.py#L216

Quoted 6 lines

This follows the upstream build docs:
https://gitlab.pyicu.org/main/pyicu#building-pyicu

---
v4: removed variable ICU_BASE (Thomas)

Committed to 2023.02.x and 2023.05.x, thanks.

Signature · 6 lines
Bye, Peter Korsgaard

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot