Skip to contentSkip to conversation

ARM: dts: st: add buswidth property to stm32f429-disco

PATCH In review Raphael Gallais-Pou 2 participants 4 messages Jul 2, 2023 – Jul 3, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: st: add buswidth property to stm32f429-disco

The ili9341 is left without a mandatory buswidth to properly communicate between the SI bus and the display. Add the device-tree property.

---
 arch/arm/boot/dts/stm32f429-disco.dts | 1 +
 1 file changed, 1 insertion(+)
arch/arm/boot/dts/stm32f429-disco.dts +1 -0
index 3b81228d46a2..5eaf95afc8c7 100644
@@ -197,6 +197,7 @@ display: display@1{
 		spi-3wire;
 		spi-max-frequency = <10000000>;
 		dc-gpios = <&gpiod 13 0>;
+		buswidth = <8>;
 		port {
 			panel_in_rgb: endpoint {
 			remote-endpoint = <&ltdc_out_rgb>;
Signature · 1 line
2.41.0
#1 lore raw
Quoted 6 lines · Raphael Gallais-Pou

The ili9341 is left without a mandatory buswidth to properly communicate between the SI bus and the display. Add the device-tree property.

---
 arch/arm/boot/dts/stm32f429-disco.dts | 1 +

There is no such file. Please rebase on recent Linux.

arch/arm/boot/dts/stm32f429-disco.dts display: display@1{ · line 200

Quoted 11 lines
 1 file changed, 1 insertion(+)
arch/arm/boot/dts/stm32f429-disco.dts +1 -0
index 3b81228d46a2..5eaf95afc8c7 100644
@@ -197,6 +197,7 @@ display: display@1{
 		spi-3wire;
 		spi-max-frequency = <10000000>;
 		dc-gpios = <&gpiod 13 0>;
+		buswidth = <8>;

There is no such spi property.

Best regards,
Krzysztof

#2 lore raw

Hi,

Le 02/07/2023 à 22:14, Krzysztof Kozlowski a écrit :

Quoted 9 lines · Raphael Gallais-Pou
Quoted 6 lines

The ili9341 is left without a mandatory buswidth to properly communicate between the SI bus and the display. Add the device-tree property.

---
  arch/arm/boot/dts/stm32f429-disco.dts | 1 +

There is no such file. Please rebase on recent Linux.

Yes, indeed. I forgot to pull, I'm sorry.

Quoted 14 lines

arch/arm/boot/dts/stm32f429-disco.dts display: display@1{ · line 200

Quoted 12 lines
  1 file changed, 1 insertion(+)
arch/arm/boot/dts/stm32f429-disco.dts +1 -0
index 3b81228d46a2..5eaf95afc8c7 100644
@@ -197,6 +197,7 @@ display: display@1{
  		spi-3wire;
  		spi-max-frequency = <10000000>;
  		dc-gpios = <&gpiod 13 0>;
+		buswidth = <8>;

There is no such spi property.

While I agree with you, I saw in staging drivers that this property was fetch in the device-tree by the fbtft core.

Should I document those in or try to do it another way ?

Quoted 4 lines

Best regards,
Krzysztof

Thanks,
Raphaël

#3 lore raw
Quoted 11 lines · Raphaël Gallais-Pou
Quoted 6 lines
Quoted 4 lines
             spi-3wire;
             spi-max-frequency = <10000000>;
             dc-gpios = <&gpiod 13 0>;

+ buswidth = <8>;

There is no such spi property.

While I agree with you, I saw in staging drivers that this property was fetch in the device-tree by the fbtft core.

Should I document those in or try to do it another way ?

You cannot use undocumented properties. Whether this should be used at all, depends what's this, why other properties cannot be used etc.