smb: client: remove unused variable 'server'
Subsystems (2)
PATCH 1/1 smb: client: remove unused variable 'server'
gcc with W=1 reportsfs/smb/client/dfs.c: In function ‘__dfs_mount_share’:fs/smb/client/dfs.c:146:33: error: variable ‘server
set but not used [-Werror=unused-but-set-variable]
146 | struct TCP_Server_Info *server;
| ^~~~~~
This variable is not used, so remove it.
--- fs/smb/client/dfs.c | 2 -- 1 file changed, 2 deletions(-)
fs/smb/client/dfs.c +0 -2
@@ -143,7 +143,6 @@ static int __dfs_mount_share(struct cifs_mount_ctx *mnt_ctx)struct smb3_fs_context *ctx = mnt_ctx->fs_ctx;char *ref_path =NULL , *full_path =NULL ;struct dfs_cache_tgt_iterator *tit; -struct TCP_Server_Info *server;struct cifs_tcon *tcon;char *origin_fullpath =NULL ;char sep =CIFS_DIR_SEP (cifs_sb);
@@ -214,7 +213,6 @@ static int __dfs_mount_share(struct cifs_mount_ctx *mnt_ctx) }while (rc == -EREMOTE );if (!rc) { - server = mnt_ctx->server; tcon = mnt_ctx->tcon;spin_lock (&tcon->tc_lock);
Signature · 1 line
2.27.0
Good catch - but this was removed a few days ago by Colin's patch
smfrench@smfrench-ThinkPad-P52:~/cifs-2.6$ git log fs/smb/client/dfs.c commit dfbf0ee092a5d7a9301c81e815b5e50b7c0aeeda Author: Colin Ian King <[email protected]> Date: Fri Jun 30 12:33:37 2023 +0100
smb: client: remove redundant pointer 'server'
The pointer 'server' is assigned but never read, the pointer is redundant and can be removed. Cleans up clang scan build warning:
fs/smb/client/dfs.c:217:3: warning: Value stored to 'server' is never read [deadcode.DeadStores]
Quoted 38 lines · Tom Rix
gcc with W=1 reports
fs/smb/client/dfs.c: In function ‘__dfs_mount_share’:fs/smb/client/dfs.c:146:33: error: variable ‘server
set but not used [-Werror=unused-but-set-variable]
146 | structTCP_Server_Info*server;
| ^~~~~~This variable is not used, so remove it.
Signed-off-by Tom Rix <[email protected]>--- fs/smb/client/dfs.c | 2 -- 1 file changed, 2 deletions(-)fs/smb/client/dfs.c +0
-3@@ -143,7 +143,6 @@ static int __dfs_mount_share(struct cifs_mount_ctx *mnt_ctx)struct smb3_fs_context *ctx = mnt_ctx->fs_ctx;char *ref_path =NULL , *full_path =NULL ;struct dfs_cache_tgt_iterator *tit; -struct TCP_Server_Info *server;struct cifs_tcon *tcon;char *origin_fullpath =NULL ;char sep =CIFS_DIR_SEP (cifs_sb);@@ -214,7 +213,6 @@ static int __dfs_mount_share(struct cifs_mount_ctx *mnt_ctx) }while (rc == -EREMOTE );if (!rc) { - server = mnt_ctx->server; tcon = mnt_ctx->tcon;spin_lock (&tcon->tc_lock); --2.27.0
Signature · 3 lines
Thanks, Steve