Skip to contentSkip to conversation

ARM: dts: st: dts fixes in stih418-b2264.dts

PATCH In review Alain Volmat 2 participants 10 messages Jul 2, 2023 – Aug 16, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

cover ARM: dts: st: dts fixes in stih418-b2264.dts

Correction of two dts warnings and led state in stih418-b2264.dts

Alain Volmat (3):
ARM: dts: st: correct serial alias in stih418-b2264.dts
ARM: dts: st: move leds out of soc in stih418-b2264.dts
ARM: dts: st: correct led level in stih418-b2264.dts

 arch/arm/boot/dts/st/stih418-b2264.dts | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)
Signature · 7 lines
2.34.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#1 lore raw

PATCH 1/3 ARM: dts: st: correct serial alias in stih418-b2264.dts

Aliases should only contain lowercase, digits or - hence correct the alias for the serial from ttyAS0 into serial0 as already done for the other boards.

---
 arch/arm/boot/dts/st/stih418-b2264.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/st/stih418-b2264.dts +1 -1
index fc32a03073b6..f496ca28850d 100644
@@ -69,7 +69,7 @@ opp04 {
 	};
 
 	aliases {
-		ttyAS0 = &sbc_serial0;
+		serial0 = &sbc_serial0;
 		ethernet0 = &ethernet0;
 	};
 
Signature · 7 lines
2.34.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
maintainer Acked-by on v1 1/3
#2 lore raw

Re: [PATCH 1/3] ARM: dts: st: correct serial alias in stih418-b2264.dts

Quoted 14 lines · Alain Volmat

Aliases should only contain lowercase, digits or - hence correct the alias for the serial from ttyAS0 into serial0 as already done for the other boards.

---
 arch/arm/boot/dts/st/stih418-b2264.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/st/stih418-b2264.dts +0 -0
index fc32a03073b6..f496ca28850d 100644

arch/arm/boot/dts/st/stih418-b2264.dts opp04 { · line 75

Quoted 8 lines
arch/arm/boot/dts/st/stih418-b2264.dts +1 -1
@@ -69,7 +69,7 @@ opp04 {
 	};
 
 	aliases {
-		ttyAS0 = &sbc_serial0;
+		serial0 = &sbc_serial0;
 		ethernet0 = &ethernet0;
 	};
 

Thanks
Patrice

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

maintainer
#3 lore raw

Re: [PATCH 1/3] ARM: dts: st: correct serial alias in stih418-b2264.dts

In reply to Alain Volmat
Quoted 14 lines · Alain Volmat

Aliases should only contain lowercase, digits or - hence correct the alias for the serial from ttyAS0 into serial0 as already done for the other boards.

---
 arch/arm/boot/dts/st/stih418-b2264.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/st/stih418-b2264.dts +0 -0
index fc32a03073b6..f496ca28850d 100644

arch/arm/boot/dts/st/stih418-b2264.dts opp04 { · line 75

Quoted 8 lines
arch/arm/boot/dts/st/stih418-b2264.dts +1 -1
@@ -69,7 +69,7 @@ opp04 {
 	};
 
 	aliases {
-		ttyAS0 = &sbc_serial0;
+		serial0 = &sbc_serial0;
 		ethernet0 = &ethernet0;
 	};
 

Applied on sti-next

Thanks
Patrice

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#4 lore raw

PATCH 2/3 ARM: dts: st: move leds out of soc in stih418-b2264.dts

In reply to Alain Volmat

Move the leds node out of the soc section
and correct the following warning:
Warning (simple_bus_reg): /soc/leds: missing or empty reg/ranges property

---
 arch/arm/boot/dts/st/stih418-b2264.dts | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)
arch/arm/boot/dts/st/stih418-b2264.dts +7 -7
index f496ca28850d..d4874282cfba 100644
@@ -73,15 +73,15 @@ aliases {
 		ethernet0 = &ethernet0;
 	};
 
-	soc {
-		leds {
-			compatible = "gpio-leds";
-			led-green {
-				gpios = <&pio1 3 GPIO_ACTIVE_HIGH>;
-				default-state = "off";
-			};
+	leds {
+		compatible = "gpio-leds";
+		led-green {
+			gpios = <&pio1 3 GPIO_ACTIVE_HIGH>;
+			default-state = "off";
 		};
+	};
 
+	soc {
 		pin-controller-sbc@961f080 {
 			gmac1 {
 				rgmii1-0 {
Signature · 7 lines
2.34.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
maintainer Acked-by on v1 2/3
#5 lore raw

Re: [PATCH 2/3] ARM: dts: st: move leds out of soc in stih418-b2264.dts

Quoted 26 lines · Alain Volmat

Move the leds node out of the soc section
and correct the following warning:
Warning (simple_bus_reg): /soc/leds: missing or empty reg/ranges property

---
 arch/arm/boot/dts/st/stih418-b2264.dts | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)
arch/arm/boot/dts/st/stih418-b2264.dts +2 -7
index f496ca28850d..d4874282cfba 100644
@@ -73,15 +73,15 @@ aliases {
 		ethernet0 = &ethernet0;
 	};
 
-	soc {
-		leds {
-			compatible = "gpio-leds";
-			led-green {
-				gpios = <&pio1 3 GPIO_ACTIVE_HIGH>;
-				default-state = "off";
-			};
+	leds {
+		compatible = "gpio-leds";

arch/arm/boot/dts/st/stih418-b2264.dts aliases { · line 87

Quoted 10 lines
arch/arm/boot/dts/st/stih418-b2264.dts +5 -0
+		led-green {
+			gpios = <&pio1 3 GPIO_ACTIVE_HIGH>;
+			default-state = "off";
 		};
+	};
 
+	soc {
 		pin-controller-sbc@961f080 {
 			gmac1 {
 				rgmii1-0 {

Thanks
PAtrice

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

maintainer
#6 lore raw

Re: [PATCH 2/3] ARM: dts: st: move leds out of soc in stih418-b2264.dts

In reply to Alain Volmat
Quoted 26 lines · Alain Volmat

Move the leds node out of the soc section
and correct the following warning:
Warning (simple_bus_reg): /soc/leds: missing or empty reg/ranges property

---
 arch/arm/boot/dts/st/stih418-b2264.dts | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)
arch/arm/boot/dts/st/stih418-b2264.dts +2 -7
index f496ca28850d..d4874282cfba 100644
@@ -73,15 +73,15 @@ aliases {
 		ethernet0 = &ethernet0;
 	};
 
-	soc {
-		leds {
-			compatible = "gpio-leds";
-			led-green {
-				gpios = <&pio1 3 GPIO_ACTIVE_HIGH>;
-				default-state = "off";
-			};
+	leds {
+		compatible = "gpio-leds";

arch/arm/boot/dts/st/stih418-b2264.dts aliases { · line 87

Quoted 10 lines
arch/arm/boot/dts/st/stih418-b2264.dts +5 -0
+		led-green {
+			gpios = <&pio1 3 GPIO_ACTIVE_HIGH>;
+			default-state = "off";
 		};
+	};
 
+	soc {
 		pin-controller-sbc@961f080 {
 			gmac1 {
 				rgmii1-0 {

Applied on sti-next

Thanks
Patrice

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

maintainer
#7 lore raw

Re: [PATCH 2/3] ARM: dts: st: move leds out of soc in stih418-b2264.dts

Quoted 35 lines · Patrice CHOTARD
Quoted 32 lines · Alain Volmat

Move the leds node out of the soc section
and correct the following warning:
Warning (simple_bus_reg): /soc/leds: missing or empty reg/ranges property

---
 arch/arm/boot/dts/st/stih418-b2264.dts | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)
arch/arm/boot/dts/st/stih418-b2264.dts +6 -7
index f496ca28850d..d4874282cfba 100644
@@ -73,15 +73,15 @@ aliases {
 		ethernet0 = &ethernet0;
 	};
 
-	soc {
-		leds {
-			compatible = "gpio-leds";
-			led-green {
-				gpios = <&pio1 3 GPIO_ACTIVE_HIGH>;
-				default-state = "off";
-			};
+	leds {
+		compatible = "gpio-leds";
+		led-green {
+			gpios = <&pio1 3 GPIO_ACTIVE_HIGH>;
+			default-state = "off";
 		};
+	};
 
Quoted 8 lines

arch/arm/boot/dts/st/stih418-b2264.dts aliases { · line 87

Quoted 4 lines
arch/arm/boot/dts/st/stih418-b2264.dts +1 -0
+	soc {
 		pin-controller-sbc@961f080 {
 			gmac1 {
 				rgmii1-0 {

Applied on sti-next

Thanks
Patrice

Applied on sti-next

Thanks
Patrice

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#8 lore raw

PATCH 3/3 ARM: dts: st: correct led level in stih418-b2264.dts

In reply to Alain Volmat

The state of the green led on the stih418-b2264 is currently inverted. Correct this by fixing the GPIO active state.

---
 arch/arm/boot/dts/st/stih418-b2264.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/st/stih418-b2264.dts +1 -1
index d4874282cfba..fdc16e9f5822 100644
@@ -76,7 +76,7 @@ aliases {
 	leds {
 		compatible = "gpio-leds";
 		led-green {
-			gpios = <&pio1 3 GPIO_ACTIVE_HIGH>;
+			gpios = <&pio1 3 GPIO_ACTIVE_LOW>;
 			default-state = "off";
 		};
 	};
Signature · 7 lines
2.34.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
maintainer Acked-by on v1 3/3
#9 lore raw

Re: [PATCH 3/3] ARM: dts: st: correct led level in stih418-b2264.dts

Quoted 13 lines · Alain Volmat

The state of the green led on the stih418-b2264 is currently inverted. Correct this by fixing the GPIO active state.

---
 arch/arm/boot/dts/st/stih418-b2264.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/st/stih418-b2264.dts +0 -0
index d4874282cfba..fdc16e9f5822 100644

arch/arm/boot/dts/st/stih418-b2264.dts aliases { · line 82

Quoted 8 lines
arch/arm/boot/dts/st/stih418-b2264.dts +1 -1
@@ -76,7 +76,7 @@ aliases {
 	leds {
 		compatible = "gpio-leds";
 		led-green {
-			gpios = <&pio1 3 GPIO_ACTIVE_HIGH>;
+			gpios = <&pio1 3 GPIO_ACTIVE_LOW>;
 			default-state = "off";
 		};
 	};

Thanks
Patrice

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel