Skip to contentSkip to conversation

gn: Disable warning as error but not disable completely

PATCH Applied Khem Raj 2 participants 2 messages Jul 3, 2023

lore
Share & tools
lore

Khem Raj

author
#0 lore raw

PATCH 1/1 gn: Disable warning as error but not disable completely

This will still emit the diagnostic but it wont break the build, additionally pass it to CXXFLAGS since thats the right subset to disable it for.

---
 meta-arm/recipes-devtools/gn/gn_git.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta-arm/recipes-devtools/gn/gn_git.bb +1 -1
index 3713787a..4b021bbe 100644
@@ -16,7 +16,7 @@ B = "${WORKDIR}/build"
 # ../git/src/gn/desc_builder.cc: In member function 'base::Value {anonymous}::BaseDescBuilder::ToBaseValue(const Scope*)':
 # ../git/src/gn/desc_builder.cc:179:21: error: redundant move in return statement [-Werror=redundant-move]
 #   179 |     return std::move(res);
-CFLAGS:append = " -Wno-redundant-move"
+CXXFLAGS += "-Wno-error=redundant-move"
 
 # Map from our _OS strings to the GN's platform values.
 def gn_platform(variable, d):
Signature · 1 line
2.41.0
Applied
#1 lore raw
Quoted 3 lines · Khem Raj

This will still emit the diagnostic but it wont break the build, additionally pass it to CXXFLAGS since thats the right subset to disable it for.

Applied, thanks!

[1/1] gn: Disable warning as error but not disable completely

      commit: fa02cad2dae68e07e4c62a2df0ac5e247207e9ca

Best regards,

Signature · 1 line
Jon Mason <[email protected]>