Skip to contentSkip to conversation

x86/xen: fix secondary processor fpu initialization

PATCH Applied Juergen Gross 3 participants 4 messages Jul 3, 2023 – Jul 5, 2023

Subsystems (2)
lore
Share & tools
lore

Juergen Gross

author maintainer
#0 lore raw

PATCH 1/1 x86/xen: fix secondary processor fpu initialization

Moving the call of fpu__init_cpu() from cpu_init() to start_secondary() broke Xen PV guests, as those don't call start_secondary() for APs.

Fix that by adding the call of fpu__init_cpu() to cpu_bringup(), which is the Xen PV replacement of start_secondary().

Fixes b81fac906a8f ("x86/fpu: Move FPU initialization into arch_cpu_finalize_init()")
---
 arch/x86/xen/smp_pv.c | 1 +
 1 file changed, 1 insertion(+)
arch/x86/xen/smp_pv.c +1 -0
index d5ae5de2daa2..cef78b8c89f4 100644
@@ -63,6 +63,7 @@ static void cpu_bringup(void)
 	cr4_init();
 	cpuhp_ap_sync_alive();
 	cpu_init();
+	fpu__init_cpu();
 	touch_softlockup_watchdog();
 
 	/* PVH runs in ring 0 and allows us to do native syscalls. Yay! */
Signature · 1 line
2.35.3
reviewer Reviewed-by on v1 1/1
#1 lore raw
Quoted 8 lines · Juergen Gross

Moving the call of fpu__init_cpu() from cpu_init() to start_secondary() broke Xen PV guests, as those don't call start_secondary() for APs.

Fix that by adding the call of fpu__init_cpu() to cpu_bringup(), which is the Xen PV replacement of start_secondary().

Fixes b81fac906a8f ("x86/fpu: Move FPU initialization into arch_cpu_finalize_init()")
author maintainer
#2 lore raw
Quoted 6 lines · Boris Ostrovsky
Quoted 3 lines · Juergen Gross

Moving the call of fpu__init_cpu() from cpu_init() to start_secondary() broke Xen PV guests, as those don't call start_secondary() for APs.

Quoted 9 lines
Quoted 5 lines

Fix that by adding the call of fpu__init_cpu() to cpu_bringup(), which is the Xen PV replacement of start_secondary().

Fixes b81fac906a8f ("x86/fpu: Move FPU initialization into arch_cpu_finalize_init()")

x86 maintainers, could this please go through the tip tree? The patch is depending on other 6.5 patches which went in via tip.

Juergen

merge bot Applied
#3 lore raw

[tip: x86/urgent] x86/xen: Fix secondary processors' FPU initialization

In reply to Juergen Gross
The following commit has been merged into the x86/urgent branch of tip:

The following commit has been merged into the x86/urgent branch of tip:

Commit-ID:     fe3e0a13e597c1c8617814bf9b42ab732db5c26e
Gitweb:        https://git.kernel.org/tip/fe3e0a13e597c1c8617814bf9b42ab732db5c26e
Author:        Juergen Gross <[email protected]>
AuthorDate:    Mon, 03 Jul 2023 15:00:32 +02:00
Committer:     Borislav Petkov (AMD) <[email protected]>
CommitterDate: Wed, 05 Jul 2023 11:44:16 +02:00

x86/xen: Fix secondary processors' FPU initialization

Moving the call of fpu__init_cpu() from cpu_init() to start_secondary() broke Xen PV guests, as those don't call start_secondary() for APs.

Call fpu__init_cpu() in Xen's cpu_bringup(), which is the Xen PV replacement of start_secondary().

Fixes b81fac906a8f ("x86/fpu: Move FPU initialization into arch_cpu_finalize_init()")
---
 arch/x86/xen/smp_pv.c | 1 +
 1 file changed, 1 insertion(+)
arch/x86/xen/smp_pv.c +1 -0
index a9cf8c8..0b6efc4 100644
@@ -63,6 +63,7 @@ static void cpu_bringup(void)
 
 	cr4_init();
 	cpu_init();
+	fpu__init_cpu();
 	touch_softlockup_watchdog();
 
 	/* PVH runs in ring 0 and allows us to do native syscalls. Yay! */