xen/sysctl: Correct comments after renaming xen_sysctl_cpu_policy fields
PATCH 1/1 xen/sysctl: Correct comments after renaming xen_sysctl_cpu_policy fields
Fixes 21e3ef57e040 ("x86: Rename {domctl,sysctl}.cpu_policy.{cpuid,msr}_policy fields")
Signed-off-by Andrew Cooper <[email protected]>
---
CC: Jan Beulich <[email protected]>
CC: Roger Pau Monné <[email protected]>
CC: Wei Liu <[email protected]>
--- xen/include/public/sysctl.h | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
xen/include/public/sysctl.h +6 -6
@@ -1047,12 +1047,12 @@ struct xen_sysctl_cpu_policy {#define XEN_SYSCTL_cpu_policy_pv_default 4#define XEN_SYSCTL_cpu_policy_hvm_default 5uint32_t index;/* IN: Which policy to query? */ -uint32_t nr_leaves;/* IN/OUT: Number of leaves in/written to -* 'cpuid_policy', or the maximum number of leaves -* if the guest handle is NULL. */ -uint32_t nr_msrs;/* IN/OUT: Number of MSRs in/written to -* 'msr_policy', or the maximum number of MSRs if -* the guest handle is NULL. */ +uint32_t nr_leaves;/* IN/OUT: Number of leaves in/written to 'leaves', +* or the maximum number of leaves if the guest +* handle is NULL. */ +uint32_t nr_msrs;/* IN/OUT: Number of MSRs in/written to 'msrs', or +* the maximum number of MSRs if the guest handle is +* NULL. */ uint32_t _rsvd;/* Must be zero. */ XEN_GUEST_HANDLE_64 (xen_cpuid_leaf_t) leaves;/* OUT */ XEN_GUEST_HANDLE_64 (xen_msr_entry_t) msrs;/* OUT */
Signature · 1 line
2.30.2
Quoted 2 lines · Andrew Cooper
Fixes 21e3ef57e040 ("x86: Rename {domctl,sysctl}.cpu_policy.{cpuid,msr}_policy fields")Signed-off-by Andrew Cooper <[email protected]>
Reviewed-by Roger Pau Monné <[email protected]>
Thanks.
Quoted 4 lines · Roger Pau Monné
Quoted 2 lines · Andrew Cooper
Fixes 21e3ef57e040 ("x86: Rename {domctl,sysctl}.cpu_policy.{cpuid,msr}_policy fields")Signed-off-by Andrew Cooper <[email protected]>Reviewed-by Roger Pau Monné <[email protected]>
Thanks, but I've just noticed that domctl needs the same adjustment.
The Fixes tag ought to have been a clue...
~Andrew
PATCH v2 1/1 xen: Correct comments after renaming xen_{dom,sys}ctl_cpu_policy fields
In reply to Andrew CooperFixes 21e3ef57e040 ("x86: Rename {domctl,sysctl}.cpu_policy.{cpuid,msr}_policy fields")
Signed-off-by Andrew Cooper <[email protected]>
---
CC: Jan Beulich <[email protected]>
CC: Roger Pau Monné <[email protected]>
CC: Wei Liu <[email protected]>
v2:
* Fix domctl too.
--- xen/include/public/domctl.h | 6 ++---- xen/include/public/sysctl.h | 10 ++++------ 2 files changed, 6 insertions(+), 10 deletions(-)
xen/include/public/domctl.h +2 -4
@@ -679,10 +679,8 @@ struct xen_domctl_set_target {* Query or set the CPUID and MSR policies for a specific domain. */ struct xen_domctl_cpu_policy { -uint32_t nr_leaves;/* IN/OUT: Number of leaves in/written to -* 'cpuid_policy'. */ -uint32_t nr_msrs;/* IN/OUT: Number of MSRs in/written to -* 'msr_policy' */ +uint32_t nr_leaves;/* IN/OUT: Number of leaves in/written to 'leaves' */ +uint32_t nr_msrs;/* IN/OUT: Number of MSRs in/written to 'msrs' */ XEN_GUEST_HANDLE_64 (xen_cpuid_leaf_t) leaves;/* IN/OUT */ XEN_GUEST_HANDLE_64 (xen_msr_entry_t) msrs;/* IN/OUT */
xen/include/public/sysctl.h +4 -6
@@ -1047,12 +1047,10 @@ struct xen_sysctl_cpu_policy {#define XEN_SYSCTL_cpu_policy_pv_default 4#define XEN_SYSCTL_cpu_policy_hvm_default 5uint32_t index;/* IN: Which policy to query? */ -uint32_t nr_leaves;/* IN/OUT: Number of leaves in/written to -* 'cpuid_policy', or the maximum number of leaves -* if the guest handle is NULL. */ -uint32_t nr_msrs;/* IN/OUT: Number of MSRs in/written to -* 'msr_policy', or the maximum number of MSRs if -* the guest handle is NULL. */ +uint32_t nr_leaves;/* IN/OUT: Number of leaves in/written to 'leaves', +* or the max number if 'leaves' is NULL. */ +uint32_t nr_msrs;/* IN/OUT: Number of MSRs in/written to 'msrs', or +* the max number of if 'msrs' is NULL. */ uint32_t _rsvd;/* Must be zero. */ XEN_GUEST_HANDLE_64 (xen_cpuid_leaf_t) leaves;/* OUT */ XEN_GUEST_HANDLE_64 (xen_msr_entry_t) msrs;/* OUT */
Signature · 1 line
2.30.2
Re: [PATCH v2] xen: Correct comments after renaming xen_{dom,sys}ctl_cpu_policy fields
Quoted 2 lines · Andrew Cooper
Fixes 21e3ef57e040 ("x86: Rename {domctl,sysctl}.cpu_policy.{cpuid,msr}_policy fields")Signed-off-by Andrew Cooper <[email protected]>
Reviewed-by Roger Pau Monné <[email protected]>
Thanks, Roger.