Skip to contentSkip to conversation

infiniband: irdma: Remove a duplicate assignment in irdma_query_ah()

PATCH Applied Minjie Du 3 participants 3 messages Jul 6, 2023 – Jul 12, 2023

Subsystems (2)
lore
Share & tools
lore

Minjie Du

author
#0 lore raw

PATCH 1/1 infiniband: irdma: Remove a duplicate assignment in irdma_query_ah()

Delete a duplicate statement from this function implementation.

---
 drivers/infiniband/hw/irdma/verbs.c | 1 -
 1 file changed, 1 deletion(-)
drivers/infiniband/hw/irdma/verbs.c +0 -1
index 9c4fe4fa9..a8326a95d 100644
@@ -4424,7 +4424,6 @@ static int irdma_query_ah(struct ib_ah *ibah, struct rdma_ah_attr *ah_attr)
 		ah_attr->grh.traffic_class = ah->sc_ah.ah_info.tc_tos;
 		ah_attr->grh.hop_limit = ah->sc_ah.ah_info.hop_ttl;
 		ah_attr->grh.sgid_index = ah->sgid_index;
-		ah_attr->grh.sgid_index = ah->sgid_index;
 		memcpy(&ah_attr->grh.dgid, &ah->dgid,
 		       sizeof(ah_attr->grh.dgid));
 	}
Signature · 1 line
2.39.0
#1 lore raw
Quoted 2 lines · Minjie Du

Delete a duplicate statement from this function implementation.

Please add "Fixes ".

Zhu Yanjun

Quoted 17 lines
---
  drivers/infiniband/hw/irdma/verbs.c | 1 -
  1 file changed, 1 deletion(-)
drivers/infiniband/hw/irdma/verbs.c +0 -1
index 9c4fe4fa9..a8326a95d 100644
@@ -4424,7 +4424,6 @@ static int irdma_query_ah(struct ib_ah *ibah, struct rdma_ah_attr *ah_attr)
  		ah_attr->grh.traffic_class = ah->sc_ah.ah_info.tc_tos;
  		ah_attr->grh.hop_limit = ah->sc_ah.ah_info.hop_ttl;
  		ah_attr->grh.sgid_index = ah->sgid_index;
-		ah_attr->grh.sgid_index = ah->sgid_index;
  		memcpy(&ah_attr->grh.dgid, &ah->dgid,
  		       sizeof(ah_attr->grh.dgid));
  	}