Skip to contentSkip to conversation

backport reproducible build selftest user-facing settings

PATCH In review [email protected] 2 participants 4 messages Jul 6, 2023

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 backport reproducible build selftest user-facing settings

Hi Steve!

Please consider backporting these patches:

[kirkstone][PATCH 1/2] selftest reproducible.py: support different [kirkstone][PATCH 2/2] selftest/reproducible: Allow chose the package

For the autobuilder they are a no-op, but for users adopting the reproducible selftest, these are very important settings to expose.

Best,
Jan-Simon

#1 lore raw

PATCH 1/2 selftest reproducible.py: support different build targets

From: Mikko Rapeli <[email protected]>

Allow users to set different build reproducibility targets than the defaults using OEQA_REPRODUCIBLE_TEST_TARGET and OEQA_REPRODUCIBLE_TEST_SSTATE_TARGETS variables in local.conf.

Fixing all issues from "world" builds is not possible in some complex build environments with lots of layers. Limiting the focus to a smaller subset allows using this test to detect and fix build reproduction issues incrementally.

(cherry picked from commit c66bebbce5995e386a1a4d055a914a39b6ee518d)
---
 meta/lib/oeqa/selftest/cases/reproducible.py | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)
meta/lib/oeqa/selftest/cases/reproducible.py +6 -2
index 2c9bc0bf90..98259ae515 100644
@@ -132,9 +132,13 @@ class ReproducibleTests(OESelftestTestCase):
     max_report_size = 250 * 1024 * 1024
 
     # targets are the things we want to test the reproducibility of
-    targets = ['core-image-minimal', 'core-image-sato', 'core-image-full-cmdline', 'core-image-weston', 'world']
+    targets = get_bb_var("OEQA_REPRODUCIBLE_TEST_TARGET")
+    if targets:
+        targets = targets.split()
+    else:
+        targets = ['core-image-minimal', 'core-image-sato', 'core-image-full-cmdline', 'core-image-weston', 'world']
     # sstate targets are things to pull from sstate to potentially cut build/debugging time
-    sstate_targets = []
+    sstate_targets = (get_bb_var("OEQA_REPRODUCIBLE_TEST_SSTATE_TARGETS") or "").split()
     save_results = False
     if 'OEQA_DEBUGGING_SAVED_OUTPUT' in os.environ:
         save_results = os.environ['OEQA_DEBUGGING_SAVED_OUTPUT']

--
2.41.0

#2 lore raw

PATCH 2/2 selftest/reproducible: Allow chose the package manager

In reply to [email protected]

From: Jose Quaresma <[email protected]>

This is a follow-up of 76e5fcb2 that also allow users to chose the package manager using OEQA_REPRODUCIBLE_TEST_PACKAGE

(cherry picked from commit 3d414d85b44077bac57aba36707b0fc699a73e97)
---
 meta/lib/oeqa/selftest/cases/reproducible.py | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
meta/lib/oeqa/selftest/cases/reproducible.py +5 -1
index 98259ae515..49318be43a 100644
@@ -126,7 +126,11 @@ class DiffoscopeTests(OESelftestTestCase):
 class ReproducibleTests(OESelftestTestCase):
     # Test the reproducibility of whatever is built between sstate_targets and targets
 
-    package_classes = ['deb', 'ipk', 'rpm']
+    package_classes = get_bb_var("OEQA_REPRODUCIBLE_TEST_PACKAGE")
+    if package_classes:
+        package_classes = package_classes.split()
+    else:
+        package_classes = ['deb', 'ipk', 'rpm']
 
     # Maximum report size, in bytes
     max_report_size = 250 * 1024 * 1024

--
2.41.0

#3 lore raw
In reply to [email protected]

Hi,

I would be very happy if that were possible, currently I can only test using the master branch.

Jose

Jan-Simon Möller <[email protected]> escreveu no dia quinta, 6/07/2023 à(s) 14:03:

Quoted 27 lines

Hi Steve!

Please consider backporting these patches:

[kirkstone][PATCH 1/2] selftest reproducible.py: support different [kirkstone][PATCH 2/2] selftest/reproducible: Allow chose the package

For the autobuilder they are a no-op, but for users adopting the reproducible selftest, these are very important settings to expose.

Best,
Jan-Simon

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group. View/Reply Online (#183940):
https://lists.openembedded.org/g/openembedded-core/message/183940
Mute This Topic: https://lists.openembedded.org/mt/99984920/5052612
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [ [email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Signature · 3 lines
Best regards,

José Quaresma