Skip to contentSkip to conversation

setsebool: drop unnecessary linking against libsepol

PATCH In review Christian Göttsche 2 participants 3 messages Jul 6, 2023 – Aug 4, 2023 SELinux security module

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 setsebool: drop unnecessary linking against libsepol

setsebool does not directly use any symbols from libsepol. Any transitional ones, via libsemanage, are available by linking against libsemanage.

---
 policycoreutils/setsebool/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
policycoreutils/setsebool/Makefile +1 -1
index 4b55046c..c1440c1c 100644
@@ -6,7 +6,7 @@ MANDIR = $(PREFIX)/share/man
 BASHCOMPLETIONDIR ?= $(PREFIX)/share/bash-completion/completions
 
 CFLAGS ?= -Werror -Wall -W
-override LDLIBS += -lsepol -lselinux -lsemanage
+override LDLIBS += -lselinux -lsemanage
 SETSEBOOL_OBJS = setsebool.o
 
 BASHCOMPLETIONS=setsebool-bash-completion.sh 
Signature · 1 line
2.40.1
Acked-by on v1 1/1
#1 lore raw
Quoted 6 lines · Christian Göttsche

setsebool does not directly use any symbols from libsepol. Any transitional ones, via libsemanage, are available by linking against libsemanage.

Quoted 20 lines
---
 policycoreutils/setsebool/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
policycoreutils/setsebool/Makefile +1 -2
index 4b55046c..c1440c1c 100644
@@ -6,7 +6,7 @@ MANDIR = $(PREFIX)/share/man
 BASHCOMPLETIONDIR ?= $(PREFIX)/share/bash-completion/completions
 
 CFLAGS ?= -Werror -Wall -W
-override LDLIBS += -lsepol -lselinux -lsemanage
+override LDLIBS += -lselinux -lsemanage
 SETSEBOOL_OBJS = setsebool.o
 
 BASHCOMPLETIONS=setsebool-bash-completion.sh
--

2.40.1

#2 lore raw
Quoted 4 lines · James Carter
Quoted 1 line · Christian Göttsche
Quoted 8 lines
Quoted 5 lines

setsebool does not directly use any symbols from libsepol. Any transitional ones, via libsemanage, are available by linking against libsemanage.

Merged.
Thanks,
Jim

Quoted 20 lines
Quoted 20 lines
---
 policycoreutils/setsebool/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
policycoreutils/setsebool/Makefile +1 -2
index 4b55046c..c1440c1c 100644
@@ -6,7 +6,7 @@ MANDIR = $(PREFIX)/share/man
 BASHCOMPLETIONDIR ?= $(PREFIX)/share/bash-completion/completions
 
 CFLAGS ?= -Werror -Wall -W
-override LDLIBS += -lsepol -lselinux -lsemanage
+override LDLIBS += -lselinux -lsemanage
 SETSEBOOL_OBJS = setsebool.o
 
 BASHCOMPLETIONS=setsebool-bash-completion.sh
--

2.40.1