Intel Hardware P-States (HWP) support
v5 cover Intel Hardware P-States (HWP) support
Hi,
This patch series adds Hardware-Controlled Performance States (HWP) for Intel processors to Xen.
v2 was only partially reviewed, so v3 is mostly a reposting of v2. In v2 & v3, I think I addressed all comments for v1. I kept patch 11 "xenpm:
Factor out a non-fatal cpuid_parse variant", with a v2 comment explaining why I keep it.
v3 adds "xen/x86: Tweak PDC bits when using HWP". Qubes testing revealed an issue where enabling HWP can crash firwmare code (maybe SMM). This requires a Linux change to get the PDC bits from Xen and pass them to ACPI. Roger has a patch [0] to set the PDC bits. Roger's 3 patch series was tested with "xen/x86: Tweak PDC bits when using HWP" on affected hardware and allowed proper operation.
v4:
There is a large amount or renaming from HWP/hwp to CPPC/cppc in the series. The driver remains hwp_ prefixed since it is dealing with the hardware interface. The sysctl, xc and xenpm interfaces were renamed to cppc to be the generic ACPI CPPC (Collaborative Processor Performance Control) interface.
struct xen_get_cpufreq_para was re-organized in a binary compatible fashion to nest scaling governor options. This allows the cppc support to use uint32_t's for its parameters.
HWP is now enabled with a top-level cpufreq=hwp option. It will fallback to cpufreq=xen if hwp is unavailable. This seems like the most user-friendly option. Since the user was trying to specify *some* cpufreq, we should give them the best that we can instead of disabling the functionality.
"xenpm: Factor out a non-fatal cpuid_parse variant" was dropped. set-cpufreq-cppc expects either a cpu number or none specified, which implies all.
Some patches were re-arrange - "xen/x86: Tweak PDC bits when using HWP" now comes immediately after "cpufreq: Add Hardware P-State (HWP) driver"
The implementation of "cpufreq: Allow restricting to internal governors only " changed, so I removed Jan's Ack.
v5:
HWP is enabled with a toplevel cpufreq=hwp option. There is no fallback by default, but a cpufreq=hwp;xen syntax is now supported. That tries hwp first. If HWP registration is unsuccessful, then xen registration is performed as a fallback.
More changes from Jan's feedback. They are typically minor and documented in individual patches.
Previous cover letter:
With HWP, the processor makes its own determinations for frequency selection, though users can set some parameters and preferences. There is also Turbo Boost which dynamically pushes the max frequency if possible.
The existing governors don't work with HWP since they select frequencies and HWP doesn't expose those. Therefore a dummy hwp-interal governor is used that doesn't do anything.
xenpm get-cpufreq-para is extended to show HWP parameters, and set-cpufreq-cppc is added to set them.
A lightly loaded OpenXT laptop showed ~1W power savings according to powertop. A mostly idle Fedora system (dom0 only) showed a more modest power savings.
This is for a 10th gen 6-core 1600 MHz base 4900 MHZ max cpu. In the default balance mode, Turbo Boost doesn't exceed 4GHz. Tweaking the energy_perf preference with xenpm set-cpufreq-para balance ene:64, I've seen the CPU hit 4.7GHz before throttling down and bouncing around between 4.3 and 4.5 GHz. Curiously the other cores read ~4GHz when turbo boost takes affect. This was done after pinning all dom0 cores, and using taskset to pin to vCPU/pCPU 11 and running a bash tightloop.
HWP defaults to disabled and running with the existing HWP configuration
- it doesn't reconfigure by default. It can be enabled with cpufreq=hwp.
Hardware Duty Cycling (HDC) is another feature to autonomously powerdown things. It defaults to enabled when HWP is enabled, but HDC can be disabled on the command line. cpufreq=xen:hwp,no-hdc
I've only tested on 8th gen and 10th gen systems with activity window and energy_perf support. So the pathes for CPUs lacking those features are untested.
Fast MSR support was removed in v2. The model specific checking was not done properly, and I don't have hardware to test with. Since writes are expected to be infrequent, I just removed the code.
This changes the systcl_pm_op hypercall, so that wants review.
Regards,
Jason
[0] https://lore.kernel.org/xen-devel/[email protected]/
Jason Andryuk (15):
cpufreq: Allow restricting to internal governors only
cpufreq: Add perf_freq to cpuinfo
cpufreq: Export intel_feature_detect xen/sysctl: Nest cpufreq scaling options pmstat&xenpm: Re-arrage for cpufreq union
cpufreq: Add Hardware P-State (HWP) driver xen/x86: Tweak PDC bits when using HWP
xenpm: Change get-cpufreq-para output for hwp
cpufreq: Export HWP parameters to userspace as CPPC
libxc: Include cppc_para in definitions
xenpm: Print HWP/CPPC parameters
xen: Add SET_CPUFREQ_HWP xen_sysctl_pm_op
libxc: Add xc_set_cpufreq_cppc
xenpm: Add set-cpufreq-cppc subcommand
CHANGELOG: Add Intel HWP entry
CHANGELOG.md | 2 +- docs/misc/xen-command-line.pandoc | 18 +- tools/include/xenctrl.h | 28 +- tools/libs/ctrl/xc_pm.c | 42 +- tools/misc/xenpm.c | 392 +++++++++-- xen/arch/x86/acpi/cpufreq/Makefile | 1 + xen/arch/x86/acpi/cpufreq/cpufreq.c | 29 +- xen/arch/x86/acpi/cpufreq/hwp.c | 646 +++++++++++++++++++ xen/arch/x86/acpi/lib.c | 5 + xen/arch/x86/cpu/mcheck/mce_intel.c | 6 + xen/arch/x86/include/asm/cpufeature.h | 12 +- xen/arch/x86/include/asm/msr-index.h | 16 +- xen/drivers/acpi/pmstat.c | 100 +-- xen/drivers/cpufreq/cpufreq.c | 56 +- xen/drivers/cpufreq/cpufreq_misc_governors.c | 9 + xen/drivers/cpufreq/cpufreq_ondemand.c | 3 + xen/drivers/cpufreq/utility.c | 1 + xen/include/acpi/cpufreq/cpufreq.h | 21 + xen/include/acpi/pdc_intel.h | 1 + xen/include/public/sysctl.h | 144 ++++- 20 files changed, 1411 insertions(+), 121 deletions(-) create mode 100644 xen/arch/x86/acpi/cpufreq/hwp.c
Signature · 1 line
2.41.0
PATCH v5 1/15 cpufreq: Allow restricting to internal governors only
For hwp, the standard governors are not usable, and only the internal one is applicable. Add the cpufreq_governor_internal boolean to indicate when an internal governor, like hwp, will be used. This is set during presmp_initcall, and governor registration can be skipped when called during initcall.
This way unusable governors are not registered, and only compatible governors are advertised to userspace.
---
v5:
Check cpufreq_governor_internal and skip registration as applicable Remove internal flag
v4:
Rework to use an internal flag
Removed Jan's Ack since the approach is different.
v3:
Switch to initdata
Add Jan Acked-by
Commit message s/they/the/ typo
Don't register hwp-internal when running non-hwp - Marek
v2:
Switch to "-internal"
Add blank line in header
--- xen/drivers/cpufreq/cpufreq.c | 1 + xen/drivers/cpufreq/cpufreq_misc_governors.c | 9 +++++++++ xen/drivers/cpufreq/cpufreq_ondemand.c | 3 +++ xen/include/acpi/cpufreq/cpufreq.h | 2 ++ 4 files changed, 15 insertions(+)
xen/drivers/cpufreq/cpufreq.c +1 -0
@@ -56,6 +56,7 @@ struct cpufreq_dom { };static LIST_HEAD_READ_MOSTLY (cpufreq_dom_list_head); +bool __initdata cpufreq_governor_internal;struct cpufreq_governor *__read_mostly cpufreq_opt_governor;LIST_HEAD_READ_MOSTLY (cpufreq_governor_list);
xen/drivers/cpufreq/cpufreq_misc_governors.c +9 -0
@@ -120,6 +120,9 @@ static int __init cf_check cpufreq_gov_userspace_init(void) {unsigned int cpu; +if ( cpufreq_governor_internal ) +return 0 ; +for_each_online_cpu (cpu)per_cpu (cpu_set_freq, cpu) = userspace_cmdline_freq;register_cpu_notifier (&cpufreq_userspace_cpu_nfb);
@@ -162,6 +165,9 @@ struct cpufreq_governor cpufreq_gov_performance = { static int __init cf_check cpufreq_gov_performance_init(void) { +if ( cpufreq_governor_internal ) +return 0 ; +return cpufreq_register_governor (&cpufreq_gov_performance); }__initcall (cpufreq_gov_performance_init);
@@ -201,6 +207,9 @@ struct cpufreq_governor cpufreq_gov_powersave = { static int __init cf_check cpufreq_gov_powersave_init(void) { +if ( cpufreq_governor_internal ) +return 0 ; +return cpufreq_register_governor (&cpufreq_gov_powersave); }__initcall (cpufreq_gov_powersave_init);
xen/drivers/cpufreq/cpufreq_ondemand.c +3 -0
@@ -360,6 +360,9 @@ struct cpufreq_governor cpufreq_gov_dbs = { static int __init cf_check cpufreq_gov_dbs_init(void) { +if ( cpufreq_governor_internal ) +return 0 ; +return cpufreq_register_governor (&cpufreq_gov_dbs); }__initcall (cpufreq_gov_dbs_init);
xen/include/acpi/cpufreq/cpufreq.h +2 -0
@@ -116,6 +116,8 @@ extern struct cpufreq_governor cpufreq_gov_powersave;extern struct list_head cpufreq_governor_list; +extern bool cpufreq_governor_internal; +extern int cpufreq_register_governor (struct cpufreq_governor *governor);extern struct cpufreq_governor *__find_governor (const char *governor);#define CPUFREQ_DEFAULT_GOVERNOR &cpufreq_gov_dbs
Signature · 1 line
2.41.0
Re: [PATCH v5 01/15] cpufreq: Allow restricting to internal governors only
Quoted 10 lines · Jason Andryuk
For hwp, the standard governors are not usable, and only the internal one is applicable. Add the
cpufreq_governor_internalboolean to indicate when an internal governor, like hwp, will be used. This is set duringpresmp_initcall, and governor registration can be skipped when called during initcall.This way unusable governors are not registered, and only compatible governors are advertised to userspace.
Signed-off-by Jason Andryuk <[email protected]>
PATCH v5 2/15 cpufreq: Add perf_freq to cpuinfo
In reply to Jason Andryukacpi-cpufreq scales the aperf/mperf measurements by max_freq, but HWP needs to scale by base frequency. Settings max_freq to base_freq "works" but the code is not obvious, and returning values to userspace is tricky. Add an additonal perf_freq member which is used for scaling aperf/mperf measurements.
---
v3:
Add Jan's Ack
I don't like this, but it seems the best way to re-use the common aperf/mperf code. The other option would be to add wrappers that then do the acpi vs. hwp scaling.
--- xen/arch/x86/acpi/cpufreq/cpufreq.c | 2 +- xen/drivers/cpufreq/utility.c | 1 + xen/include/acpi/cpufreq/cpufreq.h | 3 +++ 3 files changed, 5 insertions(+), 1 deletion(-)
xen/arch/x86/acpi/cpufreq/cpufreq.c +1 -1
@@ -316,7 +316,7 @@ unsigned int get_measured_perf(unsigned int cpu, unsigned int flag)else perf_percent =0 ; -return policy->cpuinfo.max_freq * perf_percent /100 ; +return policy->cpuinfo.perf_freq * perf_percent /100 ; } static unsigned int cf_check get_cur_freq_on_cpu(unsigned int cpu)
xen/drivers/cpufreq/utility.c +1 -0
@@ -236,6 +236,7 @@ int cpufreq_frequency_table_cpuinfo(struct cpufreq_policy *policy, policy->min = policy->cpuinfo.min_freq = min_freq; policy->max = policy->cpuinfo.max_freq = max_freq; + policy->cpuinfo.perf_freq = max_freq; policy->cpuinfo.second_max_freq = second_max_freq;if (policy->min == ~0 )
xen/include/acpi/cpufreq/cpufreq.h +3 -0
@@ -37,6 +37,9 @@ extern struct acpi_cpufreq_data *cpufreq_drv_data[NR_CPUS];struct cpufreq_cpuinfo {unsigned int max_freq;unsigned int second_max_freq;/* P1 if Turbo Mode is on */ +unsigned int perf_freq;/* Scaling freq for aperf/mpref. +acpi-cpufreq uses max_freq, but HWP uses +base_freq.*/ unsigned int min_freq;unsigned int transition_latency;/* in 10^(-9) s = nanoseconds */ };
Signature · 1 line
2.41.0
PATCH v5 3/15 cpufreq: Export intel_feature_detect
In reply to Jason AndryukExport feature_detect as intel_feature_detect so it can be re-used by HWP.
---
v4:
Add Jan's Ack
v3:
Remove void * cast when calling intel_feature_detect
v2:
export intel_feature_detect with typed pointer
Move intel_feature_detect to acpi/cpufreq/cpufreq.h since the declaration now contains struct cpufreq_policy *.
--- xen/arch/x86/acpi/cpufreq/cpufreq.c | 8 ++++++-- xen/include/acpi/cpufreq/cpufreq.h | 2 ++ 2 files changed, 8 insertions(+), 2 deletions(-)
xen/arch/x86/acpi/cpufreq/cpufreq.c +6 -2
@@ -339,9 +339,8 @@ static unsigned int cf_check get_cur_freq_on_cpu(unsigned int cpu)return extract_freq (get_cur_val (cpumask_of (cpu)), data); } -static void cf_check feature_detect(void *info) +void intel_feature_detect (struct cpufreq_policy *policy) { -struct cpufreq_policy *policy = info;unsigned int eax; eax =cpuid_eax (6 );
@@ -353,6 +352,11 @@ static void cf_check feature_detect(void *info) } } +static void cf_check feature_detect(void *info) +{ +intel_feature_detect (info); +} +static unsigned int check_freqs (const cpumask_t *mask,unsigned int freq,struct acpi_cpufreq_data *data) {
xen/include/acpi/cpufreq/cpufreq.h +2 -0
@@ -243,4 +243,6 @@ int write_userspace_scaling_setspeed(unsigned int cpu, unsigned int freq);void cpufreq_dbs_timer_suspend (void );void cpufreq_dbs_timer_resume (void ); +void intel_feature_detect (struct cpufreq_policy *policy); +#endif /* __XEN_CPUFREQ_PM_H__ */
Signature · 1 line
2.41.0
PATCH v5 4/15 xen/sysctl: Nest cpufreq scaling options
In reply to Jason AndryukAdd a union and struct so that most of the scaling variables of struct xen_get_cpufreq_para are within in a binary-compatible layout. This allows cppc_para to live in the larger union and use uint32_ts - struct xen_cppc_para will be 10 uint32_t's.
The new scaling struct is 3 * uint32_t + 16 bytes CPUFREQ_NAME_LEN + 4 * uint32_t for xen_ondemand = 11 uint32_t. That means the old size is retained, int32_t turbo_enabled doesn't move and it's binary compatible.
The out-of-context memcpy() in xc_get_cpufreq_para() now handles the copying of the fields removed there.
---
v5:
Expand commit message
Change comment to driver/governor
--- tools/include/xenctrl.h | 22 +++++++++++++--------- tools/libs/ctrl/xc_pm.c | 7 +------ tools/misc/xenpm.c | 24 ++++++++++++------------ xen/drivers/acpi/pmstat.c | 27 ++++++++++++++------------- xen/include/public/sysctl.h | 22 +++++++++++++--------- 5 files changed, 53 insertions(+), 49 deletions(-)
tools/include/xenctrl.h +13 -9
@@ -1909,16 +1909,20 @@ struct xc_get_cpufreq_para {uint32_t cpuinfo_cur_freq;uint32_t cpuinfo_max_freq;uint32_t cpuinfo_min_freq; -uint32_t scaling_cur_freq; - -char scaling_governor[CPUFREQ_NAME_LEN ]; -uint32_t scaling_max_freq; -uint32_t scaling_min_freq; - -/* for specific governor */ union { -xc_userspace_t userspace; -xc_ondemand_t ondemand; +struct { +uint32_t scaling_cur_freq; + +char scaling_governor[CPUFREQ_NAME_LEN ]; +uint32_t scaling_max_freq; +uint32_t scaling_min_freq; + +/* for specific governor */ +union { +xc_userspace_t userspace; +xc_ondemand_t ondemand; + } u; + } s; } u;int32_t turbo_enabled;
tools/libs/ctrl/xc_pm.c +1 -6
@@ -265,17 +265,12 @@ int xc_get_cpufreq_para(xc_interface *xch, int cpuid, user_para->cpuinfo_cur_freq = sys_para->cpuinfo_cur_freq; user_para->cpuinfo_max_freq = sys_para->cpuinfo_max_freq; user_para->cpuinfo_min_freq = sys_para->cpuinfo_min_freq; - user_para->scaling_cur_freq = sys_para->scaling_cur_freq; - user_para->scaling_max_freq = sys_para->scaling_max_freq; - user_para->scaling_min_freq = sys_para->scaling_min_freq; user_para->turbo_enabled = sys_para->turbo_enabled;memcpy (user_para->scaling_driver, sys_para->scaling_driver,CPUFREQ_NAME_LEN ); -memcpy (user_para->scaling_governor, - sys_para->scaling_governor,CPUFREQ_NAME_LEN ); -/* copy to user_para no matter what cpufreq governor */ +/* copy to user_para no matter what cpufreq driver/governor */ BUILD_BUG_ON (sizeof (((struct xc_get_cpufreq_para *)0 )->u) !=sizeof (((struct xen_get_cpufreq_para *)0 )->u));
tools/misc/xenpm.c +12 -12
@@ -730,39 +730,39 @@ static void print_cpufreq_para(int cpuid, struct xc_get_cpufreq_para *p_cpufreq)printf ("scaling_avail_gov : %s\n" , p_cpufreq->scaling_available_governors); -printf ("current_governor : %s\n" , p_cpufreq->scaling_governor); -if ( !strncmp (p_cpufreq->scaling_governor, +printf ("current_governor : %s\n" , p_cpufreq->u.s.scaling_governor); +if ( !strncmp (p_cpufreq->u.s.scaling_governor,"userspace" ,CPUFREQ_NAME_LEN ) ) {printf (" userspace specific :\n" );printf (" scaling_setspeed : %u\n" , - p_cpufreq->u.userspace.scaling_setspeed); + p_cpufreq->u.s.u.userspace.scaling_setspeed); } -else if ( !strncmp (p_cpufreq->scaling_governor, +else if ( !strncmp (p_cpufreq->u.s.scaling_governor,"ondemand" ,CPUFREQ_NAME_LEN ) ) {printf (" ondemand specific :\n" );printf (" sampling_rate : max [%u] min [%u] cur [%u]\n" , - p_cpufreq->u.ondemand.sampling_rate_max, - p_cpufreq->u.ondemand.sampling_rate_min, - p_cpufreq->u.ondemand.sampling_rate); + p_cpufreq->u.s.u.ondemand.sampling_rate_max, + p_cpufreq->u.s.u.ondemand.sampling_rate_min, + p_cpufreq->u.s.u.ondemand.sampling_rate);printf (" up_threshold : %u\n" , - p_cpufreq->u.ondemand.up_threshold); + p_cpufreq->u.s.u.ondemand.up_threshold); }printf ("scaling_avail_freq :" );for ( i =0 ; i < p_cpufreq->freq_num; i++ )if ( p_cpufreq->scaling_available_frequencies[i] == - p_cpufreq->scaling_cur_freq ) + p_cpufreq->u.s.scaling_cur_freq )printf (" *%d" , p_cpufreq->scaling_available_frequencies[i]);else printf (" %d" , p_cpufreq->scaling_available_frequencies[i]);printf ("\n" );printf ("scaling frequency : max [%u] min [%u] cur [%u]\n" , - p_cpufreq->scaling_max_freq, - p_cpufreq->scaling_min_freq, - p_cpufreq->scaling_cur_freq); + p_cpufreq->u.s.scaling_max_freq, + p_cpufreq->u.s.scaling_min_freq, + p_cpufreq->u.s.scaling_cur_freq);printf ("turbo mode : %s\n" , p_cpufreq->turbo_enabled ?"enabled" :"disabled or n/a" );
xen/drivers/acpi/pmstat.c +14 -13
@@ -258,37 +258,38 @@ static int get_cpufreq_para(struct xen_sysctl_pm_op *op) cpufreq_driver.get ? cpufreq_driver.get (op->cpuid) : policy->cur; op->u.get_para.cpuinfo_max_freq = policy->cpuinfo.max_freq; op->u.get_para.cpuinfo_min_freq = policy->cpuinfo.min_freq; - op->u.get_para.scaling_cur_freq = policy->cur; - op->u.get_para.scaling_max_freq = policy->max; - op->u.get_para.scaling_min_freq = policy->min; + + op->u.get_para.u.s.scaling_cur_freq = policy->cur; + op->u.get_para.u.s.scaling_max_freq = policy->max; + op->u.get_para.u.s.scaling_min_freq = policy->min;if ( cpufreq_driver.name[0 ] ) -strlcpy (op->u.get_para.scaling_driver, +strlcpy (op->u.get_para.scaling_driver, cpufreq_driver.name,CPUFREQ_NAME_LEN );else strlcpy (op->u.get_para.scaling_driver,"Unknown" ,CPUFREQ_NAME_LEN );if ( policy->governor->name[0 ] ) -strlcpy (op->u.get_para.scaling_governor, +strlcpy (op->u.get_para.u.s.scaling_governor, policy->governor->name,CPUFREQ_NAME_LEN );else -strlcpy (op->u.get_para.scaling_governor,"Unknown" ,CPUFREQ_NAME_LEN ); +strlcpy (op->u.get_para.u.s.scaling_governor,"Unknown" ,CPUFREQ_NAME_LEN );/* governor specific para */ -if ( !strncasecmp (op->u.get_para.scaling_governor, +if ( !strncasecmp (op->u.get_para.u.s.scaling_governor,"userspace" ,CPUFREQ_NAME_LEN ) ) { - op->u.get_para.u.userspace.scaling_setspeed = policy->cur; + op->u.get_para.u.s.u.userspace.scaling_setspeed = policy->cur; } -if ( !strncasecmp (op->u.get_para.scaling_governor, +if ( !strncasecmp (op->u.get_para.u.s.scaling_governor,"ondemand" ,CPUFREQ_NAME_LEN ) ) { ret =get_cpufreq_ondemand_para ( - &op->u.get_para.u.ondemand.sampling_rate_max, - &op->u.get_para.u.ondemand.sampling_rate_min, - &op->u.get_para.u.ondemand.sampling_rate, - &op->u.get_para.u.ondemand.up_threshold); + &op->u.get_para.u.s.u.ondemand.sampling_rate_max, + &op->u.get_para.u.s.u.ondemand.sampling_rate_min, + &op->u.get_para.u.s.u.ondemand.sampling_rate, + &op->u.get_para.u.s.u.ondemand.up_threshold); } op->u.get_para.turbo_enabled =cpufreq_get_turbo_status (op->cpuid);
xen/include/public/sysctl.h +13 -9
@@ -317,16 +317,20 @@ struct xen_get_cpufreq_para {uint32_t cpuinfo_cur_freq;uint32_t cpuinfo_max_freq;uint32_t cpuinfo_min_freq; -uint32_t scaling_cur_freq; - -char scaling_governor[CPUFREQ_NAME_LEN ]; -uint32_t scaling_max_freq; -uint32_t scaling_min_freq; - -/* for specific governor */ union { -struct xen_userspace userspace; -struct xen_ondemand ondemand; +struct { +uint32_t scaling_cur_freq; + +char scaling_governor[CPUFREQ_NAME_LEN ]; +uint32_t scaling_max_freq; +uint32_t scaling_min_freq; + +/* for specific governor */ +union { +struct xen_userspace userspace; +struct xen_ondemand ondemand; + } u; + } s; } u;int32_t turbo_enabled;
Signature · 1 line
2.41.0
Re: [PATCH v5 04/15] xen/sysctl: Nest cpufreq scaling options
Quoted 5 lines · Jason Andryuk
Add a union and struct so that most of the scaling variables of struct
xen_get_cpufreq_paraare within in a binary-compatible layout. This allowscppc_parato live in the larger union and useuint32_ts- structxen_cppc_parawill be 10 uint32_t's.
Quoted 8 lines
The new scaling struct is 3 *
uint32_t+ 16 bytesCPUFREQ_NAME_LEN+ 4 *uint32_tforxen_ondemand= 11uint32_t. That means the old size is retained,int32_tturbo_enableddoesn't move and it's binary compatible.The out-of-context
memcpy()inxc_get_cpufreq_para()now handles the copying of the fields removed there.Signed-off-by Jason Andryuk <[email protected]>
Nevertheless I continue to be uncertain about ...
Quoted 22 lines
tools/include/xenctrl.h +6
-9@@ -1909,16 +1909,20 @@ struct xc_get_cpufreq_para {uint32_t cpuinfo_cur_freq;uint32_t cpuinfo_max_freq;uint32_t cpuinfo_min_freq; -uint32_t scaling_cur_freq; - -char scaling_governor[CPUFREQ_NAME_LEN ]; -uint32_t scaling_max_freq; -uint32_t scaling_min_freq; - -/* for specific governor */ union { -xc_userspace_t userspace; -xc_ondemand_t ondemand; +struct { +uint32_t scaling_cur_freq; + +char scaling_governor[CPUFREQ_NAME_LEN ]; +uint32_t scaling_max_freq; +uint32_t scaling_min_freq;
tools/include/xenctrl.h struct xc_get_cpufreq_para { · line 1928
Quoted 10 lines
tools/include/xenctrl.h +7
-0+ +/* for specific governor */ +union { +xc_userspace_t userspace; +xc_ondemand_t ondemand; + } u; + } s; } u;int32_t turbo_enabled;
... all of this: Parts of the struct can apparently go out of sync with the sysctl struct, but other parts have to remain in sync without there being an appropriate build-time check (checking merely sizes clearly isn't enough). Therefore I'd really like to have a toolstack side review / ack here as well.
Jan
PATCH v5 5/15 pmstat&xenpm: Re-arrage for cpufreq union
In reply to Jason AndryukRearrange code now that xen_sysctl_pm_op's get_para fields has the nested union and struct. In particular, the scaling governor information like scaling_available_governors is inside the union, so it is not always available. Move those fields (op->u.get_para.u.s.u.*) together as well as the common fields (ones outside the union like op->u.get_para.turbo_enabled).
With that, gov_num may be 0, so bounce buffer handling needs to be modified.
scaling_governor and other fields inside op->u.get_para.u.s.u.* won't be used for hwp, so this will simplify the change when hwp support is introduced and re-indents these lines all together.
---
v5:
Remove some formatting changes
Expand commit message
--- tools/libs/ctrl/xc_pm.c | 12 ++++++++---- tools/misc/xenpm.c | 3 ++- xen/drivers/acpi/pmstat.c | 24 ++++++++++++------------ 3 files changed, 22 insertions(+), 17 deletions(-)
tools/libs/ctrl/xc_pm.c +8 -4
@@ -221,7 +221,7 @@ int xc_get_cpufreq_para(xc_interface *xch, int cpuid, {if ( (!user_para->affected_cpus) || (!user_para->scaling_available_frequencies) || - (!user_para->scaling_available_governors) ) + (user_para->gov_num && !user_para->scaling_available_governors) ) { errno =EINVAL ;return -1 ;
@@ -230,12 +230,15 @@ int xc_get_cpufreq_para(xc_interface *xch, int cpuid, goto unlock_1;if (xc_hypercall_bounce_pre (xch, scaling_available_frequencies) ) goto unlock_2; -if (xc_hypercall_bounce_pre (xch, scaling_available_governors) ) +if ( user_para->gov_num && +xc_hypercall_bounce_pre (xch, scaling_available_governors) ) goto unlock_3;set_xen_guest_handle (sys_para->affected_cpus, affected_cpus);set_xen_guest_handle (sys_para->scaling_available_frequencies, scaling_available_frequencies); -set_xen_guest_handle (sys_para->scaling_available_governors, scaling_available_governors); +if ( user_para->gov_num ) +set_xen_guest_handle (sys_para->scaling_available_governors, + scaling_available_governors); } sysctl.cmd = XEN_SYSCTL_pm_op;
@@ -278,7 +281,8 @@ int xc_get_cpufreq_para(xc_interface *xch, int cpuid, } unlock_4: -xc_hypercall_bounce_post (xch, scaling_available_governors); +if ( user_para->gov_num ) +xc_hypercall_bounce_post (xch, scaling_available_governors); unlock_3:xc_hypercall_bounce_post (xch, scaling_available_frequencies); unlock_2:
tools/misc/xenpm.c +2 -1
@@ -811,7 +811,8 @@ static int show_cpufreq_para_by_cpuid(xc_interface *xc_handle, int cpuid) ret = -ENOMEM ; goto out; } -if (!(p_cpufreq->scaling_available_governors = +if (p_cpufreq->gov_num && + !(p_cpufreq->scaling_available_governors =malloc (p_cpufreq->gov_num *CPUFREQ_NAME_LEN *sizeof (char )))) { fprintf(stderr,
xen/drivers/acpi/pmstat.c +12 -12
@@ -239,6 +239,18 @@ static int get_cpufreq_para(struct xen_sysctl_pm_op *op)if ( ret )return ret; + op->u.get_para.cpuinfo_cur_freq = + cpufreq_driver.get ? cpufreq_driver.get (op->cpuid) : policy->cur; + op->u.get_para.cpuinfo_max_freq = policy->cpuinfo.max_freq; + op->u.get_para.cpuinfo_min_freq = policy->cpuinfo.min_freq; + op->u.get_para.turbo_enabled =cpufreq_get_turbo_status (op->cpuid); + +if ( cpufreq_driver.name[0 ] ) +strlcpy (op->u.get_para.scaling_driver, + cpufreq_driver.name,CPUFREQ_NAME_LEN ); +else +strlcpy (op->u.get_para.scaling_driver,"Unknown" ,CPUFREQ_NAME_LEN ); +if ( !(scaling_available_governors =xzalloc_array (char, gov_num *CPUFREQ_NAME_LEN )) )return -ENOMEM ;
@@ -254,21 +266,10 @@ static int get_cpufreq_para(struct xen_sysctl_pm_op *op)if ( ret )return ret; - op->u.get_para.cpuinfo_cur_freq = - cpufreq_driver.get ? cpufreq_driver.get (op->cpuid) : policy->cur; - op->u.get_para.cpuinfo_max_freq = policy->cpuinfo.max_freq; - op->u.get_para.cpuinfo_min_freq = policy->cpuinfo.min_freq; - op->u.get_para.u.s.scaling_cur_freq = policy->cur; op->u.get_para.u.s.scaling_max_freq = policy->max; op->u.get_para.u.s.scaling_min_freq = policy->min; -if ( cpufreq_driver.name[0 ] ) -strlcpy (op->u.get_para.scaling_driver, - cpufreq_driver.name,CPUFREQ_NAME_LEN ); -else -strlcpy (op->u.get_para.scaling_driver,"Unknown" ,CPUFREQ_NAME_LEN ); -if ( policy->governor->name[0 ] )strlcpy (op->u.get_para.u.s.scaling_governor, policy->governor->name,CPUFREQ_NAME_LEN );
@@ -291,7 +292,6 @@ static int get_cpufreq_para(struct xen_sysctl_pm_op *op) &op->u.get_para.u.s.u.ondemand.sampling_rate, &op->u.get_para.u.s.u.ondemand.up_threshold); } - op->u.get_para.turbo_enabled =cpufreq_get_turbo_status (op->cpuid);return ret; }
Signature · 1 line
2.41.0
Re: [PATCH v5 05/15] pmstat&xenpm: Re-arrage for cpufreq union
Quoted 7 lines · Jason Andryuk
Rearrange code now that xen_sysctl_pm_op's
get_parafields has the nested union and struct. In particular, the scaling governor information likescaling_available_governorsis inside the union, so it is not always available. Move those fields (op->u.get_para.u.s.u.*) together as well as the common fields (ones outside the union likeop->u.get_para.turbo_enabled).
Quoted 8 lines
With that,
gov_nummay be 0, so bounce buffer handling needs to be modified.
scaling_governorand other fields inside op->u.get_para.u.s.u.* won't be used for hwp, so this will simplify the change when hwp support is introduced and re-indents these lines all together.Signed-off-by Jason Andryuk <[email protected]>
PATCH v5 6/15 cpufreq: Add Hardware P-State (HWP) driver
In reply to Jason AndryukFrom the Intel SDM: "Hardware-Controlled Performance States (HWP), which autonomously selects performance states while utilizing OS supplied performance guidance hints."
Enable HWP to run in autonomous mode by poking the correct MSRs. HWP is disabled by default, and cpufreq=hwp enables it.
cpufreq= parsing is expanded to allow cpufreq=hwp;xen. This allows trying HWP and falling back to xen if not available. Only hwp and xen are supported for this fallback feature. hdc is a sub-option under hwp (i.e. cpufreq=hwp,hdc=0) as is verbose.
There is no interface to configure - xen_sysctl_pm_op/xenpm will be extended to configure in subsequent patches. It will run with the default values, which should be the default 0x80 (out of 0x0-0xff) energy/performance preference.
Unscientific powertop measurement of an mostly idle, customized OpenXT install:
A 10th gen 6-core laptop showed battery discharge drop from ~9.x to ~7.x watts.
A 8th gen 4-core laptop dropped from ~10 to ~9
Power usage depends on many factors, especially display brightness, but this does show a power saving in balanced mode when CPU utilization is low.
HWP isn't compatible with an external governor - it doesn't take explicit frequency requests. Therefore a minimal internal governor, hwp, is also added as a placeholder.
While adding to the xen-command-line.pandoc entry, un-nest verbose from minfreq. They are independent.
With cpufreq=hwp,verbose, HWP prints processor capabilities that are not used by the code, like HW_FEEDBACK. This is done because otherwise there isn't a convenient way to query the information.
Xen doesn't use the HWP interrupt, so it is disabled like in the Linux pstate driver.
---
We disable on cpuid_level < 0x16. cpuid(0x16) is used to get the cpu frequencies for calculating the APERF/MPERF. Without it, things would still work, but the average cpu frequency output would be wrong.
My 8th & 10th gen test systems both report:
(XEN) HWP: 1 notify: 1 act_window: 1 energy_perf: 1 pkg_level: 0 peci: 0 (XEN) HWP: Hardware Duty Cycling (HDC) supported
(XEN) HWP: HW_FEEDBACK not supported
We can't use parse_boolean() since it requires a single name=val string and cpufreq_handle_common_option is provided two strings. Use parse_bool() and manual handle no-hwp.
FAST_IA32_HWP_REQUEST was removed in v2. The check in v1 was wrong, it's a model specific feature and the CPUID bit is only available after enabling via the MSR. Support was untested since I don't have hardware with the feature. Writes are expected to be infrequent, so just leave it out.
---
v2:
Alphabetize headers
Re-work driver registration
name hwp_drv_data anonymous union "hw"
Drop hwp_verbose_cont
style cleanups
Condense hwp_governor switchhwp_cpufreq_target remove .raw from hwp_req assignment Use typed-pointer in a few functions
Pass type to xzalloc
Add HWP_ENERGY_PERF_BALANCE/IA32_ENERGY_BIAS_BALANCE defines Add XEN_HWP_GOVERNOR define for "hwp-internal" Capitalize CPUID and MSR defines
Change '_' to '-' for energy-perf & act-window Read-modify-write MSRs updates
Use FAST_IA32_HWP_REQUEST_MSR_ENABLE define
constify pointer in hwp_set_misc_turbo
Add space after non-fallthrough break in governor switch Add IA32_ENERGY_BIAS_MASK define
Check CPUID_PM_LEAK for energy bias when needed
Fail initialization with curr_req = -1
Fold hwp_read_capabilities into hwp_init_msrs
Add command line cpufreq=xen:hwp
Add command line cpufreq=xen:hdc
Use per_cpu for hwp_drv_data pointers
Move hwp_energy_perf_bias call into hwp_write_request energy_perf 0 is valid, so hwp_energy_perf_bias cannot be skipped Ensure we don't generate interrupts
Remove Fast Write of Uncore MSR
Initialize hwp_drv_data from curr_req
Use SPDX line instead of license text in hwp.c
v3:
Add cf_check to cpufreq_gov_hwp_init() - Marek
Print cpuid_level with %#x - Marek
v4:
Use BIT() for CPUID and MSR bits
Move __initdata after type
Add __ro_after_init to feature_*
Remove aperf/mperf comment
Move feature_hwp_energy_perf { to newline
Remove _IA32_ infix
Use unsigned int & bool for bitfields
Require energy perf pref (Remove ENERGY_PERF_BIAS support) Initialize activity_window
Return errors on wrmsr failure
Change command line to: cpufreq=xen:hwp
Move hdc into the hwp-specific handle_options
Drop feature_hwp_energy_perf, feature_hwp_pkg_level_ctl & feature_hwp_peci Print features before exiting when energy/performance preference isn't available Disable HWP MSR on initialization error
Change hwp_ print macros to add prefixes
Disable HDC when hdc=0 - (opt_hdc no longer initdata)
Mark hwp governor internal and use "hwp" name
Add XEN_HWP_DRIVER
Use top-level cpufreq=hwp command line option
Document that cpufreq=hwp falls back to cpufreq=xen without hardware Add SPDX suffix GPL-2.0-only
v5:
Use _AC() macro in MSR_IA32_MISC_ENABLE_TURBO_DISENGAGE definition hwp_err arg re-ordering
Use XEN_HWP_DRIVER_NAME
Use cpufreq.h for all declarations
Clear feature_hdc on failure and print a message
Use unnamed bitfields instead of reservered
Remove asm/io.h include
static DEFINE_PER_CPU_READ_MOSTLY(struct hwp_drv_data Remove some empty newlines
Align feature_hdc assignment
Remove feature_hwp
Remove unnecesary return at end of void hwp_init_msrs() BUILD_BUG_ON member variable
Reformat a compound if
Clear pre_cpu hwp_drv_data before xfree()
Only print HWP capabilities for CPU 0
Specify processor models in turbo comment
Use arg[1] in setup_cpufreq_option()
Remove some log messages
Drop double newline
Parse verbose as a boolean instead of the custom parsing. Support cpufreq=hwp;xen fallback
Call hwp_available() from hwp_register_driver()
Move cpufreq_govenor_internal setting to hwp_register_driver
--- docs/misc/xen-command-line.pandoc | 18 +- xen/arch/x86/acpi/cpufreq/Makefile | 1 + xen/arch/x86/acpi/cpufreq/cpufreq.c | 19 +- xen/arch/x86/acpi/cpufreq/hwp.c | 513 ++++++++++++++++++++++++++ xen/arch/x86/include/asm/cpufeature.h | 12 +- xen/arch/x86/include/asm/msr-index.h | 15 +- xen/drivers/cpufreq/cpufreq.c | 55 ++- xen/include/acpi/cpufreq/cpufreq.h | 9 + xen/include/public/sysctl.h | 2 + 9 files changed, 629 insertions(+), 15 deletions(-) create mode 100644 xen/arch/x86/acpi/cpufreq/hwp.c
docs/misc/xen-command-line.pandoc +17 -1
@@ -499,7 +499,7 @@ If set, force use of the performance counters for oprofile, rather than detectin available support. ### cpufreq -> `= none | {{ <boolean> | xen } [:[powersave|performance|ondemand|userspace][,<maxfreq>][,[<minfreq>][,[verbose]]]]} | dom0-kernel` +> `= none | {{ <boolean> | xen } { [:[powersave|performance|ondemand|userspace][,[<maxfreq>]][,[<minfreq>]]] } [,verbose]} | dom0-kernel | hwp[:[<hdc>][,verbose]]` > Default: `xen`
@@ -510,6 +510,22 @@ choice of `dom0-kernel` is deprecated and not supported by all Dom0 kernels. * `<maxfreq>` and `<minfreq>` are integers which represent max and min processor frequencies respectively. * `verbose` option can be included as a string or also as `verbose=<integer>` + for `xen`. It is a boolean for `hwp`. +* `hwp` selects Hardware-Controlled Performance States (HWP) on supported Intel + hardware. HWP is a Skylake+ feature which provides better CPU power + management. The default is disabled. If `hwp` is selected, but hardware + support is not available, Xen will fallback to cpufreq=xen. +* `<hdc>` is a boolean to enable Hardware Duty Cycling (HDC). HDC enables the + processor to autonomously force physical package components into idle state. + The default is enabled, but the option only applies when `hwp` is enabled. + +There is also support for `;`-separated fallback options: +`cpufreq=hwp,verbose;xen`. This first tries `hwp` and falls back to `xen` +if unavailable. + +Note: grub2 requires to escape or quote ';', so `"cpufreq=hwp;xen"` should be +specified within double quotes inside grub.cfg. Refer to the grub2 +documentation for more information. ### cpuid (x86) > `= List of comma separated booleans`
xen/arch/x86/acpi/cpufreq/Makefile +1 -0
@@ -1,2 +1,3 @@ obj-y += cpufreq.o +obj-y += hwp.o obj-y += powernow.o
xen/arch/x86/acpi/cpufreq/cpufreq.c +18 -1
@@ -642,7 +642,24 @@ static int __init cf_check cpufreq_driver_init(void)switch ( boot_cpu_data.x86_vendor ) {case X86_VENDOR_INTEL : - ret =cpufreq_register_driver (&acpi_cpufreq_driver); +unsigned int i; + ret = -ENOENT ; + +for ( i =0 ; i < cpufreq_xen_cnt; i++ ) + { +switch ( cpufreq_xen_opts[i] ) + { +case CPUFREQ_xen: + ret =cpufreq_register_driver (&acpi_cpufreq_driver); +break ; +case CPUFREQ_hwp: + ret =hwp_register_driver (); +break ; + } + +if ( ret ==0 ) +break ; + }break ;case X86_VENDOR_AMD :
xen/arch/x86/acpi/cpufreq/hwp.c new file +513 -0
513 lines not on this page · raw message
xen/arch/x86/include/asm/cpufeature.h +10 -2
@@ -52,8 +52,16 @@ static inline bool boot_cpu_has(unsigned int feat)return cpu_has (&boot_cpu_data, feat); } -#define CPUID_PM_LEAF 6 -#define CPUID6_ECX_APERFMPERF_CAPABILITY 0x1 +#define CPUID_PM_LEAF 6 +#define CPUID6_EAX_HWP BIT(7, U) +#define CPUID6_EAX_HWP_NOTIFICATION BIT(8, U) +#define CPUID6_EAX_HWP_ACTIVITY_WINDOW BIT(9, U) +#define CPUID6_EAX_HWP_ENERGY_PERFORMANCE_PREFERENCE BIT(10, U) +#define CPUID6_EAX_HWP_PACKAGE_LEVEL_REQUEST BIT(11, U) +#define CPUID6_EAX_HDC BIT(13, U) +#define CPUID6_EAX_HWP_PECI BIT(16, U) +#define CPUID6_EAX_HW_FEEDBACK BIT(19, U) +#define CPUID6_ECX_APERFMPERF_CAPABILITY BIT(0, U)/* CPUID level 0x00000001.edx */ #define cpu_has_fpu 1
xen/arch/x86/include/asm/msr-index.h +14 -1
@@ -151,6 +151,13 @@#define MSR_PKRS 0x000006e1 +#define MSR_PM_ENABLE 0x00000770 +#define PM_ENABLE_HWP_ENABLE BIT(0, ULL) + +#define MSR_HWP_CAPABILITIES 0x00000771 +#define MSR_HWP_INTERRUPT 0x00000773 +#define MSR_HWP_REQUEST 0x00000774 +#define MSR_X2APIC_FIRST 0x00000800#define MSR_X2APIC_LAST 0x000008ff
@@ -165,6 +172,11 @@#define PASID_PASID_MASK 0x000fffff#define PASID_VALID (_AC(1, ULL) << 31) +#define MSR_PKG_HDC_CTL 0x00000db0 +#define PKG_HDC_CTL_HDC_PKG_ENABLE BIT(0, ULL) +#define MSR_PM_CTL1 0x00000db1 +#define PM_CTL1_HDC_ALLOW_BLOCK BIT(0, ULL) +#define MSR_UARCH_MISC_CTRL 0x00001b01#define UARCH_CTRL_DOITM (_AC(1, ULL) << 0)
@@ -502,7 +514,8 @@#define MSR_IA32_MISC_ENABLE_MONITOR_ENABLE (1<<18)#define MSR_IA32_MISC_ENABLE_LIMIT_CPUID (1<<22)#define MSR_IA32_MISC_ENABLE_XTPR_DISABLE (1<<23) -#define MSR_IA32_MISC_ENABLE_XD_DISABLE (_AC(1, ULL) << 34) +#define MSR_IA32_MISC_ENABLE_XD_DISABLE (_AC(1, ULL) << 34) +#define MSR_IA32_MISC_ENABLE_TURBO_DISENGAGE (_AC(1, ULL) << 38)#define MSR_IA32_TSC_DEADLINE 0x000006E0#define MSR_IA32_ENERGY_PERF_BIAS 0x000001b0
xen/drivers/cpufreq/cpufreq.c +45 -10
85 lines not on this page · raw message
xen/include/acpi/cpufreq/cpufreq.h +9 -0
@@ -24,6 +24,12 @@ DECLARE_PER_CPU(spinlock_t, cpufreq_statistic_lock);extern bool_t cpufreq_verbose; +enum cpufreq_xen_opt { + CPUFREQ_xen, + CPUFREQ_hwp, +}; +extern enum cpufreq_xen_opt cpufreq_xen_opts[2 ]; +extern unsigned int cpufreq_xen_cnt;struct cpufreq_governor ;struct acpi_cpufreq_data {
@@ -245,4 +251,7 @@ void cpufreq_dbs_timer_resume(void);void intel_feature_detect (struct cpufreq_policy *policy); +int hwp_cmdline_parse (const char *s,const char *e); +int hwp_register_driver (void ); +#endif /* __XEN_CPUFREQ_PM_H__ */
xen/include/public/sysctl.h +2 -0
@@ -296,6 +296,8 @@ struct xen_ondemand {uint32_t up_threshold; }; +#define XEN_HWP_DRIVER_NAME "hwp" +/* * cpufreq para name of this structure named * same as sysfs file name of native linux
Signature · 1 line
2.41.0
Re: [PATCH v5 06/15] cpufreq: Add Hardware P-State (HWP) driver
Quoted 6 lines · Jason Andryuk
docs/misc/xen-command-line.pandoc +2
-0@@ -510,6 +510,22 @@ choice of `dom0-kernel` is deprecated and not supported by all Dom0 kernels. * `<maxfreq>` and `<minfreq>` are integers which represent max and min processor frequencies respectively. * `verbose` option can be included as a string or also as `verbose=<integer>` + for `xen`. It is a boolean for `hwp`. +* `hwp` selects Hardware-Controlled Performance States (HWP) on supported Intel
docs/misc/xen-command-line.pandoc choice of `dom0-kernel` is deprecated and not supported by all Dom0 kernels. · line 524
Quoted 10 lines
docs/misc/xen-command-line.pandoc +10
-0+ hardware. HWP is a Skylake+ feature which provides better CPU power + management. The default is disabled. If `hwp` is selected, but hardware + support is not available, Xen will fallback to cpufreq=xen. +* `<hdc>` is a boolean to enable Hardware Duty Cycling (HDC). HDC enables the + processor to autonomously force physical package components into idle state. + The default is enabled, but the option only applies when `hwp` is enabled. + +There is also support for `;`-separated fallback options: +`cpufreq=hwp,verbose;xen`. This first tries `hwp` and falls back to `xen` +if unavailable.
In the given example, does "verbose" also apply to the fallback case? If so, perhaps better "cpufreq=hwp;xen,verbose", to eliminate that ambiguity?
xen/arch/x86/acpi/cpufreq/cpufreq.c static int __init cf_check cpufreq_driver_init(void) · line 645
Quoted 8 lines
xen/arch/x86/acpi/cpufreq/cpufreq.c +1
-1@@ -642,7 +642,24 @@ static int __init cf_check cpufreq_driver_init(void)switch ( boot_cpu_data.x86_vendor ) {case X86_VENDOR_INTEL : - ret =cpufreq_register_driver (&acpi_cpufreq_driver); +unsigned int i;
At the moment we still don't mix declarations and statements, i.e. all declarations have to be at the top of a block/scope. What iirc we do use in a couple of places (and what hence you may want to do here as well) is
...
xen/arch/x86/acpi/cpufreq/cpufreq.c static int __init cf_check cpufreq_driver_init(void) · line 648
Quoted 3 lines
xen/arch/x86/acpi/cpufreq/cpufreq.c +3
-0+ ret = -ENOENT ; + +for ( i =0 ; i < cpufreq_xen_cnt; i++ )
... declare the induction variable inside the loop header.
Quoted 5 lines
xen/arch/x86/acpi/cpufreq/cpufreq.c +5
-0+ { +switch ( cpufreq_xen_opts[i] ) + { +case CPUFREQ_xen: + ret =cpufreq_register_driver (&acpi_cpufreq_driver);
xen/arch/x86/acpi/cpufreq/cpufreq.c static int __init cf_check cpufreq_driver_init(void) · line 663
Quoted 10 lines
xen/arch/x86/acpi/cpufreq/cpufreq.c +9
-0+break ; +case CPUFREQ_hwp: + ret =hwp_register_driver (); +break ; + } + +if ( ret ==0 ) +break ; + }break ;
In this model any kind of failure results in the fallback to be tried (and the fallback's error to be returned to the caller rather than the primary one). This may or may not be what we actually want; personally I would have expected
if ( ret != -ENODEV )
break;or some such instead.
xen/arch/x86/acpi/cpufreq/cpufreq.c static int __init cf_check cpufreq_driver_init(void)
Quoted 6 lines
xen/arch/x86/acpi/cpufreq/cpufreq.c +6
-0+static bool hwp_handle_option (const char *s,const char *end) +{ +int ret; + + ret =parse_boolean ("verbose" , s, end); +if ( ret >=0 ) {
Nit: Style (brace placement).
xen/arch/x86/acpi/cpufreq/cpufreq.c
Quoted 6 lines
xen/arch/x86/acpi/cpufreq/cpufreq.c +6
-0+ cpufreq_verbose = ret; +return true; + } + + ret =parse_boolean ("hdc" , s, end); +if ( ret >=0 ) {
Same here.
Quoted 4 lines
xen/arch/x86/acpi/cpufreq/cpufreq.c +4
-0+ opt_cpufreq_hdc = ret; +return true; + } +
xen/arch/x86/acpi/cpufreq/cpufreq.c
Quoted 10 lines
xen/arch/x86/acpi/cpufreq/cpufreq.c +10
-0+return false; +} + +int __init hwp_cmdline_parse (const char *s,const char *e) +{ + do + { + const char *end = strpbrk(s, ",;"); + + if ( s && !hwp_handle_option(s, end) )
This check of s not being NULL comes too late, as strpbrk() would have de-referenced it already. Considering ...
xen/arch/x86/acpi/cpufreq/cpufreq.c
Quoted 9 lines
xen/arch/x86/acpi/cpufreq/cpufreq.c +9
-0+ { +printk (XENLOG_WARNING "cpufreq/hwp: option '%s' not recognized\n" , + s); + +return -1 ; + } + + s = end ? ++end : end; + }while ( s && s < e );
... this it probably wants to move even ahead of the loop.
Quoted 13 lines
xen/arch/x86/acpi/cpufreq/cpufreq.c +13
-0+static int hdc_set_pkg_hdc_ctl (unsigned int cpu,bool val) +{ +uint64_t msr; + +if (rdmsr_safe (MSR_PKG_HDC_CTL , msr) ) + { +hwp_err (cpu,"rdmsr_safe(MSR_PKG_HDC_CTL)\n" ); +return -1 ; + } + +if ( val ) + msr |=PKG_HDC_CTL_HDC_PKG_ENABLE ; +else
xen/arch/x86/acpi/cpufreq/cpufreq.c
Quoted 10 lines
xen/arch/x86/acpi/cpufreq/cpufreq.c +10
-0+ msr &= ~PKG_HDC_CTL_HDC_PKG_ENABLE ; + +if (wrmsr_safe (MSR_PKG_HDC_CTL , msr) ) + { +hwp_err (cpu,"wrmsr_safe(MSR_PKG_HDC_CTL): %016lx\n" , msr); +return -1 ; + } + +return 0 ; +}
Please can you use either boolean return values or proper 0 / -errno ones? (Same again then in the subsequent function.)
Quoted 45 lines
xen/arch/x86/acpi/cpufreq/cpufreq.c +45
-0+static void cf_check hwp_init_msrs(void *info) +{ +struct cpufreq_policy *policy = info; +struct hwp_drv_data *data =this_cpu (hwp_drv_data); +uint64_t val; + +/* +* Package level MSR, but we don't have a good idea of packages here, so +* just do it everytime. +*/ +if (rdmsr_safe (MSR_PM_ENABLE , val) ) + { +hwp_err (policy->cpu,"rdmsr_safe(MSR_PM_ENABLE)\n" ); + data->curr_req.raw =-1 ; +return ; + } + +/* Ensure we don't generate interrupts */ +if ( feature_hwp_notification ) +wrmsr_safe (MSR_HWP_INTERRUPT ,0 ); + +hwp_verbose ("CPU%u: MSR_PM_ENABLE: %016lx\n" , policy->cpu, val); +if ( !(val &PM_ENABLE_HWP_ENABLE ) ) + { + val |=PM_ENABLE_HWP_ENABLE ; +if (wrmsr_safe (MSR_PM_ENABLE , val) ) + { +hwp_err (policy->cpu,"wrmsr_safe(MSR_PM_ENABLE, %lx)\n" , val); + data->curr_req.raw =-1 ; +return ; + } + } + +if (rdmsr_safe (MSR_HWP_CAPABILITIES , data->hwp_caps) ) + { +hwp_err (policy->cpu,"rdmsr_safe(MSR_HWP_CAPABILITIES)\n" ); + goto error; + } + +if (rdmsr_safe (MSR_HWP_REQUEST , data->curr_req.raw) ) + { +hwp_err (policy->cpu,"rdmsr_safe(MSR_HWP_REQUEST)\n" ); + goto error; + } +
xen/arch/x86/acpi/cpufreq/cpufreq.c
Quoted 10 lines
xen/arch/x86/acpi/cpufreq/cpufreq.c +10
-0+/* +* Check for APERF/MPERF support in hardware +* also check for boost/turbo support +*/ +intel_feature_detect (policy); + +if ( feature_hdc ) + { +if (hdc_set_pkg_hdc_ctl (policy->cpu, opt_cpufreq_hdc) || +hdc_set_pm_ctl1 (policy->cpu, opt_cpufreq_hdc) ) {
Please can these two if()s be joined and the well-placed brace be retained?
xen/arch/x86/acpi/cpufreq/cpufreq.c
Quoted 3 lines
xen/arch/x86/acpi/cpufreq/cpufreq.c +3
-0+hwp_err (policy->cpu,"Disabling HDC support\n" ); + feature_hdc = false; + goto error;
Why? Can't you continue just with HDC turned off?
xen/arch/x86/acpi/cpufreq/cpufreq.c
Quoted 9 lines
xen/arch/x86/acpi/cpufreq/cpufreq.c +9
-0+static void cf_check hwp_write_request(void *info) +{ +const struct cpufreq_policy *policy = info; +struct hwp_drv_data *data =this_cpu (hwp_drv_data); +union hwp_request hwp_req = data->curr_req; + + data->ret =0 ; + +BUILD_BUG_ON (sizeof (union hwp_request ) !=sizeof (hwp_req.raw));
You changed only the right side to not be sizeof(<type>).
Quoted 4 lines
xen/arch/x86/acpi/cpufreq/cpufreq.c +4
-0+static int cf_check hwp_cpufreq_cpu_init(struct cpufreq_policy *policy) +{ +unsigned int cpu = policy->cpu; +struct hwp_drv_data *data;
xen/arch/x86/acpi/cpufreq/cpufreq.c
Quoted 10 lines
xen/arch/x86/acpi/cpufreq/cpufreq.c +10
-0+ + data = xzalloc(struct hwp_drv_data); +if ( !data ) +return -ENOMEM ; + + policy->governor = &cpufreq_gov_hwp; + +per_cpu (hwp_drv_data, cpu) = data; + +on_selected_cpus (cpumask_of (cpu), hwp_init_msrs, policy,1 );
Could I talk you into moving the helper function immediately ahead of this (sole) one using it, much like you have it for hwp_cpufreq_target() and hwp_write_request()?
Quoted 6 lines
xen/arch/x86/acpi/cpufreq/cpufreq.c +6
-0+if ( data->curr_req.raw ==-1 ) + { +hwp_err (cpu,"Could not initialize HWP properly\n" ); +per_cpu (hwp_drv_data, cpu) =NULL ; +xfree (data); +return -ENODEV ;
xen/arch/x86/acpi/cpufreq/cpufreq.c
Quoted 10 lines
xen/arch/x86/acpi/cpufreq/cpufreq.c +10
-0+ } + + data->minimum = data->curr_req.min_perf; + data->maximum = data->curr_req.max_perf; + data->desired = data->curr_req.desired; + data->energy_perf = data->curr_req.energy_perf; + data->activity_window = data->curr_req.activity_window; + +if ( cpu ==0 ) +hwp_verbose ("CPU%u: HWP_CAPABILITIES: %016lx\n" , cpu, data->hwp_caps);
While I'm fine with this (perhaps apart from you using "cpu == 0", which is an idiom we're trying to get rid of), ...
Quoted 1 line
+
hwp_verbose("CPU%u: rdmsr HWP_REQUEST %016lx\n", cpu, data->curr_req.raw);
... this once-per-CPU message still looks to verbose to me. Perhaps for both:
- print for the BSP,
- print when AP value differs from BSP (albeit I don't know how [un]likely that is)?
xen/arch/x86/acpi/cpufreq/cpufreq.c
Quoted 5 lines
xen/arch/x86/acpi/cpufreq/cpufreq.c +5
-0+static int cf_check hwp_cpufreq_cpu_exit(struct cpufreq_policy *policy) +{ +struct hwp_drv_data *data =per_cpu (hwp_drv_data, policy->cpu); +per_cpu (hwp_drv_data, policy->cpu) =NULL ; +xfree (data);
Nit: Style (blank line between declaration(s) and statement(s) please. (Also at least once again below.)
xen/drivers/cpufreq/cpufreq.c LIST_HEAD_READ_MOSTLY(cpufreq_governor_list); · line 67
Quoted 9 lines
xen/drivers/cpufreq/cpufreq.c +2
-1@@ -63,12 +63,18 @@ LIST_HEAD_READ_MOSTLY(cpufreq_governor_list);/* set xen as default cpufreq */ enum cpufreq_controller cpufreq_controller = FREQCTL_xen; -static int __init cpufreq_cmdline_parse (const char *s); +enum cpufreq_xen_opt cpufreq_xen_opts[2 ] = { CPUFREQ_xen, }; +unsigned int cpufreq_xen_cnt =1 ;
Looks like both can be __initdata?
As to the array initializer: For one Misra won't like the 2nd slot not initialized. Plus the implicit 0 there is nothing else than CPUFREQ_xen, which also ends up a little fragile. Perhaps 0 wants to stand for CPUFREQ_none (or whatever name you deem appropriate)?
Jan
Re: [PATCH v5 06/15] cpufreq: Add Hardware P-State (HWP) driver
Quoted 13 lines · Jan Beulich
Quoted 11 lines · Jason Andryuk
docs/misc/xen-command-line.pandoc +7
-0@@ -510,6 +510,22 @@ choice of `dom0-kernel` is deprecated and not supported by all Dom0 kernels. * `<maxfreq>` and `<minfreq>` are integers which represent max and min processor frequencies respectively. * `verbose` option can be included as a string or also as `verbose=<integer>` + for `xen`. It is a boolean for `hwp`. +* `hwp` selects Hardware-Controlled Performance States (HWP) on supported Intel + hardware. HWP is a Skylake+ feature which provides better CPU power + management. The default is disabled. If `hwp` is selected, but hardware + support is not available, Xen will fallback to cpufreq=xen. +* `<hdc>` is a boolean to enable Hardware Duty Cycling (HDC). HDC enables the + processor to autonomously force physical package components into idle state.
Quoted 8 lines
docs/misc/xen-command-line.pandoc choice of `dom0-kernel` is deprecated and not supported by all Dom0 kernels. · line 524
Quoted 5 lines
docs/misc/xen-command-line.pandoc +5
-0+ The default is enabled, but the option only applies when `hwp` is enabled. + +There is also support for `;`-separated fallback options: +`cpufreq=hwp,verbose;xen`. This first tries `hwp` and falls back to `xen` +if unavailable.In the given example, does "verbose" also apply to the fallback case? If so, perhaps better "cpufreq=hwp;xen,verbose", to eliminate that ambiguity?
Yes, "verbose" is applied to both. I can make the change. I mentioned it in the commit message, but I'll mention it here as well.
Quoted 14 lines
xen/arch/x86/acpi/cpufreq/cpufreq.c static int __init cf_check cpufreq_driver_init(void) · line 645
Quoted 8 lines
xen/arch/x86/acpi/cpufreq/cpufreq.c +1
-1@@ -642,7 +642,24 @@ static int __init cf_check cpufreq_driver_init(void)switch ( boot_cpu_data.x86_vendor ) {case X86_VENDOR_INTEL : - ret =cpufreq_register_driver (&acpi_cpufreq_driver); +unsigned int i;At the moment we still don't mix declarations and statements, i.e. all declarations have to be at the top of a block/scope. What iirc we do use in a couple of places (and what hence you may want to do here as well) is
...
Quoted 5 lines
xen/arch/x86/acpi/cpufreq/cpufreq.c static int __init cf_check cpufreq_driver_init(void) · line 648
Quoted 3 lines
xen/arch/x86/acpi/cpufreq/cpufreq.c +3
-0+ ret = -ENOENT ; + +for ( i =0 ; i < cpufreq_xen_cnt; i++ )... declare the induction variable inside the loop header.
Sounds good, thanks.
Quoted 21 lines
Quoted 5 lines
xen/arch/x86/acpi/cpufreq/cpufreq.c +5
-0+ { +switch ( cpufreq_xen_opts[i] ) + { +case CPUFREQ_xen: + ret =cpufreq_register_driver (&acpi_cpufreq_driver);xen/arch/x86/acpi/cpufreq/cpufreq.c static int __init cf_check cpufreq_driver_init(void) · line 663
Quoted 10 lines
xen/arch/x86/acpi/cpufreq/cpufreq.c +9
-0+break ; +case CPUFREQ_hwp: + ret =hwp_register_driver (); +break ; + } + +if ( ret ==0 ) +break ; + }break ;In this model any kind of failure results in the fallback to be tried (and the fallback's error to be returned to the caller rather than the primary one). This may or may not be what we actually want; personally I would have expected
Quoted 4 lines
if ( ret != -ENODEV ) break;or some such instead.
I guess this comes back to our fruit preferences. :)
I can switch it around like that, and make hwp_register_driver() return -ENODEV for hwp_available() returning false.
Quoted 9 lines
xen/arch/x86/acpi/cpufreq/cpufreq.c static int __init cf_check cpufreq_driver_init(void)
Quoted 6 lines
xen/arch/x86/acpi/cpufreq/cpufreq.c +6
-0+static bool hwp_handle_option (const char *s,const char *end) +{ +int ret; + + ret =parse_boolean ("verbose" , s, end); +if ( ret >=0 ) {Nit: Style (brace placement).
Quoted 8 lines
xen/arch/x86/acpi/cpufreq/cpufreq.c
Quoted 6 lines
xen/arch/x86/acpi/cpufreq/cpufreq.c +6
-0+ cpufreq_verbose = ret; +return true; + } + + ret =parse_boolean ("hdc" , s, end); +if ( ret >=0 ) {Same here.
Thanks. Sorry about those.
Quoted 18 lines
Quoted 4 lines
xen/arch/x86/acpi/cpufreq/cpufreq.c +4
-0+ opt_cpufreq_hdc = ret; +return true; + } +xen/arch/x86/acpi/cpufreq/cpufreq.c
Quoted 10 lines
xen/arch/x86/acpi/cpufreq/cpufreq.c +10
-0+return false; +} + +int __init hwp_cmdline_parse (const char *s,const char *e) +{ + do + { + const char *end = strpbrk(s, ",;"); + + if ( s && !hwp_handle_option(s, end) )This check of s not being NULL comes too late, as
strpbrk()would have de-referenced it already. Considering ...
Quoted 11 lines
xen/arch/x86/acpi/cpufreq/cpufreq.c
Quoted 9 lines
xen/arch/x86/acpi/cpufreq/cpufreq.c +9
-0+ { +printk (XENLOG_WARNING "cpufreq/hwp: option '%s' not recognized\n" , + s); + +return -1 ; + } + + s = end ? ++end : end; + }while ( s && s < e );... this it probably wants to move even ahead of the loop.
I'll switch from do/while to just while and then the NULL check will be covered. In practice, this function is never called with s == NULL.
Quoted 18 lines
Quoted 18 lines
xen/arch/x86/acpi/cpufreq/cpufreq.c +18
-0+static int hdc_set_pkg_hdc_ctl (unsigned int cpu,bool val) +{ +uint64_t msr; + +if (rdmsr_safe (MSR_PKG_HDC_CTL , msr) ) + { +hwp_err (cpu,"rdmsr_safe(MSR_PKG_HDC_CTL)\n" ); +return -1 ; + } + +if ( val ) + msr |=PKG_HDC_CTL_HDC_PKG_ENABLE ; +else + msr &= ~PKG_HDC_CTL_HDC_PKG_ENABLE ; + +if (wrmsr_safe (MSR_PKG_HDC_CTL , msr) ) + { +hwp_err (cpu,"wrmsr_safe(MSR_PKG_HDC_CTL): %016lx\n" , msr);
Quoted 8 lines
xen/arch/x86/acpi/cpufreq/cpufreq.c
Quoted 5 lines
xen/arch/x86/acpi/cpufreq/cpufreq.c +5
-0+return -1 ; + } + +return 0 ; +}Please can you use either boolean return values or proper 0 / -errno ones? (Same again then in the subsequent function.)
Sure, I'll use booleans.
Quoted 50 lines
Quoted 50 lines
xen/arch/x86/acpi/cpufreq/cpufreq.c +50
-0+static void cf_check hwp_init_msrs(void *info) +{ +struct cpufreq_policy *policy = info; +struct hwp_drv_data *data =this_cpu (hwp_drv_data); +uint64_t val; + +/* +* Package level MSR, but we don't have a good idea of packages here, so +* just do it everytime. +*/ +if (rdmsr_safe (MSR_PM_ENABLE , val) ) + { +hwp_err (policy->cpu,"rdmsr_safe(MSR_PM_ENABLE)\n" ); + data->curr_req.raw =-1 ; +return ; + } + +/* Ensure we don't generate interrupts */ +if ( feature_hwp_notification ) +wrmsr_safe (MSR_HWP_INTERRUPT ,0 ); + +hwp_verbose ("CPU%u: MSR_PM_ENABLE: %016lx\n" , policy->cpu, val); +if ( !(val &PM_ENABLE_HWP_ENABLE ) ) + { + val |=PM_ENABLE_HWP_ENABLE ; +if (wrmsr_safe (MSR_PM_ENABLE , val) ) + { +hwp_err (policy->cpu,"wrmsr_safe(MSR_PM_ENABLE, %lx)\n" , val); + data->curr_req.raw =-1 ; +return ; + } + } + +if (rdmsr_safe (MSR_HWP_CAPABILITIES , data->hwp_caps) ) + { +hwp_err (policy->cpu,"rdmsr_safe(MSR_HWP_CAPABILITIES)\n" ); + goto error; + } + +if (rdmsr_safe (MSR_HWP_REQUEST , data->curr_req.raw) ) + { +hwp_err (policy->cpu,"rdmsr_safe(MSR_HWP_REQUEST)\n" ); + goto error; + } + +/* +* Check for APERF/MPERF support in hardware +* also check for boost/turbo support +*/ +intel_feature_detect (policy);
Quoted 8 lines
xen/arch/x86/acpi/cpufreq/cpufreq.c
Quoted 5 lines
xen/arch/x86/acpi/cpufreq/cpufreq.c +5
-0+ +if ( feature_hdc ) + { +if (hdc_set_pkg_hdc_ctl (policy->cpu, opt_cpufreq_hdc) || +hdc_set_pm_ctl1 (policy->cpu, opt_cpufreq_hdc) ) {Please can these two if()s be joined and the well-placed brace be retained?
Sure.
Quoted 5 lines
xen/arch/x86/acpi/cpufreq/cpufreq.c
Quoted 3 lines
xen/arch/x86/acpi/cpufreq/cpufreq.c +3
-0+hwp_err (policy->cpu,"Disabling HDC support\n" ); + feature_hdc = false; + goto error;Why? Can't you continue just with HDC turned off?
Yes, that is what I intended to implement after your earlier review, but I failed to actually delete the goto.
Quoted 11 lines
xen/arch/x86/acpi/cpufreq/cpufreq.c
Quoted 9 lines
xen/arch/x86/acpi/cpufreq/cpufreq.c +9
-0+static void cf_check hwp_write_request(void *info) +{ +const struct cpufreq_policy *policy = info; +struct hwp_drv_data *data =this_cpu (hwp_drv_data); +union hwp_request hwp_req = data->curr_req; + + data->ret =0 ; + +BUILD_BUG_ON (sizeof (union hwp_request ) !=sizeof (hwp_req.raw));You changed only the right side to not be sizeof(<type>).
Updated. I was just focused on removing the uint64_t from your earlier comment.
Quoted 10 lines
Quoted 10 lines
xen/arch/x86/acpi/cpufreq/cpufreq.c +10
-0+static int cf_check hwp_cpufreq_cpu_init(struct cpufreq_policy *policy) +{ +unsigned int cpu = policy->cpu; +struct hwp_drv_data *data; + + data = xzalloc(struct hwp_drv_data); +if ( !data ) +return -ENOMEM ; + + policy->governor = &cpufreq_gov_hwp;
Quoted 8 lines
xen/arch/x86/acpi/cpufreq/cpufreq.c
Quoted 4 lines
xen/arch/x86/acpi/cpufreq/cpufreq.c +4
-0+ +per_cpu (hwp_drv_data, cpu) = data; + +on_selected_cpus (cpumask_of (cpu), hwp_init_msrs, policy,1 );Could I talk you into moving the helper function immediately ahead of this (sole) one using it, much like you have it for
hwp_cpufreq_target()andhwp_write_request()?
Yes. sounds good. I'll move hdc_set_pkg_hdc_ctl(), hdc_set_pm_ctl1(), hwp_get_cpu_speeds() as well since they are all called by hwp_init_msrs().
Quoted 11 lines
Quoted 11 lines
xen/arch/x86/acpi/cpufreq/cpufreq.c +11
-0+if ( data->curr_req.raw ==-1 ) + { +hwp_err (cpu,"Could not initialize HWP properly\n" ); +per_cpu (hwp_drv_data, cpu) =NULL ; +xfree (data); +return -ENODEV ; + } + + data->minimum = data->curr_req.min_perf; + data->maximum = data->curr_req.max_perf; + data->desired = data->curr_req.desired;
Quoted 8 lines
xen/arch/x86/acpi/cpufreq/cpufreq.c
Quoted 5 lines
xen/arch/x86/acpi/cpufreq/cpufreq.c +5
-0+ data->energy_perf = data->curr_req.energy_perf; + data->activity_window = data->curr_req.activity_window; + +if ( cpu ==0 ) +hwp_verbose ("CPU%u: HWP_CAPABILITIES: %016lx\n" , cpu, data->hwp_caps);While I'm fine with this (perhaps apart from you using "cpu == 0", which is an idiom we're trying to get rid of), ...
Oh, I didn't know that. What is the preferred way to identify the BSP? This doesn't necessarily run on the BSP, so "cpu"/"policy->cpu" is all we have to make a determination.
Quoted 7 lines
Quoted 1 line
+
hwp_verbose("CPU%u: rdmsr HWP_REQUEST %016lx\n", cpu, data->curr_req.raw);... this once-per-CPU message still looks to verbose to me. Perhaps for both:
- print for the BSP,
- print when AP value differs from BSP (albeit I don't know how [un]likely that is)?
On my test systems, the values have all been identical. But your differing values idea seems good.
Quoted 15 lines
xen/arch/x86/acpi/cpufreq/cpufreq.c
Quoted 5 lines
xen/arch/x86/acpi/cpufreq/cpufreq.c +5
-0+static int cf_check hwp_cpufreq_cpu_exit(struct cpufreq_policy *policy) +{ +struct hwp_drv_data *data =per_cpu (hwp_drv_data, policy->cpu); +per_cpu (hwp_drv_data, policy->cpu) =NULL ; +xfree (data);Nit: Style (blank line between declaration(s) and statement(s) please. (Also at least once again below.)
Quoted 6 lines
xen/drivers/cpufreq/cpufreq.c +0
-0@@ -63,12 +63,18 @@ LIST_HEAD_READ_MOSTLY(cpufreq_governor_list);/* set xen as default cpufreq */ enum cpufreq_controller cpufreq_controller = FREQCTL_xen;
Quoted 5 lines
xen/drivers/cpufreq/cpufreq.c LIST_HEAD_READ_MOSTLY(cpufreq_governor_list); · line 67
Quoted 3 lines
xen/drivers/cpufreq/cpufreq.c +2
-1-static int __init cpufreq_cmdline_parse (const char *s); +enum cpufreq_xen_opt cpufreq_xen_opts[2 ] = { CPUFREQ_xen, }; +unsigned int cpufreq_xen_cnt =1 ;Looks like both can be
__initdata?
Yes, thanks.
Quoted 4 lines
As to the array initializer: For one Misra won't like the 2nd slot not initialized. Plus the implicit 0 there is nothing else than
CPUFREQ_xen, which also ends up a little fragile. Perhaps 0 wants to stand forCPUFREQ_none(or whatever name you deem appropriate)?
:) I had a CPUFREQ_none originally, but dropped it as there was no need for one with cpufreq_xen_cnt controlling the iteration. I'll add it back. (gcc 12 at least complains that the switch in cpufreq_driver_init() needs to handle CPUFREQ_none, so I'll just have it return 0 in that case.)
Thanks for the review.
Regards,
Jason
Re: [PATCH v5 06/15] cpufreq: Add Hardware P-State (HWP) driver
Quoted 22 lines · Jason Andryuk
Quoted 12 lines · Jan Beulich
Quoted 11 lines · Jason Andryuk
docs/misc/xen-command-line.pandoc +7
-0@@ -510,6 +510,22 @@ choice of `dom0-kernel` is deprecated and not supported by all Dom0 kernels. * `<maxfreq>` and `<minfreq>` are integers which represent max and min processor frequencies respectively. * `verbose` option can be included as a string or also as `verbose=<integer>` + for `xen`. It is a boolean for `hwp`. +* `hwp` selects Hardware-Controlled Performance States (HWP) on supported Intel + hardware. HWP is a Skylake+ feature which provides better CPU power + management. The default is disabled. If `hwp` is selected, but hardware + support is not available, Xen will fallback to cpufreq=xen. +* `<hdc>` is a boolean to enable Hardware Duty Cycling (HDC). HDC enables the + processor to autonomously force physical package components into idle state.Quoted 8 lines
docs/misc/xen-command-line.pandoc choice of `dom0-kernel` is deprecated and not supported by all Dom0 kernels. · line 524
Quoted 5 lines
docs/misc/xen-command-line.pandoc +5
-0+ The default is enabled, but the option only applies when `hwp` is enabled. + +There is also support for `;`-separated fallback options: +`cpufreq=hwp,verbose;xen`. This first tries `hwp` and falls back to `xen` +if unavailable.In the given example, does "verbose" also apply to the fallback case? If so, perhaps better "cpufreq=hwp;xen,verbose", to eliminate that ambiguity?
Quoted 2 lines
Yes, "verbose" is applied to both. I can make the change. I mentioned it in the commit message, but I'll mention it here as well.
FTAOD my earlier comment implied that the spelling form you use above should not even be accepted when parsing. I.e. it was not just about the doc aspect.
Quoted 21 lines
Quoted 21 lines
Quoted 5 lines
xen/arch/x86/acpi/cpufreq/cpufreq.c +5
-0+ { +switch ( cpufreq_xen_opts[i] ) + { +case CPUFREQ_xen: + ret =cpufreq_register_driver (&acpi_cpufreq_driver);xen/arch/x86/acpi/cpufreq/cpufreq.c static int __init cf_check cpufreq_driver_init(void) · line 663
Quoted 10 lines
xen/arch/x86/acpi/cpufreq/cpufreq.c +9
-0+break ; +case CPUFREQ_hwp: + ret =hwp_register_driver (); +break ; + } + +if ( ret ==0 ) +break ; + }break ;In this model any kind of failure results in the fallback to be tried (and the fallback's error to be returned to the caller rather than the primary one). This may or may not be what we actually want; personally I would have expected
Quoted 6 lines
Quoted 4 lines
if ( ret != -ENODEV ) break;or some such instead.
I guess this comes back to our fruit preferences. :)
Does it? It's not just a style question here, but one of when / whether to use the fallback.
Quoted 2 lines
I can switch it around like that, and make
hwp_register_driver()return-ENODEVforhwp_available()returning false.
Thanks.
Quoted 23 lines
Quoted 11 lines
xen/arch/x86/acpi/cpufreq/hwp.c line 124
Quoted 7 lines
xen/arch/x86/acpi/cpufreq/hwp.c new file +7
-0+int __init hwp_cmdline_parse (const char *s,const char *e) +{ + do + { + const char *end = strpbrk(s, ",;"); + + if ( s && !hwp_handle_option(s, end) )This check of s not being NULL comes too late, as
strpbrk()would have de-referenced it already. Considering ...Quoted 11 lines
xen/arch/x86/acpi/cpufreq/hwp.c line 133
Quoted 9 lines
xen/arch/x86/acpi/cpufreq/hwp.c new file +9
-0+ { +printk (XENLOG_WARNING "cpufreq/hwp: option '%s' not recognized\n" , + s); + +return -1 ; + } + + s = end ? ++end : end; + }while ( s && s < e );... this it probably wants to move even ahead of the loop.
Quoted 3 lines
I'll switch from do/while to just while and then the NULL check will be covered. In practice, this function is never called with s == NULL.
In which case - why not leave things largely as they are, simply dropping the odd check of s?
Quoted 20 lines
Quoted 11 lines
Quoted 11 lines
xen/arch/x86/acpi/cpufreq/hwp.c new file +11
-0+if ( data->curr_req.raw ==-1 ) + { +hwp_err (cpu,"Could not initialize HWP properly\n" ); +per_cpu (hwp_drv_data, cpu) =NULL ; +xfree (data); +return -ENODEV ; + } + + data->minimum = data->curr_req.min_perf; + data->maximum = data->curr_req.max_perf; + data->desired = data->curr_req.desired;Quoted 8 lines
xen/arch/x86/acpi/cpufreq/hwp.c line 433
Quoted 5 lines
xen/arch/x86/acpi/cpufreq/hwp.c new file +5
-0+ data->energy_perf = data->curr_req.energy_perf; + data->activity_window = data->curr_req.activity_window; + +if ( cpu ==0 ) +hwp_verbose ("CPU%u: HWP_CAPABILITIES: %016lx\n" , cpu, data->hwp_caps);While I'm fine with this (perhaps apart from you using "cpu == 0", which is an idiom we're trying to get rid of), ...
Quoted 2 lines
Oh, I didn't know that. What is the preferred way to identify the BSP?
Sometimes we pass a separate boolean to functions, in other cases we check whether a struct cpuinfo_x86 * equals &boot_cpu_info. The latter clearly can't be used here, and the former doesn't look to be a good fit either. However, ...
Quoted 2 lines
This doesn't necessarily run on the BSP, so "cpu"/"policy->cpu"
is all we have to make a determination.
... isn't it, conversely, the case that the function only ever runs on "cpu" when it is the BSP? In which case "cpu == smp_processor_id()" ought to do the trick.
Jan
Re: [PATCH v5 06/15] cpufreq: Add Hardware P-State (HWP) driver
Quoted 24 lines · Jan Beulich
Quoted 22 lines · Jason Andryuk
Quoted 20 lines · Jan Beulich
Quoted 6 lines · Jason Andryuk
docs/misc/xen-command-line.pandoc +2
-0@@ -510,6 +510,22 @@ choice of `dom0-kernel` is deprecated and not supported by all Dom0 kernels. * `<maxfreq>` and `<minfreq>` are integers which represent max and min processor frequencies respectively. * `verbose` option can be included as a string or also as `verbose=<integer>` + for `xen`. It is a boolean for `hwp`. +* `hwp` selects Hardware-Controlled Performance States (HWP) on supported Inteldocs/misc/xen-command-line.pandoc choice of `dom0-kernel` is deprecated and not supported by all Dom0 kernels. · line 524
Quoted 10 lines
docs/misc/xen-command-line.pandoc +10
-0+ hardware. HWP is a Skylake+ feature which provides better CPU power + management. The default is disabled. If `hwp` is selected, but hardware + support is not available, Xen will fallback to cpufreq=xen. +* `<hdc>` is a boolean to enable Hardware Duty Cycling (HDC). HDC enables the + processor to autonomously force physical package components into idle state. + The default is enabled, but the option only applies when `hwp` is enabled. + +There is also support for `;`-separated fallback options: +`cpufreq=hwp,verbose;xen`. This first tries `hwp` and falls back to `xen` +if unavailable.In the given example, does "verbose" also apply to the fallback case? If so, perhaps better "cpufreq=hwp;xen,verbose", to eliminate that ambiguity?
Quoted 6 lines
Quoted 2 lines
Yes, "verbose" is applied to both. I can make the change. I mentioned it in the commit message, but I'll mention it here as well.
FTAOD my earlier comment implied that the spelling form you use above should not even be accepted when parsing. I.e. it was not just about the doc aspect.
Oh. So what exactly do you want then?
There is a single cpufreq_verbose variable today that is set by either cpufreq=hwp,verbose or cpufreq=xen,verbose. Is that okay, or should the "xen" and "hwp" each get a separate variable?
Do you only want to allow a single trailing "verbose" to apply to all of cpufreq (cpufreq=$foo,verbose)? Or do you want "verbose" to be only valid for "xen"? Both cpufreq_cmdline_parse() and hwp_cmdline_parse() just loop over their options and don't care about order, even though the documentation lists verbose last. Would you want "cpufreq=hwp,verbose,hdc" to fail to parse?
All parsing is done upfront before knowing whether "xen" or "hwp" will be used as the cpufreq driver, so there is a trickiness for implementing "verbose" only for one option. Similarly, "cpufreq=hwp,invalid;xen" will try "hwp" (but not "xen") since the live variables are updated. Even without this patch, cpufreq will be configured up to an invalid parameter.
FYI, cpufreq=xen;hwp will be accepted. "xen" shouldn't fail, so it doesn't make sense to specify that. But it didn't seem necessary to prevent it.
Quoted 24 lines
Quoted 24 lines
Quoted 24 lines
Quoted 5 lines
xen/arch/x86/acpi/cpufreq/cpufreq.c +5
-0+ { +switch ( cpufreq_xen_opts[i] ) + { +case CPUFREQ_xen: + ret =cpufreq_register_driver (&acpi_cpufreq_driver);xen/arch/x86/acpi/cpufreq/cpufreq.c static int __init cf_check cpufreq_driver_init(void) · line 663
Quoted 10 lines
xen/arch/x86/acpi/cpufreq/cpufreq.c +9
-0+break ; +case CPUFREQ_hwp: + ret =hwp_register_driver (); +break ; + } + +if ( ret ==0 ) +break ; + }break ;In this model any kind of failure results in the fallback to be tried (and the fallback's error to be returned to the caller rather than the primary one). This may or may not be what we actually want; personally I would have expected
if ( ret != -ENODEV ) break;
Quoted 6 lines
Quoted 3 lines
Quoted 1 line
or some such instead.
I guess this comes back to our fruit preferences. :)
Does it? It's not just a style question here, but one of when / whether to use the fallback.
Indeed. I was trying to allude back to the earlier conversation. Do we try the pears only when there are no apples or also when the apples are "bad"? Only falling back for no apples is fine.
Quoted 21 lines
Quoted 2 lines
I can switch it around like that, and make
hwp_register_driver()return-ENODEVforhwp_available()returning false.Thanks.
Quoted 16 lines
Quoted 16 lines
xen/arch/x86/acpi/cpufreq/hwp.c line 124
Quoted 7 lines
xen/arch/x86/acpi/cpufreq/hwp.c new file +7
-0+int __init hwp_cmdline_parse (const char *s,const char *e) +{ + do + { + const char *end = strpbrk(s, ",;"); + + if ( s && !hwp_handle_option(s, end) )This check of s not being NULL comes too late, as
strpbrk()would have de-referenced it already. Considering ...Quoted 5 lines
xen/arch/x86/acpi/cpufreq/hwp.c new file +5
-0+ { +printk (XENLOG_WARNING "cpufreq/hwp: option '%s' not recognized\n" , + s); + +return -1 ;
I should change this to -EINVAL.
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 4 lines
xen/arch/x86/acpi/cpufreq/hwp.c new file +4
-0+ } + + s = end ? ++end : end; + }while ( s && s < e );
Quoted 8 lines
Quoted 5 lines
Quoted 1 line
... this it probably wants to move even ahead of the loop.
I'll switch from do/while to just while and then the NULL check will be covered. In practice, this function is never called with s == NULL.
In which case - why not leave things largely as they are, simply dropping the odd check of s?
Sure.
Quoted 28 lines
Quoted 20 lines
Quoted 11 lines
Quoted 11 lines
xen/arch/x86/acpi/cpufreq/hwp.c new file +11
-0+if ( data->curr_req.raw ==-1 ) + { +hwp_err (cpu,"Could not initialize HWP properly\n" ); +per_cpu (hwp_drv_data, cpu) =NULL ; +xfree (data); +return -ENODEV ; + } + + data->minimum = data->curr_req.min_perf; + data->maximum = data->curr_req.max_perf; + data->desired = data->curr_req.desired;Quoted 8 lines
xen/arch/x86/acpi/cpufreq/hwp.c line 433
Quoted 5 lines
xen/arch/x86/acpi/cpufreq/hwp.c new file +5
-0+ data->energy_perf = data->curr_req.energy_perf; + data->activity_window = data->curr_req.activity_window; + +if ( cpu ==0 ) +hwp_verbose ("CPU%u: HWP_CAPABILITIES: %016lx\n" , cpu, data->hwp_caps);While I'm fine with this (perhaps apart from you using "cpu == 0", which is an idiom we're trying to get rid of), ...
Quoted 2 lines
Oh, I didn't know that. What is the preferred way to identify the BSP?
Sometimes we pass a separate boolean to functions, in other cases we check whether a struct
cpuinfo_x86* equals&boot_cpu_info. The latter clearly can't be used here, and the former doesn't look to be a good fit either. However, ...
Quoted 6 lines
Quoted 2 lines
This doesn't necessarily run on the BSP, so "cpu"/"policy->cpu"
is all we have to make a determination.... isn't it, conversely, the case that the function only ever runs on "cpu" when it is the BSP? In which case "cpu ==
smp_processor_id()" ought to do the trick.
The calls do not necessarily run from the BSP. The cpufreq init callbacks run later when dom0 uploads the ACPI processor data. If you don't want "cpu == 0", maybe just print for the first CPU regardless of number, and then print differences from that?
Regards,
Jason
Re: [PATCH v5 06/15] cpufreq: Add Hardware P-State (HWP) driver
Quoted 44 lines · Jason Andryuk
Quoted 23 lines · Jan Beulich
Quoted 22 lines · Jason Andryuk
Quoted 20 lines · Jan Beulich
Quoted 6 lines · Jason Andryuk
docs/misc/xen-command-line.pandoc +2
-0@@ -510,6 +510,22 @@ choice of `dom0-kernel` is deprecated and not supported by all Dom0 kernels. * `<maxfreq>` and `<minfreq>` are integers which represent max and min processor frequencies respectively. * `verbose` option can be included as a string or also as `verbose=<integer>` + for `xen`. It is a boolean for `hwp`. +* `hwp` selects Hardware-Controlled Performance States (HWP) on supported Inteldocs/misc/xen-command-line.pandoc choice of `dom0-kernel` is deprecated and not supported by all Dom0 kernels. · line 524
Quoted 10 lines
docs/misc/xen-command-line.pandoc +10
-0+ hardware. HWP is a Skylake+ feature which provides better CPU power + management. The default is disabled. If `hwp` is selected, but hardware + support is not available, Xen will fallback to cpufreq=xen. +* `<hdc>` is a boolean to enable Hardware Duty Cycling (HDC). HDC enables the + processor to autonomously force physical package components into idle state. + The default is enabled, but the option only applies when `hwp` is enabled. + +There is also support for `;`-separated fallback options: +`cpufreq=hwp,verbose;xen`. This first tries `hwp` and falls back to `xen` +if unavailable.In the given example, does "verbose" also apply to the fallback case? If so, perhaps better "cpufreq=hwp;xen,verbose", to eliminate that ambiguity?
Quoted 6 lines
Quoted 2 lines
Yes, "verbose" is applied to both. I can make the change. I mentioned it in the commit message, but I'll mention it here as well.
FTAOD my earlier comment implied that the spelling form you use above should not even be accepted when parsing. I.e. it was not just about the doc aspect.
Oh. So what exactly do you want then?
There is a single
cpufreq_verbosevariable today that is set by either cpufreq=hwp,verbose or cpufreq=xen,verbose. Is that okay, or should the "xen" and "hwp" each get a separate variable?Do you only want to allow a single trailing "verbose" to apply to all of cpufreq (cpufreq=$foo,verbose)? Or do you want "verbose" to be only valid for "xen"? Both
cpufreq_cmdline_parse()andhwp_cmdline_parse()just loop over their options and don't care about order, even though the documentation lists verbose last. Would you want "cpufreq=hwp,verbose,hdc" to fail to parse?
Quoted 6 lines
All parsing is done upfront before knowing whether "xen" or "hwp" will be used as the cpufreq driver, so there is a trickiness for implementing "verbose" only for one option. Similarly, "cpufreq=hwp,invalid;xen" will try "hwp" (but not "xen") since the live variables are updated. Even without this patch, cpufreq will be configured up to an invalid parameter.
Right, and I'd like to see "hwp;xen" to be treated as a "unit", with ",verbose" applying to whichever succeeds initializing. I don't think there is much point to have separate verbosity variables.
Quoted 3 lines
FYI, cpufreq=xen;hwp will be accepted. "xen" shouldn't fail, so it doesn't make sense to specify that. But it didn't seem necessary to prevent it.
Sure, that's fine.
Quoted 31 lines
Quoted 31 lines
Quoted 20 lines
Quoted 11 lines
Quoted 11 lines
xen/arch/x86/acpi/cpufreq/hwp.c new file +11
-0+if ( data->curr_req.raw ==-1 ) + { +hwp_err (cpu,"Could not initialize HWP properly\n" ); +per_cpu (hwp_drv_data, cpu) =NULL ; +xfree (data); +return -ENODEV ; + } + + data->minimum = data->curr_req.min_perf; + data->maximum = data->curr_req.max_perf; + data->desired = data->curr_req.desired;Quoted 8 lines
xen/arch/x86/acpi/cpufreq/hwp.c line 433
Quoted 5 lines
xen/arch/x86/acpi/cpufreq/hwp.c new file +5
-0+ data->energy_perf = data->curr_req.energy_perf; + data->activity_window = data->curr_req.activity_window; + +if ( cpu ==0 ) +hwp_verbose ("CPU%u: HWP_CAPABILITIES: %016lx\n" , cpu, data->hwp_caps);While I'm fine with this (perhaps apart from you using "cpu == 0", which is an idiom we're trying to get rid of), ...
Quoted 2 lines
Oh, I didn't know that. What is the preferred way to identify the BSP?
Sometimes we pass a separate boolean to functions, in other cases we check whether a struct
cpuinfo_x86* equals&boot_cpu_info. The latter clearly can't be used here, and the former doesn't look to be a good fit either. However, ...Quoted 2 lines
This doesn't necessarily run on the BSP, so "cpu"/"policy->cpu"
is all we have to make a determination.
Quoted 6 lines
Quoted 3 lines
... isn't it, conversely, the case that the function only ever runs on "cpu" when it is the BSP? In which case "cpu ==
smp_processor_id()" ought to do the trick.The calls do not necessarily run from the BSP. The cpufreq init callbacks run later when dom0 uploads the ACPI processor data.
Oh, of course. How did I manage to forget?
Quoted 3 lines
If you
don't want "cpu == 0", maybe just print for the first CPU regardless of number, and then print differences from that?
Perhaps best then.
Jan
Re: [PATCH v5 06/15] cpufreq: Add Hardware P-State (HWP) driver
Quoted 53 lines · Jan Beulich
Quoted 44 lines · Jason Andryuk
Quoted 23 lines · Jan Beulich
Quoted 22 lines · Jason Andryuk
Quoted 20 lines · Jan Beulich
Quoted 6 lines · Jason Andryuk
docs/misc/xen-command-line.pandoc +2
-0@@ -510,6 +510,22 @@ choice of `dom0-kernel` is deprecated and not supported by all Dom0 kernels. * `<maxfreq>` and `<minfreq>` are integers which represent max and min processor frequencies respectively. * `verbose` option can be included as a string or also as `verbose=<integer>` + for `xen`. It is a boolean for `hwp`. +* `hwp` selects Hardware-Controlled Performance States (HWP) on supported Inteldocs/misc/xen-command-line.pandoc choice of `dom0-kernel` is deprecated and not supported by all Dom0 kernels. · line 524
Quoted 10 lines
docs/misc/xen-command-line.pandoc +10
-0+ hardware. HWP is a Skylake+ feature which provides better CPU power + management. The default is disabled. If `hwp` is selected, but hardware + support is not available, Xen will fallback to cpufreq=xen. +* `<hdc>` is a boolean to enable Hardware Duty Cycling (HDC). HDC enables the + processor to autonomously force physical package components into idle state. + The default is enabled, but the option only applies when `hwp` is enabled. + +There is also support for `;`-separated fallback options: +`cpufreq=hwp,verbose;xen`. This first tries `hwp` and falls back to `xen` +if unavailable.In the given example, does "verbose" also apply to the fallback case? If so, perhaps better "cpufreq=hwp;xen,verbose", to eliminate that ambiguity?
Quoted 6 lines
Quoted 2 lines
Yes, "verbose" is applied to both. I can make the change. I mentioned it in the commit message, but I'll mention it here as well.
FTAOD my earlier comment implied that the spelling form you use above should not even be accepted when parsing. I.e. it was not just about the doc aspect.
Oh. So what exactly do you want then?
There is a single
cpufreq_verbosevariable today that is set by either cpufreq=hwp,verbose or cpufreq=xen,verbose. Is that okay, or should the "xen" and "hwp" each get a separate variable?Do you only want to allow a single trailing "verbose" to apply to all of cpufreq (cpufreq=$foo,verbose)? Or do you want "verbose" to be only valid for "xen"? Both
cpufreq_cmdline_parse()andhwp_cmdline_parse()just loop over their options and don't care about order, even though the documentation lists verbose last. Would you want "cpufreq=hwp,verbose,hdc" to fail to parse?Quoted 6 lines
All parsing is done upfront before knowing whether "xen" or "hwp" will be used as the cpufreq driver, so there is a trickiness for implementing "verbose" only for one option. Similarly, "cpufreq=hwp,invalid;xen" will try "hwp" (but not "xen") since the live variables are updated. Even without this patch, cpufreq will be configured up to an invalid parameter.
Quoted 3 lines
Right, and I'd like to see "hwp;xen" to be treated as a "unit", with ",verbose" applying to whichever succeeds initializing. I don't think there is much point to have separate verbosity variables.
When you say "hwp;xen" as a unit, you don't mean to intermix all the options like:
cpufreq=hwp;xen:ondemand,hdc,maxfreq=42
do you?
Because of the suboptions, I don't treat "hwp;xen" as a unit, but as strings separated by ';'.
That allows the full selection of parameters like:
cpufreq=hwc,no-hdc;xen:ondemand,maxfreq=42,minfreq=0
This lets each respective parser handle the options it knows about. This does duplicate "verbose" handling. cpufreq_cmdline_parse() and hwp_cmdline_parse() are also usable when only one of "hwp" or "xen" is specified.
These all work:
cpufreq=xen:ondemand,verbose
cpufreq=hwp,hdc,verbose
cpurfre=hwp,hdc;xen:ondemand,verbose
To disallow "verbose" in "cpufreq=hwp,verbose;xen" would require extra code, and setup_cpufreq_option() is already rather complicated IMO.
It's a corner case, but doesn't seem harmful to me. Hmmm, making the
above fail parsing may be worse since it would only try "hwp" without a fallback to "xen".
I just want to be clear on exactly what I need to implement.
Regards,
Jason
Re: [PATCH v5 06/15] cpufreq: Add Hardware P-State (HWP) driver
Quoted 78 lines · Jason Andryuk
Quoted 53 lines · Jan Beulich
Quoted 44 lines · Jason Andryuk
Quoted 23 lines · Jan Beulich
Quoted 22 lines · Jason Andryuk
Quoted 20 lines · Jan Beulich
Quoted 6 lines · Jason Andryuk
(quoted diff) +2
-0@@ -510,6 +510,22 @@ choice of `dom0-kernel` is deprecated and not supported by all Dom0 kernels. * `<maxfreq>` and `<minfreq>` are integers which represent max and min processor frequencies respectively. * `verbose` option can be included as a string or also as `verbose=<integer>` + for `xen`. It is a boolean for `hwp`. +* `hwp` selects Hardware-Controlled Performance States (HWP) on supported IntelReview choice of `dom0-kernel` is deprecated and not supported by all Dom0 kernels. · line 524
Quoted 10 lines
(quoted diff) +10
-0+ hardware. HWP is a Skylake+ feature which provides better CPU power + management. The default is disabled. If `hwp` is selected, but hardware + support is not available, Xen will fallback to cpufreq=xen. +* `<hdc>` is a boolean to enable Hardware Duty Cycling (HDC). HDC enables the + processor to autonomously force physical package components into idle state. + The default is enabled, but the option only applies when `hwp` is enabled. + +There is also support for `;`-separated fallback options: +`cpufreq=hwp,verbose;xen`. This first tries `hwp` and falls back to `xen` +if unavailable.In the given example, does "verbose" also apply to the fallback case? If so, perhaps better "cpufreq=hwp;xen,verbose", to eliminate that ambiguity?
Quoted 6 lines
Quoted 2 lines
Yes, "verbose" is applied to both. I can make the change. I mentioned it in the commit message, but I'll mention it here as well.
FTAOD my earlier comment implied that the spelling form you use above should not even be accepted when parsing. I.e. it was not just about the doc aspect.
Oh. So what exactly do you want then?
There is a single
cpufreq_verbosevariable today that is set by either cpufreq=hwp,verbose or cpufreq=xen,verbose. Is that okay, or should the "xen" and "hwp" each get a separate variable?Do you only want to allow a single trailing "verbose" to apply to all of cpufreq (cpufreq=$foo,verbose)? Or do you want "verbose" to be only valid for "xen"? Both
cpufreq_cmdline_parse()andhwp_cmdline_parse()just loop over their options and don't care about order, even though the documentation lists verbose last. Would you want "cpufreq=hwp,verbose,hdc" to fail to parse?Quoted 6 lines
All parsing is done upfront before knowing whether "xen" or "hwp" will be used as the cpufreq driver, so there is a trickiness for implementing "verbose" only for one option. Similarly, "cpufreq=hwp,invalid;xen" will try "hwp" (but not "xen") since the live variables are updated. Even without this patch, cpufreq will be configured up to an invalid parameter.
Quoted 3 lines
Right, and I'd like to see "hwp;xen" to be treated as a "unit", with ",verbose" applying to whichever succeeds initializing. I don't think there is much point to have separate verbosity variables.
When you say "hwp;xen" as a unit, you don't mean to intermix all the options like:
cpufreq=hwp;xen:ondemand,hdc,maxfreq=42
do you?Because of the suboptions, I don't treat "hwp;xen" as a unit, but as strings separated by ';'.
That allows the full selection of parameters like:
cpufreq=hwc,no-hdc;xen:ondemand,maxfreq=42,minfreq=0This lets each respective parser handle the options it knows about. This does duplicate "verbose" handling.
cpufreq_cmdline_parse()andhwp_cmdline_parse()are also usable when only one of "hwp" or "xen" is specified.These all work:
cpufreq=xen:ondemand,verbose
cpufreq=hwp,hdc,verbose
cpurfre=hwp,hdc;xen:ondemand,verbose
Quoted 7 lines
To disallow "verbose" in "cpufreq=hwp,verbose;xen" would require extra code, and
setup_cpufreq_option()is already rather complicated IMO.
It's a corner case, but doesn't seem harmful to me. Hmmm, making the
above fail parsing may be worse since it would only try "hwp" without a fallback to "xen".I just want to be clear on exactly what I need to implement.
Maybe we need to take a step back a revisit what option forms actually make sense to express. Part of the problem may be that we permit (but not require afaics) the use of colon as a separator after the "main" option ("xen", "none", "dom0-kernel", and perhaps now "hwp"). Such a colon suggests that what follows are sub-options applicable to that specific "main" option, especially since what follows "xen:" can be more than just the governor name (and in fact no governor name is required - I've been using cpufreq=xen:up_threshold=40 on some of my systems, for example). I have to admit that I don't see a clean way of (largely) retaining existing behavior while at the same time avoiding ambiguity with your additions (and it may well be that there is pre-existing ambiguity as well, but the introduction of yet another separator [semicolon] clearly makes things worse in this regard, as it suggests strong grouping).
Maybe we want to consider an alternative form of expressing the fallback. What about e.g. "cpufreq=hwp:hdc(xen:ondemand),verbose" (and its possible variations)?
Jan
Re: [PATCH v5 06/15] cpufreq: Add Hardware P-State (HWP) driver
Quoted 103 lines · Jan Beulich
Quoted 78 lines · Jason Andryuk
Quoted 53 lines · Jan Beulich
Quoted 44 lines · Jason Andryuk
Quoted 23 lines · Jan Beulich
Quoted 22 lines · Jason Andryuk
Quoted 20 lines · Jan Beulich
Quoted 6 lines · Jason Andryuk
(quoted diff) +2
-0@@ -510,6 +510,22 @@ choice of `dom0-kernel` is deprecated and not supported by all Dom0 kernels. * `<maxfreq>` and `<minfreq>` are integers which represent max and min processor frequencies respectively. * `verbose` option can be included as a string or also as `verbose=<integer>` + for `xen`. It is a boolean for `hwp`. +* `hwp` selects Hardware-Controlled Performance States (HWP) on supported IntelReview choice of `dom0-kernel` is deprecated and not supported by all Dom0 kernels. · line 524
Quoted 10 lines
(quoted diff) +10
-0+ hardware. HWP is a Skylake+ feature which provides better CPU power + management. The default is disabled. If `hwp` is selected, but hardware + support is not available, Xen will fallback to cpufreq=xen. +* `<hdc>` is a boolean to enable Hardware Duty Cycling (HDC). HDC enables the + processor to autonomously force physical package components into idle state. + The default is enabled, but the option only applies when `hwp` is enabled. + +There is also support for `;`-separated fallback options: +`cpufreq=hwp,verbose;xen`. This first tries `hwp` and falls back to `xen` +if unavailable.In the given example, does "verbose" also apply to the fallback case? If so, perhaps better "cpufreq=hwp;xen,verbose", to eliminate that ambiguity?
Quoted 6 lines
Quoted 2 lines
Yes, "verbose" is applied to both. I can make the change. I mentioned it in the commit message, but I'll mention it here as well.
FTAOD my earlier comment implied that the spelling form you use above should not even be accepted when parsing. I.e. it was not just about the doc aspect.
Oh. So what exactly do you want then?
There is a single
cpufreq_verbosevariable today that is set by either cpufreq=hwp,verbose or cpufreq=xen,verbose. Is that okay, or should the "xen" and "hwp" each get a separate variable?Do you only want to allow a single trailing "verbose" to apply to all of cpufreq (cpufreq=$foo,verbose)? Or do you want "verbose" to be only valid for "xen"? Both
cpufreq_cmdline_parse()andhwp_cmdline_parse()just loop over their options and don't care about order, even though the documentation lists verbose last. Would you want "cpufreq=hwp,verbose,hdc" to fail to parse?Quoted 6 lines
All parsing is done upfront before knowing whether "xen" or "hwp" will be used as the cpufreq driver, so there is a trickiness for implementing "verbose" only for one option. Similarly, "cpufreq=hwp,invalid;xen" will try "hwp" (but not "xen") since the live variables are updated. Even without this patch, cpufreq will be configured up to an invalid parameter.
Quoted 3 lines
Right, and I'd like to see "hwp;xen" to be treated as a "unit", with ",verbose" applying to whichever succeeds initializing. I don't think there is much point to have separate verbosity variables.
When you say "hwp;xen" as a unit, you don't mean to intermix all the options like:
cpufreq=hwp;xen:ondemand,hdc,maxfreq=42
do you?Because of the suboptions, I don't treat "hwp;xen" as a unit, but as strings separated by ';'.
That allows the full selection of parameters like:
cpufreq=hwc,no-hdc;xen:ondemand,maxfreq=42,minfreq=0This lets each respective parser handle the options it knows about. This does duplicate "verbose" handling.
cpufreq_cmdline_parse()andhwp_cmdline_parse()are also usable when only one of "hwp" or "xen" is specified.These all work:
cpufreq=xen:ondemand,verbose
cpufreq=hwp,hdc,verbose
cpurfre=hwp,hdc;xen:ondemand,verboseQuoted 7 lines
To disallow "verbose" in "cpufreq=hwp,verbose;xen" would require extra code, and
setup_cpufreq_option()is already rather complicated IMO.
It's a corner case, but doesn't seem harmful to me. Hmmm, making the
above fail parsing may be worse since it would only try "hwp" without a fallback to "xen".I just want to be clear on exactly what I need to implement.
Maybe we need to take a step back a revisit what option forms actually make sense to express. Part of the problem may be that we permit (but not require afaics) the use of colon as a separator after the "main" option ("xen", "none", "dom0-kernel", and perhaps now "hwp"). Such a colon suggests that what follows are sub-options applicable to that specific "main" option, especially since what follows "xen:" can be more than just the governor name (and in fact no governor name is required - I've been using cpufreq=xen:up_threshold=40 on some of my systems, for example). I have to admit that I don't see a clean way of (largely) retaining existing behavior while at the same time avoiding ambiguity with your additions (and it may well be that there is pre-existing ambiguity as well, but the introduction of yet another separator [semicolon] clearly makes things worse in this regard, as it suggests strong grouping).
Quoted 3 lines
Maybe we want to consider an alternative form of expressing the fallback. What about e.g. "cpufreq=hwp:hdc(xen:ondemand),verbose" (and its possible variations)?
I think I like this less.
I think the strong grouping of ';' is nice. It clearly delineates the first and fallback option, and it could be extended to N in the future. I like that if you have 2 working cpufreq= lines, you just concatenate them together with the ';'. If the suboptions were all a disjoint set, I think it would be easy to pick this.
The downside is the "verbose" handling. The strong grouping makes verbose seemingly only apply to the specified group and not globally. Not the best, but we can document that away.
I implemented something to only allow specifying "verbose" in only the last ';' grouping. It's not that bad, but seems a little weird in light of the strong grouping since it uses the same comma separator. Also, failing to parse "verbose" in the first part breaks the concatenation.
A different or additional separator could be used to separate verbose, but that seems kinda overkill and would not be backwards compatible.
Another idea could be to allow multiple cpufreq= lines. Each one would call setup_cpufreq_option(), which could track the entries in cpufreq_xen_opts[]. It still doesn't show a single "verbose" applies globally. And it breaks "later options override earlier ones." "cpufreqfallback=" is another option, but I don't particularly care for that.
I think I just prefer the ';' separator and letting "verbose" be weird. It maps well into the existing syntax and I liked it when you first suggested it.
Regards,
Jason
Re: [PATCH v5 06/15] cpufreq: Add Hardware P-State (HWP) driver
Quoted 3 lines · Jason Andryuk
I think I just prefer the ';' separator and letting "verbose" be weird. It maps well into the existing syntax and I liked it when you first suggested it.
Well, okay, then let's stick to that, emphasizing the weirdness in doc.
Jan
PATCH v5 7/15 xen/x86: Tweak PDC bits when using HWP
In reply to Jason AndryukQubes testing of HWP support had a report of a laptop, Thinkpad X1 Carbon Gen 4 with a Skylake processor, locking up during boot when HWP is enabled. A user found a kernel bug that seems to be the same issue:
https://bugzilla.kernel.org/show_bug.cgi?id=110941.
That bug was fixed by Linux commit a21211672c9a ("ACPI / processor:
Request native thermal interrupt handling via _OSC"). The tl;dr is SMM crashes when it receives thermal interrupts, so Linux calls the ACPI _OSC method to take over interrupt handling.
The Linux fix looks at the CPU features to decide whether or not to call _OSC with bit 12 set to take over native interrupt handling. Xen needs some way to communicate HWP to Dom0 for making an equivalent call.
Xen exposes modified PDC bits via the platform_op set_pminfo hypercall. Expand that to set bit 12 when HWP is present and in use.
Any generated interrupt would be handled by Xen's thermal drive, which clears the status.
Bit 12 isn't named in the linux header and is open coded in Linux's usage. Name it ACPI_PDC_CPPC_NATIVE_INTR.
This will need a corresponding linux patch to pick up and apply the PDC bits.
---
v5:
Minor fixup for feature_hwp removal
Use cpurfreq.h for declaration
v4:
Added __ro_after_init s/ACPI_PDC_CPPC_NTV_INT/ACPI_PDC_CPPC_NATIVE_INTR/ Remove _IA32_
Fixup for opt_cpufreq_hwp removal
Add Jan Reviewed-by
v3:
New
--- xen/arch/x86/acpi/cpufreq/hwp.c | 9 +++++++++ xen/arch/x86/acpi/lib.c | 5 +++++ xen/arch/x86/cpu/mcheck/mce_intel.c | 6 ++++++ xen/arch/x86/include/asm/msr-index.h | 1 + xen/include/acpi/cpufreq/cpufreq.h | 1 + xen/include/acpi/pdc_intel.h | 1 + 6 files changed, 23 insertions(+)
xen/arch/x86/acpi/cpufreq/hwp.c +9 -0
@@ -12,6 +12,8 @@#include <asm/msr.h> #include <acpi/cpufreq/cpufreq.h> +static bool __ro_after_init hwp_in_use; +static bool __ro_after_init feature_hwp_notification;static bool __ro_after_init feature_hwp_activity_window;
@@ -150,6 +152,11 @@ static int __init cf_check cpufreq_gov_hwp_init(void) }__initcall (cpufreq_gov_hwp_init); +bool hwp_active (void ) +{ +return hwp_in_use; +} +static bool __init hwp_available (void ) {unsigned int eax;
@@ -202,6 +209,8 @@ static bool __init hwp_available(void)hwp_verbose ("HW_FEEDBACK %ssupported\n" , (eax &CPUID6_EAX_HW_FEEDBACK ) ?"" :"not " ); + hwp_in_use = true; +hwp_info ("Using HWP for cpufreq\n" );return true;
xen/arch/x86/acpi/lib.c +5 -0
@@ -26,6 +26,8 @@#include <asm/fixmap.h> #include <asm/mwait.h> +#include <acpi/cpufreq/cpufreq.h> +u32 __read_mostly acpi_smi_cmd;u8 __read_mostly acpi_enable_value;u8 __read_mostly acpi_disable_value;
@@ -140,5 +142,8 @@ int arch_acpi_set_pdc_bits(u32 acpi_id, u32 *pdc, u32 mask) !(ecx & CPUID5_ECX_INTERRUPT_BREAK)) pdc[2 ] &= ~(ACPI_PDC_C_C1_FFH |ACPI_PDC_C_C2C3_FFH ); +if (hwp_active ()) + pdc[2 ] |=ACPI_PDC_CPPC_NATIVE_INTR ; +return 0 ; }
xen/arch/x86/cpu/mcheck/mce_intel.c +6 -0
@@ -15,6 +15,9 @@#include <asm/p2m.h> #include <asm/mce.h> #include <asm/apic.h> + +#include <acpi/cpufreq/cpufreq.h> +#include "mce.h" #include "x86_mca.h" #include "barrier.h"
@@ -64,6 +67,9 @@ static void cf_check intel_thermal_interrupt(struct cpu_user_regs *regs)ack_APIC_irq (); +if (hwp_active () ) +wrmsr_safe (MSR_HWP_STATUS ,0 ); +if (NOW () <per_cpu (next, cpu) )return ;
xen/arch/x86/include/asm/msr-index.h +1 -0
@@ -157,6 +157,7 @@#define MSR_HWP_CAPABILITIES 0x00000771#define MSR_HWP_INTERRUPT 0x00000773#define MSR_HWP_REQUEST 0x00000774 +#define MSR_HWP_STATUS 0x00000777#define MSR_X2APIC_FIRST 0x00000800#define MSR_X2APIC_LAST 0x000008ff
xen/include/acpi/cpufreq/cpufreq.h +1 -0
@@ -253,5 +253,6 @@ void intel_feature_detect(struct cpufreq_policy *policy);int hwp_cmdline_parse (const char *s,const char *e);int hwp_register_driver (void ); +bool hwp_active (void );#endif /* __XEN_CPUFREQ_PM_H__ */
xen/include/acpi/pdc_intel.h +1 -0
@@ -17,6 +17,7 @@#define ACPI_PDC_C_C1_FFH (0x0100)#define ACPI_PDC_C_C2C3_FFH (0x0200)#define ACPI_PDC_SMP_P_HWCOORD (0x0800) +#define ACPI_PDC_CPPC_NATIVE_INTR (0x1000)#define ACPI_PDC_EST_CAPABILITY_SMP (ACPI_PDC_SMP_C1PT | \ ACPI_PDC_C_C1_HALT | \
Signature · 1 line
2.41.0
PATCH v5 8/15 xenpm: Change get-cpufreq-para output for hwp
In reply to Jason AndryukWhen using HWP, some of the returned data is not applicable. In that case, we should just omit it to avoid confusing the user. So switch to printing the base and max frequencies since those are relevant to HWP. Similarly, stop printing the CPU frequencies since those do not apply. The scaling fields are also no longer printed.
---
v5:
Use XEN_HWP_DRIVER_NAME
Add Jan's Ack
v4:
s/turbo/max/
Check for XEN_HWP_DRIVER driver instead of "-internal"
v2:
Use full governor name XEN_HWP_GOVERNOR to change output Style fixes
--- tools/misc/xenpm.c | 83 +++++++++++++++++++++++++--------------------- 1 file changed, 46 insertions(+), 37 deletions(-)
tools/misc/xenpm.c +46 -37
@@ -711,6 +711,7 @@ void start_gather_func(int argc, char *argv[])/* print out parameters about cpu frequency */ static void print_cpufreq_para (int cpuid,struct xc_get_cpufreq_para *p_cpufreq) { +bool hwp =strcmp (p_cpufreq->scaling_driver,XEN_HWP_DRIVER_NAME ) ==0 ;int i;printf ("cpu id : %d\n" , cpuid);
@@ -720,49 +721,57 @@ static void print_cpufreq_para(int cpuid, struct xc_get_cpufreq_para *p_cpufreq)printf (" %d" , p_cpufreq->affected_cpus[i]);printf ("\n" ); -printf ("cpuinfo frequency : max [%u] min [%u] cur [%u]\n" , - p_cpufreq->cpuinfo_max_freq, - p_cpufreq->cpuinfo_min_freq, - p_cpufreq->cpuinfo_cur_freq); +if ( hwp ) +printf ("cpuinfo frequency : base [%u] max [%u]\n" , + p_cpufreq->cpuinfo_min_freq, + p_cpufreq->cpuinfo_max_freq); +else +printf ("cpuinfo frequency : max [%u] min [%u] cur [%u]\n" , + p_cpufreq->cpuinfo_max_freq, + p_cpufreq->cpuinfo_min_freq, + p_cpufreq->cpuinfo_cur_freq);printf ("scaling_driver : %s\n" , p_cpufreq->scaling_driver); -printf ("scaling_avail_gov : %s\n" , - p_cpufreq->scaling_available_governors); - -printf ("current_governor : %s\n" , p_cpufreq->u.s.scaling_governor); -if ( !strncmp (p_cpufreq->u.s.scaling_governor, -"userspace" ,CPUFREQ_NAME_LEN ) ) - { -printf (" userspace specific :\n" ); -printf (" scaling_setspeed : %u\n" , - p_cpufreq->u.s.u.userspace.scaling_setspeed); - } -else if ( !strncmp (p_cpufreq->u.s.scaling_governor, -"ondemand" ,CPUFREQ_NAME_LEN ) ) +if ( !hwp ) { -printf (" ondemand specific :\n" ); -printf (" sampling_rate : max [%u] min [%u] cur [%u]\n" , - p_cpufreq->u.s.u.ondemand.sampling_rate_max, - p_cpufreq->u.s.u.ondemand.sampling_rate_min, - p_cpufreq->u.s.u.ondemand.sampling_rate); -printf (" up_threshold : %u\n" , - p_cpufreq->u.s.u.ondemand.up_threshold); - } +printf ("scaling_avail_gov : %s\n" , + p_cpufreq->scaling_available_governors); -printf ("scaling_avail_freq :" ); -for ( i =0 ; i < p_cpufreq->freq_num; i++ ) -if ( p_cpufreq->scaling_available_frequencies[i] == - p_cpufreq->u.s.scaling_cur_freq ) -printf (" *%d" , p_cpufreq->scaling_available_frequencies[i]); -else -printf (" %d" , p_cpufreq->scaling_available_frequencies[i]); -printf ("\n" ); +printf ("current_governor : %s\n" , p_cpufreq->u.s.scaling_governor); +if ( !strncmp (p_cpufreq->u.s.scaling_governor, +"userspace" ,CPUFREQ_NAME_LEN ) ) + { +printf (" userspace specific :\n" ); +printf (" scaling_setspeed : %u\n" , + p_cpufreq->u.s.u.userspace.scaling_setspeed); + } +else if ( !strncmp (p_cpufreq->u.s.scaling_governor, +"ondemand" ,CPUFREQ_NAME_LEN ) ) + { +printf (" ondemand specific :\n" ); +printf (" sampling_rate : max [%u] min [%u] cur [%u]\n" , + p_cpufreq->u.s.u.ondemand.sampling_rate_max, + p_cpufreq->u.s.u.ondemand.sampling_rate_min, + p_cpufreq->u.s.u.ondemand.sampling_rate); +printf (" up_threshold : %u\n" , + p_cpufreq->u.s.u.ondemand.up_threshold); + } + +printf ("scaling_avail_freq :" ); +for ( i =0 ; i < p_cpufreq->freq_num; i++ ) +if ( p_cpufreq->scaling_available_frequencies[i] == + p_cpufreq->u.s.scaling_cur_freq ) +printf (" *%d" , p_cpufreq->scaling_available_frequencies[i]); +else +printf (" %d" , p_cpufreq->scaling_available_frequencies[i]); +printf ("\n" ); -printf ("scaling frequency : max [%u] min [%u] cur [%u]\n" , - p_cpufreq->u.s.scaling_max_freq, - p_cpufreq->u.s.scaling_min_freq, - p_cpufreq->u.s.scaling_cur_freq); +printf ("scaling frequency : max [%u] min [%u] cur [%u]\n" , + p_cpufreq->u.s.scaling_max_freq, + p_cpufreq->u.s.scaling_min_freq, + p_cpufreq->u.s.scaling_cur_freq); + }printf ("turbo mode : %s\n" , p_cpufreq->turbo_enabled ?"enabled" :"disabled or n/a" );
Signature · 1 line
2.41.0
PATCH v5 9/15 cpufreq: Export HWP parameters to userspace as CPPC
In reply to Jason AndryukExtend xen_get_cpufreq_para to return hwp parameters. HWP is an implementation of ACPI CPPC (Collaborative Processor Performance Control). Use the CPPC name since that might be useful in the future for AMD P-state.
We need the features bitmask to indicate fields supported by the actual hardware - this only applies to activity window for the time being.
The HWP most_efficient is mapped to CPPC lowest_nonlinear, and guaranteed is mapped to nominal. CPPC has a guaranteed that is optional while nominal is required. ACPI spec says "If this register is not implemented, OSPM assumes guaranteed performance is always equal to nominal performance."
The use of uint8_t parameters matches the hardware size. uint32_t entries grows the sysctl_t past the build assertion in setup.c. The uint8_t ranges are supported across multiple generations, so hopefully they won't change.
---
v2:
Style fixes
Don't bump XEN_SYSCTL_INTERFACE_VERSION
Drop cpufreq.h comment divider
Expand xen_hwp_para comment
Add HWP activity window mantissa/exponent defines
Handle union rename
Add const to get_hwp_para
Remove hw_ prefix from xen_hwp_para members
Use XEN_HWP_GOVERNOR
Use per_cpu for hwp_drv_data
v4:
Fixup for opt_cpufreq_hwp/hdc removalget_hwp_para() takes cpu as argXEN_ prefix HWP_ACT_WINDOW_*
Drop HWP_ACT_WINDOW_EXPONENT_SHIFT - shift MASK
Remove Energy Bias (0-15) EPP fallback
Rename xen_hwp_para to xen_cppc_para
s/hwp/cppc/
Use scaling driver to switch output
v5:
Use XEN_HWP_DRIVER_NAME
Use cpufreq.h for declarations
Fixup some comments
Drop const from unsigned int cpu
Drop some unnecessary { }
Use strncmp
Switch sizeof(char) to sizeof(*scaling_available_governors) Reindent copy_to_guest call
Add "HWP: " prefix to sysctl comments for cppc->hwp mapping
--- xen/arch/x86/acpi/cpufreq/hwp.c | 23 ++++++++++ xen/drivers/acpi/pmstat.c | 74 ++++++++++++++++-------------- xen/include/acpi/cpufreq/cpufreq.h | 2 + xen/include/public/sysctl.h | 56 ++++++++++++++++++++++ 4 files changed, 121 insertions(+), 34 deletions(-)
xen/arch/x86/acpi/cpufreq/hwp.c +23 -0
@@ -508,6 +508,29 @@ static const struct cpufreq_driver __initconstrel hwp_cpufreq_driver = .update = hwp_cpufreq_update, }; +int get_hwp_para (unsigned int cpu, +struct xen_cppc_para *cppc_para) +{ +const struct hwp_drv_data *data =per_cpu (hwp_drv_data, cpu); + +if ( data ==NULL ) +return -ENODATA ; + + cppc_para->features = + (feature_hwp_activity_window ?XEN_SYSCTL_CPPC_FEAT_ACT_WINDOW :0 ); + cppc_para->lowest = data->hw.lowest; + cppc_para->lowest_nonlinear = data->hw.most_efficient; + cppc_para->nominal = data->hw.guaranteed; + cppc_para->highest = data->hw.highest; + cppc_para->minimum = data->minimum; + cppc_para->maximum = data->maximum; + cppc_para->desired = data->desired; + cppc_para->energy_perf = data->energy_perf; + cppc_para->activity_window = data->activity_window; + +return 0 ; +} +int __init hwp_register_driver (void ) {int ret;
xen/drivers/acpi/pmstat.c +40 -34
86 lines not on this page · raw message
xen/include/acpi/cpufreq/cpufreq.h +2 -0
@@ -254,5 +254,7 @@ void intel_feature_detect(struct cpufreq_policy *policy);int hwp_cmdline_parse (const char *s,const char *e);int hwp_register_driver (void );bool hwp_active (void ); +int get_hwp_para (unsigned int cpu, +struct xen_cppc_para *cppc_para);#endif /* __XEN_CPUFREQ_PM_H__ */
xen/include/public/sysctl.h +56 -0
68 lines not on this page · raw message
Signature · 1 line
2.41.0
Re: [PATCH v5 09/15] cpufreq: Export HWP parameters to userspace as CPPC
Quoted 13 lines · Jason Andryuk
Extend
xen_get_cpufreq_parato return hwp parameters. HWP is an implementation of ACPI CPPC (Collaborative Processor Performance Control). Use the CPPC name since that might be useful in the future for AMD P-state.We need the features bitmask to indicate fields supported by the actual hardware - this only applies to activity window for the time being.
The HWP
most_efficientis mapped to CPPClowest_nonlinear, and guaranteed is mapped to nominal. CPPC has a guaranteed that is optional while nominal is required. ACPI spec says "If this register is not implemented, OSPM assumes guaranteed performance is always equal to nominal performance."
Quoted 4 lines
The use of
uint8_tparameters matches the hardware size.uint32_tentries grows thesysctl_tpast the build assertion insetup.c. Theuint8_tranges are supported across multiple generations, so hopefully they won't change.
Isn't this paragraph stale now?
Quoted 13 lines
xen/drivers/acpi/pmstat.c +2
-5@@ -251,46 +251,52 @@ static int get_cpufreq_para(struct xen_sysctl_pm_op *op)else strlcpy (op->u.get_para.scaling_driver,"Unknown" ,CPUFREQ_NAME_LEN ); -if ( !(scaling_available_governors = -xzalloc_array (char, gov_num *CPUFREQ_NAME_LEN )) ) -return -ENOMEM ; -if ( (ret =read_scaling_available_governors (scaling_available_governors, - gov_num *CPUFREQ_NAME_LEN *sizeof (char ))) ) +if ( !strncmp (op->u.get_para.scaling_driver,XEN_HWP_DRIVER_NAME , +CPUFREQ_NAME_LEN ) )
xen/drivers/acpi/pmstat.c static int get_cpufreq_para(struct xen_sysctl_pm_op *op) · line 265
Quoted 10 lines
xen/drivers/acpi/pmstat.c +9
-0+ ret =get_hwp_para (policy->cpu, &op->u.get_para.u.cppc_para); + else { +if ( !(scaling_available_governors = +xzalloc_array (char, gov_num *CPUFREQ_NAME_LEN )) ) +return -ENOMEM ; +if ( (ret =read_scaling_available_governors ( + scaling_available_governors, + gov_num *CPUFREQ_NAME_LEN * +sizeof (*scaling_available_governors) )) )
Nit: Too deep indentation of this last line. If you want to visually express the continuation of the last argument, add a pair of parens:
if ( (ret = read_scaling_available_governors(
scaling_available_governors, (gov_num * CPUFREQ_NAME_LEN *
sizeof(*scaling_available_governors)))) )
Otherwise all line beginnings want to align with one another, no matter whether new or continued argument.
Also there's a stray blank after the 1st closing paren.
Quoted 5 lines
xen/include/public/sysctl.h +0
-0@@ -296,6 +296,61 @@ struct xen_ondemand {uint32_t up_threshold; };
xen/include/public/sysctl.h struct xen_ondemand { · line 307
Quoted 10 lines
xen/include/public/sysctl.h +9
-0+struct xen_cppc_para { +/* OUT */ +/* activity_window supported if set */ +#define XEN_SYSCTL_CPPC_FEAT_ACT_WINDOW (1 << 0) +uint32_t features;/* bit flags for features */ +/* +* See Intel SDM: HWP Performance Range and Dynamic Capabilities +* +* These four are 0-255 hardware-provided values. They "continuous,
Nit: "They're"
xen/include/public/sysctl.h struct xen_ondemand { · line 310
Quoted 3 lines
xen/include/public/sysctl.h +3
-0+* abstract unit-less, performance" values. Smaller numbers are slower +* and larger ones are faster. +*/
With the adjustments (provided you agree)
Jan
Re: [PATCH v5 09/15] cpufreq: Export HWP parameters to userspace as CPPC
Quoted 3 lines · Jan Beulich
With the adjustments (provided you agree)
Acked-by Jan Beulich <[email protected]>
Yes, they all sound good. Thank you.
-Jason
PATCH v5 10/15 libxc: Include cppc_para in definitions
In reply to Jason AndryukExpose the cppc_para fields through libxc.
---
v4:
Rename hwp to cppc
Add Anthony's Ack
--- tools/include/xenctrl.h | 2 ++ 1 file changed, 2 insertions(+)
tools/include/xenctrl.h +2 -0
@@ -1892,6 +1892,7 @@ int xc_smt_disable(xc_interface *xch);*/ typedef struct xen_userspace xc_userspace_t ;typedef struct xen_ondemand xc_ondemand_t ; +typedef struct xen_cppc_para xc_cppc_para_t ;struct xc_get_cpufreq_para {/* IN/OUT variable */
@@ -1923,6 +1924,7 @@ struct xc_get_cpufreq_para {xc_ondemand_t ondemand; } u; } s; +xc_cppc_para_t cppc_para; } u;int32_t turbo_enabled;
Signature · 1 line
2.41.0
PATCH v5 11/15 xenpm: Print HWP/CPPC parameters
In reply to Jason AndryukPrint HWP-specific parameters. Some are always present, but others depend on hardware support.
---
v2:
Style fixes
Declare i outside loop
Replace repearted hardware/configured limits with spaces Fixup for hw_ removal
Use XEN_HWP_GOVERNOR
Use HWP_ACT_WINDOW_EXPONENT_*
Remove energy_perf hw autonomous - 0 doesn't mean autonomous
v4:
Return activity_window from calculate_hwp_activity_window Use blanks instead of _ in output
Use MASK_EXTR
Check XEN_HWP_DRIVER name since governor is no longer returned s/hwp/cppc
v5:
Add Jan's Reviewed-by
--- tools/misc/xenpm.c | 66 ++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 66 insertions(+)
tools/misc/xenpm.c +66 -0
@@ -708,6 +708,46 @@ void start_gather_func(int argc, char *argv[])pause (); } +static unsigned int calculate_activity_window (const xc_cppc_para_t *cppc, +const char **units) +{ +unsigned int mantissa =MASK_EXTR (cppc->activity_window, +XEN_CPPC_ACT_WINDOW_MANTISSA_MASK ); +unsigned int exponent =MASK_EXTR (cppc->activity_window, +XEN_CPPC_ACT_WINDOW_EXPONENT_MASK ); +unsigned int multiplier =1 ; +unsigned int i; + +/* +* SDM only states a 0 register is hardware selected, and doesn't mention +* a 0 mantissa with a non-0 exponent. Only special case a 0 register. +*/ +if ( cppc->activity_window ==0 ) + { + *units ="hardware selected" ; + +return 0 ; + } + +if ( exponent >=6 ) + { + *units ="s" ; + exponent -=6 ; + } +else if ( exponent >=3 ) + { + *units ="ms" ; + exponent -=3 ; + } +else + *units ="us" ; + +for ( i =0 ; i < exponent; i++ ) + multiplier *=10 ; + +return mantissa * multiplier; +} +/* print out parameters about cpu frequency */ static void print_cpufreq_para (int cpuid,struct xc_get_cpufreq_para *p_cpufreq) {
@@ -772,6 +812,32 @@ static void print_cpufreq_para(int cpuid, struct xc_get_cpufreq_para *p_cpufreq) p_cpufreq->u.s.scaling_min_freq, p_cpufreq->u.s.scaling_cur_freq); } +else + { +const xc_cppc_para_t *cppc = &p_cpufreq->u.cppc_para; + +printf ("cppc variables :\n" ); +printf (" hardware limits : lowest [%u] lowest nonlinear [%u]\n" , + cppc->lowest, cppc->lowest_nonlinear); +printf (" : nominal [%u] highest [%u]\n" , + cppc->nominal, cppc->highest); +printf (" configured limits : min [%u] max [%u] energy perf [%u]\n" , + cppc->minimum, cppc->maximum, cppc->energy_perf); + +if ( cppc->features &XEN_SYSCTL_CPPC_FEAT_ACT_WINDOW ) + { +unsigned int activity_window; +const char *units; + + activity_window =calculate_activity_window (cppc, &units); +printf (" : activity_window [%u %s]\n" , + activity_window, units); + } + +printf (" : desired [%u%s]\n" , + cppc->desired, + cppc->desired ?"" :" hw autonomous" ); + }printf ("turbo mode : %s\n" , p_cpufreq->turbo_enabled ?"enabled" :"disabled or n/a" );
Signature · 1 line
2.41.0
PATCH v5 12/15 xen: Add SET_CPUFREQ_HWP xen_sysctl_pm_op
In reply to Jason AndryukAdd SET_CPUFREQ_HWP xen_sysctl_pm_op to set HWP parameters. The sysctl supports setting multiple values simultaneously as indicated by the set_params bits. This allows atomically applying new HWP configuration via a single wrmsr.
XEN_SYSCTL_HWP_SET_PRESET_BALANCE/PERFORMANCE/POWERSAVE provide three common presets. Setting them depends on hardware limits which the hypervisor is already caching. So using them allows skipping a hypercall to query the limits (lowest/highest) to then set those same values. The code is organized to allow a preset to be refined with additional parameters if desired.
"most_efficient" and "guaranteed" could be additional presets in the future, but the are not added now. Those levels can change at runtime, but we don't have code in place to monitor and update for those events.
Since activity window may not be supported by all hardware, omit writing it when not supported, and return that fact to userspace by updating set_params.
CPPC parameter checking disallows setting reserved bytes and ensure values are only non-zero when the corresponding set_params bit is set. There is no range checking (0-255 is allowed) since hardware is documented to clip internally.
---
v5:
Use cpufreq.h for include
Add () around bit test
Fix Configure typo
Drop duplicated energy_perf comment
Define XEN_SYSCTL_CPPC_ACT_WINDOW_MASK from *_MANTISSA_MASK and *_EXPONENT_MASK Re-order XEN_SYSCTL_CPPC_SET_* flags to match field and hardware order. Remove const from set_cppc param to update set_params
Skip Activity Window if not supported by hardware and clear set_params Make parameter parsing consistent
Add an exit path when there are no parameters to write.
Expand the header file to cover the IN/OUT set_params.
Remove the "desired" lowest/highest checking as hardware clips internally
v4:
Remove IA32_ENERGY_BIAS support
Validate parameters don't exceed 255
Use CPPC/cppc nameset_cppc_para() add constset_cppc_para() return hwp_cpufreq_target()
Expand sysctl comments
v3:
Remove cpufreq_governor_internal from set_cpufreq_hwp
v2:
Update for naming anonymous union
Drop hwp_err for invalid input in set_hwp_para() Drop uint16_t cast in XEN_SYSCTL_HWP_SET_PARAM_MASK Drop parens for HWP_SET_PRESET defines
Reference activity_window format comment
Place SET_CPUFREQ_HWP after SET_CPUFREQ_PARA
Add {HWP,IA32}_ENERGY_PERF_MAX_{PERFORMANCE,POWERSAVE} defines Order defines before fields in sysctl.h
Use XEN_HWP_GOVERNOR
Use per_cpu for hwp_drv_data
--- xen/arch/x86/acpi/cpufreq/hwp.c | 101 +++++++++++++++++++++++++++++ xen/drivers/acpi/pmstat.c | 17 +++++ xen/include/acpi/cpufreq/cpufreq.h | 2 + xen/include/public/sysctl.h | 64 ++++++++++++++++++ 4 files changed, 184 insertions(+)
xen/arch/x86/acpi/cpufreq/hwp.c +101 -0
@@ -21,6 +21,10 @@ static bool __ro_after_init feature_hdc;static bool __ro_after_init opt_cpufreq_hdc = true; +#define HWP_ENERGY_PERF_MAX_PERFORMANCE 0 +#define HWP_ENERGY_PERF_BALANCE 0x80 +#define HWP_ENERGY_PERF_MAX_POWERSAVE 0xff +union hwp_request { struct
@@ -531,6 +535,103 @@ int get_hwp_para(unsigned int cpu,return 0 ; } +int set_hwp_para (struct cpufreq_policy *policy, +struct xen_set_cppc_para *set_cppc) +{ +unsigned int cpu = policy->cpu; +struct hwp_drv_data *data =per_cpu (hwp_drv_data, cpu); +bool cleared_act_window = false; + +if ( data ==NULL ) +return -EINVAL ; + +/* Validate all parameters - Disallow reserved bits. */ +if ( set_cppc->minimum >255 || + set_cppc->maximum >255 || + set_cppc->desired >255 || + set_cppc->energy_perf >255 || + set_cppc->set_params & ~XEN_SYSCTL_CPPC_SET_PARAM_MASK || + set_cppc->activity_window & ~XEN_SYSCTL_CPPC_ACT_WINDOW_MASK ) +return -EINVAL ; + +/* Only allow values if params bit is set. */ +if ( (!(set_cppc->set_params &XEN_SYSCTL_CPPC_SET_DESIRED ) && + set_cppc->desired) || + (!(set_cppc->set_params &XEN_SYSCTL_CPPC_SET_MINIMUM ) && + set_cppc->minimum) || + (!(set_cppc->set_params &XEN_SYSCTL_CPPC_SET_MAXIMUM ) && + set_cppc->maximum) || + (!(set_cppc->set_params &XEN_SYSCTL_CPPC_SET_ENERGY_PERF ) && + set_cppc->energy_perf) || + (!(set_cppc->set_params &XEN_SYSCTL_CPPC_SET_ACT_WINDOW ) && + set_cppc->activity_window) ) +return -EINVAL ; + +/* Clear out activity window if lacking HW supported. */ +if ( (set_cppc->set_params &XEN_SYSCTL_CPPC_SET_ACT_WINDOW ) && + !feature_hwp_activity_window ) { + set_cppc->set_params &= ~XEN_SYSCTL_CPPC_SET_ACT_WINDOW ; + cleared_act_window = true; + } + +/* Return if there is nothing to do. */ +if ( set_cppc->set_params ==0 ) +return cleared_act_window ?0 : -EINVAL ; + +/* Apply presets */ +switch ( set_cppc->set_params &XEN_SYSCTL_CPPC_SET_PRESET_MASK ) + { +case XEN_SYSCTL_CPPC_SET_PRESET_POWERSAVE : + data->minimum = data->hw.lowest; + data->maximum = data->hw.lowest; + data->activity_window =0 ; + data->energy_perf =HWP_ENERGY_PERF_MAX_POWERSAVE ; + data->desired =0 ; +break ; + +case XEN_SYSCTL_CPPC_SET_PRESET_PERFORMANCE : + data->minimum = data->hw.highest; + data->maximum = data->hw.highest; + data->activity_window =0 ; + data->energy_perf =HWP_ENERGY_PERF_MAX_PERFORMANCE ; + data->desired =0 ; +break ; + +case XEN_SYSCTL_CPPC_SET_PRESET_BALANCE : + data->minimum = data->hw.lowest; + data->maximum = data->hw.highest; + data->activity_window =0 ; + data->energy_perf =HWP_ENERGY_PERF_BALANCE ; + data->desired =0 ; +break ; + +case XEN_SYSCTL_CPPC_SET_PRESET_NONE : +break ; + +default : +return -EINVAL ; + } + +/* Further customize presets if needed */ +if ( set_cppc->set_params &XEN_SYSCTL_CPPC_SET_MINIMUM ) + data->minimum = set_cppc->minimum; + +if ( set_cppc->set_params &XEN_SYSCTL_CPPC_SET_MAXIMUM ) + data->maximum = set_cppc->maximum; + +if ( set_cppc->set_params &XEN_SYSCTL_CPPC_SET_ENERGY_PERF ) + data->energy_perf = set_cppc->energy_perf; + +if ( set_cppc->set_params &XEN_SYSCTL_CPPC_SET_DESIRED ) + data->desired = set_cppc->desired; + +if ( set_cppc->set_params &XEN_SYSCTL_CPPC_SET_ACT_WINDOW ) + data->activity_window = set_cppc->activity_window & +XEN_SYSCTL_CPPC_ACT_WINDOW_MASK ; + +return hwp_cpufreq_target (policy,0 ,0 ); +} +int __init hwp_register_driver (void ) {int ret;
xen/drivers/acpi/pmstat.c +17 -0
@@ -400,6 +400,19 @@ static int set_cpufreq_para(struct xen_sysctl_pm_op *op)return ret; } +static int set_cpufreq_cppc (struct xen_sysctl_pm_op *op) +{ +struct cpufreq_policy *policy =per_cpu (cpufreq_cpu_policy, op->cpuid); + +if ( !policy || !policy->governor ) +return -EINVAL ; + +if ( !hwp_active () ) +return -EINVAL ; + +return set_hwp_para (policy, &op->u.set_cppc); +} +int do_pm_op (struct xen_sysctl_pm_op *op) {int ret =0 ;
@@ -472,6 +485,10 @@ int do_pm_op(struct xen_sysctl_pm_op *op)break ; } +case SET_CPUFREQ_CPPC : + ret =set_cpufreq_cppc (op); +break ; +case GET_CPUFREQ_AVGFREQ : { op->u.get_avgfreq =cpufreq_driver_getavg (op->cpuid,USR_GETAVG );
xen/include/acpi/cpufreq/cpufreq.h +2 -0
@@ -256,5 +256,7 @@ int hwp_register_driver(void);bool hwp_active (void );int get_hwp_para (unsigned int cpu,struct xen_cppc_para *cppc_para); +int set_hwp_para (struct cpufreq_policy *policy, +struct xen_set_cppc_para *set_cppc);#endif /* __XEN_CPUFREQ_PM_H__ */
xen/include/public/sysctl.h +64 -0
82 lines not on this page · raw message
Signature · 1 line
2.41.0
Re: [PATCH v5 12/15] xen: Add SET_CPUFREQ_HWP xen_sysctl_pm_op
xen/arch/x86/acpi/cpufreq/hwp.c int get_hwp_para(unsigned int cpu, · line 546
Quoted 13 lines · Jason Andryuk
xen/arch/x86/acpi/cpufreq/hwp.c +9
-0@@ -531,6 +535,103 @@ int get_hwp_para(unsigned int cpu,return 0 ; } +int set_hwp_para (struct cpufreq_policy *policy, +struct xen_set_cppc_para *set_cppc) +{ +unsigned int cpu = policy->cpu; +struct hwp_drv_data *data =per_cpu (hwp_drv_data, cpu); +bool cleared_act_window = false; + +if ( data ==NULL ) +return -EINVAL ;
I don't think EINVAL is appropriate here. EOPNOTSUPP might be, or ENOENT, or EIO, or perhaps a few others.
xen/arch/x86/acpi/cpufreq/hwp.c int get_hwp_para(unsigned int cpu, · line 554
Quoted 7 lines
xen/arch/x86/acpi/cpufreq/hwp.c +7
-0+/* Validate all parameters - Disallow reserved bits. */ +if ( set_cppc->minimum >255 || + set_cppc->maximum >255 || + set_cppc->desired >255 || + set_cppc->energy_perf >255 || + set_cppc->set_params & ~XEN_SYSCTL_CPPC_SET_PARAM_MASK || + set_cppc->activity_window & ~XEN_SYSCTL_CPPC_ACT_WINDOW_MASK )
Nit: Parentheses again please around the operands of &.
Quoted 15 lines
xen/arch/x86/acpi/cpufreq/hwp.c +15
-0+return -EINVAL ; + +/* Only allow values if params bit is set. */ +if ( (!(set_cppc->set_params &XEN_SYSCTL_CPPC_SET_DESIRED ) && + set_cppc->desired) || + (!(set_cppc->set_params &XEN_SYSCTL_CPPC_SET_MINIMUM ) && + set_cppc->minimum) || + (!(set_cppc->set_params &XEN_SYSCTL_CPPC_SET_MAXIMUM ) && + set_cppc->maximum) || + (!(set_cppc->set_params &XEN_SYSCTL_CPPC_SET_ENERGY_PERF ) && + set_cppc->energy_perf) || + (!(set_cppc->set_params &XEN_SYSCTL_CPPC_SET_ACT_WINDOW ) && + set_cppc->activity_window) ) +return -EINVAL ; +
xen/arch/x86/acpi/cpufreq/hwp.c int get_hwp_para(unsigned int cpu, · line 579
Quoted 10 lines
xen/arch/x86/acpi/cpufreq/hwp.c +10
-0+/* Clear out activity window if lacking HW supported. */ +if ( (set_cppc->set_params &XEN_SYSCTL_CPPC_SET_ACT_WINDOW ) && + !feature_hwp_activity_window ) { + set_cppc->set_params &= ~XEN_SYSCTL_CPPC_SET_ACT_WINDOW ; + cleared_act_window = true; + } + +/* Return if there is nothing to do. */ +if ( set_cppc->set_params ==0 ) +return cleared_act_window ?0 : -EINVAL ;
Is it really necessary to return an error when there's nothing to do? We have various hypercalls which can degenerate to no-ops under certain conditions, and which simply return success then.
Quoted 5 lines
xen/drivers/acpi/pmstat.c +0
-0@@ -400,6 +400,19 @@ static int set_cpufreq_para(struct xen_sysctl_pm_op *op)return ret; }
xen/drivers/acpi/pmstat.c static int set_cpufreq_para(struct xen_sysctl_pm_op *op) · line 411
Quoted 10 lines
xen/drivers/acpi/pmstat.c +9
-0+static int set_cpufreq_cppc (struct xen_sysctl_pm_op *op) +{ +struct cpufreq_policy *policy =per_cpu (cpufreq_cpu_policy, op->cpuid); + +if ( !policy || !policy->governor ) +return -EINVAL ; + +if ( !hwp_active () ) +return -EINVAL ;
In both cases I again wonder in how far EINVAL is really appropriate.
Quoted 38 lines
xen/include/public/sysctl.h +32
-0@@ -351,6 +351,68 @@ struct xen_cppc_para {uint32_t activity_window; }; +/* +* Set CPPC values. +* +* Configure the parameters for CPPC. Set bits in set_params control which +* values are applied. If a bit is not set in set_params, the field must be +* zero. +* +* For HWP specifically, values must be limited to 0-255 or within +* XEN_SYSCTL_CPPC_ACT_WINDOW_MASK for activity window. Set bits outside the +* range will be returned as -EINVAL. +* +* Activity Window may not be supported by the hardware. In that case, the +* returned set_params will clear XEN_SYSCTL_CPPC_SET_ACT_WINDOW to indicate +* that it was not applied - though the rest of the values will be applied. +* +* There are a set of presets along with individual fields. Presets are +* applied first, and then individual fields. This allows customizing +* a preset without having to specify every value. +* +* The preset options values are as follows: +* +* preset | minimum | maxium | energy_perf +* ------------+---------+---------+---------------- +* powersave | lowest | lowest | powersave (255) +* ------------+---------+---------+---------------- +* balance | lowest | highest | balance (128) +* ------------+---------+---------+---------------- +* performance | highest | highest | performance (0) +* +* desired and activity_window are set to 0, hardware selected. +*/ +struct xen_set_cppc_para {
xen/include/public/sysctl.h struct xen_cppc_para { · line 395
Quoted 10 lines
xen/include/public/sysctl.h +10
-0+#define XEN_SYSCTL_CPPC_SET_MINIMUM (1U << 0) +#define XEN_SYSCTL_CPPC_SET_MAXIMUM (1U << 1) +#define XEN_SYSCTL_CPPC_SET_DESIRED (1U << 2) +#define XEN_SYSCTL_CPPC_SET_ENERGY_PERF (1U << 3) +#define XEN_SYSCTL_CPPC_SET_ACT_WINDOW (1U << 4) +#define XEN_SYSCTL_CPPC_SET_PRESET_MASK 0xf0000000 +#define XEN_SYSCTL_CPPC_SET_PRESET_NONE 0x00000000 +#define XEN_SYSCTL_CPPC_SET_PRESET_BALANCE 0x10000000 +#define XEN_SYSCTL_CPPC_SET_PRESET_POWERSAVE 0x20000000 +#define XEN_SYSCTL_CPPC_SET_PRESET_PERFORMANCE 0x30000000
As corrections for the respective Misra rule are in the process of being merged, please add U suffixes here (at the very least on the _MASK).
Jan
Re: [PATCH v5 12/15] xen: Add SET_CPUFREQ_HWP xen_sysctl_pm_op
Quoted 6 lines · Jan Beulich
Quoted 4 lines · Jason Andryuk
xen/arch/x86/acpi/cpufreq/hwp.c +0
-0@@ -531,6 +535,103 @@ int get_hwp_para(unsigned int cpu,return 0 ; }
Quoted 12 lines
xen/arch/x86/acpi/cpufreq/hwp.c int get_hwp_para(unsigned int cpu, · line 546
Quoted 9 lines
xen/arch/x86/acpi/cpufreq/hwp.c +9
-0+int set_hwp_para (struct cpufreq_policy *policy, +struct xen_set_cppc_para *set_cppc) +{ +unsigned int cpu = policy->cpu; +struct hwp_drv_data *data =per_cpu (hwp_drv_data, cpu); +bool cleared_act_window = false; + +if ( data ==NULL ) +return -EINVAL ;I don't think EINVAL is appropriate here. EOPNOTSUPP might be, or ENOENT, or EIO, or perhaps a few others.
Yes. ENOENT seems good here since a NULL data is comparable to not existing.
Quoted 9 lines
xen/arch/x86/acpi/cpufreq/hwp.c int get_hwp_para(unsigned int cpu, · line 554
Quoted 7 lines
xen/arch/x86/acpi/cpufreq/hwp.c +7
-0+/* Validate all parameters - Disallow reserved bits. */ +if ( set_cppc->minimum >255 || + set_cppc->maximum >255 || + set_cppc->desired >255 || + set_cppc->energy_perf >255 || + set_cppc->set_params & ~XEN_SYSCTL_CPPC_SET_PARAM_MASK || + set_cppc->activity_window & ~XEN_SYSCTL_CPPC_ACT_WINDOW_MASK )Nit: Parentheses again please around the operands of &.
Sure
Quoted 21 lines
Quoted 21 lines
xen/arch/x86/acpi/cpufreq/hwp.c +21
-0+return -EINVAL ; + +/* Only allow values if params bit is set. */ +if ( (!(set_cppc->set_params &XEN_SYSCTL_CPPC_SET_DESIRED ) && + set_cppc->desired) || + (!(set_cppc->set_params &XEN_SYSCTL_CPPC_SET_MINIMUM ) && + set_cppc->minimum) || + (!(set_cppc->set_params &XEN_SYSCTL_CPPC_SET_MAXIMUM ) && + set_cppc->maximum) || + (!(set_cppc->set_params &XEN_SYSCTL_CPPC_SET_ENERGY_PERF ) && + set_cppc->energy_perf) || + (!(set_cppc->set_params &XEN_SYSCTL_CPPC_SET_ACT_WINDOW ) && + set_cppc->activity_window) ) +return -EINVAL ; + +/* Clear out activity window if lacking HW supported. */ +if ( (set_cppc->set_params &XEN_SYSCTL_CPPC_SET_ACT_WINDOW ) && + !feature_hwp_activity_window ) { + set_cppc->set_params &= ~XEN_SYSCTL_CPPC_SET_ACT_WINDOW ; + cleared_act_window = true; + }
Quoted 8 lines
xen/arch/x86/acpi/cpufreq/hwp.c int get_hwp_para(unsigned int cpu, · line 579
Quoted 4 lines
xen/arch/x86/acpi/cpufreq/hwp.c +4
-0+ +/* Return if there is nothing to do. */ +if ( set_cppc->set_params ==0 ) +return cleared_act_window ?0 : -EINVAL ;Is it really necessary to return an error when there's nothing to do? We have various hypercalls which can degenerate to no-ops under certain conditions, and which simply return success then.
With all the earlier parameter checking, I think it would be fine to return success here for a no-op.
Quoted 6 lines
Quoted 6 lines
xen/drivers/acpi/pmstat.c +0
-0@@ -400,6 +400,19 @@ static int set_cpufreq_para(struct xen_sysctl_pm_op *op)return ret; }
Quoted 11 lines
xen/drivers/acpi/pmstat.c static int set_cpufreq_para(struct xen_sysctl_pm_op *op) · line 411
Quoted 9 lines
xen/drivers/acpi/pmstat.c +9
-0+static int set_cpufreq_cppc (struct xen_sysctl_pm_op *op) +{ +struct cpufreq_policy *policy =per_cpu (cpufreq_cpu_policy, op->cpuid); + +if ( !policy || !policy->governor ) +return -EINVAL ; + +if ( !hwp_active () ) +return -EINVAL ;In both cases I again wonder in how far EINVAL is really appropriate.
-EOPNOTSUPP seems good for the !hwp_active() case. Maybe ENOENT for the policy one.
Quoted 44 lines
Quoted 44 lines
xen/include/public/sysctl.h +38
-0@@ -351,6 +351,68 @@ struct xen_cppc_para {uint32_t activity_window; }; +/* +* Set CPPC values. +* +* Configure the parameters for CPPC. Set bits in set_params control which +* values are applied. If a bit is not set in set_params, the field must be +* zero. +* +* For HWP specifically, values must be limited to 0-255 or within +* XEN_SYSCTL_CPPC_ACT_WINDOW_MASK for activity window. Set bits outside the +* range will be returned as -EINVAL. +* +* Activity Window may not be supported by the hardware. In that case, the +* returned set_params will clear XEN_SYSCTL_CPPC_SET_ACT_WINDOW to indicate +* that it was not applied - though the rest of the values will be applied. +* +* There are a set of presets along with individual fields. Presets are +* applied first, and then individual fields. This allows customizing +* a preset without having to specify every value. +* +* The preset options values are as follows: +* +* preset | minimum | maxium | energy_perf +* ------------+---------+---------+---------------- +* powersave | lowest | lowest | powersave (255) +* ------------+---------+---------+---------------- +* balance | lowest | highest | balance (128) +* ------------+---------+---------+---------------- +* performance | highest | highest | performance (0) +* +* desired and activity_window are set to 0, hardware selected. +*/ +struct xen_set_cppc_para { +#define XEN_SYSCTL_CPPC_SET_MINIMUM (1U << 0) +#define XEN_SYSCTL_CPPC_SET_MAXIMUM (1U << 1) +#define XEN_SYSCTL_CPPC_SET_DESIRED (1U << 2) +#define XEN_SYSCTL_CPPC_SET_ENERGY_PERF (1U << 3) +#define XEN_SYSCTL_CPPC_SET_ACT_WINDOW (1U << 4) +#define XEN_SYSCTL_CPPC_SET_PRESET_MASK 0xf0000000
Quoted 8 lines
xen/include/public/sysctl.h struct xen_cppc_para { · line 395
Quoted 4 lines
xen/include/public/sysctl.h +4
-0+#define XEN_SYSCTL_CPPC_SET_PRESET_NONE 0x00000000 +#define XEN_SYSCTL_CPPC_SET_PRESET_BALANCE 0x10000000 +#define XEN_SYSCTL_CPPC_SET_PRESET_POWERSAVE 0x20000000 +#define XEN_SYSCTL_CPPC_SET_PRESET_PERFORMANCE 0x30000000As corrections for the respective Misra rule are in the process of being merged, please add U suffixes here (at the very least on the
_MASK).
Sure.
Thanks,
Jason
PATCH v5 13/15 libxc: Add xc_set_cpufreq_cppc
In reply to Jason AndryukAdd xc_set_cpufreq_cppc to allow calling xen_systctl_pm_op SET_CPUFREQ_CPPC.
---
v2:
Mark xc_set_hwp_para_t const
v4:
s/hwp/cppc/
Add Anthony's Ack
v5:
Remove const and copy back result
--- tools/include/xenctrl.h | 4 ++++ tools/libs/ctrl/xc_pm.c | 23 +++++++++++++++++++++++ 2 files changed, 27 insertions(+)
tools/include/xenctrl.h +4 -0
@@ -1930,11 +1930,15 @@ struct xc_get_cpufreq_para {int32_t turbo_enabled; }; +typedef struct xen_set_cppc_para xc_set_cppc_para_t ; +int xc_get_cpufreq_para (xc_interface *xch,int cpuid,struct xc_get_cpufreq_para *user_para);int xc_set_cpufreq_gov (xc_interface *xch,int cpuid,char *govname);int xc_set_cpufreq_para (xc_interface *xch,int cpuid,int ctrl_type,int ctrl_value); +int xc_set_cpufreq_cppc (xc_interface *xch,int cpuid, +xc_set_cppc_para_t *set_cppc);int xc_get_cpufreq_avgfreq (xc_interface *xch,int cpuid,int *avg_freq);int xc_set_sched_opt_smt (xc_interface *xch,uint32_t value);
tools/libs/ctrl/xc_pm.c +23 -0
@@ -329,6 +329,29 @@ int xc_set_cpufreq_para(xc_interface *xch, int cpuid,return xc_sysctl (xch, &sysctl); } +int xc_set_cpufreq_cppc (xc_interface *xch,int cpuid, +xc_set_cppc_para_t *set_cppc) +{ +DECLARE_SYSCTL ; +int ret; + +if ( !xch ) + { + errno =EINVAL ; +return -1 ; + } + sysctl.cmd = XEN_SYSCTL_pm_op; + sysctl.u.pm_op.cmd =SET_CPUFREQ_CPPC ; + sysctl.u.pm_op.cpuid = cpuid; + sysctl.u.pm_op.u.set_cppc = *set_cppc; + + ret =xc_sysctl (xch, &sysctl); + + *set_cppc = sysctl.u.pm_op.u.set_cppc; + +return ret; +} +int xc_get_cpufreq_avgfreq (xc_interface *xch,int cpuid,int *avg_freq) {int ret =0 ;
Signature · 1 line
2.41.0
PATCH v5 14/15 xenpm: Add set-cpufreq-cppc subcommand
In reply to Jason Andryukset-cpufreq-cppc allows setting the Hardware P-State (HWP) parameters.
It can be run on all or just a single cpu. There are presets of balance, powersave & performance. Those can be further tweaked by param:val arguments as explained in the usage description.
Parameter names are just checked to the first 3 characters to shorten typing.
Some options are hardware dependent, and ranges can be found in get-cpufreq-para.
---
v5:
Make i unsigned int
Use local max_cpuid instead of max_cpu_nr
Add Jan's Ack
Check set_params and print a message if activity window wasn't set
v4:
Remove energy bias 0-15 & 7 references
Use MASK_INSR
Fixup { placement
Drop extra case in parse_activity_window
strcmp suffix
Expand help text
s/hwp/cppc/
Use isdigit() to check cpuid - otherwise run on all CPUs.
v2:
Compare provided parameter name and not just 3 characters. Use "-" in parameter names
Remove hw_
Replace sscanf with strchr & strtoul.
Remove toplevel error message with lower level ones. Help text s/127/128/
Help text mention truncation.
Avoid some truncation rounding down by adding 5 before division. Help test mention default microseconds
Also comment the limit check written to avoid overflow.
--- tools/misc/xenpm.c | 244 +++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 244 insertions(+)
tools/misc/xenpm.c +244 -0
@@ -16,6 +16,8 @@*/ #define MAX_NR_CPU 512 +#include <ctype.h> +#include <limits.h> #include <stdio.h> #include <stdlib.h> #include <unistd.h>
@@ -67,6 +69,30 @@ void show_help(void)" set-max-cstate <num>|'unlimited' [<num2>|'unlimited']\n" " set the C-State limitation (<num> >= 0) and\n" " optionally the C-sub-state limitation (<num2> >= 0)\n" +" set-cpufreq-cppc [cpuid] [balance|performance|powersave] <param:val>*\n" +" set Hardware P-State (HWP) parameters\n" +" on CPU <cpuid> or all if omitted.\n" +" optionally a preset of one of:\n" +" balance|performance|powersave\n" +" an optional list of param:val arguments\n" +" minimum:N (0-255)\n" +" maximum:N (0-255)\n" +" get-cpufreq-para lowest/highest\n" +" values are limits for\n" +" minumum/maximum.\n" +" desired:N (0-255)\n" +" set explicit performance target.\n" +" non-zero disables auto-HWP mode.\n" +" energy-perf:N (0-255)\n" +" energy/performance hint\n" +" lower - favor performance\n" +" higher - favor powersave\n" +" 128 - balance\n" +" act-window:N{,m,u}s range 1us-1270s\n" +" window for internal calculations.\n" +" units default to \"us\" if unspecified.\n" +" truncates un-representable values.\n" +" 0 lets the hardware decide.\n" " start [seconds] start collect Cx/Px statistics,\n" " output after CTRL-C or SIGINT or several seconds.\n" " enable-turbo-mode [cpuid] enable Turbo Mode for processors that support it.\n"
@@ -1292,6 +1318,223 @@ void disable_turbo_mode(int argc, char *argv[]) errno, strerror(errno)); } +/* +* Parse activity_window:NNN{us,ms,s} and validate range. +* +* Activity window is a 7bit mantissa (0-127) with a 3bit exponent (0-7) base +* 10 in microseconds. So the range is 1 microsecond to 1270 seconds. A value +* of 0 lets the hardware autonomously select the window. +* +* Return 0 on success +* -1 on error +*/ +static int parse_activity_window (xc_set_cppc_para_t *set_cppc,unsigned long u, +const char *suffix) +{ +unsigned int exponent =0 ; +unsigned int multiplier =1 ; + +if ( suffix && suffix[0 ] ) + { +if (strcmp (suffix,"s" ) ==0 ) + { + multiplier =1000 *1000 ; + exponent =6 ; + } +else if (strcmp (suffix,"ms" ) ==0 ) + { + multiplier =1000 ; + exponent =3 ; + } +else if (strcmp (suffix,"us" ) !=0 ) + { +fprintf (stderr,"invalid activity window units: \"%s\"\n" , suffix); + +return -1 ; + } + } + +/* u * multipler > 1270 * 1000 * 1000 transformed to avoid overflow. */ +if ( u >1270 *1000 *1000 / multiplier ) + { +fprintf (stderr,"activity window is too large\n" ); + +return -1 ; + } + +/* looking for 7 bits of mantissa and 3 bits of exponent */ +while ( u >127 ) + { + u +=5 ;/* Round up to mitigate truncation rounding down +e.g. 128 -> 120 vs 128 -> 130. */ + u /=10 ; + exponent +=1 ; + } + + set_cppc->activity_window = +MASK_INSR (exponent,XEN_CPPC_ACT_WINDOW_EXPONENT_MASK ) | +MASK_INSR (u,XEN_CPPC_ACT_WINDOW_MANTISSA_MASK ); + set_cppc->set_params |=XEN_SYSCTL_CPPC_SET_ACT_WINDOW ; + +return 0 ; +} + +static int parse_cppc_opts (xc_set_cppc_para_t *set_cppc,int *cpuid, +int argc,char *argv[]) +{ +int i =0 ; + +if ( argc <1 ) + { +fprintf (stderr,"Missing arguments\n" ); +return -1 ; + } + +if (isdigit (argv[i][0 ]) ) + { +if (sscanf (argv[i],"%d" , cpuid) !=1 || *cpuid <0 ) + { +fprintf (stderr,"Could not parse cpuid \"%s\"\n" , argv[i]); +return -1 ; + } + + i++; + } + +if ( i == argc ) + { +fprintf (stderr,"Missing arguments\n" ); +return -1 ; + } + +if (strcasecmp (argv[i],"powersave" ) ==0 ) + { + set_cppc->set_params =XEN_SYSCTL_CPPC_SET_PRESET_POWERSAVE ; + i++; + } +else if (strcasecmp (argv[i],"performance" ) ==0 ) + { + set_cppc->set_params =XEN_SYSCTL_CPPC_SET_PRESET_PERFORMANCE ; + i++; + } +else if (strcasecmp (argv[i],"balance" ) ==0 ) + { + set_cppc->set_params =XEN_SYSCTL_CPPC_SET_PRESET_BALANCE ; + i++; + } + +for ( ; i < argc; i++) + { +unsigned long val; +char *param = argv[i]; +char *value; +char *suffix; +int ret; + + value =strchr (param,':' ); +if ( value ==NULL ) + { +fprintf (stderr,"\"%s\" is an invalid cppc parameter\n" , argv[i]); +return -1 ; + } + + value[0 ] ='\0' ; + value++; + + errno =0 ; + val =strtoul (value, &suffix,10 ); +if ( (errno && val ==ULONG_MAX ) || value == suffix ) + { +fprintf (stderr,"Could not parse number \"%s\"\n" , value); +return -1 ; + } + +if (strncasecmp (param,"act-window" ,strlen (param)) ==0 ) + { + ret =parse_activity_window (set_cppc, val, suffix); +if (ret) +return -1 ; + +continue ; + } + +if ( val >255 ) + { +fprintf (stderr,"\"%s\" value \"%lu\" is out of range\n" , param, + val); +return -1 ; + } + +if ( suffix && suffix[0 ] ) + { +fprintf (stderr,"Suffix \"%s\" is invalid\n" , suffix); +return -1 ; + } + +if (strncasecmp (param,"minimum" ,MAX (2 ,strlen (param))) ==0 ) + { + set_cppc->minimum = val; + set_cppc->set_params |=XEN_SYSCTL_CPPC_SET_MINIMUM ; + } +else if (strncasecmp (param,"maximum" ,MAX (2 ,strlen (param))) ==0 ) + { + set_cppc->maximum = val; + set_cppc->set_params |=XEN_SYSCTL_CPPC_SET_MAXIMUM ; + } +else if (strncasecmp (param,"desired" ,strlen (param)) ==0 ) + { + set_cppc->desired = val; + set_cppc->set_params |=XEN_SYSCTL_CPPC_SET_DESIRED ; + } +else if (strncasecmp (param,"energy-perf" ,strlen (param)) ==0 ) + { + set_cppc->energy_perf = val; + set_cppc->set_params |=XEN_SYSCTL_CPPC_SET_ENERGY_PERF ; + } +else + { +fprintf (stderr,"\"%s\" is an invalid parameter\n" , param); +return -1 ; + } + } + +if ( set_cppc->set_params ==0 ) + { +fprintf (stderr,"No parameters set in request\n" ); +return -1 ; + } + +return 0 ; +} + +static void cppc_set_func (int argc,char *argv[]) +{ +xc_set_cppc_para_t set_cppc = {}; +unsigned int max_cpuid = max_cpu_nr; +int cpuid =-1 ; +unsigned int i =0 ; +uint32_t set_params; + +if (parse_cppc_opts (&set_cppc, &cpuid, argc, argv) ) +exit (EINVAL ); + +if ( cpuid !=-1 ) + { + i = cpuid; + max_cpuid = i +1 ; + } + + set_params = set_cppc.set_params; +for ( ; i < max_cpuid; i++ ) { +if (xc_set_cpufreq_cppc (xc_handle, i, &set_cppc) ) +fprintf (stderr,"[CPU%d] failed to set cppc params (%d - %s)\n" , + i, errno,strerror (errno)); + } + +if ( (set_params ^ set_cppc.set_params) &XEN_SYSCTL_CPPC_SET_ACT_WINDOW ) +printf ("Activity window not supported and omitted\n" ); +} +struct {const char *name;void (*function)(int argc,char *argv[]);
@@ -1302,6 +1545,7 @@ struct { { "get-cpufreq-average", cpufreq_func }, { "start", start_gather_func }, { "get-cpufreq-para", cpufreq_para_func }, + { "set-cpufreq-cppc", cppc_set_func }, { "set-scaling-maxfreq", scaling_max_freq_func }, { "set-scaling-minfreq", scaling_min_freq_func }, { "set-scaling-governor", scaling_governor_func },
Signature · 1 line
2.41.0
PATCH v5 15/15 CHANGELOG: Add Intel HWP entry
In reply to Jason Andryuk---
v3:
Position under existing Added section
Add Henry's Ack
v2:
Add blank line
--- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
CHANGELOG.md +1 -1
@@ -24,7 +24,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) - xl/libxl can customize SMBIOS strings for HVM guests. - Add support for AVX512-FP16 on x86. - On Arm, Xen supports guests running SVE/SVE2 instructions. (Tech Preview) - + - Add Intel Hardware P-States (HWP) cpufreq driver. ## [4.17.0](https://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=RELEASE-4.17.0) - 2022-12-12
Signature · 1 line
2.41.0