Skip to contentSkip to conversation

kernel: kprobes: Remove unnecessary ‘0’ values from ret

PATCH In review Li zeming 2 participants 2 messages Jul 3, 2023 – Jul 6, 2023

Subsystems (2)
lore
Share & tools
lore

Li zeming

author
#0 lore raw

PATCH 1/1 kernel: kprobes: Remove unnecessary ‘0’ values from ret

ret is assigned first, so it does not need to initialize the assignment.

---
 kernel/kprobes.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/kprobes.c +1 -1
index ec50f9f380c1..a009c8ccd8ea 100644
@@ -2692,7 +2692,7 @@ void kprobe_free_init_mem(void)
 
 static int __init init_kprobes(void)
 {
-	int i, err = 0;
+	int i, err;
 
 	/* FIXME allocate the probe table, currently defined statically */
 	/* initialize all list heads */
Signature · 1 line
2.18.2
#1 lore raw
Quoted 2 lines · On Wed, 5 Jul 2023 04:10:56 +0800 Li zeming <[email protected]> wrote:

ret is assigned first, so it does not need to initialize the assignment.

OK, but can you merge this to the first one?
https://lore.kernel.org/all/[email protected]/

Thank you,

Quoted 21 lines
---
 kernel/kprobes.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/kprobes.c +1 -1
index ec50f9f380c1..a009c8ccd8ea 100644
@@ -2692,7 +2692,7 @@ void kprobe_free_init_mem(void)
 
 static int __init init_kprobes(void)
 {
-	int i, err = 0;
+	int i, err;
 
 	/* FIXME allocate the probe table, currently defined statically */
 	/* initialize all list heads */
Signature · 1 line
2.18.2
Signature · 1 line
Masami Hiramatsu (Google) <[email protected]>