Skip to contentSkip to conversation

usb: phy: add usb phy notify port status API

PATCH Superseded Stanley Chang 3 participants 12 messages Jul 7, 2023 – Jul 24, 2023

Subsystems (3)

v7 of 9 Superseded Latest is v9 →

lore
Share & tools
lore
#0 lore raw

PATCH v7 1/5 usb: phy: add usb phy notify port status API

In Realtek SoC, the parameter of usb phy is designed to can dynamic tuning base on port status. Therefore, add a notify callback of phy driver when usb port status change.

The Realtek phy driver is designed to dynamically adjust disconnection level and calibrate phy parameters. When the device connected bit changes and when the disconnected bit changes, do port status change notification:

Check if portstatus is USB_PORT_STAT_CONNECTION and portchange is USB_PORT_STAT_C_CONNECTION.
1. The device is connected, the driver lowers the disconnection level and calibrates the phy parameters.
2. The device disconnects, the driver increases the disconnect level and calibrates the phy parameters.

When controller to notify connect that device is already ready. If we adjust the disconnection level in notify_connect, the disconnect may have been triggered at this stage. So we need to change that as early as possible. Therefore, we add an api to notify phy the port status changes.

---
v6 to v7 change:
No change
v5 to v6 change:
No change
v4 to v5 change:
No change
v3 to v4 change:
Fix the warning for checkpatch with strict.
v2 to v3 change:
Add more comments about the reason for adding this api
v1 to v2 change:
No change

---
 drivers/usb/core/hub.c  | 13 +++++++++++++
 include/linux/usb/phy.h | 13 +++++++++++++
 2 files changed, 26 insertions(+)
drivers/usb/core/hub.c +13 -0
index a739403a9e45..8433ff89dea6 100644
@@ -614,6 +614,19 @@ static int hub_ext_port_status(struct usb_hub *hub, int port1, int type,
 		ret = 0;
 	}
 	mutex_unlock(&hub->status_mutex);
+
+	if (!ret) {
+		struct usb_device *hdev = hub->hdev;
+
+		if (hdev && !hdev->parent) {
+			struct usb_hcd *hcd = bus_to_hcd(hdev->bus);
+
+			if (hcd->usb_phy)
+				usb_phy_notify_port_status(hcd->usb_phy,
+							   port1 - 1, *status, *change);
+		}
+	}
+
 	return ret;
 }
 
include/linux/usb/phy.h +13 -0
index e4de6bc1f69b..b513749582d7 100644
@@ -144,6 +144,10 @@ struct usb_phy {
 	 */
 	int	(*set_wakeup)(struct usb_phy *x, bool enabled);
 
+	/* notify phy port status change */
+	int	(*notify_port_status)(struct usb_phy *x, int port,
+				      u16 portstatus, u16 portchange);
+
 	/* notify phy connect status change */
 	int	(*notify_connect)(struct usb_phy *x,
 			enum usb_device_speed speed);
@@ -316,6 +320,15 @@ usb_phy_set_wakeup(struct usb_phy *x, bool enabled)
 		return 0;
 }
 
+static inline int
+usb_phy_notify_port_status(struct usb_phy *x, int port, u16 portstatus, u16 portchange)
+{
+	if (x && x->notify_port_status)
+		return x->notify_port_status(x, port, portstatus, portchange);
+	else
+		return 0;
+}
+
 static inline int
 usb_phy_notify_connect(struct usb_phy *x, enum usb_device_speed speed)
 {
Signature · 1 line
2.34.1
#1 lore raw

PATCH v7 2/5 phy: realtek: usb: Add driver for the Realtek SoC USB 2.0 PHY

Realtek DHC (digital home center) RTD SoCs support DWC3 XHCI USB controller. Added the driver to drive the USB 2.0 PHY transceivers.

---
v6 to v7 change:
rename the porperty realtek,driving-level-compensate
v5 to v6 change:
No change
v4 to v5 change:
1. Remove the compatible realtek,usb2phy.
2. Add the compatible data for realtek,rtd1395-usb2phy-2port
3. Remove the set_parameter in debugfs.
4. Revise the error and debug log.
5. Modify the coding style based Krzysztof comments.
v3 to v4 change:
1. Remove the parameter and non hardware properties from dts. Add the compatible data included the config and parameter.
2. Fix the warning for checkpatch with strict.
3. Remove useless debug messages.
4. Fix the incorrect or useless "if() return" which pointer check.
5. Remove the phy power domain control due to we control on other driver.
v2 to v3 change:
1. Broken down into two patches, one for each of USB 2 & 3 PHY.
2. Removed parameter v1 support for simplification.
3. Use remove_new for driver remove callback.
v1 to v2 change:
1. Move the drivers to drivers/phy/ for generic phy driver
2. Use the generic phy driver api to initialize phy
3. Use readl/writel to instead phy_read/phy_write directly.
4. Use read_poll_timeout() in function utmi_wait_register.
5. Revised some coding styles.
6. fix the compiler warning for kernel test robot.

---
 drivers/phy/Kconfig                |    1 +
 drivers/phy/Makefile               |    1 +
 drivers/phy/realtek/Kconfig        |   14 +
 drivers/phy/realtek/Makefile       |    2 +
 drivers/phy/realtek/phy-rtk-usb2.c | 1329 ++++++++++++++++++++++++++++
 5 files changed, 1347 insertions(+)
 create mode 100644 drivers/phy/realtek/Kconfig
 create mode 100644 drivers/phy/realtek/Makefile
 create mode 100644 drivers/phy/realtek/phy-rtk-usb2.c
drivers/phy/Kconfig +1 -0
index f46e3148d286..6d04a0029c6c 100644
@@ -86,6 +86,7 @@ source "drivers/phy/motorola/Kconfig"
 source "drivers/phy/mscc/Kconfig"
 source "drivers/phy/qualcomm/Kconfig"
 source "drivers/phy/ralink/Kconfig"
+source "drivers/phy/realtek/Kconfig"
 source "drivers/phy/renesas/Kconfig"
 source "drivers/phy/rockchip/Kconfig"
 source "drivers/phy/samsung/Kconfig"
drivers/phy/Makefile +1 -0
index 54f312c10a40..ba7c100b14fc 100644
@@ -26,6 +26,7 @@ obj-y					+= allwinner/	\
 					   mscc/	\
 					   qualcomm/	\
 					   ralink/	\
+					   realtek/	\
 					   renesas/	\
 					   rockchip/	\
 					   samsung/	\
drivers/phy/realtek/Kconfig new file +14 -0
new file mode 100644
index 000000000000..2f2f453729d5
@@ -0,0 +1,14 @@
+# SPDX-License-Identifier: GPL-2.0
+#
+# Phy drivers for Realtek platforms
+#
+config PHY_RTK_RTD_USB2PHY
+	tristate "Realtek RTD USB2 PHY Transceiver Driver"
+	depends on USB_SUPPORT
+	select GENERIC_PHY
+	select USB_PHY
+	help
+	  Enable this to support Realtek SoC USB2 phy transceiver.
+	  The DHC (digital home center) RTD series SoCs used the Synopsys
+	  DWC3 USB IP. This driver will do the PHY initialization
+	  of the parameters.
drivers/phy/realtek/Makefile new file +2 -0
new file mode 100644
index 000000000000..cf5d440841a2
@@ -0,0 +1,2 @@
+# SPDX-License-Identifier: GPL-2.0
+obj-$(CONFIG_PHY_RTK_RTD_USB2PHY)	+= phy-rtk-usb2.o
drivers/phy/realtek/phy-rtk-usb2.c new file +1329 -0

1,329 lines not on this page · raw message

Signature · 1 line
2.34.1
#2 lore raw

PATCH v7 3/5 phy: realtek: usb: Add driver for the Realtek SoC USB 3.0 PHY

In reply to Stanley Chang

Realtek DHC (digital home center) RTD SoCs support DWC3 XHCI USB controller. Added the driver to drive the USB 3.0 PHY transceivers.

---
v6 to v7 change:
No change
v5 to v6 change:
No change
v4 to v5 change:
1. Remove the compatible realtek,usb3phy.
2. Remove the set_parameter in debugfs.
3. Revise the error and debug log.
v3 to v4 change:
1. Remove the parameter and non hardware properties from dts. Add the compatible data included the config and parameter.
2. Fix the warning for checkpatch with strict.
3. Remove useless debug messages.
4. Fix the incorrect or useless "if() return" which pointer check.
v2 to v3 change:
1. Broken down into two patches, one for each of USB 2 & 3 PHY.
2. Removed parameter v1 support for simplification.
3. Used remove_new for driver remove callback.
v1 to v2 change:
1. Move the drivers to drivers/phy/ for generic phy driver
2. Use the generic phy driver api to initialize phy
3. Use readl/writel to instead phy_read/phy_write directly.
4. Use read_poll_timeout() in function utmi_wait_register.
5. Revised some coding styles.
6. fix the compiler warning for kernel test robot.

---
 drivers/phy/realtek/Kconfig        |  11 +
 drivers/phy/realtek/Makefile       |   1 +
 drivers/phy/realtek/phy-rtk-usb3.c | 766 +++++++++++++++++++++++++++++
 3 files changed, 778 insertions(+)
 create mode 100644 drivers/phy/realtek/phy-rtk-usb3.c
drivers/phy/realtek/Kconfig +11 -0
index 2f2f453729d5..a5a5a71edc9c 100644
@@ -12,3 +12,14 @@ config PHY_RTK_RTD_USB2PHY
 	  The DHC (digital home center) RTD series SoCs used the Synopsys
 	  DWC3 USB IP. This driver will do the PHY initialization
 	  of the parameters.
+
+config PHY_RTK_RTD_USB3PHY
+	tristate "Realtek RTD USB3 PHY Transceiver Driver"
+	depends on USB_SUPPORT
+	select GENERIC_PHY
+	select USB_PHY
+	help
+	  Enable this to support Realtek SoC USB3 phy transceiver.
+	  The DHC (digital home center) RTD series SoCs used the Synopsys
+	  DWC3 USB IP. This driver will do the PHY initialization
+	  of the parameters.
drivers/phy/realtek/Makefile +1 -0
index cf5d440841a2..ed7b47ff8a26 100644
@@ -1,2 +1,3 @@
 # SPDX-License-Identifier: GPL-2.0
 obj-$(CONFIG_PHY_RTK_RTD_USB2PHY)	+= phy-rtk-usb2.o
+obj-$(CONFIG_PHY_RTK_RTD_USB3PHY)	+= phy-rtk-usb3.o
drivers/phy/realtek/phy-rtk-usb3.c new file +766 -0

766 lines not on this page · raw message

Signature · 1 line
2.34.1
#3 lore raw

PATCH v7 4/5 dt-bindings: phy: realtek: Add Realtek DHC RTD SoC USB 2.0 PHY

In reply to Stanley Chang

Document the USB PHY bindings for Realtek SoCs. Realtek DHC (digital home center) RTD SoCs support DWC3 XHCI USB controller and using USB 2.0 PHY transceiver.

---
v6 to v7 change:
1. Revise the commit message
2. Change the property name for realtek,driving-level-compensate
3. Add if/then schema for specific properties
v5 to v6 change:
Drop the redundant examples
Drop the label of example
v4 to v5 change:
1. Add more examples.
2. Remove the compatible realtek,usb2phy.
3. Revise the descriptor of the property.
4. Add the default of the property.
v3 to v4 change:
1. Remove the parameter and non hardware properties from dts.
2. Using the compatible data included the config and parameter in driver.
v2 to v3 change:
1. Broken down into two patches, one for each of USB 2 & 3.
2. Add more description about Realtek RTD SoCs architecture.
3. Removed parameter v1 support for simplification.
4. Revised the compatible name for fallback compatible.
5. Remove some properties that can be set in the driver.
v1 to v2 change:
Add phy-cells for generic phy driver

---
 .../bindings/phy/realtek,usb2phy.yaml         | 175 ++++++++++++++++++
 1 file changed, 175 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/phy/realtek,usb2phy.yaml
Documentation/devicetree/bindings/phy/realtek,usb2phy.yaml new file +175 -0
new file mode 100644
index 000000000000..9911ada39ee7
@@ -0,0 +1,175 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+# Copyright 2023 Realtek Semiconductor Corporation
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/phy/realtek,usb2phy.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Realtek DHC SoCs USB 2.0 PHY
+
+maintainers:
+  - Stanley Chang <[email protected]>
+
+description: |
+  Realtek USB 2.0 PHY support the digital home center (DHC) RTD series SoCs.
+  The USB 2.0 PHY driver is designed to support the XHCI controller. The SoCs
+  support multiple XHCI controllers. One PHY device node maps to one XHCI
+  controller.
+
+  RTD1295/RTD1619 SoCs USB
+  The USB architecture includes three XHCI controllers.
+  Each XHCI maps to one USB 2.0 PHY and map one USB 3.0 PHY on some
+  controllers.
+  XHCI controller#0 -- usb2phy -- phy#0
+                    |- usb3phy -- phy#0
+  XHCI controller#1 -- usb2phy -- phy#0
+  XHCI controller#2 -- usb2phy -- phy#0
+                    |- usb3phy -- phy#0
+
+  RTD1395 SoCs USB
+  The USB architecture includes two XHCI controllers.
+  The controller#0 has one USB 2.0 PHY. The controller#1 includes two USB 2.0
+  PHY.
+  XHCI controller#0 -- usb2phy -- phy#0
+  XHCI controller#1 -- usb2phy -- phy#0
+                               |- phy#1
+
+  RTD1319/RTD1619b SoCs USB
+  The USB architecture includes three XHCI controllers.
+  Each XHCI maps to one USB 2.0 PHY and map one USB 3.0 PHY on controllers#2.
+  XHCI controller#0 -- usb2phy -- phy#0
+  XHCI controller#1 -- usb2phy -- phy#0
+  XHCI controller#2 -- usb2phy -- phy#0
+                    |- usb3phy -- phy#0
+
+  RTD1319d SoCs USB
+  The USB architecture includes three XHCI controllers.
+  Each xhci maps to one USB 2.0 PHY and map one USB 3.0 PHY on controllers#0.
+  XHCI controller#0 -- usb2phy -- phy#0
+                    |- usb3phy -- phy#0
+  XHCI controller#1 -- usb2phy -- phy#0
+  XHCI controller#2 -- usb2phy -- phy#0
+
+  RTD1312c/RTD1315e SoCs USB
+  The USB architecture includes three XHCI controllers.
+  Each XHCI maps to one USB 2.0 PHY.
+  XHCI controller#0 -- usb2phy -- phy#0
+  XHCI controller#1 -- usb2phy -- phy#0
+  XHCI controller#2 -- usb2phy -- phy#0
+
+properties:
+  compatible:
+    enum:
+      - realtek,rtd1295-usb2phy
+      - realtek,rtd1312c-usb2phy
+      - realtek,rtd1315e-usb2phy
+      - realtek,rtd1319-usb2phy
+      - realtek,rtd1319d-usb2phy
+      - realtek,rtd1395-usb2phy
+      - realtek,rtd1395-usb2phy-2port
+      - realtek,rtd1619-usb2phy
+      - realtek,rtd1619b-usb2phy
+
+  reg:
+    items:
+      - description: PHY data registers
+      - description: PHY control registers
+
+  "#phy-cells":
+    const: 0
+
+  nvmem-cells:
+    maxItems: 2
+    description:
+      Phandles to nvmem cell that contains the trimming data.
+      If unspecified, default value is used.
+
+  nvmem-cell-names:
+    items:
+      - const: usb-dc-cal
+      - const: usb-dc-dis
+    description:
+      The following names, which correspond to each nvmem-cells.
+      usb-dc-cal is the driving level for each phy specified via efuse.
+      usb-dc-dis is the disconnection level for each phy specified via efuse.
+
+  realtek,inverse-hstx-sync-clock:
+    description:
+      For one of the phys of RTD1619b SoC, the synchronous clock of the
+      high-speed tx must be inverted.
+    type: boolean
+
+  realtek,driving-level:
+    description:
+      Control the magnitude of High speed Dp/Dm output swing (mV).
+      For a different board or port, the original magnitude maybe not meet
+      the specification. In this situation we can adjust the value to meet
+      the specification.
+    $ref: /schemas/types.yaml#/definitions/uint32
+    default: 8
+    minimum: 0
+    maximum: 31
+
+  realtek,driving-level-compensate:
+    description:
+      For RTD1315e SoC, the driving level can be adjusted by reading the
+      efuse table. This property provides drive compensation.
+      If the magnitude of High speed Dp/Dm output swing still not meet the
+      specification, then we can set this value to meet the specification.
+    $ref: /schemas/types.yaml#/definitions/int32
+    default: 0
+    minimum: -8
+    maximum: 8
+
+  realtek,disconnection-compensate:
+    description:
+      This adjusts the disconnection level compensation for the different
+      boards with different disconnection level.
+    $ref: /schemas/types.yaml#/definitions/int32
+    default: 0
+    minimum: -8
+    maximum: 8
+
+required:
+  - compatible
+  - reg
+  - "#phy-cells"
+
+allOf:
+  - if:
+      not:
+        properties:
+          compatible:
+            contains:
+              enum:
+                - realtek,rtd1619b-usb2phy
+    then:
+      properties:
+        realtek,inverse-hstx-sync-clock: false
+
+  - if:
+      not:
+        properties:
+          compatible:
+            contains:
+              enum:
+                - realtek,rtd1315e-usb2phy
+    then:
+      properties:
+        realtek,driving-level-compensate: false
+
+additionalProperties: false
+
+examples:
+  - |
+    usb-phy@13214 {
+        compatible = "realtek,rtd1619b-usb2phy";
+        reg = <0x13214 0x4>, <0x28280 0x4>;
+        #phy-cells = <0>;
+        nvmem-cells = <&otp_usb_port0_dc_cal>, <&otp_usb_port0_dc_dis>;
+        nvmem-cell-names = "usb-dc-cal", "usb-dc-dis";
+
+        realtek,inverse-hstx-sync-clock;
+        realtek,driving-level = <0xa>;
+        realtek,disconnection-compensate = <(-1)>;
+    };
Signature · 1 line
2.34.1
maintainer Reviewed-by on v7 4/5
#4 lore raw

Re: [PATCH v7 4/5] dt-bindings: phy: realtek: Add Realtek DHC RTD SoC USB 2.0 PHY

Quoted 30 lines · Stanley Chang

Document the USB PHY bindings for Realtek SoCs. Realtek DHC (digital home center) RTD SoCs support DWC3 XHCI USB controller and using USB 2.0 PHY transceiver.

---
v6 to v7 change:
1. Revise the commit message
2. Change the property name for realtek,driving-level-compensate
3. Add if/then schema for specific properties
v5 to v6 change:
Drop the redundant examples
Drop the label of example
v4 to v5 change:
1. Add more examples.
2. Remove the compatible realtek,usb2phy.
3. Revise the descriptor of the property.
4. Add the default of the property.
v3 to v4 change:
1. Remove the parameter and non hardware properties from dts.
2. Using the compatible data included the config and parameter in driver.
v2 to v3 change:
1. Broken down into two patches, one for each of USB 2 & 3.
2. Add more description about Realtek RTD SoCs architecture.
3. Removed parameter v1 support for simplification.
4. Revised the compatible name for fallback compatible.
5. Remove some properties that can be set in the driver.
v1 to v2 change:
Add phy-cells for generic phy driver

Quoted 5 lines
---
 .../bindings/phy/realtek,usb2phy.yaml         | 175 ++++++++++++++++++
 1 file changed, 175 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/phy/realtek,usb2phy.yaml
Signature · 3 lines
linux-phy mailing list
[email protected]
https://lists.infradead.org/mailman/listinfo/linux-phy
#5 lore raw

PATCH v7 5/5 dt-bindings: phy: realtek: Add Realtek DHC RTD SoC USB 3.0 PHY

In reply to Stanley Chang

Document the USB PHY bindings for Realtek SoCs. Realtek DHC (digital home center) RTD SoCs support DWC3 XHCI USB controller and using USB 3.0 PHY transceiver.

---
v6 to v7 change:
Revise the commit message.
v5 to v6 change:
Drop the labels of example.
v4 to v5 change:
1. Remove the compatible realtek,usb3phy.
2. Add the default of the property.
v3 to v4 change:
1. Remove the parameter and non hardware properties from dts.
2. Using the compatible data included the config and parameter in driver.
v2 to v3 change:
1. Broken down into two patches, one for each of USB 2 & 3.
2. Add more description about Realtek RTD SoCs architecture.
3. Removed parameter v1 support for simplification.
4. Revised the compatible name for fallback compatible.
5. Remove some properties that can be set in the driver.
v1 to v2 change:
Add phy-cells for generic phy driver

---
 .../bindings/phy/realtek,usb3phy.yaml         | 107 ++++++++++++++++++
 1 file changed, 107 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/phy/realtek,usb3phy.yaml
Documentation/devicetree/bindings/phy/realtek,usb3phy.yaml new file +107 -0
new file mode 100644
index 000000000000..dfe2bb4e59e7
@@ -0,0 +1,107 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+# Copyright 2023 Realtek Semiconductor Corporation
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/phy/realtek,usb3phy.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Realtek DHC SoCs USB 3.0 PHY
+
+maintainers:
+  - Stanley Chang <[email protected]>
+
+description: |
+  Realtek USB 3.0 PHY support the digital home center (DHC) RTD series SoCs.
+  The USB 3.0 PHY driver is designed to support the XHCI controller. The SoCs
+  support multiple XHCI controllers. One PHY device node maps to one XHCI
+  controller.
+
+  RTD1295/RTD1619 SoCs USB
+  The USB architecture includes three XHCI controllers.
+  Each XHCI maps to one USB 2.0 PHY and map one USB 3.0 PHY on some
+  controllers.
+  XHCI controller#0 -- usb2phy -- phy#0
+                    |- usb3phy -- phy#0
+  XHCI controller#1 -- usb2phy -- phy#0
+  XHCI controller#2 -- usb2phy -- phy#0
+                    |- usb3phy -- phy#0
+
+  RTD1319/RTD1619b SoCs USB
+  The USB architecture includes three XHCI controllers.
+  Each XHCI maps to one USB 2.0 PHY and map one USB 3.0 PHY on controllers#2.
+  XHCI controller#0 -- usb2phy -- phy#0
+  XHCI controller#1 -- usb2phy -- phy#0
+  XHCI controller#2 -- usb2phy -- phy#0
+                    |- usb3phy -- phy#0
+
+  RTD1319d SoCs USB
+  The USB architecture includes three XHCI controllers.
+  Each xhci maps to one USB 2.0 PHY and map one USB 3.0 PHY on controllers#0.
+  XHCI controller#0 -- usb2phy -- phy#0
+                    |- usb3phy -- phy#0
+  XHCI controller#1 -- usb2phy -- phy#0
+  XHCI controller#2 -- usb2phy -- phy#0
+
+properties:
+  compatible:
+    enum:
+      - realtek,rtd1295-usb3phy
+      - realtek,rtd1319-usb3phy
+      - realtek,rtd1319d-usb3phy
+      - realtek,rtd1619-usb3phy
+      - realtek,rtd1619b-usb3phy
+
+  reg:
+    maxItems: 1
+
+  "#phy-cells":
+    const: 0
+
+  nvmem-cells:
+    maxItems: 1
+    description: A phandle to the tx lfps swing trim data provided by
+      a nvmem device, if unspecified, default values shall be used.
+
+  nvmem-cell-names:
+    items:
+      - const: usb_u3_tx_lfps_swing_trim
+
+  realtek,amplitude-control-coarse-tuning:
+    description:
+      This adjusts the signal amplitude for normal operation and beacon LFPS.
+      This value is a parameter for coarse tuning.
+      For different boards, if the default value is inappropriate, this
+      property can be assigned to adjust.
+    $ref: /schemas/types.yaml#/definitions/uint32
+    default: 255
+    minimum: 0
+    maximum: 255
+
+  realtek,amplitude-control-fine-tuning:
+    description:
+      This adjusts the signal amplitude for normal operation and beacon LFPS.
+      This value is used for fine-tuning parameters.
+    $ref: /schemas/types.yaml#/definitions/uint32
+    default: 65535
+    minimum: 0
+    maximum: 65535
+
+required:
+  - compatible
+  - reg
+  - "#phy-cells"
+
+additionalProperties: false
+
+examples:
+  - |
+    usb-phy@13e10 {
+        compatible = "realtek,rtd1319d-usb3phy";
+        reg = <0x13e10 0x4>;
+        #phy-cells = <0>;
+
+        nvmem-cells = <&otp_usb_u3_tx_lfps_swing_trim>;
+        nvmem-cell-names = "usb_u3_tx_lfps_swing_trim";
+
+        realtek,amplitude-control-coarse-tuning = <0x77>;
+    };
Signature · 1 line
2.34.1
maintainer Reviewed-by on v7 5/5
#6 lore raw

Re: [PATCH v7 5/5] dt-bindings: phy: realtek: Add Realtek DHC RTD SoC USB 3.0 PHY

Quoted 25 lines · Stanley Chang

Document the USB PHY bindings for Realtek SoCs. Realtek DHC (digital home center) RTD SoCs support DWC3 XHCI USB controller and using USB 3.0 PHY transceiver.

---
v6 to v7 change:
Revise the commit message.
v5 to v6 change:
Drop the labels of example.
v4 to v5 change:
1. Remove the compatible realtek,usb3phy.
2. Add the default of the property.
v3 to v4 change:
1. Remove the parameter and non hardware properties from dts.
2. Using the compatible data included the config and parameter in driver.
v2 to v3 change:
1. Broken down into two patches, one for each of USB 2 & 3.
2. Add more description about Realtek RTD SoCs architecture.
3. Removed parameter v1 support for simplification.
4. Revised the compatible name for fallback compatible.
5. Remove some properties that can be set in the driver.
v1 to v2 change:
Add phy-cells for generic phy driver

Quoted 5 lines
---
 .../bindings/phy/realtek,usb3phy.yaml         | 107 ++++++++++++++++++
 1 file changed, 107 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/phy/realtek,usb3phy.yaml
Signature · 3 lines
linux-phy mailing list
[email protected]
https://lists.infradead.org/mailman/listinfo/linux-phy
#7 lore raw
In reply to Stanley Chang
Quoted 15 lines · Stanley Chang

In Realtek SoC, the parameter of usb phy is designed to can dynamic tuning base on port status. Therefore, add a notify callback of phy driver when usb port status change.

The Realtek phy driver is designed to dynamically adjust disconnection level and calibrate phy parameters. When the device connected bit changes and when the disconnected bit changes, do port status change notification:

Check if portstatus is USB_PORT_STAT_CONNECTION and portchange is USB_PORT_STAT_C_CONNECTION.
1. The device is connected, the driver lowers the disconnection level and calibrates the phy parameters.
2. The device disconnects, the driver increases the disconnect level and calibrates the phy parameters.

Quoted 4 lines

When controller to notify connect that device is already ready. If we adjust the disconnection level in notify_connect, the disconnect may have been triggered at this stage. So we need to change that as early as possible. Therefore, we add an api to notify phy the port status changes.

How do you know that the disconnect will not have already been triggered at this point, when the status changes?

Quoted 25 lines

---
v6 to v7 change:
No change
v5 to v6 change:
No change
v4 to v5 change:
No change
v3 to v4 change:
Fix the warning for checkpatch with strict.
v2 to v3 change:
Add more comments about the reason for adding this api
v1 to v2 change:
No change

---
 drivers/usb/core/hub.c  | 13 +++++++++++++
 include/linux/usb/phy.h | 13 +++++++++++++
 2 files changed, 26 insertions(+)
drivers/usb/core/hub.c +0 -0
index a739403a9e45..8433ff89dea6 100644

drivers/usb/core/hub.c static int hub_ext_port_status(struct usb_hub *hub, int port1, int type, · line 621

Quoted 8 lines
drivers/usb/core/hub.c +5 -0
@@ -614,6 +614,19 @@ static int hub_ext_port_status(struct usb_hub *hub, int port1, int type,
 		ret = 0;
 	}
 	mutex_unlock(&hub->status_mutex);
+
+	if (!ret) {
+		struct usb_device *hdev = hub->hdev;
+
+		if (hdev && !hdev->parent) {

Why the check for no parent? Please document that here in a comment.

drivers/usb/core/hub.c static int hub_ext_port_status(struct usb_hub *hub, int port1, int type, · line 629

Quoted 8 lines
drivers/usb/core/hub.c +8 -0
+			struct usb_hcd *hcd = bus_to_hcd(hdev->bus);
+
+			if (hcd->usb_phy)
+				usb_phy_notify_port_status(hcd->usb_phy,
+							   port1 - 1, *status, *change);
+		}
+	}
+

This is safe to notify with the hub mutex unlocked? Again, a comment would be helpful to future people explaining why that is so.

thanks,

greg k-h

#8 lore raw
Quoted 19 lines · Stanley Chang
Quoted 7 lines

In Realtek SoC, the parameter of usb phy is designed to can dynamic tuning base on port status. Therefore, add a notify callback of phy driver when usb port status change.

The Realtek phy driver is designed to dynamically adjust disconnection level and calibrate phy parameters. When the device connected bit changes and when the disconnected bit changes, do port status change

notification:

Quoted 8 lines

Check if portstatus is USB_PORT_STAT_CONNECTION and portchange is USB_PORT_STAT_C_CONNECTION.
1. The device is connected, the driver lowers the disconnection level and calibrates the phy parameters.
2. The device disconnects, the driver increases the disconnect level and calibrates the phy parameters.

Quoted 7 lines
Quoted 4 lines

When controller to notify connect that device is already ready. If we adjust the disconnection level in notify_connect, the disconnect may have been triggered at this stage. So we need to change that as early as possible. Therefore, we add an api to notify phy the port status changes.

How do you know that the disconnect will not have already been triggered at this point, when the status changes?

The status change of connection is before port reset.
In this stage, the device is not port enable, and it will not trigger disconnection.

Quoted 26 lines

drivers/usb/core/hub.c static int hub_ext_port_status(struct usb_hub *hub,

Quoted 25 lines

---
v6 to v7 change:
No change
v5 to v6 change:
No change
v4 to v5 change:
No change
v3 to v4 change:
Fix the warning for checkpatch with strict.
v2 to v3 change:
Add more comments about the reason for adding this api
v1 to v2 change:
No change
---
drivers/usb/core/hub.c | 13 +++++++++++++ include/linux/usb/phy.h |
13 +++++++++++++

 2 files changed, 26 insertions(+)
drivers/usb/core/hub.c index renamed from drivers/usb/core/hub.c +0 -0

a739403a9e45..8433ff89dea6 100644

drivers/usb/core/hub.c +0 -0
@@ -614,6 +614,19 @@ static int hub_ext_port_status(struct usb_hub *hub,

int port1, int type,

Quoted 10 lines

drivers/usb/core/hub.c static int hub_ext_port_status(struct usb_hub *hub, int port1, int type, · line 621

Quoted 8 lines
drivers/usb/core/hub.c +5 -0
              ret = 0;
      }
      mutex_unlock(&hub->status_mutex);
+
+     if (!ret) {
+             struct usb_device *hdev = hub->hdev;
+
+             if (hdev && !hdev->parent) {

Why the check for no parent? Please document that here in a comment.

I will add a comment :
/* Only notify roothub. That is, when hdev->parent is empty. */

Quoted 5 lines

drivers/usb/core/hub.c static int hub_ext_port_status(struct usb_hub *hub, int port1, int type, · line 629

Quoted 4 lines
drivers/usb/core/hub.c +4 -0
+                     struct usb_hcd *hcd = bus_to_hcd(hdev->bus);
+
+                     if (hcd->usb_phy)
+

usb_phy_notify_port_status(hcd->usb_phy,

Quoted 9 lines

drivers/usb/core/hub.c static int hub_ext_port_status(struct usb_hub *hub, · line 626

Quoted 1 line
drivers/usb/core/hub.c +1 -0
+                                                        port1 -

1, *status, *change);

drivers/usb/core/hub.c static int hub_ext_port_status(struct usb_hub *hub, int port1, int type, · line 629

Quoted 3 lines
drivers/usb/core/hub.c +3 -0
+             }
+     }
+

This is safe to notify with the hub mutex unlocked? Again, a comment would be helpful to future people explaining why that is so.

I will add a comment:
/*
* There is no need to lock status_mutex here, because status_mutex
* protects hub->status, and the phy driver only checks the port
* status without changing the status.
*/

Thanks,
Stanley

.

#9 lore raw
Quoted 24 lines · Stanley Chang[昌育德]
Quoted 24 lines · Stanley Chang
Quoted 7 lines

In Realtek SoC, the parameter of usb phy is designed to can dynamic tuning base on port status. Therefore, add a notify callback of phy driver when usb port status change.

The Realtek phy driver is designed to dynamically adjust disconnection level and calibrate phy parameters. When the device connected bit changes and when the disconnected bit changes, do port status change

notification:

Quoted 12 lines

Check if portstatus is USB_PORT_STAT_CONNECTION and portchange is USB_PORT_STAT_C_CONNECTION.
1. The device is connected, the driver lowers the disconnection level and calibrates the phy parameters.
2. The device disconnects, the driver increases the disconnect level and calibrates the phy parameters.

When controller to notify connect that device is already ready. If we adjust the disconnection level in notify_connect, the disconnect may have been triggered at this stage. So we need to change that as early as possible. Therefore, we add an api to notify phy the port status changes.

Quoted 5 lines
Quoted 2 lines

How do you know that the disconnect will not have already been triggered at this point, when the status changes?

The status change of connection is before port reset.
In this stage, the device is not port enable, and it will not trigger disconnection.

Ok, then say that here please :)

Quoted 37 lines
Quoted 26 lines

drivers/usb/core/hub.c static int hub_ext_port_status(struct usb_hub *hub,

Quoted 25 lines

---
v6 to v7 change:
No change
v5 to v6 change:
No change
v4 to v5 change:
No change
v3 to v4 change:
Fix the warning for checkpatch with strict.
v2 to v3 change:
Add more comments about the reason for adding this api
v1 to v2 change:
No change
---
drivers/usb/core/hub.c | 13 +++++++++++++ include/linux/usb/phy.h |
13 +++++++++++++

 2 files changed, 26 insertions(+)
drivers/usb/core/hub.c index renamed from drivers/usb/core/hub.c +0 -0

a739403a9e45..8433ff89dea6 100644

drivers/usb/core/hub.c +0 -0
@@ -614,6 +614,19 @@ static int hub_ext_port_status(struct usb_hub *hub,

int port1, int type,

Quoted 10 lines

drivers/usb/core/hub.c static int hub_ext_port_status(struct usb_hub *hub, int port1, int type, · line 621

Quoted 8 lines
drivers/usb/core/hub.c +5 -0
              ret = 0;
      }
      mutex_unlock(&hub->status_mutex);
+
+     if (!ret) {
+             struct usb_device *hdev = hub->hdev;
+
+             if (hdev && !hdev->parent) {

Why the check for no parent? Please document that here in a comment.

Quoted 2 lines

I will add a comment :
/* Only notify roothub. That is, when hdev->parent is empty. */

Also document this that this will only happen for root hub status changes, that's not obvious in the callback name or documentation or anywhere else here.

Quoted 15 lines
Quoted 5 lines

drivers/usb/core/hub.c static int hub_ext_port_status(struct usb_hub *hub, int port1, int type, · line 629

Quoted 4 lines
drivers/usb/core/hub.c +4 -0
+                     struct usb_hcd *hcd = bus_to_hcd(hdev->bus);
+
+                     if (hcd->usb_phy)
+

usb_phy_notify_port_status(hcd->usb_phy,

Quoted 9 lines

drivers/usb/core/hub.c static int hub_ext_port_status(struct usb_hub *hub, · line 626

Quoted 1 line
drivers/usb/core/hub.c +1 -0
+                                                        port1 -

1, *status, *change);

drivers/usb/core/hub.c static int hub_ext_port_status(struct usb_hub *hub, int port1, int type, · line 629

Quoted 3 lines
drivers/usb/core/hub.c +3 -0
+             }
+     }
+

This is safe to notify with the hub mutex unlocked? Again, a comment would be helpful to future people explaining why that is so.

Quoted 6 lines

I will add a comment:
/*
* There is no need to lock status_mutex here, because status_mutex
* protects hub->status, and the phy driver only checks the port
* status without changing the status.
*/

Looks good, if you do it without the trailing whitespace :)

thanks,

greg k-h

#10 lore raw

Hi Greg,

Quoted 9 lines
Quoted 6 lines
Quoted 3 lines

How do you know that the disconnect will not have already been triggered at this point, when the status changes?

The status change of connection is before port reset.
In this stage, the device is not port enable, and it will not trigger

disconnection.

Ok, then say that here please :)

Okay. I will add it.

Quoted 18 lines
Quoted 18 lines
Quoted 17 lines

drivers/usb/core/hub.c static int hub_ext_port_status(struct usb_hub · line 614

Quoted 6 lines
drivers/usb/core/hub.c index renamed from drivers/usb/core/hub.c +0 -0

a739403a9e45..8433ff89dea6 100644

drivers/usb/core/hub.c +0 -0
@@ -614,6 +614,19 @@ static int hub_ext_port_status(struct usb_hub
 *hub,

int port1, int type,

drivers/usb/core/hub.c static int hub_ext_port_status(struct usb_hub *hub, int port1, int type, · line 621

Quoted 8 lines
drivers/usb/core/hub.c +5 -0
              ret = 0;
      }
      mutex_unlock(&hub->status_mutex);
+
+     if (!ret) {
+             struct usb_device *hdev = hub->hdev;
+
+             if (hdev && !hdev->parent) {

Why the check for no parent? Please document that here in a comment.

Quoted 5 lines
Quoted 2 lines

I will add a comment :
/* Only notify roothub. That is, when hdev->parent is empty. */

Also document this that this will only happen for root hub status changes, that's not obvious in the callback name or documentation or anywhere else here.

All usb phy notifications (connection, disconnection) are only for roothub. So I don't special to doc this.

Quoted 16 lines
Quoted 6 lines
Quoted 6 lines

drivers/usb/core/hub.c static int hub_ext_port_status(struct usb_hub *hub, int port1, int type, · line 629

Quoted 4 lines
drivers/usb/core/hub.c +4 -0
+                     struct usb_hcd *hcd = bus_to_hcd(hdev->bus);
+
+                     if (hcd->usb_phy)
+

usb_phy_notify_port_status(hcd->usb_phy,

Quoted 1 line
drivers/usb/core/hub.c +1 -0
+

port1 -

Quoted 9 lines
Quoted 8 lines

1, *status, *change);

drivers/usb/core/hub.c static int hub_ext_port_status(struct usb_hub *hub, int port1, int type, · line 629

Quoted 3 lines
drivers/usb/core/hub.c +3 -0
+             }
+     }
+

This is safe to notify with the hub mutex unlocked? Again, a comment would be helpful to future people explaining why that is so.

Quoted 9 lines
Quoted 6 lines

I will add a comment:
/*
* There is no need to lock status_mutex here, because status_mutex
* protects hub->status, and the phy driver only checks the port
* status without changing the status.
*/

Looks good, if you do it without the trailing whitespace :)

Okay

Thanks,
Stanley

#11 lore raw
In reply to Greg Kroah-Hartman

Hi Greg,

Quoted 12 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines

drivers/usb/core/hub.c static int hub_ext_port_status(struct usb_hub *hub, int port1, int type, · line 621

Quoted 5 lines
drivers/usb/core/hub.c +5 -0
+
+     if (!ret) {
+             struct usb_device *hdev = hub->hdev;
+
+             if (hdev && !hdev->parent) {

Why the check for no parent? Please document that here in a

comment.

Quoted 4 lines
Quoted 3 lines

I will add a comment :
/* Only notify roothub. That is, when hdev->parent is empty. */

Quoted 6 lines
Quoted 2 lines

Also document this that this will only happen for root hub status changes, that's not obvious in the callback name or documentation or

anywhere else here.

All usb phy notifications (connection, disconnection) are only for roothub. So I don't special to doc this.

I will add the comment:
/*
* Applies to roothub only. That is, when hdev->parent is
* empty. Only the roothub will be notified of port state
* changes, since the USB PHY only cares about changes at
* the next level.
*/

Thanks,
Stanley