net: mana: Configure hwc timeout from hardware
Subsystems (6)
PATCH v2 1/1 net: mana: Configure hwc timeout from hardware
At present hwc timeout value is a fixed value. This patch sets the hwc timeout from the hardware.
---
V1 -> V2:
* Added return check for mana_gd_query_hwc_timeout
* Removed dev_err from mana_gd_query_hwc_timeout
--- .../net/ethernet/microsoft/mana/gdma_main.c | 30 ++++++++++++++++++- .../net/ethernet/microsoft/mana/hw_channel.c | 25 +++++++++++++++- include/net/mana/gdma.h | 20 ++++++++++++- include/net/mana/hw_channel.h | 5 ++++ 4 files changed, 77 insertions(+), 3 deletions(-)
drivers/net/ethernet/microsoft/mana/gdma_main.c +29 -1
@@ -106,6 +106,27 @@ static int mana_gd_query_max_resources(struct pci_dev *pdev)return 0 ; } +static int mana_gd_query_hwc_timeout (struct pci_dev *pdev,u32 *timeout_val) +{ +struct gdma_context *gc =pci_get_drvdata (pdev); +struct gdma_query_hwc_timeout_req req = {}; +struct gdma_query_hwc_timeout_resp resp = {}; +int err; + +mana_gd_init_req_hdr (&req.hdr,GDMA_QUERY_HWC_TIMEOUT , +sizeof (req),sizeof (resp)); + req.timeout_ms = *timeout_val; + err =mana_gd_send_request (gc,sizeof (req), &req,sizeof (resp), &resp); +if (err || resp.hdr.status) +return err ? err : -EPROTO ; + + *timeout_val = resp.timeout_ms; +dev_info (gc->dev,"Successfully changed the timeout value %u\n" , + *timeout_val); + +return 0 ; +} +static int mana_gd_detect_devices (struct pci_dev *pdev) {struct gdma_context *gc =pci_get_drvdata (pdev);
@@ -879,6 +900,7 @@ int mana_gd_verify_vf_version(struct pci_dev *pdev)struct gdma_context *gc =pci_get_drvdata (pdev);struct gdma_verify_ver_resp resp = {};struct gdma_verify_ver_req req = {}; +struct hw_channel_context *hwc = gc->hwc.driver_data;int err; mana_gd_init_req_hdr(&req.hdr, GDMA_VERIFY_VF_DRIVER_VERSION,
@@ -907,7 +929,13 @@ int mana_gd_verify_vf_version(struct pci_dev *pdev) err, resp.hdr.status);return err ? err : -EPROTO ; } - +if (resp.pf_cap_flags1 &GDMA_DRV_CAP_FLAG_1_HWC_TIMEOUT_RECONFIG ) { + err =mana_gd_query_hwc_timeout (pdev, &hwc->hwc_timeout); +if (err) { +dev_err (gc->dev,"Failed to set the hwc timeout %d\n" , err); +return err; + } + }return 0 ; }
drivers/net/ethernet/microsoft/mana/hw_channel.c +24 -1
@@ -174,7 +174,25 @@ static void mana_hwc_init_event_handler(void *ctx, struct gdma_queue *q_self,complete (&hwc->hwc_init_eqe_comp);break ; +case GDMA_EQE_HWC_SOC_RECONFIG_DATA : + type_data.as_uint32 = event->details[0 ]; + type = type_data.type; + val = type_data.value; + +switch (type) { +case HWC_DATA_CFG_HWC_TIMEOUT : + hwc->hwc_timeout = val; +break ; + +default : +dev_warn (hwc->dev,"Received unknown reconfig type %u\n" , type); +break ; + } + +break ; +default : +dev_warn (hwc->dev,"Received unknown gdma event %u\n" , event->type);/* Ignore unknown events, which should never happen. */ break ; }
@@ -704,6 +722,7 @@ int mana_hwc_create_channel(struct gdma_context *gc) gd->pdid =INVALID_PDID ; gd->doorbell =INVALID_DOORBELL ; + hwc->hwc_timeout =HW_CHANNEL_WAIT_RESOURCE_TIMEOUT_MS ;/* mana_hwc_init_queues() only creates the required data structures, * and doesn't touch the HWC device. */
@@ -770,6 +789,8 @@ void mana_hwc_destroy_channel(struct gdma_context *gc) hwc->gdma_dev->doorbell =INVALID_DOORBELL ; hwc->gdma_dev->pdid =INVALID_PDID ; + hwc->hwc_timeout =0 ; +kfree (hwc); gc->hwc.driver_data =NULL ; gc->hwc.gdma_context =NULL ;
@@ -818,6 +839,7 @@ int mana_hwc_send_request(struct hw_channel_context *hwc, u32 req_len, dest_vrq = hwc->pf_dest_vrq_id; dest_vrcq = hwc->pf_dest_vrcq_id; } +dev_err (hwc->dev,"HWC: timeout %u ms\n" , hwc->hwc_timeout); err =mana_hwc_post_tx_wqe (txq, tx_wr, dest_vrq, dest_vrcq, false);if (err) {
@@ -825,7 +847,8 @@ int mana_hwc_send_request(struct hw_channel_context *hwc, u32 req_len, goto out; } -if (!wait_for_completion_timeout (&ctx->comp_event,30 *HZ )) { +if (!wait_for_completion_timeout (&ctx->comp_event, + (hwc->hwc_timeout /1000 ) *HZ )) {dev_err (hwc->dev,"HWC: Request timed out!\n" ); err = -ETIMEDOUT ; goto out;
include/net/mana/gdma.h +19 -1
@@ -33,6 +33,7 @@ enum gdma_request_type {GDMA_DESTROY_PD =30 ,GDMA_CREATE_MR =31 ,GDMA_DESTROY_MR =32 , + GDMA_QUERY_HWC_TIMEOUT = 84, /* 0x54 */ };#define GDMA_RESOURCE_DOORBELL_PAGE 27
@@ -57,6 +58,8 @@ enum gdma_eqe_type {GDMA_EQE_HWC_INIT_EQ_ID_DB =129 ,GDMA_EQE_HWC_INIT_DATA =130 ,GDMA_EQE_HWC_INIT_DONE =131 , +GDMA_EQE_HWC_SOC_RECONFIG =132 , + GDMA_EQE_HWC_SOC_RECONFIG_DATA = 133, }; enum {
@@ -531,10 +534,12 @@ enum {* so the driver is able to reliably support features like busy_poll. */ #define GDMA_DRV_CAP_FLAG_1_NAPI_WKDONE_FIX BIT(2) +#define GDMA_DRV_CAP_FLAG_1_HWC_TIMEOUT_RECONFIG BIT(3)#define GDMA_DRV_CAP_FLAGS1 \ (GDMA_DRV_CAP_FLAG_1_EQ_SHARING_MULTI_VPORT | \ - GDMA_DRV_CAP_FLAG_1_NAPI_WKDONE_FIX) + GDMA_DRV_CAP_FLAG_1_NAPI_WKDONE_FIX | \ + GDMA_DRV_CAP_FLAG_1_HWC_TIMEOUT_RECONFIG)#define GDMA_DRV_CAP_FLAGS2 0
@@ -664,6 +669,19 @@ struct gdma_disable_queue_req {u32 alloc_res_id_on_creation; };/* HW DATA */ +/* GDMA_QUERY_HWC_TIMEOUT */ +struct gdma_query_hwc_timeout_req { +struct gdma_req_hdr hdr; +u32 timeout_ms; +u32 reserved; +}; + +struct gdma_query_hwc_timeout_resp { +struct gdma_resp_hdr hdr; +u32 timeout_ms; +u32 reserved; +}; +enum atb_page_size {ATB_PAGE_SIZE_4K ,ATB_PAGE_SIZE_8K ,
include/net/mana/hw_channel.h +5 -0
@@ -23,6 +23,10 @@#define HWC_INIT_DATA_PF_DEST_RQ_ID 10#define HWC_INIT_DATA_PF_DEST_CQ_ID 11 +#define HWC_DATA_CFG_HWC_TIMEOUT 1 + +#define HW_CHANNEL_WAIT_RESOURCE_TIMEOUT_MS 30000 +/* Structures labeled with "HW DATA" are exchanged with the hardware. All of * them are naturally aligned and hence don't need __packed. */
@@ -182,6 +186,7 @@ struct hw_channel_context {u32 pf_dest_vrq_id;u32 pf_dest_vrcq_id; +u32 hwc_timeout;struct hwc_caller_ctx *caller_ctx; };
Signature · 1 line
2.34.1
kernel test robot
build botFYI: kernel test robot notices the stable kernel rule is not satisfied.
Hi,
Thanks for your patch.
FYI: kernel test robot notices the stable kernel rule is not satisfied.
Rule: 'Cc: [email protected]' or 'commit <sha1> upstream.'
Subject: [PATCH V2 net] net: mana: Configure hwc timeout from hardware
The check is based on https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
Signature · 2 lines
0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
Greg KH
maintainerQuoted 2 lines · Souradeep Chakrabarti
At present hwc timeout value is a fixed value. This patch sets the hwc timeout from the hardware.
This really does not describe what is happening here. Please read the documentation for how to write a good changelog text.
Quoted 6 lines
Signed-off-by Souradeep Chakrabarti <[email protected]>---
V1 -> V2:
* Added return check formana_gd_query_hwc_timeout
* Removeddev_errfrommana_gd_query_hwc_timeout
<formletter>
This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.
</formletter>
Greg KH
maintainerQuoted 30 lines · Souradeep Chakrabarti
At present hwc timeout value is a fixed value. This patch sets the hwc timeout from the hardware.
Signed-off-by Souradeep Chakrabarti <[email protected]>---
V1 -> V2:
* Added return check formana_gd_query_hwc_timeout
* Removeddev_errfrommana_gd_query_hwc_timeout--- .../net/ethernet/microsoft/mana/gdma_main.c | 30 ++++++++++++++++++- .../net/ethernet/microsoft/mana/hw_channel.c | 25 +++++++++++++++- include/net/mana/gdma.h | 20 ++++++++++++- include/net/mana/hw_channel.h | 5 ++++ 4 files changed, 77 insertions(+), 3 deletions(-)drivers/net/ethernet/microsoft/mana/gdma_main.c +7
-0@@ -106,6 +106,27 @@ static int mana_gd_query_max_resources(struct pci_dev *pdev)return 0 ; } +static int mana_gd_query_hwc_timeout (struct pci_dev *pdev,u32 *timeout_val) +{ +struct gdma_context *gc =pci_get_drvdata (pdev); +struct gdma_query_hwc_timeout_req req = {}; +struct gdma_query_hwc_timeout_resp resp = {}; +int err; +
drivers/net/ethernet/microsoft/mana/gdma_main.c static int mana_gd_query_max_resources(struct pci_dev *pdev) · line 125
Quoted 10 lines
drivers/net/ethernet/microsoft/mana/gdma_main.c +10
-0+mana_gd_init_req_hdr (&req.hdr,GDMA_QUERY_HWC_TIMEOUT , +sizeof (req),sizeof (resp)); + req.timeout_ms = *timeout_val; + err =mana_gd_send_request (gc,sizeof (req), &req,sizeof (resp), &resp); +if (err || resp.hdr.status) +return err ? err : -EPROTO ; + + *timeout_val = resp.timeout_ms; +dev_info (gc->dev,"Successfully changed the timeout value %u\n" , + *timeout_val);
When the kernel works properly, it is quiet. Please always remove your debugging code before submitting changes for inclusion.
thanks,
greg k-h
Quoted 68 lines
-----Original Message-----
From: Greg KH <[email protected]>
Sent: Friday, July 7, 2023 3:47 PM
To: Souradeep Chakrabarti <[email protected]>
Cc: KY Srinivasan <[email protected]>; Haiyang Zhang <[email protected]>; [email protected]; Dexuan Cui <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]; Long Li <[email protected]>; Ajay Sharma <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; Souradeep Chakrabarti <[email protected]>
Subject: [EXTERNAL] Re: [PATCH V2 net] net: mana: Configure hwc timeout from hardwareQuoted 11 lines · Souradeep Chakrabarti
At present hwc timeout value is a fixed value. This patch sets the hwc timeout from the hardware.
Signed-off-by: Souradeep Chakrabarti <[email protected]>
---
V1 -> V2:
* Added return check formana_gd_query_hwc_timeout
* Removeddev_errfrommana_gd_query_hwc_timeout--- .../net/ethernet/microsoft/mana/gdma_main.c | 30++++++++++++++++++-
drivers/net/ethernet/microsoft/mana/gdma_main.c static int mana_gd_query_max_resources(struct
Quoted 11 lines
.../net/ethernet/microsoft/mana/hw_channel.c | 25 +++++++++++++++- include/net/mana/gdma.h | 20 ++++++++++++- include/net/mana/hw_channel.h | 5 ++++ 4 files changed, 77 insertions(+), 3 deletions(-)drivers/net/ethernet/microsoft/mana/gdma_main.c +0
-0@@ -106,6 +106,27 @@ static int mana_gd_query_max_resources(struct
pci_dev*pdev)Quoted 10 lines
drivers/net/ethernet/microsoft/mana/gdma_main.c +7
-0return 0 ; } +static int mana_gd_query_hwc_timeout (struct pci_dev *pdev,u32 +*timeout_val) { +struct gdma_context *gc =pci_get_drvdata (pdev); +struct gdma_query_hwc_timeout_req req = {}; +struct gdma_query_hwc_timeout_resp resp = {}; +int err; +drivers/net/ethernet/microsoft/mana/gdma_main.c static int mana_gd_query_max_resources(struct pci_dev *pdev) · line 125
Quoted 10 lines
drivers/net/ethernet/microsoft/mana/gdma_main.c +10
-0+mana_gd_init_req_hdr (&req.hdr,GDMA_QUERY_HWC_TIMEOUT , +sizeof (req),sizeof (resp)); + req.timeout_ms = *timeout_val; + err =mana_gd_send_request (gc,sizeof (req), &req,sizeof (resp), &resp); +if (err || resp.hdr.status) +return err ? err : -EPROTO ; + + *timeout_val = resp.timeout_ms; +dev_info (gc->dev,"Successfully changed the timeout value %u\n" , + *timeout_val);When the kernel works properly, it is quiet. Please always remove your debugging code before submitting changes for inclusion.
Quoted 3 lines
thanks,
greg k-h
Thank you for the comments, will take care of them in the next revision. regards,
Souradeep
Quoted 20 lines · Souradeep Chakrabarti
At present hwc timeout value is a fixed value. This patch sets the hwc timeout from the hardware.
Signed-off-by Souradeep Chakrabarti <[email protected]>---
V1 -> V2:
* Added return check formana_gd_query_hwc_timeout
* Removeddev_errfrommana_gd_query_hwc_timeout--- .../net/ethernet/microsoft/mana/gdma_main.c | 30 ++++++++++++++++++- .../net/ethernet/microsoft/mana/hw_channel.c | 25 +++++++++++++++- include/net/mana/gdma.h | 20 ++++++++++++- include/net/mana/hw_channel.h | 5 ++++ 4 files changed, 77 insertions(+), 3 deletions(-)drivers/net/ethernet/microsoft/mana/gdma_main.c +0
-0
drivers/net/ethernet/microsoft/mana/gdma_main.c static int mana_gd_query_max_resources(struct pci_dev *pdev) · line 113
Quoted 8 lines
drivers/net/ethernet/microsoft/mana/gdma_main.c +5
-0@@ -106,6 +106,27 @@ static int mana_gd_query_max_resources(struct pci_dev *pdev)return 0 ; } +static int mana_gd_query_hwc_timeout (struct pci_dev *pdev,u32 *timeout_val) +{ +struct gdma_context *gc =pci_get_drvdata (pdev); +struct gdma_query_hwc_timeout_req req = {}; +struct gdma_query_hwc_timeout_resp resp = {};
Please use reverse xmas tree - longest line to shortest - for local variables in Networking code.
...
drivers/net/ethernet/microsoft/mana/gdma_main.c int mana_gd_verify_vf_version(struct pci_dev *pdev) · line 904
Quoted 6 lines
drivers/net/ethernet/microsoft/mana/gdma_main.c +1
-0@@ -879,6 +900,7 @@ int mana_gd_verify_vf_version(struct pci_dev *pdev)struct gdma_context *gc =pci_get_drvdata (pdev);struct gdma_verify_ver_resp resp = {};struct gdma_verify_ver_req req = {}; +struct hw_channel_context *hwc = gc->hwc.driver_data;int err;
Ditto.