Skip to contentSkip to conversation

dt-bindings: Input: exc3000 - Support power supply regulators

PATCH Applied Mike Looijmans 2 participants 4 messages Jul 7, 2023 – Jul 8, 2023 1 message not in the archive

Subsystems (3)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): 1b153bce-a66a-45ee-a5c6-963ea6fb1c82.949ef384-8293-46b8-903f-40a477c056ae.067a6add-28c9-4499-a235-882581bddc85@emailsignatures365.codetwo.com

#1 lore raw

PATCH v2 1/2 dt-bindings: Input: exc3000 - Support power supply regulators

Add power supply regulator support to the exc3000 devices.

---

(no changes since v1)

 .../devicetree/bindings/input/touchscreen/eeti,exc3000.yaml     | 2 ++
 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/input/touchscreen/eeti,exc3000.yaml +2 -0
index 007adbc89c14..9dc25d30a0a8 100644
@@ -24,6 +24,8 @@ properties:
     maxItems: 1
   reset-gpios:
     maxItems: 1
+  vdd-supply:
+    description: Power supply regulator for the chip
   touchscreen-size-x: true
   touchscreen-size-y: true
   touchscreen-inverted-x: true
Signature · 18 lines
2.17.1


Met vriendelijke groet / kind regards,

Mike Looijmans
System Expert


TOPIC Embedded Products B.V.
Materiaalweg 4, 5681 RJ Best
The Netherlands

T: +31 (0) 499 33 69 69
E: [email protected]
W: www.topic.nl

Please consider the environment before printing this e-mail
#2 lore raw

PATCH v2 2/2 Input: exc3000 - Support power supply regulators

Add power supply regulator support to the exc3000 devices.

---

Changes in v2:
Add missing "return" statement
Use devm_regulator_get_enable without _optional

 drivers/input/touchscreen/exc3000.c | 7 +++++++
 1 file changed, 7 insertions(+)
drivers/input/touchscreen/exc3000.c +7 -0
index 4af4c1e5d0da..e3f6d21b3c1b 100644
@@ -18,6 +18,7 @@
 #include <linux/interrupt.h>
 #include <linux/module.h>
 #include <linux/of.h>
+#include <linux/regulator/consumer.h>
 #include <linux/sizes.h>
 #include <linux/timer.h>
 #include <asm/unaligned.h>
@@ -360,6 +361,12 @@ static int exc3000_probe(struct i2c_client *client)
 	if (IS_ERR(data->reset))
 		return PTR_ERR(data->reset);
 
+	/* For proper reset sequence, enable power while reset asserted */
+	error = devm_regulator_get_enable(&client->dev, "vdd");
+	if (error && error != -ENODEV)
+		return dev_err_probe(&client->dev, error,
+				     "failed to request vdd regulator\n");
+
 	if (data->reset) {
 		msleep(EXC3000_RESET_MS);
 		gpiod_set_value_cansleep(data->reset, 0);
Signature · 18 lines
2.17.1


Met vriendelijke groet / kind regards,

Mike Looijmans
System Expert


TOPIC Embedded Products B.V.
Materiaalweg 4, 5681 RJ Best
The Netherlands

T: +31 (0) 499 33 69 69
E: [email protected]
W: www.topic.nl

Please consider the environment before printing this e-mail
maintainer Applied
#3 lore raw

Re: [PATCH v2 2/2] Input: exc3000 - Support power supply regulators

Quoted 4 lines · Mike Looijmans

Add power supply regulator support to the exc3000 devices.

Applied, thank you.

Signature · 1 line
Dmitry