Skip to contentSkip to conversation

platform/x86: touchscreen_dmi: Add info for the Archos 101 Cesium Educ tablet

PATCH In review Thomas GENTY 2 participants 4 messages Jul 7, 2023 – Jul 14, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 platform/x86: touchscreen_dmi: Add info for the Archos 101 Cesium Educ tablet

Add info for the Archos 101 Cesium Educ tablet
It was tested using gslx680_ts_acpi module
PR at https://github.com/onitake/gsl-firmware/pull/210 for the firmware

---
 drivers/platform/x86/touchscreen_dmi.c | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)
drivers/platform/x86/touchscreen_dmi.c +22 -0
index 68e66b60445c..a5b687eed8f3 100644
@@ -26,6 +26,21 @@ struct ts_dmi_data {
 
 /* NOTE: Please keep all entries sorted alphabetically */
 
+static const struct property_entry archos_101_cesium_educ_props[] = {
+	PROPERTY_ENTRY_U32("touchscreen-size-x", 1280),
+	PROPERTY_ENTRY_U32("touchscreen-size-y", 1850),
+	PROPERTY_ENTRY_BOOL("touchscreen-inverted-x"),
+	PROPERTY_ENTRY_BOOL("touchscreen-swapped-x-y"),
+	PROPERTY_ENTRY_U32("silead,max-fingers", 10),
+	PROPERTY_ENTRY_STRING("firmware-name", "gsl1680-archos-101-cesium-educ.fw"),
+	{ }
+};
+
+static const struct ts_dmi_data archos_101_cesium_educ_data = {
+	.acpi_name      = "MSSL1680:00",
+	.properties     = archos_101_cesium_educ_props,
+};
+
 static const struct property_entry chuwi_hi8_props[] = {
 	PROPERTY_ENTRY_U32("touchscreen-size-x", 1665),
 	PROPERTY_ENTRY_U32("touchscreen-size-y", 1140),
@@ -1047,6 +1062,13 @@ static const struct ts_dmi_data vinga_twizzle_j116_data = {
 
 /* NOTE: Please keep this table sorted alphabetically */
 const struct dmi_system_id touchscreen_dmi_table[] = {
+	{
+		/* Archos 101 Cesium Educ */
+		.driver_data = (void *)&archos_101_cesium_educ_data,
+		.matches = {
+			DMI_MATCH(DMI_PRODUCT_NAME, "ARCHOS 101 Cesium Educ"),
+		},
+	},
 	{
 		/* Chuwi Hi8 */
 		.driver_data = (void *)&chuwi_hi8_data,
Signature · 1 line
2.41.0
#1 lore raw

Hi,

Quoted 5 lines · Thomas GENTY

Add info for the Archos 101 Cesium Educ tablet
It was tested using gslx680_ts_acpi module
PR at https://github.com/onitake/gsl-firmware/pull/210 for the firmware

Thank you for your patch, I've applied this patch to my fixes branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=fixes

Note it will show up in my fixes branch once I've pushed my local branch there, which might take a while.

I will include this patch in my next fixes pull-req to Linus for the current kernel development cycle.

Note I do wonder if this tablet can benefit from then following change on top when used with the kernel's builtin silead driver:

drivers/platform/x86/touchscreen_dmi.c +1 -0
index a5b687eed8f3..5f9ce4960861 100644
@@ -32,6 +32,7 @@ static const struct property_entry archos_101_cesium_educ_props[] = {
 	PROPERTY_ENTRY_BOOL("touchscreen-inverted-x"),
 	PROPERTY_ENTRY_BOOL("touchscreen-swapped-x-y"),
 	PROPERTY_ENTRY_U32("silead,max-fingers", 10),
+	PROPERTY_ENTRY_BOOL("silead,home-button"),
 	PROPERTY_ENTRY_STRING("firmware-name", "gsl1680-archos-101-cesium-educ.fw"),
 	{ }
 };

I expect this will make the windows logo beneath the touchscreen send meta/super key events when pressed (you can check this with e.g. evtest).

Can you please give this a go ?

Regards,

Hans

Quoted 44 lines
---
 drivers/platform/x86/touchscreen_dmi.c | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)
drivers/platform/x86/touchscreen_dmi.c +22 -0
index 68e66b60445c..a5b687eed8f3 100644
@@ -26,6 +26,21 @@ struct ts_dmi_data {
 
 /* NOTE: Please keep all entries sorted alphabetically */
 
+static const struct property_entry archos_101_cesium_educ_props[] = {
+	PROPERTY_ENTRY_U32("touchscreen-size-x", 1280),
+	PROPERTY_ENTRY_U32("touchscreen-size-y", 1850),
+	PROPERTY_ENTRY_BOOL("touchscreen-inverted-x"),
+	PROPERTY_ENTRY_BOOL("touchscreen-swapped-x-y"),
+	PROPERTY_ENTRY_U32("silead,max-fingers", 10),
+	PROPERTY_ENTRY_STRING("firmware-name", "gsl1680-archos-101-cesium-educ.fw"),
+	{ }
+};
+
+static const struct ts_dmi_data archos_101_cesium_educ_data = {
+	.acpi_name      = "MSSL1680:00",
+	.properties     = archos_101_cesium_educ_props,
+};
+
 static const struct property_entry chuwi_hi8_props[] = {
 	PROPERTY_ENTRY_U32("touchscreen-size-x", 1665),
 	PROPERTY_ENTRY_U32("touchscreen-size-y", 1140),
@@ -1047,6 +1062,13 @@ static const struct ts_dmi_data vinga_twizzle_j116_data = {
 
 /* NOTE: Please keep this table sorted alphabetically */
 const struct dmi_system_id touchscreen_dmi_table[] = {
+	{
+		/* Archos 101 Cesium Educ */
+		.driver_data = (void *)&archos_101_cesium_educ_data,
+		.matches = {
+			DMI_MATCH(DMI_PRODUCT_NAME, "ARCHOS 101 Cesium Educ"),
+		},
+	},
 	{
 		/* Chuwi Hi8 */
 		.driver_data = (void *)&chuwi_hi8_data,
#2 lore raw

Le 11/07/2023 à 12:14, Hans de Goede a écrit :
Hi,

Quoted 12 lines

Hi,

Quoted 5 lines · Thomas GENTY

Add info for the Archos 101 Cesium Educ tablet
It was tested using gslx680_ts_acpi module
PR at https://github.com/onitake/gsl-firmware/pull/210 for the firmware

Thank you for your patch, I've applied this patch to my fixes branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=fixes

Quoted 7 lines

Note it will show up in my fixes branch once I've pushed my local branch there, which might take a while.

I will include this patch in my next fixes pull-req to Linus for the current kernel development cycle.

Note I do wonder if this tablet can benefit from then following change on top when used with the kernel's builtin silead driver:

It can,

I will submit a new patch with this enable and correct the previous one. it seems I have inverted all axes

Regards,

Tom

Quoted 69 lines
drivers/platform/x86/touchscreen_dmi.c +1 -0
index a5b687eed8f3..5f9ce4960861 100644
@@ -32,6 +32,7 @@ static const struct property_entry archos_101_cesium_educ_props[] = {
  	PROPERTY_ENTRY_BOOL("touchscreen-inverted-x"),
  	PROPERTY_ENTRY_BOOL("touchscreen-swapped-x-y"),
  	PROPERTY_ENTRY_U32("silead,max-fingers", 10),
+	PROPERTY_ENTRY_BOOL("silead,home-button"),
  	PROPERTY_ENTRY_STRING("firmware-name", "gsl1680-archos-101-cesium-educ.fw"),
  	{ }
  };

I expect this will make the windows logo beneath the touchscreen send meta/super key events when pressed (you can check this with e.g. evtest).

Can you please give this a go ?

Regards,

Hans

Quoted 44 lines
---
  drivers/platform/x86/touchscreen_dmi.c | 22 ++++++++++++++++++++++
  1 file changed, 22 insertions(+)
drivers/platform/x86/touchscreen_dmi.c +22 -0
index 68e66b60445c..a5b687eed8f3 100644
@@ -26,6 +26,21 @@ struct ts_dmi_data {
 
  /* NOTE: Please keep all entries sorted alphabetically */
 
+static const struct property_entry archos_101_cesium_educ_props[] = {
+	PROPERTY_ENTRY_U32("touchscreen-size-x", 1280),
+	PROPERTY_ENTRY_U32("touchscreen-size-y", 1850),
+	PROPERTY_ENTRY_BOOL("touchscreen-inverted-x"),
+	PROPERTY_ENTRY_BOOL("touchscreen-swapped-x-y"),
+	PROPERTY_ENTRY_U32("silead,max-fingers", 10),
+	PROPERTY_ENTRY_STRING("firmware-name", "gsl1680-archos-101-cesium-educ.fw"),
+	{ }
+};
+
+static const struct ts_dmi_data archos_101_cesium_educ_data = {
+	.acpi_name      = "MSSL1680:00",
+	.properties     = archos_101_cesium_educ_props,
+};
+
  static const struct property_entry chuwi_hi8_props[] = {
  	PROPERTY_ENTRY_U32("touchscreen-size-x", 1665),
  	PROPERTY_ENTRY_U32("touchscreen-size-y", 1140),
@@ -1047,6 +1062,13 @@ static const struct ts_dmi_data vinga_twizzle_j116_data = {
 
  /* NOTE: Please keep this table sorted alphabetically */
  const struct dmi_system_id touchscreen_dmi_table[] = {
+	{
+		/* Archos 101 Cesium Educ */
+		.driver_data = (void *)&archos_101_cesium_educ_data,
+		.matches = {
+			DMI_MATCH(DMI_PRODUCT_NAME, "ARCHOS 101 Cesium Educ"),
+		},
+	},
  	{
  		/* Chuwi Hi8 */
  		.driver_data = (void *)&chuwi_hi8_data,
#3 lore raw

Hi,

Quoted 17 lines · On 7/14/23 09:53, [email protected] wrote:

Le 11/07/2023 à 12:14, Hans de Goede a écrit :
Hi,

Quoted 15 lines

Hi,

Quoted 5 lines · Thomas GENTY

Add info for the Archos 101 Cesium Educ tablet
It was tested using gslx680_ts_acpi module
PR at https://github.com/onitake/gsl-firmware/pull/210 for the firmware

Thank you for your patch, I've applied this patch to my fixes branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=fixes

Note it will show up in my fixes branch once I've pushed my local branch there, which might take a while.

Quoted 6 lines
Quoted 4 lines

I will include this patch in my next fixes pull-req to Linus for the current kernel development cycle.

Note I do wonder if this tablet can benefit from then following change on top when used with the kernel's builtin silead driver:

It can,

Good.

Quoted 1 line

I will submit a new patch with this enable and correct the previous one. it seems I have inverted all axes

I have already send out this one to Linus and it already is in Linus' master branch:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/log/drivers/platform/x86/touchscreen_dmi.c

So please make the new patch a follow-up patch. I'll make sure that the follow-up also gets sends to Linus before 6.5 gets released.

Regards,

Hans

Quoted 67 lines
Quoted 65 lines
drivers/platform/x86/touchscreen_dmi.c +1 -0
index a5b687eed8f3..5f9ce4960861 100644
@@ -32,6 +32,7 @@ static const struct property_entry archos_101_cesium_educ_props[] = {
       PROPERTY_ENTRY_BOOL("touchscreen-inverted-x"),
       PROPERTY_ENTRY_BOOL("touchscreen-swapped-x-y"),
       PROPERTY_ENTRY_U32("silead,max-fingers", 10),
+    PROPERTY_ENTRY_BOOL("silead,home-button"),
       PROPERTY_ENTRY_STRING("firmware-name", "gsl1680-archos-101-cesium-educ.fw"),
       { }
   };

I expect this will make the windows logo beneath the touchscreen send meta/super key events when pressed (you can check this with e.g. evtest).

Can you please give this a go ?

Regards,

Hans

Quoted 41 lines

---
  drivers/platform/x86/touchscreen_dmi.c | 22 ++++++++++++++++++++++

  1 file changed, 22 insertions(+)
drivers/platform/x86/touchscreen_dmi.c +21 -0
index 68e66b60445c..a5b687eed8f3 100644
@@ -26,6 +26,21 @@ struct ts_dmi_data {
     /* NOTE: Please keep all entries sorted alphabetically */
   +static const struct property_entry archos_101_cesium_educ_props[] = {
+    PROPERTY_ENTRY_U32("touchscreen-size-x", 1280),
+    PROPERTY_ENTRY_U32("touchscreen-size-y", 1850),
+    PROPERTY_ENTRY_BOOL("touchscreen-inverted-x"),
+    PROPERTY_ENTRY_BOOL("touchscreen-swapped-x-y"),
+    PROPERTY_ENTRY_U32("silead,max-fingers", 10),
+    PROPERTY_ENTRY_STRING("firmware-name", "gsl1680-archos-101-cesium-educ.fw"),
+    { }
+};
+
+static const struct ts_dmi_data archos_101_cesium_educ_data = {
+    .acpi_name      = "MSSL1680:00",
+    .properties     = archos_101_cesium_educ_props,
+};
+
   static const struct property_entry chuwi_hi8_props[] = {
       PROPERTY_ENTRY_U32("touchscreen-size-x", 1665),
       PROPERTY_ENTRY_U32("touchscreen-size-y", 1140),
@@ -1047,6 +1062,13 @@ static const struct ts_dmi_data vinga_twizzle_j116_data = {
     /* NOTE: Please keep this table sorted alphabetically */
   const struct dmi_system_id touchscreen_dmi_table[] = {
+    {
+        /* Archos 101 Cesium Educ */
+        .driver_data = (void *)&archos_101_cesium_educ_data,
+        .matches = {
+            DMI_MATCH(DMI_PRODUCT_NAME, "ARCHOS 101 Cesium Educ"),
+        },
+    },
       {
           /* Chuwi Hi8 */
           .driver_data = (void *)&chuwi_hi8_data,