Skip to contentSkip to conversation

drm/panel: simple: Drop prepared_time

PATCH In review Marek Vasut 3 participants 4 messages Jul 9, 2023 – Jul 20, 2023

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/panel: simple: Drop prepared_time

This has been superseded by RPM in commit
3235b0f20a0a ("drm/panel: panel-simple: Use runtime pm to avoid excessive unprepare / prepare") and the last user of the non-RPM case has been dropped in commit
b6d5ffce11dd ("drm/panel-simple: Non-eDP panels don't need "HPD" handling") whatever is left in this driver is just assigned and never used.
Drop the remaining parts.

---
Cc: Daniel Vetter <[email protected]>
Cc: David Airlie <[email protected]>
Cc: Douglas Anderson <[email protected]>
Cc: Neil Armstrong <[email protected]>
Cc: Sam Ravnborg <[email protected]>
Cc: [email protected]

---
 drivers/gpu/drm/panel/panel-simple.c | 4 ----
 1 file changed, 4 deletions(-)
drivers/gpu/drm/panel/panel-simple.c +0 -4
index 37afed67fea7e..e943148dd2b0c 100644
@@ -141,7 +141,6 @@ struct panel_simple {
 
 	bool prepared;
 
-	ktime_t prepared_time;
 	ktime_t unprepared_time;
 
 	const struct panel_desc *desc;
@@ -351,8 +350,6 @@ static int panel_simple_resume(struct device *dev)
 	if (p->desc->delay.prepare)
 		msleep(p->desc->delay.prepare);
 
-	p->prepared_time = ktime_get_boottime();
-
 	return 0;
 }
 
@@ -566,7 +563,6 @@ static int panel_simple_probe(struct device *dev, const struct panel_desc *desc)
 		return -ENOMEM;
 
 	panel->enabled = false;
-	panel->prepared_time = 0;
 	panel->unprepared_time = ktime_get_boottime();
 	panel->desc = desc;
 
Signature · 1 line
2.40.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 7 lines · Marek Vasut

This has been superseded by RPM in commit
3235b0f20a0a ("drm/panel: panel-simple: Use runtime pm to avoid excessive unprepare / prepare") and the last user of the non-RPM case has been dropped in commit
b6d5ffce11dd ("drm/panel-simple: Non-eDP panels don't need "HPD" handling") whatever is left in this driver is just assigned and never used.
Drop the remaining parts.

Quoted 8 lines

---
Cc: Daniel Vetter <[email protected]>
Cc: David Airlie <[email protected]>
Cc: Douglas Anderson <[email protected]>
Cc: Neil Armstrong <[email protected]>
Cc: Sam Ravnborg <[email protected]>
Cc: [email protected]

Thanks,

Reviewed-by on v1 1/1
#2 lore raw
In reply to Marek Vasut

Hi,

Quoted 16 lines · Marek Vasut

This has been superseded by RPM in commit
3235b0f20a0a ("drm/panel: panel-simple: Use runtime pm to avoid excessive unprepare / prepare") and the last user of the non-RPM case has been dropped in commit
b6d5ffce11dd ("drm/panel-simple: Non-eDP panels don't need "HPD" handling") whatever is left in this driver is just assigned and never used.
Drop the remaining parts.

---
Cc: Daniel Vetter <[email protected]>
Cc: David Airlie <[email protected]>
Cc: Douglas Anderson <[email protected]>
Cc: Neil Armstrong <[email protected]>
Cc: Sam Ravnborg <[email protected]>
Cc: [email protected]

Quoted 3 lines
---
 drivers/gpu/drm/panel/panel-simple.c | 4 ----
 1 file changed, 4 deletions(-)

Thanks for cleaning this up.

I'm happy to apply this or happy for others to. I'll wait a few more days and then apply it if nobody else has.

-Doug

#3 lore raw

Hi,

Quoted 24 lines · Doug Anderson

Hi,

Quoted 16 lines · Marek Vasut

This has been superseded by RPM in commit
3235b0f20a0a ("drm/panel: panel-simple: Use runtime pm to avoid excessive unprepare / prepare") and the last user of the non-RPM case has been dropped in commit
b6d5ffce11dd ("drm/panel-simple: Non-eDP panels don't need "HPD" handling") whatever is left in this driver is just assigned and never used.
Drop the remaining parts.

---
Cc: Daniel Vetter <[email protected]>
Cc: David Airlie <[email protected]>
Cc: Douglas Anderson <[email protected]>
Cc: Neil Armstrong <[email protected]>
Cc: Sam Ravnborg <[email protected]>
Cc: [email protected]

Quoted 3 lines
---
 drivers/gpu/drm/panel/panel-simple.c | 4 ----
 1 file changed, 4 deletions(-)
Quoted 6 lines

Thanks for cleaning this up.

I'm happy to apply this or happy for others to. I'll wait a few more days and then apply it if nobody else has.

As promised, I've pushed this to drm-misc-next.

c942e935ff3f drm/panel: simple: Drop prepared_time

I had to manually resolve the context conflict since this patch only applied cleanly atop your other patch [1]. However, the resolution was trivial.

[1] https://lore.kernel.org/all/[email protected]/