Skip to contentSkip to conversation

mfd: rk808: turn MFD_RK8XX into a tristate

PATCH In review Ivan Babrou 2 participants 3 messages Jul 9, 2023 – Jul 10, 2023 Multifunction devices (MFD)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mfd: rk808: turn MFD_RK8XX into a tristate

Prior to commit c20e8c5b1203 ("mfd: rk808: Split into core and i2c") it was possible to build rk808 as a module and have CONFIG_MFD_CORE=m too. After that the intermediary CONFIG_MFD_RK8XX was added as a boolean, forcing mfd_core to be compiled in whenever rk808 was enabled, even if it was still built as a module.

Fixes c20e8c5b1203 ("mfd: rk808: Split into core and i2c")
---
 drivers/mfd/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mfd/Kconfig +1 -1
index 6f5b259a6d6a..f6b519eaaa71 100644
@@ -1197,7 +1197,7 @@ config MFD_RC5T583
 	  different functionality of the device.
 
 config MFD_RK8XX
-	bool
+	tristate
 	select MFD_CORE
 
 config MFD_RK8XX_I2C
Signature · 1 line
2.41.0
#1 lore raw

Hi,

Quoted 9 lines · Ivan Babrou

Prior to commit c20e8c5b1203 ("mfd: rk808: Split into core and i2c") it was possible to build rk808 as a module and have CONFIG_MFD_CORE=m too. After that the intermediary CONFIG_MFD_RK8XX was added as a boolean, forcing mfd_core to be compiled in whenever rk808 was enabled, even if it was still built as a module.

Fixes c20e8c5b1203 ("mfd: rk808: Split into core and i2c")

---

The same fix has already been send by Geert some days ago:

https://lore.kernel.org/all/d132363fc9228473e9e652b70a3761b94de32d70.1688475844.git.geert+renesas@glider.be/

-- Sebastian

Quoted 19 lines
 drivers/mfd/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mfd/Kconfig +1 -1
index 6f5b259a6d6a..f6b519eaaa71 100644
@@ -1197,7 +1197,7 @@ config MFD_RC5T583
 	  different functionality of the device.
 
 config MFD_RK8XX
-	bool
+	tristate
 	select MFD_CORE
 
 config MFD_RK8XX_I2C
Signature · 1 line
2.41.0
#2 lore raw
Quoted 10 lines · Sebastian Reichel

Hi,

Quoted 6 lines · Ivan Babrou

Prior to commit c20e8c5b1203 ("mfd: rk808: Split into core and i2c") it was possible to build rk808 as a module and have CONFIG_MFD_CORE=m too. After that the intermediary CONFIG_MFD_RK8XX was added as a boolean, forcing mfd_core to be compiled in whenever rk808 was enabled, even if it was still built as a module.

Quoted 7 lines
Quoted 3 lines
Fixes c20e8c5b1203 ("mfd: rk808: Split into core and i2c")

---

The same fix has already been send by Geert some days ago:

https://lore.kernel.org/all/d132363fc9228473e9e652b70a3761b94de32d70.1688475844.git.geert+renesas@glider.be/

Ah, I looked through the devicetree mailing list archive (where the original patch was sent) and haven't found anything there.