Skip to contentSkip to conversation

dt-bindings: ti-serdes-mux: Add defines for SERDES4 in J784S4 SoC

PATCH In review Jayesh Choudhary 2 participants 7 messages Jul 10, 2023 – Jul 11, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dt-bindings: ti-serdes-mux: Add defines for SERDES4 in J784S4 SoC

SERDES4 has 4 lanes. Add lane definitions for it.

---
 include/dt-bindings/mux/ti-serdes.h | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
include/dt-bindings/mux/ti-serdes.h +20 -0
index 669ca2d6abce..0d7aec677df9 100644
@@ -179,4 +179,24 @@
 #define J784S4_SERDES2_LANE3_IP3_UNUSED		0x2
 #define J784S4_SERDES2_LANE3_IP4_UNUSED		0x3
 
+#define J784S4_SERDES4_LANE0_EDP_LANE0		0x0
+#define J784S4_SERDES4_LANE0_QSGMII_LANE5	0x1
+#define J784S4_SERDES4_LANE0_IP3_UNUSED		0x2
+#define J784S4_SERDES4_LANE0_IP4_UNUSED		0x3
+
+#define J784S4_SERDES4_LANE1_EDP_LANE1		0x0
+#define J784S4_SERDES4_LANE1_QSGMII_LANE6	0x1
+#define J784S4_SERDES4_LANE1_IP3_UNUSED		0x2
+#define J784S4_SERDES4_LANE1_IP4_UNUSED		0x3
+
+#define J784S4_SERDES4_LANE2_EDP_LANE2		0x0
+#define J784S4_SERDES4_LANE2_QSGMII_LANE7	0x1
+#define J784S4_SERDES4_LANE2_IP3_UNUSED		0x2
+#define J784S4_SERDES4_LANE2_IP4_UNUSED		0x3
+
+#define J784S4_SERDES4_LANE3_EDP_LANE3		0x0
+#define J784S4_SERDES4_LANE3_QSGMII_LANE8	0x1
+#define J784S4_SERDES4_LANE3_USB		0x2
+#define J784S4_SERDES4_LANE3_IP4_UNUSED		0x3
+
 #endif /* _DT_BINDINGS_MUX_TI_SERDES */
Signature · 1 line
2.25.1
#1 lore raw
Quoted 5 lines · Jayesh Choudhary

SERDES4 has 4 lanes. Add lane definitions for it.

---
 include/dt-bindings/mux/ti-serdes.h | 20 ++++++++++++++++++++

Where are the users of this binding constants? IOW, why do you need to add these?

I don't see users of existing constants either...

Best regards,
Krzysztof

#2 lore raw

Hello Krzysztof,

Quoted 12 lines · Krzysztof Kozlowski
Quoted 5 lines · Jayesh Choudhary

SERDES4 has 4 lanes. Add lane definitions for it.

---
  include/dt-bindings/mux/ti-serdes.h | 20 ++++++++++++++++++++

Where are the users of this binding constants? IOW, why do you need to add these?

I don't see users of existing constants either...

These constants are propagated in the idle-state property for the mux-controller node (named serdes_ln_ctrl) usually in the final board dts files and occasionally in the main dtsi files for TI SoCs.

-Jayesh

#3 lore raw
Quoted 13 lines · Jayesh Choudhary

Hello Krzysztof,

Quoted 10 lines · Krzysztof Kozlowski
Quoted 5 lines · Jayesh Choudhary

SERDES4 has 4 lanes. Add lane definitions for it.

---
  include/dt-bindings/mux/ti-serdes.h | 20 ++++++++++++++++++++

Where are the users of this binding constants? IOW, why do you need to add these?

Quoted 6 lines
Quoted 2 lines

I don't see users of existing constants either...

These constants are propagated in the idle-state property for the mux-controller node (named serdes_ln_ctrl) usually in the final board dts files and occasionally in the main dtsi files for TI SoCs.

So they are not used. Do not add headers which are not used - neither to the kernel sources, nor to the DTSI. The header constants don't even look as suitable for bindings, although this is tricky to judge without users.

Best regards,
Krzysztof

#4 lore raw
Quoted 14 lines · Krzysztof Kozlowski
Quoted 13 lines · Jayesh Choudhary

Hello Krzysztof,

Quoted 10 lines · Krzysztof Kozlowski
Quoted 5 lines · Jayesh Choudhary

SERDES4 has 4 lanes. Add lane definitions for it.

---
   include/dt-bindings/mux/ti-serdes.h | 20 ++++++++++++++++++++

Where are the users of this binding constants? IOW, why do you need to add these?

Quoted 8 lines
Quoted 6 lines
Quoted 2 lines

I don't see users of existing constants either...

These constants are propagated in the idle-state property for the mux-controller node (named serdes_ln_ctrl) usually in the final board dts files and occasionally in the main dtsi files for TI SoCs.

So they are not used.

'They' as in SERDES4 definition or others as well??

Do not add headers which are not used - neither to

Quoted 7 lines

the kernel sources, nor to the DTSI. The header constants don't even look as suitable for bindings, although this is tricky to judge without users.

Best regards,
Krzysztof

#5 lore raw
Quoted 20 lines · Jayesh Choudhary
Quoted 17 lines · Krzysztof Kozlowski
Quoted 16 lines · Jayesh Choudhary

Hello Krzysztof,

Quoted 12 lines · Krzysztof Kozlowski
Quoted 5 lines · Jayesh Choudhary

SERDES4 has 4 lanes. Add lane definitions for it.

---
   include/dt-bindings/mux/ti-serdes.h | 20 ++++++++++++++++++++

Where are the users of this binding constants? IOW, why do you need to add these?

I don't see users of existing constants either...

Quoted 7 lines
Quoted 5 lines
Quoted 3 lines

These constants are propagated in the idle-state property for the mux-controller node (named serdes_ln_ctrl) usually in the final board dts files and occasionally in the main dtsi files for TI SoCs.

So they are not used.

'They' as in SERDES4 definition or others as well??

I made quick greps and it seems that none of the defines - existing and new - are used. But here anyway we talk about this patch, which without users does not have any rationale.

Best regards,
Krzysztof

#6 lore raw
Quoted 25 lines · Krzysztof Kozlowski
Quoted 24 lines · Jayesh Choudhary
Quoted 21 lines · Krzysztof Kozlowski
Quoted 19 lines · Jayesh Choudhary

Hello Krzysztof,

Quoted 12 lines · Krzysztof Kozlowski
Quoted 5 lines · Jayesh Choudhary

SERDES4 has 4 lanes. Add lane definitions for it.

---
    include/dt-bindings/mux/ti-serdes.h | 20 ++++++++++++++++++++

Where are the users of this binding constants? IOW, why do you need to add these?

I don't see users of existing constants either...

These constants are propagated in the idle-state property for the mux-controller node (named serdes_ln_ctrl) usually in the final board dts files and occasionally in the main dtsi files for TI SoCs.

Quoted 7 lines
Quoted 3 lines
Quoted 1 line

So they are not used.

'They' as in SERDES4 definition or others as well??

I made quick greps and it seems that none of the defines - existing and new - are used. But here anyway we talk about this patch, which without users does not have any rationale.

These defines are yet to be added. For reference:
https://lore.kernel.org/all/[email protected]/

SERDES4 by default is used for display but it can be configured for QSGMII too. There are users for that configuration as well. So it felt reasonable to add the definitions for SERDES4 which were missed earlier.

Warm Regards,
-Jayesh