Skip to contentSkip to conversation

Add support for Radxa ROCK 4SE

PATCH Applied Christopher Obbard 2 participants 5 messages Jul 10, 2023 – Jul 11, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

v2 cover Add support for Radxa ROCK 4SE

Add support for the RK3399T-based Radxa ROCK 4SE board. This board offers similar peripherals and form-factor to the ROCK Pi 4B but uses the cost-optimised RK3399T processor (which has different a OPP table but otherwise minimal changes) and some other minor hardware changes between the Rock Pi 4B (described in the devicetree).

The first patch moves the RK3399 OPP table from the generic Radxa ROCK Pi 4 dtsi into board-specific devicetree files, in preparation for the ROCK 4SE devicetree file (in later patches).

The second patch adds the devicetree binding documentation for the Radxa ROCK 4SE.

The third patch adds the board-specific devicetree file for the Radxa ROCK 4SE.

Changes in v2:
- Add Krzysztof Kozlowski's Acked-by tag.
- Set proper interrupt type for brcmf.

Christopher Obbard (3):
arm64: dts: rockchip: Move OPP table from ROCK Pi 4 dtsi
dt-bindings: arm: rockchip: Add Radxa ROCK 4SE
arm64: dts: rockchip: Add Radxa ROCK 4SE

 .../devicetree/bindings/arm/rockchip.yaml     |  5 ++
 arch/arm64/boot/dts/rockchip/Makefile         |  1 +
 .../boot/dts/rockchip/rk3399-rock-4se.dts     | 65 +++++++++++++++++++
 .../boot/dts/rockchip/rk3399-rock-pi-4.dtsi   |  1 -
 .../boot/dts/rockchip/rk3399-rock-pi-4a.dts   |  1 +
 .../boot/dts/rockchip/rk3399-rock-pi-4b.dts   |  1 +
 .../boot/dts/rockchip/rk3399-rock-pi-4c.dts   |  1 +
 7 files changed, 74 insertions(+), 1 deletion(-)
 create mode 100644 arch/arm64/boot/dts/rockchip/rk3399-rock-4se.dts
Signature · 1 line
2.40.1
#1 lore raw

PATCH v2 1/3 arm64: dts: rockchip: Move OPP table from ROCK Pi 4 dtsi

The ROCK 4SE uses the RK3399-T variant of the RK3399 SoC, which has some changes to the OPP tables. Prepare for the bringup of this SoC by moving the inclusion of existing OPP tables from the common devicetree into each board-specific devicetree.

---

(no changes since v1)

 arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi | 1 -
 arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4a.dts | 1 +
 arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4b.dts | 1 +
 arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4c.dts | 1 +
 4 files changed, 3 insertions(+), 1 deletion(-)
arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi +0 -1
index 907071d4fe80..ec307ee20c66 100644
@@ -9,7 +9,6 @@
 #include <dt-bindings/leds/common.h>
 #include <dt-bindings/pwm/pwm.h>
 #include "rk3399.dtsi"
-#include "rk3399-opp.dtsi"
 
 / {
 	aliases {
arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4a.dts +1 -0
index 89f2af5e111d..931334aa3d62 100644
@@ -6,6 +6,7 @@
 
 /dts-v1/;
 #include "rk3399-rock-pi-4.dtsi"
+#include "rk3399-opp.dtsi"
 
 / {
 	model = "Radxa ROCK Pi 4A";
arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4b.dts +1 -0
index 0806545922f5..e98a182f8572 100644
@@ -6,6 +6,7 @@
 
 /dts-v1/;
 #include "rk3399-rock-pi-4.dtsi"
+#include "rk3399-opp.dtsi"
 
 / {
 	model = "Radxa ROCK Pi 4B";
arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4c.dts +1 -0
index 4053ba72618c..d32efab74e94 100644
@@ -7,6 +7,7 @@
 
 /dts-v1/;
 #include "rk3399-rock-pi-4.dtsi"
+#include "rk3399-opp.dtsi"
 
 / {
 	model = "Radxa ROCK Pi 4C";
Signature · 1 line
2.40.1
#2 lore raw

PATCH v2 2/3 dt-bindings: arm: rockchip: Add Radxa ROCK 4SE

In reply to Christopher Obbard

Add devicetree binding entry for the Radxa ROCK 4SE.

---

Changes in v2:
- Add Krzysztof Kozlowski's Acked-by tag.

 Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
 1 file changed, 5 insertions(+)
Documentation/devicetree/bindings/arm/rockchip.yaml +5 -0
index ecdb72a519cb..3b7bf86cec02 100644
@@ -694,6 +694,11 @@ properties:
           - const: radxa,rock-4c-plus
           - const: rockchip,rk3399
 
+      - description: Radxa ROCK 4SE
+        items:
+          - const: radxa,rock-4se
+          - const: rockchip,rk3399
+
       - description: Radxa ROCK Pi E
         items:
           - const: radxa,rockpi-e
Signature · 1 line
2.40.1
#3 lore raw

PATCH v2 3/3 arm64: dts: rockchip: Add Radxa ROCK 4SE

In reply to Christopher Obbard

Add board-specific devicetree file for the RK3399T-based Radxa ROCK 4SE board. This board offers similar peripherals in a similar form-factor to the existing ROCK Pi 4B but uses the cost-optimised RK3399T processor (which has different OPP table than the RK3399) and other minimal hardware changes.

---

Changes in v2:
- Set proper interrupt type for brcmf.

 arch/arm64/boot/dts/rockchip/Makefile         |  1 +
 .../boot/dts/rockchip/rk3399-rock-4se.dts     | 65 +++++++++++++++++++
 2 files changed, 66 insertions(+)
 create mode 100644 arch/arm64/boot/dts/rockchip/rk3399-rock-4se.dts
arch/arm64/boot/dts/rockchip/Makefile +1 -0
index b7fb908eb92d..7ab29cbe71c4 100644
@@ -58,6 +58,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-roc-pc.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-roc-pc-mezzanine.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-roc-pc-plus.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-rock-4c-plus.dtb
+dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-rock-4se.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-rock-pi-4a.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-rock-pi-4a-plus.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-rock-pi-4b.dtb
arch/arm64/boot/dts/rockchip/rk3399-rock-4se.dts new file +65 -0

65 lines not on this page · raw message

Signature · 1 line
2.40.1
maintainer Applied
#4 lore raw
In reply to Christopher Obbard
Quoted 11 lines · Christopher Obbard

Add support for the RK3399T-based Radxa ROCK 4SE board. This board offers similar peripherals and form-factor to the ROCK Pi 4B but uses the cost-optimised RK3399T processor (which has different a OPP table but otherwise minimal changes) and some other minor hardware changes between the Rock Pi 4B (described in the devicetree).

The first patch moves the RK3399 OPP table from the generic Radxa ROCK Pi 4 dtsi into board-specific devicetree files, in preparation for the ROCK 4SE devicetree file (in later patches).

[...]

Applied, thanks!

[1/3] arm64: dts: rockchip: Move OPP table from ROCK Pi 4 dtsi

      commit: fd2762a626461ca4d9d829431a8a7f9f8e6c3395
[2/3] dt-bindings: arm: rockchip: Add Radxa ROCK 4SE
      commit: e7afb99e8f52f24514267f5482cd2f274220b360
[3/3] arm64: dts: rockchip: Add Radxa ROCK 4SE
      commit: 86a0e14a82ea723c7b7381799f060612dc65cdf3

Best regards,

Signature · 1 line
Heiko Stuebner <[email protected]>