drm/amdkfd: report dispatch id always saved in ttmps after gc9.4.2
Subsystems (3)
PATCH 1/1 drm/amdkfd: report dispatch id always saved in ttmps after gc9.4.2
The feature to save the dispatch ID in trap temporaries 6 & 7 on context save is unconditionally enabled during MQD initialization.
Now that TTMPs are always setup regardless of debug mode for GC 9.4.3, we should report that the dispatch ID is always available for debug/trap handling.
Signed-off-by Jonathan Kim <[email protected]>
--- drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/amdkfd/kfd_topology.c +3 -2
@@ -1941,10 +1941,11 @@ static void kfd_topology_set_capabilities(struct kfd_topology_device *dev)HSA_DBG_WATCH_ADDR_MASK_LO_BIT_GFX9 |HSA_DBG_WATCH_ADDR_MASK_HI_BIT ; -if (KFD_GC_VERSION (dev->gpu) <IP_VERSION (9 ,4 ,2 )) +if (KFD_GC_VERSION (dev->gpu) !=IP_VERSION (9 ,4 ,2 )) dev->node_props.debug_prop |=HSA_DBG_DISPATCH_INFO_ALWAYS_VALID ; -else + +if (KFD_GC_VERSION (dev->gpu) >=IP_VERSION (9 ,4 ,2 )) dev->node_props.capability |=HSA_CAP_TRAP_DEBUG_PRECISE_MEMORY_OPERATIONS_SUPPORTED ; }else {
Signature · 1 line
2.25.1
Quoted 8 lines · Jonathan Kim
The feature to save the dispatch ID in trap temporaries 6 & 7 on context save is unconditionally enabled during MQD initialization.
Now that TTMPs are always setup regardless of debug mode for GC 9.4.3, we should report that the dispatch ID is always available for debug/trap handling.
Signed-off-by Jonathan Kim <[email protected]>
Reviewed-by Felix Kuehling <[email protected]>
Quoted 22 lines
--- drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)drivers/gpu/drm/amd/amdkfd/kfd_topology.c +3
-2@@ -1941,10 +1941,11 @@ static void kfd_topology_set_capabilities(struct kfd_topology_device *dev)HSA_DBG_WATCH_ADDR_MASK_LO_BIT_GFX9 |HSA_DBG_WATCH_ADDR_MASK_HI_BIT ; -if (KFD_GC_VERSION (dev->gpu) <IP_VERSION (9 ,4 ,2 )) +if (KFD_GC_VERSION (dev->gpu) !=IP_VERSION (9 ,4 ,2 )) dev->node_props.debug_prop |=HSA_DBG_DISPATCH_INFO_ALWAYS_VALID ; -else + +if (KFD_GC_VERSION (dev->gpu) >=IP_VERSION (9 ,4 ,2 )) dev->node_props.capability |=HSA_CAP_TRAP_DEBUG_PRECISE_MEMORY_OPERATIONS_SUPPORTED ; }else {