Skip to contentSkip to conversation

imx8m: soc.c: demote some printfs to debug

PATCH In review Rasmus Villemoes 4 participants 4 messages May 22, 2023 – Jul 11, 2023

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 imx8m: soc.c: demote some printfs to debug

Getting

Found /vpu_g1@38300000 node
Modify /vpu_g1@38300000:status disabled
Found /vpu_g2@38310000 node
Modify /vpu_g2@38310000:status disabled

etc. on the console on every boot is needlessly verbose. Demote the "Found ..." lines to debug(), which is consistent with other instances in soc.c.

---
 arch/arm/mach-imx/imx8m/soc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/mach-imx/imx8m/soc.c +2 -2
index 5a4f8358c9..f5c82dff35 100644
@@ -736,7 +736,7 @@ static int disable_fdt_nodes(void *blob, const char *const nodes_path[], int siz
 		if (nodeoff < 0)
 			continue; /* Not found, skip it */
 
-		printf("Found %s node\n", nodes_path[i]);
+		debug("Found %s node\n", nodes_path[i]);
 
 add_status:
 		rc = fdt_setprop(blob, nodeoff, "status", status, strlen(status) + 1);
@@ -1265,7 +1265,7 @@ int ft_system_setup(void *blob, struct bd_info *bd)
 		if (nodeoff >= 0) {
 			const char *speed = "high-speed";
 
-			printf("Found %s node\n", usb_dwc3_path[v]);
+			debug("Found %s node\n", usb_dwc3_path[v]);
 
 usb_modify_speed:
 
Signature · 1 line
2.37.2
Reviewed-by on v1 1/1
#1 lore raw
Quoted 7 lines · Rasmus Villemoes

Getting

Found /vpu_g1@38300000 node
Modify /vpu_g1@38300000:status disabled
Found /vpu_g2@38310000 node
Modify /vpu_g2@38310000:status disabled

Quoted 5 lines

etc. on the console on every boot is needlessly verbose. Demote the "Found ..." lines to debug(), which is consistent with other instances in soc.c.

Reviewed-by on v1 1/1
#2 lore raw
In reply to Rasmus Villemoes
Quoted 7 lines · Rasmus Villemoes

Getting

   Found /vpu_g1@38300000 node
   Modify /vpu_g1@38300000:status disabled
   Found /vpu_g2@38310000 node
   Modify /vpu_g2@38310000:status disabled
Quoted 5 lines

etc. on the console on every boot is needlessly verbose. Demote the "Found ..." lines to debug(), which is consistent with other instances in soc.c.

Quoted 26 lines
---
  arch/arm/mach-imx/imx8m/soc.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/mach-imx/imx8m/soc.c +2 -2
index 5a4f8358c9..f5c82dff35 100644
@@ -736,7 +736,7 @@ static int disable_fdt_nodes(void *blob, const char *const nodes_path[], int siz
  		if (nodeoff < 0)
  			continue; /* Not found, skip it */
 
-		printf("Found %s node\n", nodes_path[i]);
+		debug("Found %s node\n", nodes_path[i]);
 
  add_status:
  		rc = fdt_setprop(blob, nodeoff, "status", status, strlen(status) + 1);
@@ -1265,7 +1265,7 @@ int ft_system_setup(void *blob, struct bd_info *bd)
  		if (nodeoff >= 0) {
  			const char *speed = "high-speed";
 
-			printf("Found %s node\n", usb_dwc3_path[v]);
+			debug("Found %s node\n", usb_dwc3_path[v]);
 
  usb_modify_speed:
 
#3 lore raw

PATCH 1/1 imx8m: soc.c: demote some printfs to debug

In reply to Rasmus Villemoes
Quoted 11 lines

Getting
Found /vpu_g1@38300000 node
Modify /vpu_g1@38300000:status disabled
Found /vpu_g2@38310000 node
Modify /vpu_g2@38310000:status disabled
etc. on the console on every boot is needlessly verbose. Demote the "Found ..." lines to debug(), which is consistent with other instances in soc.c.

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,        Managing Director: Erika Unter  
HRB 165235 Munich,   Office: Kirchenstr.5, 82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: [email protected]
=====================================================================