Skip to contentSkip to conversation

kernel: params: Remove unnecessary ‘0’ values from err

PATCH In review Li zeming 3 participants 3 messages Jul 10, 2023

lore
Share & tools
lore

Li zeming

author
#0 lore raw

PATCH 1/1 kernel: params: Remove unnecessary ‘0’ values from err

err is assigned first, so it does not need to initialize the assignment.

---
 kernel/params.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/params.c +1 -1
index 6a7548979aa9..f8837a5f2c3e 100644
@@ -331,7 +331,7 @@ EXPORT_SYMBOL(param_ops_bool);
 
 int param_set_bool_enable_only(const char *val, const struct kernel_param *kp)
 {
-	int err = 0;
+	int err;
 	bool new_value;
 	bool orig_value = *(bool *)kp->arg;
 	struct kernel_param dummy_kp = *kp;
Signature · 1 line
2.18.2
Reviewed-by on v1 1/1
#1 lore raw
Quoted 3 lines · Li zeming

err is assigned first, so it does not need to initialize the assignment.

Thanks.

Quoted 17 lines
---
 kernel/params.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/params.c +1 -1
index 6a7548979aa9..f8837a5f2c3e 100644
@@ -331,7 +331,7 @@ EXPORT_SYMBOL(param_ops_bool);
 
 int param_set_bool_enable_only(const char *val, const struct kernel_param *kp)
 {
-	int err = 0;
+	int err;
 	bool new_value;
 	bool orig_value = *(bool *)kp->arg;
 	struct kernel_param dummy_kp = *kp;
Signature · 1 line
~Randy