Skip to contentSkip to conversation

SVM: Fix warnings in svm.h

PATCH In review [email protected] 3 participants 3 messages Jul 12, 2023 1 message not in the archive

Subsystems (3)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 1/1 SVM: Fix warnings in svm.h

The following checkpatch warnings are removed:
WARNING: Prefer __packed over __attribute__((__packed__))

---
 arch/x86/include/asm/svm.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/include/asm/svm.h +1 -1
index e7c7379d6ac7..7ecebccf8a83 100644
@@ -119,7 +119,7 @@ enum {
 };
 
-struct __attribute__ ((__packed__)) vmcb_control_area {
+struct __packed vmcb_control_area {
     u32 intercepts[MAX_INTERCEPT];
     u32 reserved_1[15 - MAX_INTERCEPT];
     u16 pause_filter_thresh;
#2 lore raw
Quoted 2 lines · On Wed, Jul 12, 2023 at 09:39:24PM +0800, [email protected] wrote:

The following checkpatch warnings are removed:
WARNING: Prefer __packed over __attribute__((__packed__))

Can you please stop with these pointless checkpatch things?

#3 lore raw
Quoted 5 lines · Peter Zijlstra
Quoted 2 lines · On Wed, Jul 12, 2023 at 09:39:24PM +0800, [email protected] wrote:

The following checkpatch warnings are removed:
WARNING: Prefer __packed over __attribute__((__packed__))

Can you please stop with these pointless checkpatch things?

We should probably document that checkpatch should usually just be used on patches and not on entire files.

Signature · 1 line
~Randy