selftests: ALSA: Fix fclose on an already fclosed file pointer
Subsystems (5)
PATCH 1/1 selftests: ALSA: Fix fclose on an already fclosed file pointer
In the case where a sysfs file cannot be opened the error return path fcloses file pointer fpl, however, fpl has already been closed in the previous stanza. Fix the double fclose by removing it.
Fixes 10b98a4db11a ("selftests: ALSA: Add test for the 'pcmtest' driver")
Signed-off-by Colin Ian King <[email protected]>
--- tools/testing/selftests/alsa/test-pcmtest-driver.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
tools/testing/selftests/alsa/test-pcmtest-driver.c +1 -3
@@ -47,10 +47,8 @@ static int read_patterns(void)sprintf (pf,"/sys/kernel/debug/pcmtest/fill_pattern%d" , i); fp =fopen (pf,"r" ); -if (!fp) { -fclose (fpl); +if (!fp)return -1 ; - }fread (patterns[i].buf,1 , patterns[i].len, fp);fclose (fp); }
Signature · 1 line
2.39.2
Quoted 3 lines · Colin Ian King
In the case where a sysfs file cannot be opened the error return path fcloses file pointer fpl, however, fpl has already been closed in the previous stanza. Fix the double fclose by removing it.
Reviewed-by Mark Brown <[email protected]>
Takashi Iwai
AppliedQuoted 7 lines · Colin Ian King
In the case where a sysfs file cannot be opened the error return path fcloses file pointer fpl, however, fpl has already been closed in the previous stanza. Fix the double fclose by removing it.
Fixes 10b98a4db11a ("selftests: ALSA: Add test for the 'pcmtest' driver")Signed-off-by Colin Ian King <[email protected]>
Thanks, applied.
Takashi